From ec081e6a3a98cb947e872e9650ecdf14e022a72c Mon Sep 17 00:00:00 2001 From: jgallego Date: Thu, 12 Dec 2019 13:53:54 +0100 Subject: [PATCH] campo claimDestinationFk ya no esta como required --- .../03-ticketCreateWithoutZone.sql | 2 +- .../06-claim-module/02_development.spec.js | 34 ------------------- loopback/locale/es.json | 3 +- .../claim/back/methods/claim/getSummary.js | 3 -- .../claim/back/models/claim-development.json | 11 ------ 5 files changed, 3 insertions(+), 50 deletions(-) diff --git a/db/changes/10100-allSaints/03-ticketCreateWithoutZone.sql b/db/changes/10100-allSaints/03-ticketCreateWithoutZone.sql index 459033a534..b4840e31dc 100644 --- a/db/changes/10100-allSaints/03-ticketCreateWithoutZone.sql +++ b/db/changes/10100-allSaints/03-ticketCreateWithoutZone.sql @@ -36,7 +36,7 @@ BEGIN CALL vn.zone_getShippedWarehouse(vlanded, vAddressFk, vAgencyModeFk); - SELECT id INTO vZoneFk FROM tmp.zoneGetShipped + SELECT zoneFk INTO vZoneFk FROM tmp.zoneGetShipped WHERE shipped = vShipped AND warehouseFk = vWarehouseFk LIMIT 1; INSERT INTO vn2008.Tickets ( diff --git a/e2e/paths/06-claim-module/02_development.spec.js b/e2e/paths/06-claim-module/02_development.spec.js index 7df38e9457..640eff6368 100644 --- a/e2e/paths/06-claim-module/02_development.spec.js +++ b/e2e/paths/06-claim-module/02_development.spec.js @@ -94,38 +94,4 @@ describe('Claim development', () => { expect(worker).toEqual('deliveryNick'); expect(redelivery).toEqual('Reparto'); }); - - it('should delete the first development, add an empty one and save it', async() => { - const result = await nightmare - .waitToClick(selectors.claimDevelopment.firstDeleteDevelopmentButton) - .waitToClick(selectors.claimDevelopment.addDevelopmentButton) - .waitToClick(selectors.claimDevelopment.saveDevelopmentButton) - .waitForLastSnackbar(); - - expect(result).toEqual('Data saved!'); - }); - - it('should confirm the second development was auto filled', async() => { - const reason = await nightmare - .reloadSection('claim.card.development') - .waitToGetProperty(`${selectors.claimDevelopment.secondClaimReasonAutocomplete} input`, 'value'); - - const result = await nightmare - .waitToGetProperty(`${selectors.claimDevelopment.secondClaimResultAutocomplete} input`, 'value'); - - const responsible = await nightmare - .waitToGetProperty(`${selectors.claimDevelopment.secondClaimResponsibleAutocomplete} input`, 'value'); - - const worker = await nightmare - .waitToGetProperty(`${selectors.claimDevelopment.secondClaimWorkerAutocomplete} input`, 'value'); - - const redelivery = await nightmare - .waitToGetProperty(`${selectors.claimDevelopment.secondClaimRedeliveryAutocomplete} input`, 'value'); - - expect(reason).toEqual('Prisas'); - expect(result).toEqual('Otros daños'); - expect(responsible).toEqual('Compradores'); - expect(worker).toEqual('managerNick'); - expect(redelivery).toEqual('Cliente'); - }); }); diff --git a/loopback/locale/es.json b/loopback/locale/es.json index 70293a9655..78a7992b5a 100644 --- a/loopback/locale/es.json +++ b/loopback/locale/es.json @@ -117,5 +117,6 @@ "You should specify a date": "Debes especificar una fecha", "You should specify at least a start or end date": "Debes especificar al menos una fecha de inicio o de fín", "Start date should be lower than end date": "La fecha de inicio debe ser menor que la fecha de fín", - "You should mark at least one week day": "Debes marcar al menos un día de la semana" + "You should mark at least one week day": "Debes marcar al menos un día de la semana", + "Swift / BIC can't be empty": "Swift / BIC can't be empty" } \ No newline at end of file diff --git a/modules/claim/back/methods/claim/getSummary.js b/modules/claim/back/methods/claim/getSummary.js index bdf5faf639..35e4e14792 100644 --- a/modules/claim/back/methods/claim/getSummary.js +++ b/modules/claim/back/methods/claim/getSummary.js @@ -104,9 +104,6 @@ module.exports = Self => { } } }, - { - relation: 'claimDestination' - }, { relation: 'claimReason' }, diff --git a/modules/claim/back/models/claim-development.json b/modules/claim/back/models/claim-development.json index 7d37c13ee4..94c677304a 100644 --- a/modules/claim/back/models/claim-development.json +++ b/modules/claim/back/models/claim-development.json @@ -18,9 +18,6 @@ "claimResponsibleFk": { "required": true }, - "workerFk": { - "required": true - }, "claimReasonFk": { "required": true }, @@ -29,9 +26,6 @@ }, "claimRedeliveryFk": { "required": true - }, - "claimDestinationFk": { - "required": true } }, "relations": { @@ -64,11 +58,6 @@ "type": "belongsTo", "model": "ClaimRedelivery", "foreignKey": "claimRedeliveryFk" - }, - "claimDestination": { - "type": "belongsTo", - "model": "ClaimDestination", - "foreignKey": "claimDestinationFk" } } }