From 2adf96cb379ded5aaf2be24be1b75e8b2fd87dae Mon Sep 17 00:00:00 2001
From: guillermo <guillermo@verdnatura.es>
Date: Tue, 7 May 2024 13:03:50 +0200
Subject: [PATCH] refactor: #6585 Deleted transaction ticket_doCmr

---
 db/routines/vn/procedures/ticket_doCmr.sql | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/db/routines/vn/procedures/ticket_doCmr.sql b/db/routines/vn/procedures/ticket_doCmr.sql
index 61d8da5f9..40af388c7 100644
--- a/db/routines/vn/procedures/ticket_doCmr.sql
+++ b/db/routines/vn/procedures/ticket_doCmr.sql
@@ -7,7 +7,7 @@ BEGIN
 *
 * @param vSelf El id del ticket
 */
-	DECLARE vCmrFk, vPreviousCmrFk, vCurrentCmrFk INT;
+	DECLARE vCmrFk INT;
 	SELECT cmrFk INTO vCmrFk
 		FROM ticket
 		WHERE id = vSelf;
@@ -44,8 +44,6 @@ BEGIN
 				AND t.id = vSelf
 			GROUP BY t.id;
 	
-	START TRANSACTION;
-	
 	IF vCmrFk THEN
 		UPDATE cmr c
 				JOIN tTicket t
@@ -57,9 +55,7 @@ BEGIN
 				c.supplierFk = t.supplierFk,
 				c.ead = t.landed
 			WHERE id = vCmrFk;
-	ELSE
-		SELECT MAX(id) INTO vPreviousCmrFk FROM cmr;
-		
+	ELSE		
 		INSERT INTO cmr (
 			senderInstruccions,
 			truckPlate,
@@ -70,17 +66,14 @@ BEGIN
 			ead
 		)
 			SELECT * FROM tTicket;
-	
-		SELECT MAX(id) INTO vCurrentCmrFk FROM cmr;
 
-		IF vPreviousCmrFk <> vCurrentCmrFk THEN
+		IF (SELECT EXISTS(SELECT * FROM tTicket)) THEN
 			UPDATE ticket
 				SET cmrFk = vCurrentCmrFk
-				WHERE id = vSelf;
+				WHERE id = LAST_INSERT_ID();
 		END IF;
 	END IF;
 
-	COMMIT;
 	DROP TEMPORARY TABLE tTicket;
 END$$
 DELIMITER ;