From 32793990ec6d86b0ab24181db3416f305c5a3d90 Mon Sep 17 00:00:00 2001
From: guillermo <guillermo@verdnatura.es>
Date: Mon, 8 Jul 2024 14:01:18 +0200
Subject: [PATCH] refactor: refs #7662 Minor change

---
 db/routines/vn/procedures/collection_new.sql  |  1 -
 .../ticket_splitItemPackingType.sql           | 20 +++++++++----------
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/db/routines/vn/procedures/collection_new.sql b/db/routines/vn/procedures/collection_new.sql
index 029427306..cd4b1b47f 100644
--- a/db/routines/vn/procedures/collection_new.sql
+++ b/db/routines/vn/procedures/collection_new.sql
@@ -229,7 +229,6 @@ BEGIN
 			AND ((vTicketVolume + @volume) <= vVolumeLimit OR vVolumeLimit IS NULL) THEN
 
 			CALL ticket_splitItemPackingType(vTicketFk, vItemPackingTypeFk);
-			DROP TEMPORARY TABLE tmp.ticketIPT;
 
 			UPDATE tmp.productionBuffer pb
 					JOIN (
diff --git a/db/routines/vn/procedures/ticket_splitItemPackingType.sql b/db/routines/vn/procedures/ticket_splitItemPackingType.sql
index bc4c94d46..2a84948c9 100644
--- a/db/routines/vn/procedures/ticket_splitItemPackingType.sql
+++ b/db/routines/vn/procedures/ticket_splitItemPackingType.sql
@@ -10,7 +10,6 @@ BEGIN
  *
  * @param vSelf Id ticket
  * @param vItemPackingTypeFk Tipo para el que se reserva el número de ticket original
- * @return table tmp.ticketIPT(ticketFk, itemPackingTypeFk)
  */
 	DECLARE vItemPackingTypeFk VARCHAR(1) DEFAULT 'H';
 	DECLARE vNewTicketFk INT;
@@ -61,17 +60,17 @@ BEGIN
 		FROM tSaleGroup
 		WHERE itemPackingTypeFk IS NOT NULL;
 
-	CREATE OR REPLACE TEMPORARY TABLE tmp.ticketIPT(
+	CREATE OR REPLACE TEMPORARY TABLE tTicketIPT(
 		ticketFk INT,
 		itemPackingTypeFk VARCHAR(1)
 	) ENGINE = MEMORY;
 
 	CASE vPackingTypesToSplit
 		WHEN 0 THEN
-			INSERT INTO tmp.ticketIPT(ticketFk, itemPackingTypeFk)
+			INSERT INTO tTicketIPT(ticketFk, itemPackingTypeFk)
 				VALUES(vSelf, vItemPackingTypeFk);
 		WHEN 1 THEN
-			INSERT INTO tmp.ticketIPT(ticketFk, itemPackingTypeFk)
+			INSERT INTO tTicketIPT(ticketFk, itemPackingTypeFk)
 				SELECT vSelf, itemPackingTypeFk
 					FROM tSaleGroup
 					WHERE itemPackingTypeFk IS NOT NULL;
@@ -79,7 +78,7 @@ BEGIN
 			OPEN vSaleGroup;
 			FETCH vSaleGroup INTO vItemPackingTypeFk;
 
-			INSERT INTO tmp.ticketIPT(ticketFk, itemPackingTypeFk)
+			INSERT INTO tTicketIPT(ticketFk, itemPackingTypeFk)
 				VALUES(vSelf, vItemPackingTypeFk);
 
 			l: LOOP
@@ -92,7 +91,7 @@ BEGIN
 
 				CALL ticket_Clone(vSelf, vNewTicketFk);
 
-				INSERT INTO tmp.ticketIPT(ticketFk, itemPackingTypeFk)
+				INSERT INTO tTicketIPT(ticketFk, itemPackingTypeFk)
 					VALUES(vNewTicketFk, vItemPackingTypeFk);
 			END LOOP;
 
@@ -101,13 +100,13 @@ BEGIN
 			SELECT s.id
 				FROM sale s
 					JOIN tSale ts ON ts.id = s.id
-					JOIN tmp.ticketIPT t ON t.itemPackingTypeFk = ts.itemPackingTypeFk
+					JOIN tTicketIPT t ON t.itemPackingTypeFk = ts.itemPackingTypeFk
 				WHERE s.ticketFk = vSelf
 				FOR UPDATE;
 
 			UPDATE sale s
 					JOIN tSale ts ON ts.id = s.id
-					JOIN tmp.ticketIPT t ON t.itemPackingTypeFk = ts.itemPackingTypeFk
+					JOIN tTicketIPT t ON t.itemPackingTypeFk = ts.itemPackingTypeFk
 				SET s.ticketFk = t.ticketFk;
 
 			SELECT itemPackingTypeFk INTO vItemPackingTypeFk
@@ -118,7 +117,7 @@ BEGIN
 
 			UPDATE sale s
 					JOIN tSale ts ON ts.id = s.id
-					JOIN tmp.ticketIPT t ON t.itemPackingTypeFk = vItemPackingTypeFk
+					JOIN tTicketIPT t ON t.itemPackingTypeFk = vItemPackingTypeFk
 				SET s.ticketFk = t.ticketFk
 				WHERE ts.itemPackingTypeFk IS NULL;
 	END CASE;
@@ -127,6 +126,7 @@ BEGIN
 
 	DROP TEMPORARY TABLE
 		tSale,
-		tSaleGroup;
+		tSaleGroup,
+		tTicketIPT;
 END$$
 DELIMITER ;