Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 6389-changesMonitor

db/routines/vn/triggers/itemType_afterDelete.sql

@@ -0,0 +1,12 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`vn`@`localhost` TRIGGER `vn`.`itemType_afterDelete`
+	AFTER DELETE ON `itemType`
+	FOR EACH ROW
+BEGIN
+	INSERT INTO itemTypeLog
+		SET `action` = 'delete',
+			`changedModel` = 'ItemType',
+			`changedModelId` = OLD.id,
+			`userFk` = account.myUser_getId();
+END$$
+DELIMITER ;

db/routines/vn/triggers/itemType_beforeInsert.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`vn`@`localhost` TRIGGER `vn`.`itemType_beforeInsert`
+	BEFORE INSERT ON `itemType`
+	FOR EACH ROW
+BEGIN
+	SET NEW.editorFk = account.myUser_getId();
+END$$
+DELIMITER ;

db/routines/vn/triggers/itemType_beforeUpdate.sql

@@ -3,6 +3,7 @@ CREATE OR REPLACE DEFINER=`vn`@`localhost` TRIGGER `vn`.`itemType_beforeUpdate`
 	BEFORE UPDATE ON `itemType`
 	FOR EACH ROW
 BEGIN
+	SET NEW.editorFk = account.myUser_getId();
 	IF NEW.itemPackingTypeFk = '' THEN
 
 		SET NEW.itemPackingTypeFk = NULL;

db/routines/vn/triggers/productionConfig_afterDelete.sql

@@ -3,7 +3,7 @@ CREATE OR REPLACE DEFINER=`vn`@`localhost` TRIGGER `vn`.`productionConfig_afterD
 	AFTER DELETE ON `productionConfig`
 	FOR EACH ROW
 BEGIN
-	INSERT INTO productionConfig
+	INSERT INTO productionConfigLog
 		SET `action` = 'delete',
 			`changedModel` = 'ProductionConfig',
 			`changedModelId` = OLD.id,

db/versions/11297-graySalal/00-firstScript.sql

@@ -0,0 +1,27 @@
+ALTER TABLE vn.itemType
+    ADD editorFk int(10) unsigned DEFAULT NULL NULL,
+    ADD CONSTRAINT itemType_user_FK FOREIGN KEY (editorFk) REFERENCES account.`user`(id);
+
+CREATE TABLE `vn`.`itemTypeLog` (
+  `id` int(11) NOT NULL AUTO_INCREMENT,
+  `originFk` int(11) DEFAULT NULL,
+  `userFk` int(10) unsigned DEFAULT NULL,
+  `action` set('insert','update','delete') NOT NULL,
+  `creationDate` timestamp NULL DEFAULT current_timestamp(),
+  `description` text CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL,
+  `changedModel` enum('ItemType') NOT NULL DEFAULT 'ItemType',
+  `oldInstance` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_bin DEFAULT NULL CHECK (json_valid(`oldInstance`)),
+  `newInstance` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_bin DEFAULT NULL CHECK (json_valid(`newInstance`)),
+  `changedModelId` int(11) NOT NULL,
+  `changedModelValue` varchar(45) DEFAULT NULL,
+  `summaryId` varchar(30) DEFAULT NULL,
+  PRIMARY KEY (`id`),
+  KEY `itemTypeLogUserFk_idx` (`userFk`),
+  KEY `itemTypeLog_changedModel` (`changedModel`,`changedModelId`,`creationDate`),
+  KEY `itemTypeLog_originFk` (`originFk`,`creationDate`),
+  KEY `itemTypeLog_creationDate_IDX` (`creationDate` DESC) USING BTREE,
+  CONSTRAINT `itemTypeLogUserFk` FOREIGN KEY (`userFk`) REFERENCES `account`.`user` (`id`) ON DELETE CASCADE ON UPDATE CASCADE
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci `PAGE_COMPRESSED`=1;
+
+INSERT IGNORE INTO salix.ACL (model,property,principalId)
+	VALUES ('ItemTypeLog','find','employee');

db/versions/11297-graySalal/01-firstScript.sql

@@ -0,0 +1,3 @@
+ALTER TABLE vn.itemType
+	ADD CONSTRAINT itemType_itemPackingType_FK FOREIGN KEY (itemPackingTypeFk)
+		REFERENCES vn.itemPackingType(code) ON DELETE RESTRICT ON UPDATE CASCADE;

loopback/locale/en.json

@@ -240,6 +240,9 @@
 	"There is already a tray with the same height": "There is already a tray with the same height",
 	"The height must be greater than 50cm": "The height must be greater than 50cm",
 	"The maximum height of the wagon is 200cm": "The maximum height of the wagon is 200cm",
-    "The quantity claimed cannot be greater than the quantity of the line": "The quantity claimed cannot be greater than the quantity of the line",
+	"The quantity claimed cannot be greater than the quantity of the line": "The quantity claimed cannot be greater than the quantity of the line",
-    "There are tickets for this area, delete them first": "There are tickets for this area, delete them first"
+	"There are tickets for this area, delete them first": "There are tickets for this area, delete them first",
+	"null": "null",
+	"Invalid or expired verification code": "Invalid or expired verification code",
+	"Payment method is required": "Payment method is required"
 }

loopback/locale/es.json

@@ -385,5 +385,6 @@
 	"The quantity claimed cannot be greater than the quantity of the line": "La cantidad reclamada no puede ser mayor que la cantidad de la línea",
 	"type cannot be blank": "Se debe rellenar el tipo",
 	"There are tickets for this area, delete them first": "Hay tickets para esta sección, borralos primero",
-	"There is no company associated with that warehouse": "No hay ninguna empresa asociada a ese almacén"
+	"There is no company associated with that warehouse": "No hay ninguna empresa asociada a ese almacén",
+	"The web user's email already exists": "El correo del usuario web ya existe"
 }

loopback/locale/fr.json

@@ -363,5 +363,6 @@
 	"It has been invoiced but the PDF of refund not be generated": "Il a été facturé mais le PDF de remboursement n'a pas été généré",
 	"Cannot send mail": "Impossible d'envoyer le mail",
     "Original invoice not found": "Facture originale introuvable",
-    "The quantity claimed cannot be greater than the quantity of the line": "Le montant réclamé ne peut pas être supérieur au montant de la ligne"
+    "The quantity claimed cannot be greater than the quantity of the line": "Le montant réclamé ne peut pas être supérieur au montant de la ligne",
+    "The web user's email already exists": "L'email de l'internaute existe déjà"
 }

loopback/locale/pt.json

@@ -363,5 +363,6 @@
 	"It has been invoiced but the PDF of refund not be generated": "Foi faturado mas não foi gerado o PDF do reembolso",
     "Original invoice not found": "Fatura original não encontrada",
 	"Cannot send mail": "Não é possível enviar o email",
-    "The quantity claimed cannot be greater than the quantity of the line": "O valor reclamado não pode ser superior ao valor da linha"
+    "The quantity claimed cannot be greater than the quantity of the line": "O valor reclamado não pode ser superior ao valor da linha",
+    "The web user's email already exists": "O e-mail do utilizador da web já existe."
 }

modules/client/back/methods/client/createWithUser.js

@@ -1,3 +1,4 @@
+/* eslint max-len: ["error", { "code": 150 }]*/
 const UserError = require('vn-loopback/util/user-error');
 
 module.exports = function(Self) {
@@ -98,6 +99,8 @@ module.exports = function(Self) {
             return client;
         } catch (e) {
             if (tx) await tx.rollback();
+            if (e.message && e.message.includes(`Email already exists`)) throw new UserError(`The web user's email already exists`);
+
             throw e;
         }
     };

modules/item/back/model-config.json

@@ -47,6 +47,9 @@
     "ItemType": {
         "dataSource": "vn"
     },
+    "ItemTypeLog": {
+        "dataSource": "vn"
+    },
     "ItemTypeTag": {
         "dataSource": "vn"
     },

modules/item/back/models/item-type-log.json

@@ -0,0 +1,9 @@
+{
+	"name": "ItemTypeLog",
+	"base": "Log",
+	"options": {
+		"mysql": {
+			"table": "itemTypeLog"
+		}
+	}
+}

modules/item/back/models/item-type.json

@@ -29,6 +29,12 @@
         },
         "isLaid": {
             "type": "boolean"
+        },
+        "maxRefs": {
+            "type": "string"
+        },
+        "isFragile": {
+            "type": "boolean"
         }
     },
     "relations": {

modules/ticket/back/methods/sale/recalculatePrice.js

@@ -48,7 +48,7 @@ module.exports = Self => {
                 CALL vn.sale_recalcComponent(null);
                 DROP TEMPORARY TABLE tmp.recalculateSales;`;
 
-            const recalculation = await Self.rawSql(query, salesIds, myOptions);
+            const recalculation = await Self.rawSql(query, [salesIds], myOptions);
 
             if (tx) await tx.commit();
 

modules/ticket/back/methods/sale/specs/updatePrice.spec.js

@@ -85,6 +85,25 @@ describe('sale updatePrice()', () => {
         }
     });
 
+    it('should check if priceFixed has changed', async() => {
+        const tx = await models.Sale.beginTransaction({});
+
+        try {
+            const options = {transaction: tx};
+
+            const price = 3;
+            const beforeUpdate = await models.Sale.findById(saleId, null, options);
+            await models.Sale.updatePrice(ctx, saleId, price, options);
+            const afterUpdate = await models.Sale.findById(saleId, null, options);
+
+            expect(beforeUpdate.priceFixed).not.toEqual(afterUpdate.priceFixed);
+            await tx.rollback();
+        } catch (e) {
+            await tx.rollback();
+            throw e;
+        }
+    });
+
     it('should set price as a decimal number and check the sale has the mana component changing the salesPersonMana', async() => {
         const tx = await models.Sale.beginTransaction({});
 

modules/ticket/back/methods/sale/updatePrice.js

@@ -91,7 +91,21 @@ module.exports = Self => {
                     value: componentValue
                 }, myOptions);
             }
-            await sale.updateAttributes({price: newPrice}, myOptions);
+
+            const [priceFixed] = await Self.rawSql(`
+                SELECT SUM(value) value
+                    FROM sale s
+                        JOIN saleComponent sc ON sc.saleFk = s.id
+                        JOIN component c ON c.id = sc.componentFk
+                        JOIN componentType ct ON ct.id = c.typeFk
+                    WHERE ct.isBase
+                        AND s.id = ?
+            `, [id], myOptions);
+
+            await sale.updateAttributes({
+                price: newPrice,
+                priceFixed: priceFixed.value
+            }, myOptions);
 
             await Self.rawSql('CALL vn.manaSpellersRequery(?)', [userId], myOptions);
             await Self.rawSql('CALL vn.ticket_recalc(?, NULL)', [sale.ticketFk], myOptions);

modules/ticket/back/models/sale.json

@@ -28,6 +28,9 @@
         "discount": {
             "type": "number"
         },
+        "priceFixed": {
+            "type": "number"
+        },
         "reserved": {
             "type": "boolean"
         },

modules/worker/back/models/worker.json

@@ -204,6 +204,15 @@
             ]
         },
         "summary": {
+            "fields": [
+                "id",
+                "firstName",
+                "lastName",
+                "bossFk",
+                "sex",
+                "phone",
+                "mobileExtension"
+            ],
             "include": [
                 {
                     "relation": "user",