From 334c5f03a5e5ce83e1da625945891ee510f6f264 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 27 Nov 2023 10:47:49 +0100
Subject: [PATCH] refs #5878 feat: validate params in supplier model

---
 .../back/methods/client/updateFiscalData.js   |   4 +-
 .../back/methods/supplier/updateFiscalData.js | 137 ++++++++++--------
 2 files changed, 76 insertions(+), 65 deletions(-)

diff --git a/modules/client/back/methods/client/updateFiscalData.js b/modules/client/back/methods/client/updateFiscalData.js
index c3b92f6b12..c87eba6be4 100644
--- a/modules/client/back/methods/client/updateFiscalData.js
+++ b/modules/client/back/methods/client/updateFiscalData.js
@@ -128,9 +128,7 @@ module.exports = Self => {
         let tx;
         const myOptions = {};
         const models = Self.app.models;
-        const args = ctx.args;
-        const userId = ctx.req.accessToken.userId;
-        const $t = ctx.req.__;
+        const {args, req: {__: $t}} = ctx;
 
         if (typeof options == 'object')
             Object.assign(myOptions, options);
diff --git a/modules/supplier/back/methods/supplier/updateFiscalData.js b/modules/supplier/back/methods/supplier/updateFiscalData.js
index 271ed8769e..c0f0be14c0 100644
--- a/modules/supplier/back/methods/supplier/updateFiscalData.js
+++ b/modules/supplier/back/methods/supplier/updateFiscalData.js
@@ -1,3 +1,65 @@
+const validatorBodyModel = require('../../../../client/back/methods/client/body_model_validator');
+
+const BODY_MODEL = [{
+    arg: 'name',
+    type: 'string'
+},
+{
+    arg: 'nif',
+    type: 'string'
+},
+{
+    arg: 'account',
+    type: 'any'
+},
+{
+    arg: 'sageTaxTypeFk',
+    type: 'any'
+},
+{
+    arg: 'sageWithholdingFk',
+    type: 'any'
+},
+{
+    arg: 'sageTransactionTypeFk',
+    type: 'any'
+},
+{
+    arg: 'postCode',
+    type: 'any'
+},
+{
+    arg: 'street',
+    type: 'any'
+},
+{
+    arg: 'city',
+    type: 'string'
+},
+{
+    arg: 'provinceFk',
+    type: 'any'
+},
+{
+    arg: 'countryFk',
+    type: 'any'
+},
+{
+    arg: 'supplierActivityFk',
+    type: 'string'
+},
+{
+    arg: 'healthRegister',
+    type: 'string'
+},
+{
+    arg: 'isVies',
+    type: 'boolean'
+},
+{
+    arg: 'isTrucker',
+    type: 'boolean'
+}];
 module.exports = Self => {
     Self.remoteMethod('updateFiscalData', {
         description: 'Updates fiscal data of a supplier',
@@ -14,65 +76,11 @@ module.exports = Self => {
             http: {source: 'path'}
         },
         {
-            arg: 'name',
-            type: 'string'
-        },
-        {
-            arg: 'nif',
-            type: 'string'
-        },
-        {
-            arg: 'account',
-            type: 'any'
-        },
-        {
-            arg: 'sageTaxTypeFk',
-            type: 'any'
-        },
-        {
-            arg: 'sageWithholdingFk',
-            type: 'any'
-        },
-        {
-            arg: 'sageTransactionTypeFk',
-            type: 'any'
-        },
-        {
-            arg: 'postCode',
-            type: 'any'
-        },
-        {
-            arg: 'street',
-            type: 'any'
-        },
-        {
-            arg: 'city',
-            type: 'string'
-        },
-        {
-            arg: 'provinceFk',
-            type: 'any'
-        },
-        {
-            arg: 'countryFk',
-            type: 'any'
-        },
-        {
-            arg: 'supplierActivityFk',
-            type: 'string'
-        },
-        {
-            arg: 'healthRegister',
-            type: 'string'
-        },
-        {
-            arg: 'isVies',
-            type: 'boolean'
-        },
-        {
-            arg: 'isTrucker',
-            type: 'boolean'
-        }],
+            arg: 'data',
+            type: 'object',
+            http: {source: 'body'}
+        }
+        ],
         returns: {
             arg: 'res',
             type: 'string',
@@ -86,13 +94,18 @@ module.exports = Self => {
 
     Self.updateFiscalData = async(ctx, supplierId) => {
         const models = Self.app.models;
-        const args = ctx.args;
+        const {args} = ctx;
         const supplier = await models.Supplier.findById(supplierId);
 
         // Remove unwanted properties
         delete args.ctx;
         delete args.id;
-
-        return supplier.updateAttributes(args);
+        const {isValid, tag} = validatorBodyModel(BODY_MODEL, args.data);
+        if (!isValid) {
+            const key = $t(`${tag}`);
+            throw new Error($t('Model is not valid', {key})
+            );
+        }
+        return supplier.updateAttributes(args.data);
     };
 };