Merge pull request 'feat: refs #7173 Bloquear facturas recibidas contabilizadas' (!2258) from 7173-Restricción-eliminar/modificar-vn.invoiceIn into dev

Reviewed-on: #2258
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>

db/dump/fixtures.before.sql

@@ -2551,15 +2551,15 @@ INSERT INTO `vn`.`duaEntry` (`duaFk`, `entryFk`, `value`, `customsValue`, `euroV
 REPLACE INTO `vn`.`invoiceIn`(`id`, `serialNumber`,`serial`, `supplierFk`, `issued`, `created`, `supplierRef`, `isBooked`, `companyFk`, `docFk`)
     VALUES
         (1,  1001,  'R', 1, util.VN_CURDATE(), util.VN_CURDATE(), 1234, 0, 442, 1),
-        (2,  1002,  'R', 1, util.VN_CURDATE(), util.VN_CURDATE(), 1235, 1, 442, 1),
+        (2,  1002,  'R', 1, util.VN_CURDATE(), util.VN_CURDATE(), 1235, 0, 442, 1),
         (3,  1003,  'R', 1, util.VN_CURDATE(), util.VN_CURDATE(), 1236, 0, 442, 1),
         (4,  1004,  'R', 1, util.VN_CURDATE(), util.VN_CURDATE(), 1237, 0, 442, 1),
-        (5,  1005,  'R', 1, util.VN_CURDATE(), util.VN_CURDATE(), 1238, 1, 442, 1),
+        (5,  1005,  'R', 1, util.VN_CURDATE(), util.VN_CURDATE(), 1238, 0, 442, 1),
         (6,  1006,  'R', 2, util.VN_CURDATE(), util.VN_CURDATE(), 1239, 0, 442, 1),
-        (7,  1007,  'R', 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1240, 1, 442, 1),
+        (7,  1007,  'R', 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1240, 0, 442, 1),
-        (8,  1008,  'R', 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1241, 1, 442, 1),
+        (8,  1008,  'R', 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1241, 0, 442, 1),
-        (9,  1009,  'R', 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1242, 1, 442, 1),
+        (9,  1009,  'R', 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1242, 0, 442, 1),
-        (10, 1010,  'R', 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1243, 1, 442, 1);
+        (10, 1010,  'R', 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1243, 0, 442, 1);
 
 INSERT INTO `vn`.`invoiceInConfig` (`id`, `retentionRate`, `retentionName`, `sageWithholdingFk`, `daysAgo`)
     VALUES
@@ -2614,6 +2614,10 @@ INSERT INTO `vn`.`invoiceInIntrastat` (`invoiceInFk`, `net`, `intrastatFk`, `amo
         (2, 13.20, 5080000, 15.00, 580, 5),
         (2, 16.10, 6021010, 25.00, 80,  5);
 
+UPDATE `vn`.`invoiceIn`
+	SET isBooked = TRUE
+	WHERE id IN (2, 5, 7, 8, 9, 10);
+
 INSERT INTO `vn`.`ticketRecalc`(`ticketFk`)
     SELECT t.id
         FROM vn.ticket t

db/routines/vn/procedures/invoiceInTax_afterUpsert.sql

@@ -10,6 +10,8 @@ BEGIN
 	DECLARE vLines INT;
 	DECLARE vHasDistinctTransactions INT;
 
+	CALL invoiceIn_checkBooked(vInvoiceInFk);
+
 	SELECT taxRowLimit INTO vTaxRowLimit FROM invoiceInConfig;
 	
 	SELECT COUNT(*) INTO vLines

db/routines/vn/procedures/invoiceIn_checkBooked.sql

@@ -0,0 +1,22 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`invoiceIn_checkBooked`(
+	vSelf INT
+)
+BEGIN
+/**
+ * Comprueba si una factura recibida está contabilizada,
+ * y si lo está retorna un throw.
+ *
+ * @param vSelf Id invoiceIn
+ */
+	DECLARE vIsBooked BOOL;
+
+	SELECT isBooked INTO vIsBooked
+		FROM invoiceIn
+		WHERE id = vSelf;
+
+	IF vIsBooked THEN
+		CALL util.throw('InvoiceIn is already booked');
+	END IF;
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInCorrection_beforeDelete.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInCorrection_beforeDelete`
+	BEFORE DELETE ON `invoiceInCorrection`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(OLD.correctingFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInCorrection_beforeInsert.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInCorrection_beforeInsert`
+	BEFORE INSERT ON `invoiceInCorrection`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(NEW.correctingFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInCorrection_beforeUpdate.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInCorrection_beforeUpdate`
+	BEFORE UPDATE ON `invoiceInCorrection`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(OLD.correctingFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInDueDay_beforeDelete.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInDueDay_beforeDelete`
+	BEFORE DELETE ON `invoiceInDueDay`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(OLD.invoiceInFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInDueDay_beforeInsert.sql

@@ -5,6 +5,8 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInDueDay_befor
 BEGIN
 	DECLARE vIsNotified BOOLEAN;
 
+	CALL invoiceIn_checkBooked(NEW.invoiceInFk);
+
 	SET NEW.editorFk = account.myUser_getId();
     
     SELECT isNotified INTO vIsNotified 

db/routines/vn/triggers/invoiceInDueDay_beforeUpdate.sql

@@ -5,6 +5,7 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInDueDay_befor
 BEGIN
 	DECLARE vIsNotified BOOLEAN;
 
+	CALL invoiceIn_checkBooked(OLD.invoiceInFk);
 	SET NEW.editorFk = account.myUser_getId();
     
     SELECT isNotified INTO vIsNotified 

db/routines/vn/triggers/invoiceInIntrastat_beforeDelete.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInIntrastat_beforeDelete`
+	BEFORE DELETE ON `invoiceInIntrastat`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(OLD.invoiceInFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInIntrastat_beforeInsert.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInIntrastat_beforeInsert`
+	BEFORE INSERT ON `invoiceInIntrastat`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(NEW.invoiceInFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInIntrastat_beforeUpdate.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInIntrastat_beforeUpdate`
+	BEFORE UPDATE ON `invoiceInIntrastat`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(OLD.invoiceInFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInTax_beforeDelete.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInTax_beforeDelete`
+	BEFORE DELETE ON `invoiceInTax`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(OLD.invoiceInFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceInTax_beforeUpdate.sql

@@ -3,6 +3,8 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceInTax_beforeUp
 	BEFORE UPDATE ON `invoiceInTax`
 	FOR EACH ROW
 BEGIN
+	CALL invoiceIn_checkBooked(OLD.invoiceInFk);
+	
 	IF NOT (NEW.invoiceInFk <=> OLD.invoiceInFk) THEN 
 		CALL invoiceInTax_afterUpsert(NEW.invoiceInFk);
 	END IF;

db/routines/vn/triggers/invoiceIn_afterUpdate.sql

@@ -3,7 +3,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceIn_afterUpdate
 	AFTER UPDATE ON `invoiceIn`
 	FOR EACH ROW
 BEGIN
-
 	IF NEW.issued != OLD.issued    
 		OR NEW.currencyFk != OLD.currencyFk THEN
 

db/routines/vn/triggers/invoiceIn_beforeDelete.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceIn_beforeDelete`
+	BEFORE DELETE ON `invoiceIn`
+	FOR EACH ROW
+BEGIN
+	CALL invoiceIn_checkBooked(OLD.id);
+END$$
+DELIMITER ;

db/routines/vn/triggers/invoiceIn_beforeUpdate.sql

@@ -5,6 +5,10 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`invoiceIn_beforeUpdat
 BEGIN
 	DECLARE vWithholdingSageFk INT;
 
+	IF NEW.isBooked = OLD.isBooked THEN
+		CALL invoiceIn_checkBooked(OLD.id);
+	END IF;
+
 	IF NOT (NEW.supplierRef <=> OLD.supplierRef) AND NOT util.checkPrintableChars(NEW.supplierRef) THEN
 		CALL util.throw('The invoiceIn reference contains invalid characters');
 	END IF;

modules/invoiceIn/back/methods/invoice-in-due-day/specs/new.spec.js

@@ -13,11 +13,10 @@ describe('invoiceInDueDay new()', () => {
 
     it('should correctly create a new due day', async() => {
         const userId = 9;
-        const invoiceInFk = 6;
+        const invoiceInFk = 3;
 
         const ctx = {
             req: {
-
                 accessToken: {userId: userId},
             }
         };

modules/invoiceIn/back/methods/invoice-in/specs/filter.spec.js

@@ -158,7 +158,7 @@ describe('InvoiceIn filter()', () => {
 
             const result = await models.InvoiceIn.filter(ctx, {}, options);
 
-            expect(result.length).toEqual(6);
+            expect(result.length).toEqual(4);
 
             await tx.rollback();
         } catch (e) {