Merge pull request '#7289 Sales already moved' (!3212) from 7289_sales_already_moved into dev

Reviewed-on: #3212
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>

loopback/locale/en.json

@@ -244,5 +244,7 @@
 	"Invalid or expired verification code": "Invalid or expired verification code",
     "There are tickets for this area, delete them first": "There are tickets for this area, delete them first",
 	"ticketLostExpedition": "The ticket [{{ticketId}}]({{{ticketUrl}}}) has the following lost expedition:{{ expeditionId }}",
-	"Payment method is required": "Payment method is required"
+	"Payment method is required": "Payment method is required",
+    "Sales already moved": "Sales already moved"
+
 }

loopback/locale/es.json

@@ -387,5 +387,6 @@
 	"There are tickets for this area, delete them first": "Hay tickets para esta sección, borralos primero",
 	"There is no company associated with that warehouse": "No hay ninguna empresa asociada a ese almacén",
 	"ticketLostExpedition": "El ticket [{{ticketId}}]({{{ticketUrl}}}) tiene la siguiente expedición perdida:{{ expeditionId }}",
-	"The web user's email already exists": "El correo del usuario web ya existe"
-}
+	"The web user's email already exists": "El correo del usuario web ya existe",
+	"Sales already moved": "Ya han sido transferidas"
+}

modules/ticket/back/methods/ticket/transferSales.js

@@ -81,6 +81,10 @@ module.exports = Self => {
             if (ticketId != id && hasClaimedSales)
                 throw new UserError(`Can't transfer claimed sales`);
 
+            const missingSales = sales.some(({id}) => !map.has(id));
+            if (missingSales)
+                throw new UserError($t('Sales already moved'));
+
             for (const sale of sales) {
                 const originalSale = map.get(sale.id);
                 if (sale.quantity == originalSale?.quantity) {