From 45e41de9a9a47ebdc0e75577763795b1f38b24bf Mon Sep 17 00:00:00 2001
From: alexm <alexm@verdnatura.es>
Date: Tue, 3 Oct 2023 14:03:52 +0200
Subject: [PATCH] refs #5918 fix(worker_time-control): isMailSended

---
 .../00-ACL_workerDepartment.sql                  |  0
 .../updateWorkerTimeControlMail.js               | 16 ++++++++--------
 modules/worker/front/time-control/index.js       | 11 ++++++-----
 3 files changed, 14 insertions(+), 13 deletions(-)
 rename db/changes/{233601 => 234201}/00-ACL_workerDepartment.sql (100%)

diff --git a/db/changes/233601/00-ACL_workerDepartment.sql b/db/changes/234201/00-ACL_workerDepartment.sql
similarity index 100%
rename from db/changes/233601/00-ACL_workerDepartment.sql
rename to db/changes/234201/00-ACL_workerDepartment.sql
diff --git a/modules/worker/back/methods/worker-time-control/updateWorkerTimeControlMail.js b/modules/worker/back/methods/worker-time-control/updateWorkerTimeControlMail.js
index 6fe30de91d..e12cf9c592 100644
--- a/modules/worker/back/methods/worker-time-control/updateWorkerTimeControlMail.js
+++ b/modules/worker/back/methods/worker-time-control/updateWorkerTimeControlMail.js
@@ -37,9 +37,8 @@ module.exports = Self => {
         }
     });
 
-    Self.updateWorkerTimeControlMail = async(ctx, options) => {
+    Self.updateWorkerTimeControlMail = async(ctx, workerId, year, week, state, reason, options) => {
         const models = Self.app.models;
-        const args = ctx.args;
 
         const myOptions = {};
 
@@ -48,20 +47,21 @@ module.exports = Self => {
 
         const workerTimeControlMail = await models.WorkerTimeControlMail.findOne({
             where: {
-                workerFk: args.workerId,
-                year: args.year,
-                week: args.week
+                workerFk: workerId,
+                year,
+                week
             }
         }, myOptions);
 
+        console.log('workerTimeControlMail: ', workerTimeControlMail);
         if (!workerTimeControlMail) throw new UserError(`There aren't records for this week`);
 
         await workerTimeControlMail.updateAttributes({
-            state: args.state,
-            reason: args.reason || null
+            state,
+            reason: reason || null
         }, myOptions);
 
-        if (args.state == 'SENDED') {
+        if (state == 'SENDED') {
             await workerTimeControlMail.updateAttributes({
                 sendedCounter: workerTimeControlMail.sendedCounter + 1
             }, myOptions);
diff --git a/modules/worker/front/time-control/index.js b/modules/worker/front/time-control/index.js
index 0b427a10d5..4bf25886fa 100644
--- a/modules/worker/front/time-control/index.js
+++ b/modules/worker/front/time-control/index.js
@@ -143,21 +143,22 @@ class Controller extends Section {
     }
 
     isMailSended() {
-        const filterTimeControl = {
+        const filter = {
             where: {
                 year: this._date.getFullYear(),
                 week: this.getWeekNumber(this._date)
             },
             limit: 1
         };
-        this.$http.get('WorkerTimeControlMails', {filterTimeControl})
+        // no repeat request
+        this.$http.get('WorkerTimeControlMails', {filter})
             .then(res => {
                 if (!res.data.length) {
                     this.canResend = false;
                     return;
                 }
 
-                const filterDepartment = {
+                const filter = {
                     where: {
                         workerFk: this.$params.id
                     },
@@ -165,9 +166,9 @@ class Controller extends Section {
                         relation: 'department'
                     }
                 };
-                this.$http.get('WorkerDepartments', {filterDepartment})
+                this.$http.get('WorkerDepartments/findOne', {filter})
                     .then(res => {
-                        const department = res.data[0].department;
+                        const department = res.data.department;
                         if (department.isTeleworking) this.canResend = true;
                     });
             });