verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 58 Releases Wiki Activity

refactor test updateBillingData

This commit is contained in:
Bernat 2018-09-27 10:03:11 +02:00
parent 504096d702
commit 46a62854d6
2 changed files with 38 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
services/loopback/common/methods/client/specs/updateBasicData.spec.js
View File

@ -22,7 +22,7 @@ describe('Client updateBasicData', () => {
expect(error.toString()).toContain(`You don't have enough privileges to do that`);
});
it('should update the client discal data and return the count if changes made', async() => {
it('should update the client fiscal data and return the count if changes made', async() => {
let id = 101;
let client = await app.models.Client.findById(id);

50
services/loopback/common/methods/client/specs/updateBillingData.spec.js
View File

@ -3,7 +3,15 @@ const app = require(`${servicesDir}/client/server/server`);
describe('Client updateBillingData', () => {
afterAll(async() => {
let ctxOfAdmin = {req: {accessToken: {userId: 5}}};
let validparams = {iban: null};
let validparams = {
phone: 1111111111,
payMethodFk: 5,
dueDay: 0,
iban: null,
hasLcr: 0,
hasCoreVnl: 1,
hasSepaVnl: 1
};
let idWithDataChecked = 101;
await app.models.Client.updateBillingData(ctxOfAdmin, validparams, idWithDataChecked);
@ -13,7 +21,7 @@ describe('Client updateBillingData', () => {
let error;
let ctxOfNoAdmin = {req: {accessToken: {userId: 1}}};
let params = [];
let params = {iban: null};
let idWithDataChecked = 101;
await app.models.Client.updateBillingData(ctxOfNoAdmin, params, idWithDataChecked)
@ -21,29 +29,45 @@ describe('Client updateBillingData', () => {
error = e;
});
expect(error.toString()).toContain(`You don't have enough privileges to do that`);
expect(error.message).toEqual(`You don't have enough privileges to do that`);
});
it('should return an error if the user is administrative and the isTaxDataChecked value is true BUT the params aint valid', async() => {
let error;
it('should update the billing data and check if the changes were made', async() => {
let ctxOfAdmin = {req: {accessToken: {userId: 5}}};
let invalidparams = {invalid: 'param for update'};
let params = {
phone: 2222222222,
payMethodFk: 4,
dueDay: 30,
iban: 'ES91 2100 0418 4502 0005 1332',
hasLcr: 1,
hasCoreVnl: 0,
hasSepaVnl: 0
};
let idWithDataChecked = 101;
await app.models.Client.updateBillingData(ctxOfAdmin, invalidparams, idWithDataChecked)
.catch(e => {
error = e;
});
await app.models.Client.updateBillingData(ctxOfAdmin, params, idWithDataChecked);
let client = await app.models.Client.findById(idWithDataChecked);
expect(error.toString()).toContain(`You don't have enough privileges to do that`);
expect(client.phone).not.toEqual(params.phone);
expect(client.payMethodFk).toEqual(params.payMethodFk);
expect(client.dueDay).toEqual(params.dueDay);
expect(client.iban).toEqual(params.iban);
expect(client.hasLcr).toBeTruthy();
expect(client.hasCoreVnl).toBeFalsy();
expect(client.hasSepaVnl).toBeFalsy();
});
it('should return an error if the given IBAN is an invalid one', async() => {
let ctxOfAdmin = {req: {accessToken: {userId: 5}}};
let validparams = {iban: 12345};
let validparams = {
payMethodFk: 5,
iban: null};
let idWithDataChecked = 101;
await app.models.Client.updateBillingData(ctxOfAdmin, validparams, idWithDataChecked);
validparams = {iban: 12345};
try {
await app.models.Client.updateBillingData(ctxOfAdmin, validparams, idWithDataChecked);
} catch (error) {