Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 6095-refFk-null-on-search

CHANGELOG.md

@@ -1,3 +1,4 @@
+
 # Changelog
 
 All notable changes to this project will be documented in this file.

README.md

@@ -54,6 +54,12 @@ For end-to-end tests run from project's root.
 $ npm run test:e2e
 ```
 
+## Generate changeLog test → master
+```
+$ bash changelog.sh
+```
+
+
 ## Visual Studio Code extensions
 
 Open Visual Studio Code, press Ctrl+P and paste the following commands.

back/methods/chat/sendCheckingPresence.js

@@ -1,3 +1,5 @@
+const isProduction = require('vn-loopback/server/boot/isProduction');
+
 module.exports = Self => {
     Self.remoteMethodCtx('sendCheckingPresence', {
         description: 'Creates a message in the chat model checking the user status',
@@ -37,7 +39,7 @@ module.exports = Self => {
         if (!recipient)
             throw new Error(`Could not send message "${message}" to worker id ${recipientId} from user ${userId}`);
 
-        if (process.env.NODE_ENV == 'test')
+        if (!isProduction())
             message = `[Test:Environment to user ${userId}] ` + message;
 
         const chat = await models.Chat.create({

back/methods/chat/sendQueued.js

@@ -1,4 +1,6 @@
 const axios = require('axios');
+const isProduction = require('vn-loopback/server/boot/isProduction');
+
 module.exports = Self => {
     Self.remoteMethodCtx('sendQueued', {
         description: 'Send a RocketChat message',
@@ -94,7 +96,7 @@ module.exports = Self => {
      * @return {Promise} - The request promise
      */
     Self.sendMessage = async function sendMessage(senderFk, recipient, message) {
-        if (process.env.NODE_ENV !== 'production') {
+        if (!isProduction(false)) {
             return new Promise(resolve => {
                 return resolve({
                     statusCode: 200,
@@ -149,7 +151,7 @@ module.exports = Self => {
      * @return {Promise} - The request promise
      */
     Self.getUserStatus = async function getUserStatus(username) {
-        if (process.env.NODE_ENV !== 'production') {
+        if (!isProduction(false)) {
             return new Promise(resolve => {
                 return resolve({
                     data: {

back/methods/dms/deleteTrashFiles.js

@@ -1,6 +1,7 @@
 const UserError = require('vn-loopback/util/user-error');
 const fs = require('fs-extra');
 const path = require('path');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     Self.remoteMethod('deleteTrashFiles', {
@@ -22,7 +23,7 @@ module.exports = Self => {
         if (typeof options == 'object')
             Object.assign(myOptions, options);
 
-        if (process.env.NODE_ENV == 'test')
+        if (!isProduction())
             throw new UserError(`Action not allowed on the test environment`);
 
         const models = Self.app.models;

back/methods/docuware/upload.js

@@ -1,5 +1,6 @@
 const UserError = require('vn-loopback/util/user-error');
 const axios = require('axios');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     Self.remoteMethodCtx('upload', {
@@ -119,7 +120,7 @@ module.exports = Self => {
                 ]
             };
 
-            if (process.env.NODE_ENV != 'production')
+            if (!isProduction(false))
                 throw new UserError('Action not allowed on the test environment');
 
             // delete old

back/methods/image/scrub.js

@@ -1,6 +1,7 @@
 const fs = require('fs-extra');
 const path = require('path');
 const UserError = require('vn-loopback/util/user-error');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     Self.remoteMethod('scrub', {
@@ -43,8 +44,7 @@ module.exports = Self => {
     Self.scrub = async function(collection, remove, limit, dryRun, skipLock) {
         const $ = Self.app.models;
 
-        const env = process.env.NODE_ENV;
+        dryRun = dryRun || !isProduction(false);
-        dryRun = dryRun || (env && env !== 'production');
 
         const instance = await $.ImageCollection.findOne({
             fields: ['id'],

back/methods/image/upload.js

@@ -1,6 +1,7 @@
 const UserError = require('vn-loopback/util/user-error');
 const fs = require('fs/promises');
 const path = require('path');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     Self.remoteMethodCtx('upload', {
@@ -41,7 +42,7 @@ module.exports = Self => {
             if (!hasWriteRole)
                 throw new UserError(`You don't have enough privileges`);
 
-            if (process.env.NODE_ENV == 'test')
+            if (!isProduction())
                 throw new UserError(`Action not allowed on the test environment`);
 
             // Upload file to temporary path

back/methods/mrw-config/cancelShipment.js

@@ -39,8 +39,6 @@ module.exports = Self => {
         const xmlString = response.data;
         const parser = new DOMParser();
         const xmlDoc = parser.parseFromString(xmlString, 'text/xml');
-        const [resultElement] = xmlDoc.getElementsByTagName('Mensaje');
+        return xmlDoc.getElementsByTagName('Mensaje')[0].textContent;
-
-        return resultElement.textContent;
     };
 };

back/methods/mrw-config/createShipment.js

@@ -42,7 +42,8 @@ module.exports = Self => {
             throw new UserError(`Some mrwConfig parameters are not set`);
 
         const query =
-            `SELECT CASE co.code 
+            `SELECT 
+                CASE co.code 
                     WHEN 'ES' THEN a.postalCode
                     WHEN 'PT' THEN LEFT(a.postalCode, 4)
                     WHEN 'AD' THEN REPLACE(a.postalCode, 'AD', '00')
@@ -89,14 +90,9 @@ module.exports = Self => {
         const getLabelResponse = await sendXmlDoc('getLabel', {mrw, shipmentId}, 'text/xml');
         const file = getTextByTag(getLabelResponse, 'EtiquetaFile');
 
-        try {
-            await models.Expedition.updateAll({id: expeditionFk}, {externalId: shipmentId}, myOptions);
         if (tx) await tx.commit();
-        } catch (error) {
+
-            if (tx) await tx.rollback();
+        return {shipmentId, file};
-            throw error;
-        }
-        return file;
     };
 
     function getTextByTag(xmlDoc, tag) {

back/methods/mrw-config/specs/createShipment.spec.js

@@ -81,9 +81,9 @@ describe('MRWConfig createShipment()', () => {
 
         spyOn(axios, 'post').and.callFake(() => Promise.resolve(mockPostResponses.pop()));
 
-        const base64Binary = await models.MrwConfig.createShipment(expedition1.id, options);
+        const {file} = await models.MrwConfig.createShipment(expedition1.id, options);
 
-        expect(base64Binary).toEqual(mockBase64Binary);
+        expect(file).toEqual(mockBase64Binary);
     });
 
     it('should fail if mrwConfig has no data', async() => {

back/methods/notification/send.js

@@ -1,4 +1,5 @@
 const {Email} = require('vn-print');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     Self.remoteMethod('send', {
@@ -70,7 +71,7 @@ module.exports = Self => {
                     const newParams = Object.assign({}, queueParams, sendParams);
                     const email = new Email(queueName, newParams);
 
-                    if (process.env.NODE_ENV != 'test')
+                    if (isProduction())
                         await email.send();
 
                     await queue.updateAttribute('status', statusSent);

back/model-config.json

@@ -186,5 +186,8 @@
     },
     "AgencyWorkCenter": {
         "dataSource": "vn"
+    },
+    "RouteConfig": {
+        "dataSource": "vn"
     }
 }

back/models/routeConfig.json

@@ -0,0 +1,18 @@
+{
+    "name": "RouteConfig",
+	"base": "VnModel",
+    "options": {
+        "mysql": {
+            "table": "routeConfig"
+        }
+    },
+    "properties": {
+        "id": {
+            "type": "number",
+            "description": "Identifier"
+        },
+        "kmMax": {
+            "type": "number"
+        }
+    }
+}

changelog.sh

@@ -0,0 +1,34 @@
+features_types=(chore feat style)
+changes_types=(refactor perf)
+fix_types=(fix revert)
+file="CHANGELOG.md"
+file_tmp="temp_log.txt"
+file_current_tmp="temp_current_log.txt"
+
+setType(){
+    echo "### $1" >> $file_tmp
+    arr=("$@")
+    echo "" > $file_current_tmp
+    for i in "${arr[@]}"
+    do
+        git log --grep="$i" --oneline --no-merges --format="- %s %d by:%an" master..test >> $file_current_tmp
+    done
+    # remove duplicates
+    sort -o $file_current_tmp -u $file_current_tmp
+    cat $file_current_tmp >> $file_tmp
+    echo "" >> $file_tmp
+    # remove tmp current file
+    [ -e $file_current_tmp ] && rm $file_current_tmp
+}
+
+echo "# Version XX.XX - XXXX-XX-XX" >> $file_tmp
+echo "" >> $file_tmp
+
+setType "Added 🆕" "${features_types[@]}"
+setType "Changed 📦" "${changes_types[@]}"
+setType "Fixed 🛠️" "${fix_types[@]}"
+
+cat $file >> $file_tmp
+mv $file_tmp $file
+
+

db/.pullinfo.json

@@ -9,7 +9,7 @@
     },
     "vn": {
       "view": {
-        "expeditionPallet_Print": "288cbd6e8289df083ed5eb1a2c808f7a82ba4c90c8ad9781104808a7a54471fb"
+        "expeditionPallet_Print": "06613719475fcdba8309607c38cc78efc2e348cca7bc96b48dc3ae3c12426f54"
       }
     }
   }

db/routines/edi/procedures/ekt_scan.sql

@@ -23,22 +23,19 @@ BEGIN
 	DECLARE vXtraLongAgj INT;
 	DECLARE vDefaultKlo INT;
 
-	SELECT
+	SELECT usefulAuctionLeftSegmentLength,
-		ec.usefulAuctionLeftSegmentLength,
+			standardBarcodeLength,
-		ec.standardBarcodeLength,
+			floridayBarcodeLength,
-		ec.floridayBarcodeLength,
+			floramondoBarcodeLength,
-		ec.floramondoBarcodeLength,
+			defaultKlo
-		ec.defaultKlo
+		INTO vUsefulAuctionLeftSegmentLength,
-		INTO
-			vUsefulAuctionLeftSegmentLength,
 			vStandardBarcodeLength,
 			vFloridayBarcodeLength,
 			vFloramondoBarcodeLength,
 			vDefaultKlo
-		FROM edi.ektConfig ec;
+		FROM ektConfig;
 
-	DROP TEMPORARY TABLE IF EXISTS tmp.ekt;
+	CREATE OR REPLACE TEMPORARY TABLE tmp.ekt
-	CREATE TEMPORARY TABLE tmp.ekt
 		ENGINE = MEMORY
 		SELECT id ektFk FROM ekt LIMIT 0;
 
@@ -46,14 +43,14 @@ BEGIN
 		WHEN LENGTH(vBarcode) <= vFloridayBarcodeLength THEN
 			INSERT INTO tmp.ekt
 				SELECT id 
-					FROM edi.ektRecent e
+					FROM ektRecent e
 					WHERE e.cps = vBarcode
 						OR e.batchNumber = vBarcode;
 
 		WHEN LENGTH(vBarcode) = vFloramondoBarcodeLength THEN
 			INSERT INTO tmp.ekt
 				SELECT e.id 
-					FROM edi.ektRecent e
+					FROM ektRecent e
 					WHERE e.pro = MID(vBarcode,2,6) 
 						AND CAST(e.ptd AS SIGNED) = MID(vBarcode, 8, 5);
 
@@ -74,13 +71,15 @@ BEGIN
 				SELECT id
 					FROM ekt
 					WHERE fec >= vFec - INTERVAL 1 DAY
-					AND ((
+					AND (
-						vKlo = vDefaultKlo
+						(vKlo = vDefaultKlo
 							AND (klo = vKlo OR klo IS NULL OR klo = 0)
-							AND agj IN (vShortAgj, vLongAgj, vXtraLongAgj))
+							AND agj IN (vShortAgj, vLongAgj, vXtraLongAgj)
-						OR (klo = vKlo
+						) OR (
+							klo = vKlo
 							AND auction = vAuction
-							AND agj = vShortAgj)
+							AND agj = vShortAgj
+						)
 					)
 				ORDER BY agj DESC, fec DESC
 				LIMIT 1;
@@ -91,9 +90,11 @@ BEGIN
 			IF NOT vIsFound THEN
 				INSERT INTO tmp.ekt
 					SELECT id 
-						FROM edi.ektRecent e
+						FROM ektRecent e
-						WHERE e.batchNumber 
+						WHERE e.batchNumber = LEFT(
-							= LEFT(vBarcode,vUsefulAuctionLeftSegmentLength)
+								vBarcode,
+								vUsefulAuctionLeftSegmentLength
+							)
 							AND e.batchNumber > 0;
 
 				SELECT COUNT(*) FROM tmp.ekt INTO vIsFound;
@@ -103,7 +104,7 @@ BEGIN
 			IF NOT vIsFound THEN
 				INSERT INTO tmp.ekt
 					SELECT id 
-						FROM edi.ektRecent e
+						FROM ektRecent e
 						WHERE e.putOrderFk = vBarcode;
 
 				SELECT COUNT(*) FROM tmp.ekt INTO vIsFound;
@@ -113,13 +114,23 @@ BEGIN
 			IF NOT vIsFound THEN
 				INSERT INTO tmp.ekt
 					SELECT id 
-						FROM edi.ektRecent e
+						FROM ektRecent e
-						WHERE e.deliveryNumber
+						WHERE e.deliveryNumber = MID(vBarcode, 4, 13)
-					= MID(vBarcode, 4, 13)
 							AND e.deliveryNumber > 0;
 
 				SELECT COUNT(*) FROM tmp.ekt INTO vIsFound;
 			END IF;
+
+			-- Solo campo agj
+			IF NOT vIsFound THEN
+				INSERT INTO tmp.ekt
+					SELECT id 
+						FROM ektRecent
+						WHERE agj = vShortAgj;
+
+				SELECT COUNT(*) FROM tmp.ekt INTO vIsFound;
+			END IF;
+
 	END CASE;
 
 	IF vIsFound THEN

db/routines/vn/events/client_userDisable.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` EVENT `vn`.`client_userDisable`
+	ON SCHEDULE EVERY 1 MONTH
+		STARTS '2023-06-01 00:00:00.000'
+	ON COMPLETION PRESERVE
+	ENABLE
+DO CALL client_userDisable()$$
+DELIMITER ;

db/routines/vn/events/clientsDisable.sql

@@ -1,25 +0,0 @@
-DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` EVENT `vn`.`clientsDisable`
-	ON SCHEDULE EVERY 1 MONTH
-		STARTS '2023-06-01 00:00:00.000'
-	ON COMPLETION PRESERVE
-	ENABLE
-DO BEGIN
-	UPDATE account.user u
-			JOIN client c ON c.id = u.id
-			LEFT JOIN account.account a ON a.id = u.id
-		SET u.active = FALSE
-		WHERE c.typeFk = 'normal'
-			AND a.id IS NULL
-			AND u.active
-			AND c.created < util.VN_CURDATE() - INTERVAL 12 MONTH 
-			AND u.id NOT IN (
-				SELECT DISTINCT c.id
-					FROM client c
-						LEFT JOIN ticket t ON t.clientFk = c.id
-					WHERE c.salesPersonFk IS NOT NULL
-						OR t.created > util.VN_CURDATE() - INTERVAL 12 MONTH 
-						OR shipped > util.VN_CURDATE() - INTERVAL 12 MONTH 
-				);
-END$$
-DELIMITER ;

db/routines/vn/procedures/buy_clone.sql

@@ -0,0 +1,57 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`buy_clone`(vEntryFk INT)
+BEGIN
+/**
+ * Clone buys to an entry
+ *
+ * @param vEntryFk The entry id
+ * @table tmp.buy(id) 
+ */
+		INSERT INTO buy(
+				entryFk,
+				itemFk,
+				quantity,
+				buyingValue,
+				freightValue,
+				isIgnored,
+				stickers,
+				packagingFk,
+				packing,
+				`grouping`,
+				groupingMode,
+				comissionValue,
+				packageValue,
+				price1,
+				price2,
+				price3,
+				minPrice,
+				isChecked,
+				location,
+				weight,
+				itemOriginalFk)
+			SELECT vEntryFk,
+					b.itemFk,
+					b.quantity,
+					b.buyingValue,
+					b.freightValue,
+					b.isIgnored,
+					b.stickers,
+					b.packagingFk,
+					b.packing,
+					b.`grouping`,
+					b.groupingMode,
+					b.comissionValue,
+					b.packageValue,
+					b.price1,
+					b.price2,
+					b.price3,
+					b.minPrice,
+					b.isChecked,
+					b.location,
+					b.weight,
+					b.itemOriginalFk
+				FROM tmp.buy tb
+					JOIN vn.buy b ON b.id = tb.id;
+	
+END$$
+DELIMITER ;

db/routines/vn/procedures/client_userDisable.sql

@@ -0,0 +1,33 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`client_userDisable`()
+BEGIN
+/**
+* Desactiva los clientes inactivos en los últimos X meses.
+*/
+	DECLARE vMonths INT;
+
+	SELECT monthsToDisableUser INTO vMonths
+		FROM clientConfig;
+
+	IF vMonths IS NULL THEN
+		CALL util.throw('Config parameter not set');
+	END IF;
+
+	UPDATE account.user u
+			JOIN client c ON c.id = u.id
+			LEFT JOIN account.account a ON a.id = u.id
+		SET u.active = FALSE
+		WHERE c.typeFk = 'normal'
+			AND a.id IS NULL
+			AND u.active
+			AND c.created < util.VN_CURDATE() - INTERVAL vMonths MONTH 
+			AND u.id NOT IN (
+				SELECT DISTINCT c.id
+					FROM client c
+						LEFT JOIN ticket t ON t.clientFk = c.id
+					WHERE c.salesPersonFk IS NOT NULL
+						OR t.created > util.VN_CURDATE() - INTERVAL vMonths MONTH 
+						OR shipped > util.VN_CURDATE() - INTERVAL vMonths MONTH 
+			);
+END$$
+DELIMITER ;

db/routines/vn/procedures/entry_cloneHeader.sql

@@ -9,8 +9,8 @@ BEGIN
  * Clones an entry header.
  *
  * @param vSelf The entry id
+ * @param OUT vNewEntryFk The new entry id
  * @param vTravelFk Travel for the new entry or %NULL to use the source entry travel
- * @param vNewEntryFk The new entry id
  */
 	INSERT INTO entry(
 			travelFk,

db/routines/vn/procedures/entry_copyBuys.sql

@@ -1,59 +1,18 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`entry_copyBuys`(vSelf INT, vCopyTo INT)
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`entry_copyBuys`(vSelf INT, vDestinationEntryFk INT)
 BEGIN
 /**
- * Copies an entry buys to another buy.
+ * Copies all buys from an entry to an entry.
  *
  * @param vSelf The entry id
- * @param vCopyTo The destination entry id
+ * @param vDestinationEntryFk The destination entry id
  */
-	INSERT INTO buy(
+	CREATE OR REPLACE TEMPORARY TABLE tmp.buy
-			entryFk,
+		SELECT id
-			itemFk,
-			quantity,
-			buyingValue,
-			freightValue,
-			isIgnored,
-			stickers,
-			packing,
-			`grouping`,
-			groupingMode,
-			containerFk,
-			comissionValue,
-			packageValue,
-			packagingFk,
-			price1,
-			price2,
-			price3,
-			minPrice,
-			isChecked,
-			location,
-			weight,
-			itemOriginalFk
-		)
-		SELECT vCopyTo,
-				itemFk,
-				quantity,
-				buyingValue,
-				freightValue,
-				isIgnored,
-				stickers,
-				packing,
-				`grouping`,
-				groupingMode,
-				containerFk,
-				comissionValue,
-				packageValue,
-				packagingFk,
-				price1,
-				price2,
-				price3,
-				minPrice,
-				isChecked,
-				location,
-				weight,
-				itemOriginalFk
 			FROM buy
 			WHERE entryFk = vSelf;
+
+	CALL buy_clone(vDestinationEntryFk);
+	DROP TEMPORARY TABLE tmp.buy;
 END$$
 DELIMITER ;

db/routines/vn/procedures/entry_fixMisfit.sql

@@ -26,7 +26,6 @@ BEGIN
 			packing,
 			`grouping`,
 			groupingMode,
-			containerFk,
 			comissionValue,
 			packageValue,
 			location,
@@ -46,7 +45,6 @@ BEGIN
 				packing,
 				`grouping`,
 				groupingMode,
-				containerFk,
 				comissionValue,
 				packageValue,
 				location,

db/routines/vn/procedures/entry_moveNotPrinted.sql

@@ -56,7 +56,6 @@ BEGIN
 			packing,
 			`grouping`,
 			groupingMode,
-			containerFk,
 			comissionValue,
 			packageValue,
 			packagingFk,
@@ -77,7 +76,6 @@ BEGIN
 				packing,
 				`grouping`,
 				groupingMode,
-				containerFk,
 				comissionValue,
 				packageValue,
 				packagingFk,
@@ -114,7 +112,6 @@ BEGIN
 					packing,
 					`grouping`,
 					groupingMode,
-					containerFk,
 					comissionValue,
 					packageValue,
 					location,
@@ -133,7 +130,6 @@ BEGIN
 				packing,
 				`grouping`,
 				groupingMode,
-				containerFk,
 				comissionValue,
 				packageValue,
 				location,

db/routines/vn/procedures/entry_splitByShelving.sql

@@ -76,7 +76,6 @@ BEGIN
 								packing,
 								`grouping`,
 								groupingMode,
-								containerFk,
 								comissionValue,
 								packageValue,
 								location,
@@ -103,7 +102,6 @@ BEGIN
 							packing,
 							`grouping`,
 							groupingMode,
-							containerFk,
 							comissionValue,
 							packageValue,
 							location,

db/routines/vn/procedures/itemPlacementSupplyStockGetTargetList.sql

@@ -18,11 +18,12 @@ BEGIN
 			JOIN vn.parking p ON p.id = sh.parkingFk
 			JOIN vn.sector sc ON sc.id = p.sectorFk
 			JOIN vn.warehouse w ON w.id = sc.warehouseFk
-		WHERE sc.id = vSectorFk
+		WHERE ish.visible > 0
-			AND ish.visible > 0
 			AND ish.itemFk = vItemFk
 		GROUP BY ish.id
-		ORDER BY sh.priority DESC,
+		ORDER BY 
+			(sc.id = vSectorFk) DESC,
+			sh.priority DESC,
 			ish.created, 
 			p.pickingOrder;
 END$$

db/routines/vn/procedures/itemShelving_getItemDetails.sql

@@ -0,0 +1,55 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`itemShelving_getItemDetails`(
+	vBarcodeItem INT, 
+	vShelvingFK VARCHAR(10) 
+)
+BEGIN
+/**
+ * Obtiene el precio y visible de un item
+ *
+ * @param vBarcodeItem barcode de artículo
+ * @param vShelvingFK Ubicación actual del artículo
+ */
+	DECLARE vIsItem BOOL;
+	DECLARE vBuyFk INT;
+	DECLARE vWarehouseFk INT;
+
+	SELECT COUNT(*) > 0 INTO vIsItem 
+		FROM item 
+		WHERE id = vBarcodeItem;
+
+	IF vIsItem THEN 
+		SELECT warehouseFk INTO vWarehouseFk
+			FROM operator
+			WHERE workerFk = account.myUser_getId();
+
+		CALL buyUltimate(vWarehouseFk, util.VN_CURDATE());
+
+		SELECT buyFk INTO vBuyFk
+			FROM  tmp.buyUltimate
+			WHERE itemFk = vBarcodeItem
+				AND warehouseFk = vWarehouseFk;
+
+		DELETE FROM tmp.buyUltimate;		
+	ELSE
+		SELECT vBarcodeItem INTO vBuyFk;
+	END IF;
+		
+	WITH visible AS(
+		SELECT itemFk,
+				IFNULL(buyingValue, 0) +
+							IFNULL(freightValue, 0) +
+							IFNULL(comissionValue, 0) +
+							IFNULL(packageValue, 0) itemCost
+			FROM vn.buy b 
+			WHERE b.id = vBuyFk
+	) SELECT v.itemFk,
+			vShelvingFK,
+			v.itemCost,
+			SUM(ish.visible) visible
+		FROM vn.itemShelving ish
+			JOIN visible v
+		WHERE ish.shelvingFK = vShelvingFK COLLATE utf8mb3_general_ci
+				AND ish.itemFk = v.itemFk;
+END$$
+DELIMITER ;

db/routines/vn/procedures/item_comparative.sql

@@ -23,7 +23,6 @@ proc: BEGIN
  * @param tmp.comparativeFilterType(filterFk INT ,itemTypeFk INT)
  * @return tmp.comparative
  */
-
 	DECLARE vDayRangeStart DATE;
 	DECLARE vDayRangeEnd DATE;
 	DECLARE w1, w2, w3, w4, w5, w6, w7 INT;
@@ -59,14 +58,14 @@ proc: BEGIN
 	END IF;
 
 	SELECT MIN(dated) INTO vDayRangeStart
-		FROM vn.time
+		FROM `time`
 		WHERE dated <= vDate
 			GROUP BY period
 			ORDER BY dated desc 
 		LIMIT 1 OFFSET vWeekRange;
 
 	SELECT MAX(dated) INTO vDayRangeEnd
-		FROM vn.time
+		FROM `time`
 		WHERE dated >= vDate
 			GROUP BY period
 			ORDER BY dated ASC 
@@ -83,12 +82,11 @@ proc: BEGIN
 				JOIN itemType t ON t.id = i.typeFk
 				JOIN itemCategory c ON c.id = t.categoryFk
 				LEFT JOIN worker w ON w.id = t.workerFk
-			WHERE (NOT vHasTypeFilter
+			WHERE (NOT vHasTypeFilter OR t.id IN (
-					OR t.id IN (SELECT itemTypeFk FROM tmp.comparativeFilterType))
+					SELECT itemTypeFk FROM tmp.comparativeFilterType
-				AND (vBuyerFk IS NULL
+				))
-					OR t.workerFk = vBuyerFk) 
+				AND (vBuyerFk IS NULL OR t.workerFk = vBuyerFk) 
-				AND (vIsFloramondo IS NULL
+				AND (vIsFloramondo IS NULL OR i.isFloramondo = vIsFloramondo); 
-					OR i.isFloramondo = vIsFloramondo); 
 
 	IF vDate < util.VN_CURDATE() THEN
 		ALTER TABLE tmp.itemInventory
@@ -115,10 +113,11 @@ proc: BEGIN
 		SET i = i + 1;
 
 		SELECT t.period INTO vPeriod
-			FROM vn.`time` t
+			FROM `time` t
 			WHERE t.dated = vDayRangeStart + INTERVAL (vWeekCount * (i - 1)) DAY;
 
-		INSERT IGNORE INTO tTable(cy, ly, zy) VALUES(vPeriod, vPeriod - 100, vPeriod - 200);
+		INSERT IGNORE INTO tTable(cy, ly, zy)
+			VALUES(vPeriod, vPeriod - 100, vPeriod - 200);
 	UNTIL i = vWeekCount END REPEAT;
 
 	SELECT cy, ly, zy INTO w1, y1, z1 FROM tTable LIMIT 1;
@@ -130,7 +129,6 @@ proc: BEGIN
 	SELECT cy, ly, zy INTO w7, y7, z7 FROM tTable WHERE cy > w6 LIMIT 1;
 
 	-- Genera una tabla con los datos del año pasado.
-
 	CREATE OR REPLACE TEMPORARY TABLE tLastYear
 		(KEY (lItemFk))
 		ENGINE = MEMORY
@@ -151,15 +149,14 @@ proc: BEGIN
 				SUM(IF(c.timePeriod = y7, c.price, 0)) lprice7
 			FROM tmp.itemInventory ai
 				JOIN comparative c ON c.itemFk = ai.id
-				JOIN warehouse w on w.id = c.warehouseFk
+				JOIN warehouse w ON w.id = c.warehouseFk
 				JOIN tTable wt ON c.timePeriod = wt.ly
-			WHERE IFNULL(vWarehouseFk, c.warehouseFk) = c.warehouseFk
+			WHERE (vWarehouseFk IS NULL OR vWarehouseFk = c.warehouseFk)
 				AND w.isComparative
 				AND (vCountryFk IS NULL OR c.countryFk = vCountryFk)
 			GROUP BY ai.id;
 
-	-- Genera una tabla con los datos de hace DOS años.
+	-- Genera una tabla con los datos de hace 2 años
-
 	CREATE OR REPLACE TEMPORARY TABLE tTwoYearsAgo
 		(KEY (tItemFk))
 		ENGINE = MEMORY
@@ -180,59 +177,58 @@ proc: BEGIN
 				SUM(IF(c.timePeriod = z7, c.price, 0)) vlprice7
 			FROM tmp.itemInventory ai
 				JOIN comparative c ON c.itemFk = ai.id
-				JOIN warehouse w on w.id = c.warehouseFk
+				JOIN warehouse w ON w.id = c.warehouseFk
 				JOIN tTable wt ON c.timePeriod = wt.zy
-			WHERE IFNULL(vWarehouseFk, c.warehouseFk) = c.warehouseFk
+			WHERE (vWarehouseFk IS NULL OR vWarehouseFk = c.warehouseFk)
 				AND w.isComparative
 				AND (vCountryFk IS NULL OR c.countryFk = vCountryFk)
 			GROUP BY ai.id;
 
-	-- Genera una tabla con los datos de este año.ss
+	-- Genera una tabla con los datos de este año
-
 	CREATE OR REPLACE TEMPORARY TABLE tCurrentYear
 		(KEY (cItemFk))
 		ENGINE = MEMORY
 		SELECT t.itemFk cItemFk,
-				SUM(IF(week = w1, total, 0)) cweek1,
+				SUM(IF(`week` = w1, total, 0)) cweek1,
-				SUM(IF(week = w2, total, 0)) cweek2,
+				SUM(IF(`week` = w2, total, 0)) cweek2,
-				SUM(IF(week = w3, total, 0)) cweek3,
+				SUM(IF(`week` = w3, total, 0)) cweek3,
-				SUM(IF(week = w4, total, 0)) cweek4,
+				SUM(IF(`week` = w4, total, 0)) cweek4,
-				SUM(IF(week = w5, total, 0)) cweek5,
+				SUM(IF(`week` = w5, total, 0)) cweek5,
-				SUM(IF(week = w6, total, 0)) cweek6,
+				SUM(IF(`week` = w6, total, 0)) cweek6,
-				SUM(IF(week = w7, total, 0)) cweek7,
+				SUM(IF(`week` = w7, total, 0)) cweek7,
-				SUM(IF(week = w1, price, 0)) cprice1,
+				SUM(IF(`week` = w1, price, 0)) cprice1,
-				SUM(IF(week = w2, price, 0)) cprice2,
+				SUM(IF(`week` = w2, price, 0)) cprice2,
-				SUM(IF(week = w3, price, 0)) cprice3,
+				SUM(IF(`week` = w3, price, 0)) cprice3,
-				SUM(IF(week = w4, price, 0)) cprice4,
+				SUM(IF(`week` = w4, price, 0)) cprice4,
-				SUM(IF(week = w5, price, 0)) cprice5,
+				SUM(IF(`week` = w5, price, 0)) cprice5,
-				SUM(IF(week = w6, price, 0)) cprice6,
+				SUM(IF(`week` = w6, price, 0)) cprice6,
-				SUM(IF(week = w7, price, 0)) cprice7
+				SUM(IF(`week` = w7, price, 0)) cprice7
 			FROM (
 				SELECT s.itemFk,
 						ti.period `week`,
 						SUM(s.quantity) total,
 						TRUNCATE(SUM(s.quantity * s.priceFixed), 0) price
-					FROM ticket t
+					FROM ticket t FORCE INDEX (Fecha)
 						JOIN sale s ON t.id = s.ticketFk
 						JOIN tmp.itemInventory it ON it.id = s.itemFk
-						JOIN time ti ON ti.dated = DATE(t.shipped)
+						JOIN `time` ti ON ti.dated = DATE(t.shipped)
 						JOIN item i ON i.id = s.itemFk
 						JOIN itemType tp ON tp.id = i.typeFk
 						JOIN itemCategory ic ON ic.id = tp.categoryFk
 						JOIN warehouse w ON w.id = t.warehouseFk
-						STRAIGHT_JOIN address ad ON ad.id = t.addressFk
+						JOIN `address` ad ON ad.id = t.addressFk
 						JOIN province p ON p.id = ad.provinceFk
 						JOIN `client` c ON c.id = ad.clientFk
 					WHERE t.shipped BETWEEN vDayRangeStart AND util.dayEnd(vDayRangeEnd)
-						AND c.typeFk IN ('Normal','handMaking')
+						AND c.typeFk IN ('normal', 'handMaking')
-						AND w.id = COALESCE(vWarehouseFk, w.id)
+						AND (vWarehouseFk IS NULL OR vWarehouseFk = w.id)
-						AND w.isComparative
 						AND (vCountryFk IS NULL OR p.countryFk = vCountryFk)
-					GROUP BY i.id, week
+						AND w.isComparative
+					GROUP BY i.id, `week`
 			) t
 			GROUP BY t.itemFk;
 
-	-- Genera la tabla con la comparativa.
+	-- Genera la tabla con la comparativa
 	CREATE OR REPLACE TEMPORARY TABLE tmp.comparative
 		ENGINE = MEMORY
 		SELECT it.subName productor,
@@ -240,13 +236,13 @@ proc: BEGIN
 				b.buyingValue costefijo,
 				b.groupingMode caja,
 				it.image ArticleImage,
-				IFNULL(it.inkFk,"?") color,
+				IFNULL(it.inkFk, '?') color,
 				tp.code tipo,
 				it.typeFk tipo_id,
 				o.code origen,
 				it.category categoria,
 				it.stems tallos,
-				it.size medida,
+				it.`size` medida,
 				it.name article,
 				w.code codigoTrabajador,
 				tp.categoryFk reino_id,
@@ -264,17 +260,20 @@ proc: BEGIN
 				e.id provider_id,
 				it.comment comments,
 				it.description itemDescription,
-				IF(cy.cItemFk IS NULL AND i.visible = 0 AND i.avalaible = 0 
+				IF(cy.cItemFk IS NULL AND i.visible = 0
-					AND IFNULL(i.sd, 0) = 0, FALSE, TRUE) filtret,
+					AND i.avalaible = 0 AND (i.sd IS NULL OR i.sd = 0), 
+					FALSE,
+					TRUE
+				) filtret,
 				IF(it.hasMinPrice, FORMAT(it.minPrice, 2), "") pvp,
 				s.company_name
 			FROM tmp.itemInventory i
 				JOIN item it ON it.id = i.id
-				LEFT JOIN itemType tp ON tp.id = it.typeFk
+				JOIN itemType tp ON tp.id = it.typeFk
-				LEFT JOIN worker w ON w.id = tp.workerFk
+				JOIN worker w ON w.id = tp.workerFk
 				LEFT JOIN buy b ON b.id = i.buy_id
-				LEFT JOIN entry e ON e.id = b.entryFk
+				LEFT JOIN `entry` e ON e.id = b.entryFk
-				LEFT JOIN origin o ON o.id = it.originFk
+				JOIN origin o ON o.id = it.originFk
 				LEFT JOIN tLastYear ly ON ly.lItemFk = it.id
 				LEFT JOIN tCurrentYear cy ON cy.cItemFk = it.id
 				LEFT JOIN tTwoYearsAgo zy ON zy.tItemFk = it.id
@@ -287,8 +286,8 @@ proc: BEGIN
 				OR ly.lweek1 OR ly.lweek2 OR ly.lweek3 OR ly.lweek4 OR ly.lweek5 OR ly.lweek6 OR ly.lweek7 
 				OR zy.vlweek1 OR zy.vlweek2 OR zy.vlweek3 OR zy.vlweek4 OR zy.vlweek5 OR zy.vlweek6 OR zy.vlweek7;
 
-	-- Elimina las tablas temporales creadas...
+	DROP TEMPORARY TABLE IF EXISTS
-	DROP TEMPORARY TABLE IF EXISTS tmp.itemInventory,
+		tmp.itemInventory,
 		tTwoYearsAgo,
 		tLastYear,
 		tCurrentYear,

db/routines/vn/procedures/item_devalueA2.sql

@@ -0,0 +1,408 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`item_devalueA2`(
+	vSelf INT, 
+	vShelvingFK VARCHAR(10), 
+	vBuyingValue DECIMAL(10,4),
+	vQuantity INT
+)
+BEGIN
+/**
+ * Devalua un item modificando su calidad de A1 a A2.
+ * Si no existe el item A2 lo crea y genera los movimientos de las entradas 
+ * de almacén y shelvings correspondientes
+ *
+ * @param vSelf Id de artículo a devaluar
+ * @param vShelvingFK Ubicación actual del artículo
+ * @param vBuyingValue Nuevo precio de coste
+ * @param vQuantity Cantidad del ítem a pasar a A2
+ */
+	DECLARE vItemA2Fk INT;
+	DECLARE vLastBuyFk BIGINT;
+	DECLARE vA1BuyFk INT;
+	DECLARE vA2BuyFk INT;
+	DECLARE vTargetEntryFk INT;
+	DECLARE vTargetEntryDate DATE;
+	DECLARE vTargetItemShelvingFk BIGINT;
+	DECLARE vWarehouseFk INT;
+	DECLARE vCacheFk INT;
+	DECLARE vLastEntryFk INT;
+	DECLARE vCurrentVisible INT;
+	DECLARE vDevalueTravelFk INT;
+	DECLARE vCurdate DATE;
+	DECLARE vBuyingValueOriginal DECIMAL(10,4);
+
+	DECLARE CONTINUE HANDLER FOR SQLEXCEPTION
+	BEGIN
+		ROLLBACK;
+		RESIGNAL;
+	END;
+
+	IF (SELECT TRUE FROM item WHERE id = vSelf AND (category <> 'A1' OR category IS NULL)) THEN 
+		CALL util.throw('Item has not category A1');
+	END IF; 
+
+	SELECT warehouseFk INTO vWarehouseFk
+		FROM userConfig 
+		WHERE userFk = account.myUser_getId();
+
+	IF NOT vWarehouseFk OR  vWarehouseFk IS NULL THEN 
+		CALL util.throw ('Operator has not a valid warehouse');
+	END IF;
+
+	IF vQuantity <= 0 OR vQuantity IS NULL THEN 
+		CALL util.throw ('The quantity is incorrect');
+	END IF;
+
+	SELECT util.VN_CURDATE() INTO vCurdate;
+	
+	SELECT t.id INTO vDevalueTravelFk
+		FROM travel t
+			JOIN travelConfig tc
+		WHERE t.shipped = vCurdate
+			AND t.landed = vCurdate
+			AND t.warehouseInFk = vWarehouseFk
+			AND t.warehouseOutFk = tc.devalueWarehouseOutFk
+			AND t.agencyModeFk = tc.devalueAgencyModeFk
+		LIMIT 1;
+
+	IF NOT vDevalueTravelFk OR vDevalueTravelFk IS NULL THEN
+		INSERT INTO travel ( 
+				shipped, 
+				landed, 
+				warehouseInFk, 
+				warehouseOutFk, 
+				`ref`, 
+				isReceived, 
+				agencyModeFk)
+			SELECT vCurdate, 
+					vCurdate, 
+					vWarehouseFk, 
+					tc.devalueWarehouseOutFk, 
+					tc.devalueRef, 
+					TRUE, 
+					tc.devalueAgencyModeFk
+				FROM travelConfig tc;
+		SET vDevalueTravelFk = LAST_INSERT_ID();	
+	END IF;
+
+	SELECT id, DATE(dated) INTO vTargetEntryFk, vTargetEntryDate
+		FROM `entry` e
+ 		WHERE DATE(dated) = vCurdate
+			AND typeFk = 'devaluation'
+			AND travelFk = vDevalueTravelFk
+		ORDER BY created DESC
+		LIMIT 1;
+
+	CALL buyUltimate(vWarehouseFk, vCurdate);
+
+	SELECT b.entryFk, bu.buyFk,IFNULL(b.buyingValue, 0) INTO vLastEntryFk, vLastBuyFk, vBuyingValueOriginal
+		FROM tmp.buyUltimate bu
+			JOIN vn.buy b ON b.id = bu.buyFk
+		WHERE bu.itemFk = vSelf
+			AND bu.warehouseFk = vWarehouseFk;
+
+	IF vBuyingValue > vBuyingValueOriginal THEN
+			CALL util.throw ('Price not valid');
+	END IF;
+
+	IF vLastEntryFk IS NULL OR vLastBuyFk IS NULL THEN
+		CALL util.throw ('The item has not a buy');
+	END IF;
+
+	SELECT id,visible INTO vTargetItemShelvingFk, vCurrentVisible
+		FROM itemShelving
+		WHERE shelvingFk = vShelvingFK COLLATE utf8mb3_general_ci
+			AND itemFk = vSelf
+		LIMIT 1;
+	
+	IF vCurrentVisible IS NULL THEN
+		CALL util.throw ('The shelving has not a visible for this item');
+	END IF;
+
+	IF vQuantity > vCurrentVisible THEN
+		CALL util.throw('Quantity is greater than visible');
+	END IF;	
+		
+	START TRANSACTION;
+
+	IF NOT vTargetEntryFk OR vTargetEntryFk IS NULL 
+			OR NOT vTargetEntryDate <=> vCurdate THEN
+		INSERT INTO entry(
+			travelFk,
+			supplierFk,
+			dated,
+			commission,
+			currencyFk,
+			companyFk,
+			clonedFrom,
+			typeFk
+		)
+		SELECT vDevalueTravelFk,
+				supplierFk,
+				vCurdate,
+				commission,
+				currencyFk,
+				companyFk,
+				vLastEntryFk,
+				'devaluation'
+			FROM entry
+			WHERE id = vLastEntryFk;
+			
+		SET vTargetEntryFk 	= LAST_INSERT_ID();	
+	END IF;
+	
+	SELECT i.id INTO vItemA2Fk
+		FROM item i
+			JOIN (
+				SELECT i.id,
+						i.name,
+						i.subname,
+						i.value5,
+						i.value6,
+						i.value7,
+						i.value8,
+						i.value9,
+						i.value10,
+						i.NumberOfItemsPerCask,
+						i.EmbalageCode,
+						i.quality
+					FROM item i
+					WHERE i.id = vSelf
+			)i2 ON i2.name <=> i.name
+				AND i2.subname <=> i.subname
+				AND i2.value5 <=> i.value5
+				AND i2.value6 <=> i.value6
+				AND i2.value8 <=> i.value8
+				AND i2.value9 <=> i.value9
+				AND i2.value10 <=> i.value10
+				AND i2.NumberOfItemsPerCask <=> i.NumberOfItemsPerCask
+				AND i2.EmbalageCode <=> i.EmbalageCode
+				AND i2.quality <=> i.quality
+		WHERE i.id <> i2.id 
+			AND i.category = 'A2'
+		LIMIT 1;
+
+	IF vItemA2Fk IS NULL THEN
+		INSERT INTO item (
+				equivalent, 
+				name, 
+				`size`, 
+				stems, 
+				minPrice, 
+				isToPrint, 
+				family, 
+				box, 
+				category, 
+				originFk, 
+				doPhoto, 
+				image, 
+				inkFk, 
+				intrastatFk, 
+				hasMinPrice, 
+				created, 
+				comment, 
+				typeFk, 
+				generic, 
+				producerFk, 
+				description, 
+				density, 
+				relevancy, 
+				expenseFk, 
+				isActive, 
+				longName, 
+				subName, 
+				minimum, 
+				upToDown, 
+				supplyResponseFk, 
+				hasKgPrice, 
+				isFloramondo, 
+				isFragile, 
+				numberOfItemsPerCask, 
+				embalageCode, 
+				quality, 
+				stemMultiplier, 
+				itemPackingTypeFk, 
+				packingOut, 
+				genericFk, 
+				isLaid, 
+				lastUsed,
+				weightByPiece, 
+				editorFk, 
+				recycledPlastic, 
+				nonRecycledPlastic) 
+			SELECT equivalent, 
+					name, 
+					`size`, 
+					stems, 
+					minPrice, 
+					isToPrint, 
+					family, 
+					box, 
+					'A2', 
+					originFk, 
+					doPhoto, 
+					image, 
+					inkFk, 
+					intrastatFk, 
+					hasMinPrice, 
+					created, 
+					comment, 
+					typeFk, 
+					generic, 
+					producerFk, 
+					description, 
+					density, 
+					relevancy, 
+					expenseFk, 
+					isActive, 
+					longName, 
+					subName,
+					minimum, 
+					upToDown, 
+					supplyResponseFk, 
+					hasKgPrice, 
+					isFloramondo, 
+					isFragile, 
+					numberOfItemsPerCask, 
+					embalageCode, 
+					quality, 
+					stemMultiplier, 
+					itemPackingTypeFk, 
+					packingOut, 
+					genericFk, 
+					isLaid, 
+					lastUsed,
+					weightByPiece, 
+					editorFk, 
+					recycledPlastic, 
+					nonRecycledPlastic
+				FROM item 
+				WHERE id = vSelf;
+
+		SET vItemA2Fk = LAST_INSERT_ID();
+
+		INSERT INTO itemTag (itemFk, tagFk, `value`, intValue, priority, editorFk) 
+			SELECT vItemA2Fk, tagFk, `value`, intValue, priority, editorFk
+				FROM itemTag 
+				WHERE id = vSelf;
+
+		UPDATE itemTaxCountry itc
+				JOIN itemTaxCountry itc2 ON itc2.itemFk = vSelf
+					AND itc2.countryFk = itc.countryFk
+			SET itc2.taxClassFk = itc.taxClassFk
+			WHERE itc.id = vItemA2Fk;
+
+		INSERT INTO itemBotanical (itemFk, genusFk, specieFk) 
+			SELECT vItemA2Fk, genusFk, specieFk
+				FROM itemBotanical 
+				WHERE itemFk = vSelf;
+	END IF;
+
+	IF vQuantity = vCurrentVisible THEN
+		DELETE FROM itemShelving
+			WHERE id = vTargetItemShelvingFk;
+	ELSE
+		UPDATE itemShelving
+			SET visible = vCurrentVisible - vQuantity
+			WHERE id = vTargetItemShelvingFk;
+	END IF;
+
+	INSERT INTO buy(
+			entryFk,
+			itemFk,
+			quantity,
+			buyingValue,
+			freightValue,
+			isIgnored,
+			stickers,
+			packagingFk,
+			packing,
+			`grouping`,
+			groupingMode,
+			comissionValue,
+			packageValue,
+			price1,
+			price2,
+			price3,
+			minPrice,
+			isChecked,
+			location,
+			weight,
+			itemOriginalFk)
+		SELECT vTargetEntryFk,
+				itemFk,
+				- LEAST(vQuantity, vCurrentVisible),
+				buyingValue,
+				freightValue,
+				TRUE,
+				stickers,
+				packagingFk,
+				packing,
+				`grouping`,
+				groupingMode,
+				comissionValue,
+				packageValue,
+				price1,
+				price2,
+				price3,
+				minPrice,
+				isChecked,
+				location,
+				weight,
+				itemOriginalFk
+			FROM vn.buy 
+			WHERE id = vLastBuyFk
+		UNION 
+		SELECT vTargetEntryFk,
+				vItemA2Fk,
+				vQuantity,
+				vBuyingValue,
+				freightValue,
+				TRUE,
+				stickers,
+				packagingFk,
+				packing,
+				`grouping`,
+				groupingMode,
+				comissionValue,
+				packageValue,
+				price1,
+				price2,
+				price3,
+				minPrice,
+				isChecked,
+				location,
+				weight,
+				itemOriginalFk
+			FROM vn.buy 
+			WHERE id = vLastBuyFk;
+
+	INSERT IGNORE INTO itemShelving (
+			itemFk, 
+			shelvingFk, 
+			visible, 
+			`grouping`, 
+			packing, 
+			packagingFk, 
+			userFk, 
+			isChecked) 
+		SELECT vItemA2Fk, 
+				shelvingFk, 
+				vQuantity ,
+				`grouping`, 
+				packing, 
+				packagingFk, 
+				account.myUser_getId(), 
+				isChecked
+			FROM itemShelving
+			WHERE itemFK = vSelf
+				AND shelvingFk = vShelvingFK COLLATE utf8mb3_general_ci
+			ON DUPLICATE KEY UPDATE 
+				visible = vQuantity + VALUES(visible);
+
+	COMMIT;
+	CALL cache.visible_refresh(vCacheFk, TRUE, vWarehouseFk);
+	CALL cache.available_refresh(vCacheFk, TRUE, vWarehouseFk, vCurdate);
+	CALL buy_recalcPricesByBuy(vA2BuyFk);
+END$$
+DELIMITER ;

db/routines/vn/procedures/supplierPackaging_ReportSource.sql

@@ -35,7 +35,7 @@ BEGIN
 						itemFk,
 						longName,
 						supplier,
-						entryFk,
+						CONCAT('E',entryFk) entryFk,
 						landed,
 						`in`,
 						`out`,
@@ -49,16 +49,98 @@ BEGIN
 						itemFk,
 						longName,
 						supplier,
-						'previous',
+						'E previous',
 						vFromDated,
 						SUM(`in`),
 						SUM(`out`),
 						NULL,
-						buyingValue
+						AVG(buyingValue)
 					FROM supplierPackaging
 					WHERE supplierFk = vSupplierFk
 						AND landed < vFromDated
 					GROUP BY itemFk
+				UNION ALL
+				SELECT vSupplierFk,
+						s.itemFk,
+						i.longName,
+						c.name,
+						CONCAT('T',s.ticketFk),
+						DATE(t.shipped),
+						-LEAST(s.quantity,0) `in`,
+						GREATEST(s.quantity,0) `out`,
+						t.warehouseFk,
+						s.price * (100 - s.discount) / 100
+					FROM sale s
+						JOIN item i ON i.id = s.itemFk
+						JOIN packaging p ON p.itemFk = i.id
+						JOIN ticket t ON t.id = s.ticketFk
+						JOIN client c ON c.id = t.clientFk
+						JOIN supplier su ON su.nif = c.fi
+					WHERE su.id = vSupplierFk
+						AND t.shipped >= vFromDated
+						AND p.isPackageReturnable
+				UNION ALL
+				SELECT vSupplierFk,
+						s.itemFk,
+						i.longName,
+						c.name,
+						'T previous',
+						vFromDated,
+						SUM(-LEAST(s.quantity,0)) `in`,
+						SUM(GREATEST(s.quantity,0)) `out`,
+						NULL,
+						AVG(s.price * (100 - s.discount) / 100)
+					FROM sale s
+						JOIN item i ON i.id = s.itemFk
+						JOIN packaging p ON p.itemFk = i.id
+						JOIN ticket t ON t.id = s.ticketFk
+						JOIN client c ON c.id = t.clientFk
+						JOIN supplier su ON su.nif = c.fi
+					WHERE su.id = vSupplierFk
+						AND t.shipped < vFromDated
+						AND p.isPackageReturnable
+					GROUP BY s.itemFk
+				UNION ALL
+				SELECT vSupplierFk,
+						p.itemFk,
+						i.longName,
+						c.name,
+						CONCAT('TP',tp.ticketFk),
+						DATE(t.shipped),
+						-LEAST(tp.quantity,0) `in`,
+						GREATEST(tp.quantity,0) `out`,
+						t.warehouseFk,
+						0
+					FROM ticketPackaging tp
+						JOIN packaging p ON p.id = tp.packagingFk
+						JOIN item i ON i.id = p.itemFk
+						JOIN ticket t ON t.id = tp.ticketFk
+						JOIN client c ON c.id = t.clientFk
+						JOIN supplier su ON su.nif = c.fi
+					WHERE su.id = vSupplierFk
+						AND t.shipped >= vFromDated
+						AND p.isPackageReturnable
+				UNION ALL
+				SELECT vSupplierFk,
+						p.itemFk,
+						i.longName,
+						c.name,
+						'TP previous',
+						vFromDated,
+						SUM(-LEAST(tp.quantity,0)) `in`,
+						SUM(GREATEST(tp.quantity,0)) `out`,
+						NULL,
+						0
+					FROM ticketPackaging tp
+						JOIN packaging p ON p.id = tp.packagingFk
+						JOIN item i ON i.id = p.itemFk
+						JOIN ticket t ON t.id = tp.ticketFk
+						JOIN client c ON c.id = t.clientFk
+						JOIN supplier su ON su.nif = c.fi
+					WHERE su.id = vSupplierFk
+						AND t.shipped >= vFromDated
+						AND p.isPackageReturnable
+					GROUP BY p.itemFk
 					ORDER BY itemFk, landed, entryFk
 				) sub
 			WHERE `out` OR `in`;
@@ -69,8 +151,8 @@ BEGIN
 			supplier,
 			entryFk,
 			landed,
-			`in`,
+			CAST(`in` AS DECIMAL(10,0)) `in`,
-			`out`,
+			CAST(`out` AS DECIMAL(10,0)) `out`,
 			warehouse,
 			buyingValue,
 			balance

db/routines/vn/procedures/ticketPackaging_add.sql

@@ -27,7 +27,10 @@ BEGIN
 		SELECT DISTINCT clientFk
 			FROM (
 				SELECT clientFk, SUM(quantity) totalQuantity
-					FROM tmp.packagingToInvoice
+					FROM tmp.packagingToInvoice tpi
+						JOIN client c ON c.id = tpi.clientFk
+						LEFT JOIN supplier s ON s.nif = c.fi
+					WHERE s.id IS NULL
 					GROUP BY itemFk, clientFk
 					HAVING totalQuantity > 0)sub;
 

db/routines/vn/procedures/worker_checkMultipleDevice.sql

@@ -0,0 +1,24 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`worker_checkMultipleDevice`(
+	vSelf INT
+)
+BEGIN
+/**
+ * Verify if a worker has multiple assigned devices,
+ * except for freelancers.
+ *
+ * @param vUserFk worker id.
+ */
+	DECLARE vHasPda BOOLEAN;
+	DECLARE vIsFreelance BOOLEAN;
+	DECLARE vMaxDevicesPerUser INT;
+	
+	SELECT COUNT(*) INTO vHasPda FROM deviceProductionUser WHERE userFk = vSelf; 
+	SELECT IFNULL(isFreelance, FALSE) INTO vIsFreelance FROM worker WHERE id = vSelf;
+	SELECT IFNULL(maxDevicesPerUser, FALSE)  INTO vMaxDevicesPerUser FROM deviceProductionConfig LIMIT 1;
+
+	IF NOT vIsFreelance AND vHasPda > vMaxDevicesPerUser THEN
+		CALL util.throw('You can only have one PDA');
+	END IF;
+END$$
+DELIMITER ;

db/routines/vn/triggers/deviceProductionUser_afterInsert.sql

@@ -0,0 +1,8 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`deviceProductionUser_afterInsert`
+	AFTER INSERT ON `deviceProductionUser`
+	FOR EACH ROW
+BEGIN
+	CALL worker_checkMultipleDevice(NEW.userFk);
+END$$
+DELIMITER ;

db/routines/vn/triggers/deviceProductionUser_beforeUpdate.sql

@@ -3,6 +3,8 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`deviceProductionUser_
 	BEFORE UPDATE ON `deviceProductionUser`
 	FOR EACH ROW
 BEGIN
+	
+	CALL worker_checkMultipleDevice(NEW.userFk);
 	SET NEW.editorFk = account.myUser_getId();
 END$$
 DELIMITER ;

db/routines/vn/views/saleVolume.sql

@@ -37,7 +37,7 @@ FROM (
 			)
 			JOIN `vn`.`volumeConfig` `vc`
 		)
-		JOIN `vn`.`itemCost` `ic` ON(
+		JOIN `vn`.`itemCost` `ic` FORCE INDEX (`PRIMARY`) ON(
 			`ic`.`itemFk` = `s`.`itemFk`
 			AND `ic`.`warehouseFk` = `t`.`warehouseFk`
 		)

db/routines/vn2008/views/Compres.sql

@@ -28,6 +28,5 @@ AS SELECT `c`.`id` AS `Id_Compra`,
 	`c`.`workerFk` AS `Id_Trabajador`,
 	`c`.`weight` AS `weight`,
 	`c`.`dispatched` AS `dispatched`,
-	`c`.`containerFk` AS `container_id`,
 	`c`.`itemOriginalFk` AS `itemOriginalFk`
 FROM `vn`.`buy` `c`

db/versions/10955-orangeRuscus/00-firstScript.sql

@@ -0,0 +1,17 @@
+INSERT IGNORE INTO vn.entryType (code, description)
+	VALUES ('devaluation', 'Devaluación');
+
+ALTER TABLE vn.travelConfig ADD IF NOT EXISTS devalueWarehouseOutFk SMALLINT(6) UNSIGNED NULL 
+	COMMENT 'Datos del travel para las entradas generadas al devaluar artículos de A1 a A2';
+
+ALTER TABLE vn.travelConfig ADD IF NOT EXISTS devalueAgencyModeFk INT(11) NULL;
+ALTER TABLE vn.travelConfig ADD IF NOT EXISTS devalueRef varchar(20) NULL;
+
+ALTER TABLE vn.travelConfig DROP FOREIGN KEY IF EXISTS travelConfig_agencyMode_FK;
+
+ALTER TABLE vn.travelConfig ADD CONSTRAINT travelConfig_agencyMode_FK 
+	FOREIGN KEY (devalueAgencyModeFk) REFERENCES vn.agencyMode(id) ON DELETE SET NULL ON UPDATE CASCADE;
+
+ALTER TABLE vn.travelConfig DROP FOREIGN KEY IF EXISTS travelConfig_warehouse_FK;
+ALTER TABLE vn.travelConfig ADD CONSTRAINT travelConfig_warehouse_FK 
+	FOREIGN KEY (devalueWarehouseOutFk) REFERENCES vn.warehouse(id) ON DELETE SET NULL ON UPDATE CASCADE;

db/versions/11010-blackChrysanthemum/00-firstScript.sql

@@ -0,0 +1,21 @@
+ALTER TABLE vn.deviceProductionUser DROP INDEX IF EXISTS deviceProductionUser_UN;
+
+ALTER TABLE vn.deviceProductionUser DROP FOREIGN KEY IF EXISTS deviceProductionUser_FK;
+
+ALTER TABLE vn.deviceProductionUser DROP PRIMARY KEY;
+
+ALTER TABLE vn.deviceProductionUser ADD IF NOT EXISTS id INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY FIRST;
+
+ALTER TABLE vn.deviceProductionUser ADD CONSTRAINT deviceProductionUser_deviceProduction_FK FOREIGN KEY IF NOT EXISTS (deviceProductionFk) REFERENCES vn.deviceProduction(id);
+
+ALTER TABLE vn.deviceProductionUser ADD CONSTRAINT deviceProductionUser_unique UNIQUE KEY IF NOT EXISTS (deviceProductionFk);
+
+ALTER TABLE vn.deviceProductionUser ADD IF NOT EXISTS simSerialNumber TEXT NULL;
+
+ALTER TABLE vn.deviceProductionConfig ADD IF NOT EXISTS maxDevicesPerUser INT UNSIGNED NULL;
+
+UPDATE vn.deviceProductionConfig SET maxDevicesPerUser=1 WHERE id=1;
+
+INSERT IGNORE INTO salix.ACL (model,property,accessType,permission,principalType,principalId)
+	VALUES ('Worker','getAvailablePda','READ','ALLOW','ROLE','hr');
+

db/versions/11055-wheatPaniculata/00-firstScript.sql

@@ -0,0 +1,5 @@
+ALTER TABLE vn.clientConfig
+    ADD monthsToDisableUser int(10) unsigned DEFAULT NULL NULL;
+
+UPDATE IGNORE vn.clientConfig
+    SET monthsToDisableUser = 12;

db/versions/11057-chocolateMoss/00-part.sql

@@ -0,0 +1,26 @@
+DROP TABLE IF EXISTS vn2008.scanTree__;
+DROP TABLE IF EXISTS vn2008.payroll_embargos__;
+DROP TABLE IF EXISTS vn2008.unary_source__;
+DROP TABLE IF EXISTS vn2008.unary_scan_line_buy__;
+DROP TABLE IF EXISTS vn2008.unary_scan_line__;
+DROP TABLE IF EXISTS vn2008.unary_scan__;
+DROP TABLE IF EXISTS vn2008.scan_line__;
+DROP TABLE IF EXISTS vn2008.Familias__;
+DROP TABLE IF EXISTS vn2008.language__;
+DROP TABLE IF EXISTS vn2008.Clientes_dits__;
+DROP TABLE IF EXISTS vn2008.unary_scan_line_expedition__;
+DROP TABLE IF EXISTS vn2008.warehouse_group__;
+DROP TABLE IF EXISTS vn2008.Espionajes__;
+DROP TABLE IF EXISTS vn2008.jerarquia__;
+DROP TABLE IF EXISTS vn2008.wks__;
+DROP TABLE IF EXISTS vn2008.Proveedores_comunicados__;
+DROP TABLE IF EXISTS vn2008.integra2_escala__;
+DROP TABLE IF EXISTS vn2008.cp__;
+DROP TABLE IF EXISTS vn2008.unary__;
+DROP TABLE IF EXISTS vn2008.Estados__;
+DROP TABLE IF EXISTS vn2008.agency_hour__;
+DROP TABLE IF EXISTS vn2008.Reservas__;
+DROP TABLE IF EXISTS vn2008.cyc_declaration__;
+DROP TABLE IF EXISTS vn2008.route__;
+DROP TABLE IF EXISTS vn2008.Proveedores_escritos__;
+DROP TABLE IF EXISTS vn2008.config__;

db/versions/11057-chocolateMoss/01-part.sql

@@ -0,0 +1,41 @@
+DROP TABLE IF EXISTS vn2008.form_query__;
+DROP TABLE IF EXISTS vn2008.filtros__;
+DROP TABLE IF EXISTS vn2008.Objetivos__;
+UPDATE IGNORE vn.province
+	SET zoneFk = NULL
+	WHERE zoneFk IN (
+		SELECT zoneFk
+			FROM vn.province
+			WHERE zoneFk IS NOT NULL AND zoneFk NOT IN (SELECT id FROM vn.`zone`)
+	);
+ALTER TABLE vn.province DROP FOREIGN KEY province_zone_fk;
+ALTER TABLE vn.province MODIFY COLUMN zoneFk int(11) DEFAULT NULL NULL;
+ALTER TABLE vn.province ADD CONSTRAINT
+    province_zone_FK FOREIGN KEY (zoneFk) REFERENCES vn.`zone`(id) ON DELETE CASCADE ON UPDATE CASCADE;
+DROP TABLE IF EXISTS vn2008.zones__;
+DROP TABLE IF EXISTS vn2008.rec_translator__;
+DROP TABLE IF EXISTS vn2008.warehouse_joined__;
+DROP TABLE IF EXISTS vn2008.warehouse_filtro__;
+DROP TABLE IF EXISTS vn2008.viaxpress__;
+DROP TABLE IF EXISTS vn2008.cl_que__;
+DROP TABLE IF EXISTS vn2008.Recibos_recorded__;
+RENAME TABLE vn.coolerPathDetail TO vn.coolerPathDetail__;
+ALTER TABLE vn.coolerPathDetail__ DROP FOREIGN KEY coolerPathDetail_FK;
+DROP TABLE IF EXISTS vn2008.cooler_path__;
+DROP TABLE IF EXISTS vn2008.payrroll_apEmpresarial__;
+DROP TABLE IF EXISTS vn2008.Compres_ok__;
+DROP TABLE IF EXISTS vn2008.Movimientos_avisar__;
+DROP TABLE IF EXISTS vn2008.Clases__;
+DROP TABLE IF EXISTS vn2008.payroll_basess__;
+DROP TABLE IF EXISTS vn2008.payroll_tipobasess__;
+DROP TABLE IF EXISTS vn2008.guillen__;
+DROP TABLE IF EXISTS vn2008.guillen_carry__;
+DROP TABLE IF EXISTS vn2008.Series__;
+DROP TABLE IF EXISTS vn2008.Permisos__;
+ALTER TABLE vn.buy DROP FOREIGN KEY buy_FK_1;
+DROP TABLE IF EXISTS vn2008.container__;
+DROP TABLE IF EXISTS vn2008.travel_reserve__;
+DROP TABLE IF EXISTS vn2008.tmpNEWTARIFAS__;
+DROP TABLE IF EXISTS vn2008.Clientes_potenciales__;
+DROP TABLE IF EXISTS vn2008.duaDismissed__;
+DROP TABLE IF EXISTS vn2008.cl_pet__;

db/versions/11057-chocolateMoss/02-part.sql

@@ -0,0 +1,27 @@
+DROP TABLE IF EXISTS vn2008.expeditions_deleted__;
+DROP TABLE IF EXISTS vn2008.Tipos_f11__;
+DROP TABLE IF EXISTS vn2008.commission__;
+DROP TABLE IF EXISTS vn2008.Movimientos_revisar__;
+DROP TABLE IF EXISTS vn2008.recibida_agricola__;
+DROP TABLE IF EXISTS vn2008.tipsa__;
+DROP TABLE IF EXISTS vn2008.rounding__;
+DROP TABLE IF EXISTS vn2008.Informes__;
+DROP TABLE IF EXISTS vn2008.Monitoring__;
+DROP TABLE IF EXISTS vn2008.Forms__;
+DROP TABLE IF EXISTS vn2008.Clientes_event__;
+DROP TABLE IF EXISTS vn2008.wh_selection__;
+DROP TABLE IF EXISTS vn2008.template_bionic_component__;
+DROP TABLE IF EXISTS vn2008.Agencias_province__;
+DROP TABLE IF EXISTS vn2008.travel_pattern__;
+DROP TABLE IF EXISTS vn2008.sort_merge_results_ernesto__;
+DROP TABLE IF EXISTS vn2008.Conteo__;
+DROP TABLE IF EXISTS vn2008.Consignatarios_devices__;
+DROP TABLE IF EXISTS vn2008.link__;
+DROP TABLE IF EXISTS vn2008.agency_warehouse__;
+DROP TABLE IF EXISTS vn2008.warehouse_lc__;
+DROP TABLE IF EXISTS vn2008.emp_day_pay__;
+DROP TABLE IF EXISTS vn2008.Entradas_kop__;
+DROP TABLE IF EXISTS vn2008.dock__;
+DROP TABLE IF EXISTS vn2008.unaryScanFilter__;
+DROP TABLE IF EXISTS vn2008.Grupos__;
+DROP TABLE IF EXISTS vn2008.nichos__;

db/versions/11057-chocolateMoss/03-part.sql

@@ -0,0 +1,26 @@
+DROP TABLE IF EXISTS vn2008.preparation_exception__;
+DROP TABLE IF EXISTS vn2008.Clientes_empresa__;
+DROP TABLE IF EXISTS vn2008.call_information__;
+DROP TABLE IF EXISTS vn2008.template_bionic_price__;
+DROP TABLE IF EXISTS vn2008.invoice_observation__;
+DROP TABLE IF EXISTS vn2008.edi_testigos__;
+DROP TABLE IF EXISTS vn2008.cl_dep__;
+DROP TABLE IF EXISTS vn2008.agencia_descuadre__;
+DROP TABLE IF EXISTS vn2008.payroll_datos__;
+DROP TABLE IF EXISTS vn2008.tblIVA__;
+DROP TABLE IF EXISTS vn2008.cyc__;
+DROP TABLE IF EXISTS vn2008.Tickets_stack__;
+DROP TABLE IF EXISTS vn2008.config_host_forms__;
+DROP TABLE IF EXISTS vn2008.template_bionic_lot__;
+DROP TABLE IF EXISTS vn2008.payroll_bonificaciones__;
+DROP TABLE IF EXISTS vn2008.widget__;
+DROP TABLE IF EXISTS vn2008.accion_dits__;
+DROP TABLE IF EXISTS vn2008.credit_card__;
+DROP TABLE IF EXISTS vn2008.Brasa__;
+DROP TABLE IF EXISTS vn2008.Jefes__;
+DROP TABLE IF EXISTS vn2008.call_option__;
+DROP TABLE IF EXISTS vn2008.expeditions_pictures__;
+DROP TABLE IF EXISTS vn2008.scan__;
+DROP TABLE IF EXISTS vn2008.trolley__;
+DROP TABLE IF EXISTS vn2008.transport__;
+DROP TABLE IF EXISTS vn2008.Baldas__;

db/versions/11058-aquaCataractarum/00-firstScript.sql

@@ -0,0 +1,2 @@
+-- Place your SQL code here
+ALTER TABLE floranet.`order` ADD IF NOT EXISTS observations TEXT NULL;

db/versions/11059-crimsonAnthurium/00-firstScript.sql

@@ -0,0 +1,3 @@
+-- Place your SQL code here
+INSERT INTO salix.ACL (model,property,accessType,permission,principalType,principalId)
+	VALUES ('RouteConfig','*','READ','ALLOW','ROLE','employee');

db/versions/11061-silverMastic/00-firstScript.sql

@@ -0,0 +1 @@
+ALTER TABLE vn.buy CHANGE containerFk containerFk__ smallint(5) unsigned DEFAULT NULL NULL;

e2e/paths/03-worker/07_pda.spec.js

@@ -1,41 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Worker pda path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('hr', 'worker');
-        await page.accessToSearchResult('employeeNick');
-        await page.accessToSection('worker.card.pda');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should check if worker has already a PDA allocated', async() => {
-        expect(await page.waitToGetProperty(selectors.workerPda.currentPDA, 'value')).toContain('serialNumber1');
-    });
-
-    it('should deallocate the PDA', async() => {
-        await page.waitToClick(selectors.workerPda.delete);
-        let message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('PDA deallocated');
-    });
-
-    it('should allocate a new PDA', async() => {
-        await page.autocompleteSearch(selectors.workerPda.newPDA, 'serialNumber2');
-        await page.waitToClick(selectors.workerPda.submit);
-        let message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('PDA allocated');
-    });
-
-    it('should check if a new PDA has been allocated', async() => {
-        expect(await page.waitToGetProperty(selectors.workerPda.currentPDA, 'value')).toContain('serialNumber2');
-    });
-});

loopback/common/models/application.js

@@ -1,4 +1,3 @@
-
 module.exports = function(Self) {
     require('../methods/application/status')(Self);
     require('../methods/application/post')(Self);

loopback/locale/en.json

@@ -225,5 +225,6 @@
 	"ticketCommercial": "The ticket {{ ticket }} for the salesperson {{ salesMan }} is in preparation. (automatically generated message)",
 	"This password can only be changed by the user themselves": "This password can only be changed by the user themselves",
 	"They're not your subordinate": "They're not your subordinate",
-	"InvoiceIn is already booked": "InvoiceIn is already booked"
+	"InvoiceIn is already booked": "InvoiceIn is already booked",
+	"This workCenter is already assigned to this agency": "This workCenter is already assigned to this agency"
 }

loopback/locale/es.json

@@ -356,5 +356,7 @@
 	"InvoiceIn is already booked": "La factura recibida está contabilizada",
 	"This workCenter is already assigned to this agency": "Este centro de trabajo ya está asignado a esta agencia",
 	"Select ticket or client": "Elija un ticket o un client",
-	"It was not able to create the invoice": "No se pudo crear la factura"
+	"It was not able to create the invoice": "No se pudo crear la factura",
+	"This PDA is already assigned to another user": "This PDA is already assigned to another user",
+	"ticketCommercial": "El ticket {{ ticket }} para el vendedor {{ salesMan }} está en preparación. (mensaje generado automáticamente)"
 }

loopback/server/boot/isProduction.js

@@ -0,0 +1,3 @@
+module.exports = (localAsProduction = true) => {
+    return (!process.env.NODE_ENV && localAsProduction) || process.env.NODE_ENV == 'production';
+};

modules/account/back/models/ldap-config.js

@@ -3,9 +3,10 @@ const app = require('vn-loopback/server/server');
 const ldap = require('../util/ldapjs-extra');
 const crypto = require('crypto');
 const nthash = require('smbhash').nthash;
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
-    const shouldSync = process.env.NODE_ENV !== 'test';
+    const shouldSync = isProduction();
 
     Self.getLinker = async function() {
         return await Self.findOne({

modules/account/back/models/samba-config.js

@@ -1,6 +1,7 @@
 
 const ldap = require('../util/ldapjs-extra');
 const execFile = require('child_process').execFile;
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 /**
  * Summary of userAccountControl flags:
@@ -12,7 +13,7 @@ const UserAccountControlFlags = {
 };
 
 module.exports = Self => {
-    const shouldSync = process.env.NODE_ENV !== 'test';
+    const shouldSync = isProduction();
 
     Self.getLinker = async function() {
         return await Self.findOne({

modules/client/back/methods/sms/send.js

@@ -1,5 +1,6 @@
 const got = require('got');
 const UserError = require('vn-loopback/util/user-error');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     Self.remoteMethod('send', {
@@ -47,7 +48,7 @@ module.exports = Self => {
 
         let response;
         try {
-            if (process.env.NODE_ENV !== 'production')
+            if (!isProduction(false))
                 response = {result: [{status: 'ok'}]};
             else {
                 const jsonTest = {

modules/entry/back/methods/entry/addFromBuy.js

@@ -76,7 +76,6 @@ module.exports = Self => {
                     packing: buyUltimate.packing,
                     grouping: buyUltimate.grouping,
                     groupingMode: buyUltimate.groupingMode,
-                    containerFk: buyUltimate.containerFk,
                     comissionValue: buyUltimate.comissionValue,
                     packageValue: buyUltimate.packageValue,
                     location: buyUltimate.location,

modules/entry/back/models/buy.json

@@ -63,9 +63,6 @@
         "isIgnored": {
             "type": "boolean"
         },
-        "containerFk": {
-            "type": "number"
-        },
         "location": {
             "type": "number"
         },

modules/invoiceOut/back/methods/invoiceOut/download.js

@@ -1,5 +1,6 @@
 const fs = require('fs-extra');
 const path = require('path');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     Self.remoteMethodCtx('download', {
@@ -66,7 +67,7 @@ module.exports = Self => {
             console.error(err);
         });
 
-        if (process.env.NODE_ENV == 'test') {
+        if (!isProduction()) {
             try {
                 await fs.access(file.path);
             } catch (error) {

modules/invoiceOut/back/models/invoice-out.js

@@ -1,6 +1,7 @@
 const print = require('vn-print');
 const path = require('path');
 const UserError = require('vn-loopback/util/user-error');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     require('../methods/invoiceOut/filter')(Self);
@@ -59,7 +60,7 @@ module.exports = Self => {
             hasPdf: true
         }, options);
 
-        if (process.env.NODE_ENV !== 'test') {
+        if (isProduction()) {
             await print.storage.write(buffer, {
                 type: 'invoice',
                 path: pdfFile.path,

modules/mdb/back/methods/mdbVersion/upload.js

@@ -1,6 +1,7 @@
 const fs = require('fs-extra');
 const path = require('path');
 const UserError = require('vn-loopback/util/user-error');
+const isProduction = require('vn-loopback/server/boot/isProduction');
 
 module.exports = Self => {
     Self.remoteMethodCtx('upload', {
@@ -111,7 +112,7 @@ module.exports = Self => {
             const destinationFile = path.join(
                 accessContainer.client.root, accessContainer.name, appName, `${toVersion}.7z`);
 
-            if (process.env.NODE_ENV == 'test')
+            if (!isProduction())
                 await fs.unlink(srcFile);
             else {
                 await fs.move(srcFile, destinationFile, {

modules/route/back/methods/roadmap/clone.js

@@ -62,12 +62,12 @@ module.exports = Self => {
 
                 const clone = await models.Roadmap.create(roadmap, options);
 
-                const expeditionTrucks = roadmap.expeditionTruck();
+                const roadmapStops = roadmap.roadmapStop();
-                expeditionTrucks.map(expeditionTruck => {
+                roadmapStops.map(roadmapStop => {
-                    expeditionTruck.roadmapFk = clone.id;
+                    roadmapStop.roadmapFk = clone.id;
-                    return expeditionTruck;
+                    return roadmapStop;
                 });
-                await models.ExpeditionTruck.create(expeditionTrucks, options);
+                await models.RoadmapStop.create(roadmapStops, options);
             }
 
             await tx.commit();

modules/route/back/model-config.json

@@ -8,7 +8,7 @@
     "DeliveryPoint": {
         "dataSource": "vn"
     },
-    "ExpeditionTruck": {
+    "RoadmapStop": {
         "dataSource": "vn"
     },
     "Roadmap": {

modules/route/back/models/roadmap.json

@@ -54,9 +54,9 @@
             "model": "Supplier",
             "foreignKey": "supplierFk"
         },
-        "expeditionTruck": {
+        "roadmapStop": {
             "type": "hasMany",
-            "model": "ExpeditionTruck",
+            "model": "RoadmapStop",
             "foreignKey": "roadmapFk"
         }
 	}

modules/route/back/models/roadmapStop.json

@@ -1,9 +1,9 @@
 {
-    "name": "ExpeditionTruck",
+    "name": "RoadmapStop",
     "base": "VnModel",
     "options": {
         "mysql": {
-        "table": "expeditionTruck"
+        "table": "roadmapStop"
         }
     },
     "properties": {

modules/route/front/roadmap/stops/index.html

@@ -1,22 +1,22 @@
 <vn-crud-model
     vn-id="model"
-    url="ExpeditionTrucks"
+    url="RoadmapStops"
     where="{roadmapFk: $ctrl.$params.id}"
     order="eta ASC"
-    data="$ctrl.expeditionTrucks"
+    data="$ctrl.roadmapStops"
     auto-load="true">
 </vn-crud-model>
 <vn-watcher
     vn-id="watcher"
-    data="$ctrl.expeditionTrucks"
+    data="$ctrl.roadmapStops"
     form="form">
 </vn-watcher>
 <form class="vn-w-md" name="form" ng-submit="$ctrl.onSubmit()">
     <vn-card class="vn-pa-lg">
-        <vn-horizontal ng-repeat="expeditionTruck in $ctrl.expeditionTrucks">
+        <vn-horizontal ng-repeat="roadmapStop in $ctrl.roadmapStops">
             <vn-autocomplete vn-one
                 label="Warehouse"
-                ng-model="expeditionTruck.warehouseFk"
+                ng-model="roadmapStop.warehouseFk"
                 url="Warehouses"
                 show-field="name"
                 value-field="id"
@@ -25,18 +25,18 @@
             </vn-autocomplete>
             <vn-date-picker vn-one
                 label="ETA date"
-                ng-model="expeditionTruck.eta"
+                ng-model="roadmapStop.eta"
                 rule>
             </vn-date-picker>
             <vn-input-time
                 vn-one
                 label="ETA hour"
-                ng-model="expeditionTruck.eta">
+                ng-model="roadmapStop.eta">
             </vn-input-time>
             <vn-textArea
                 vn-one
                 label="Description"
-                ng-model="expeditionTruck.description"
+                ng-model="roadmapStop.description"
                 rule>
             </vn-textArea>
             <vn-none>

modules/route/front/roadmap/summary/index.html

@@ -49,7 +49,7 @@
                         vn-bind="+"
                         vn-tooltip="Add stop"
                         icon="add_circle"
-                        vn-click-stop="addExpeditionTruck.show()">
+                        vn-click-stop="addRoadmapStop.show()">
                     </vn-icon-button>
                 </a>
             </h4>
@@ -61,9 +61,9 @@
                     </vn-tr>
                 </vn-thead>
                 <vn-tbody>
-                    <vn-tr ng-repeat="expeditionTruck in summary.expeditionTruck">
+                    <vn-tr ng-repeat="roadmapStop in summary.roadmapStop">
-                        <vn-td>{{expeditionTruck.warehouse.name}}</vn-td>
+                        <vn-td>{{roadmapStop.warehouse.name}}</vn-td>
-                        <vn-td expand>{{expeditionTruck.eta | date:'dd/MM/yyyy HH:mm'}}</vn-td>
+                        <vn-td expand>{{roadmapStop.eta | date:'dd/MM/yyyy HH:mm'}}</vn-td>
                     </vn-tr>
                 </vn-tbody>
             </vn-table>
@@ -75,14 +75,14 @@
 </vn-supplier-descriptor-popover>
 
 <vn-dialog
-    vn-id="addExpeditionTruck"
+    vn-id="addRoadmapStop"
     on-open="$ctrl.getETD()"
     on-accept="$ctrl.onAddAccept()">
     <tpl-body>
         <vn-horizontal>
             <vn-autocomplete
                 label="Warehouse"
-                ng-model="$ctrl.expeditionTruck.warehouseFk"
+                ng-model="$ctrl.roadmapStop.warehouseFk"
                 url="Warehouses"
                 show-field="name"
                 value-field="id"
@@ -93,18 +93,18 @@
         <vn-horizontal>
             <vn-date-picker
                 label="ETA date"
-                ng-model="$ctrl.expeditionTruck.eta"
+                ng-model="$ctrl.roadmapStop.eta"
                 rule>
             </vn-date-picker>
             <vn-input-time
                 label="ETA hour"
-                ng-model="$ctrl.expeditionTruck.eta">
+                ng-model="$ctrl.roadmapStop.eta">
             </vn-input-time>
         </vn-horizontal>
         <vn-horizontal>
             <vn-textArea
                 label="Description"
-                ng-model="$ctrl.expeditionTruck.description"
+                ng-model="$ctrl.roadmapStop.description"
                 rule>
             </vn-textArea>
         </vn-horizontal>

modules/route/front/roadmap/summary/index.js

@@ -20,7 +20,7 @@ class Controller extends Component {
             include: [
                 {relation: 'supplier'},
                 {relation: 'worker'},
-                {relation: 'expeditionTruck',
+                {relation: 'roadmapStop',
                     scope: {
                         include: [
                             {relation: 'warehouse'}
@@ -36,19 +36,19 @@ class Controller extends Component {
         const eta = new Date(this.roadmap.etd);
         eta.setDate(eta.getDate() + 1);
 
-        this.expeditionTruck = {eta: eta};
+        this.roadmapStop = {eta: eta};
     }
 
     onAddAccept() {
         try {
             const data = {
                 roadmapFk: this.roadmap.id,
-                warehouseFk: this.expeditionTruck.warehouseFk,
+                warehouseFk: this.roadmapStop.warehouseFk,
-                eta: this.expeditionTruck.eta,
+                eta: this.roadmapStop.eta,
-                description: this.expeditionTruck.description
+                description: this.roadmapStop.description
             };
 
-            this.$http.post(`ExpeditionTrucks`, data)
+            this.$http.post(`RoadmapStops`, data)
                 .then(() => {
                     this.loadData();
                     this.vnApp.showSuccess(this.$t('Data saved!'));

modules/ticket/back/methods/ticket/closeAll.js

@@ -138,12 +138,13 @@ module.exports = Self => {
                     JOIN alertLevel al ON al.id = ts.alertLevel
                     JOIN agencyMode am ON am.id = t.agencyModeFk
                     JOIN deliveryMethod dm ON dm.id = am.deliveryMethodFk
-                    JOIN zone z ON z.id = t.zoneFk
+                    LEFT JOIN ticketObservation tob ON tob.ticketFk = t.id
                 SET t.routeFk = NULL
                 WHERE DATE(t.shipped) BETWEEN ? - INTERVAL 2 DAY AND util.dayEnd(?)
                     AND al.code NOT IN ('DELIVERED', 'PACKED')
-                    AND t.routeFk
+                    AND NOT t.packages
-                    AND z.name LIKE '%MADRID%'`, [toDate, toDate], {userId: ctx.req.accessToken.userId});
+                    AND tob.id IS NULL
+                    AND t.routeFk`, [toDate, toDate], {userId: ctx.req.accessToken.userId});
 
         return {
             message: 'Success'

modules/ticket/back/models/expeditionPallet.json

@@ -23,9 +23,9 @@
         }
     },
     "relations": {
-        "expeditionTruck": {
+        "roadmapStop": {
             "type": "belongsTo",
-            "model": "ExpeditionTruck",
+            "model": "RoadmapStop",
             "foreignKey": "truckFk" 
         }
     }

modules/ticket/back/models/ticket-log.json

@@ -8,7 +8,8 @@
 	},
     "properties": {
         "id": {
-            "type": "string"
+            "type": "number",
+            "id": true
         },
         "originFk": {
             "type": "number"

modules/ticket/front/descriptor-menu/index.js

@@ -37,18 +37,19 @@ class Controller extends Section {
         });
 
         const filter = {
-            fields: ['originFk', 'creationDate', 'newInstance'],
+            fields: ['id', 'originFk', 'creationDate', 'newInstance'],
             where: {
                 originFk: value,
                 newInstance: {like: '%"isDeleted":true%'}
             },
-            order: 'creationDate DESC'
+            order: 'creationDate DESC',
+            limit: 1
         };
-        this.$http.get(`TicketLogs/findOne`, {filter})
+        this.$http.get(`TicketLogs`, {filter})
             .then(res => {
-                if (res && res.data) {
+                if (res && res.data && res.data.length) {
                     const now = Date.vnNew();
-                    const maxDate = new Date(res.data.creationDate);
+                    const maxDate = new Date(res.data[0].creationDate);
                     maxDate.setHours(maxDate.getHours() + 1);
                     if (now <= maxDate)
                         return this.canRestoreTicket = true;

modules/worker/back/methods/worker/getAvailablePda.js

@@ -0,0 +1,23 @@
+module.exports = Self => {
+    Self.remoteMethod('getAvailablePda', {
+        description: 'returns devices without user',
+        accessType: 'READ',
+        accepts: [],
+        returns: {
+            type: 'array',
+            root: true
+        },
+        http: {
+            path: `/getAvailablePda`,
+            verb: 'GET'
+        }
+    });
+    Self.getAvailablePda = async() => {
+        return Self.app.models.DeviceProduction.rawSql(
+            `SELECT d.*
+                FROM deviceProduction d
+                    LEFT JOIN deviceProductionUser du ON du.deviceProductionFk = d.id
+                WHERE du.deviceProductionFk IS NULL`
+        );
+    };
+};

modules/worker/back/methods/worker/specs/getAvailablePda.spec.js

@@ -0,0 +1,13 @@
+const models = require('vn-loopback/server/server').models;
+
+describe('worker getAvailablePda()', () => {
+    it('should return a Pda that has no user assigned', async() => {
+        const [{id}] = await models.Worker.getAvailablePda();
+
+        const deviceProductionUser = await models.DeviceProductionUser.findOne({
+            where: {deviceProductionFk: id}
+        });
+
+        expect(!deviceProductionUser).toBeTruthy();
+    });
+});

modules/worker/back/models/device-production-user.js

@@ -0,0 +1,8 @@
+const UserError = require('vn-loopback/util/user-error');
+module.exports = Self => {
+    Self.rewriteDbError(function(err) {
+        if (err.code === 'ER_DUP_ENTRY')
+            return new UserError(`This PDA is already assigned to another user`);
+        return err;
+    });
+};

modules/worker/back/models/device-production-user.json

@@ -14,6 +14,10 @@
         }
     },
     "properties": {
+        "id": {
+            "type": "number",
+            "id": true
+        },
         "deviceProductionFk": {
             "type": "number",
             "id": true
@@ -21,6 +25,9 @@
         "userFk": {
             "type": "number"
         },
+        "simSerialNumber": {
+            "type": "string"
+        },
         "created": {
             "type": "date"
         }
@@ -36,5 +43,10 @@
             "model": "User",
             "foreignKey": "userFk"
         }
+    },
+    "scope": {
+        "include":{
+           "relation": "deviceProduction"
+        }
     }
 }

modules/worker/back/models/worker.js

@@ -20,6 +20,7 @@ module.exports = Self => {
     require('../methods/worker/search')(Self);
     require('../methods/worker/isAuthorized')(Self);
     require('../methods/worker/setPassword')(Self);
+    require('../methods/worker/getAvailablePda')(Self);
 
     Self.validateAsync('fi', tinIsValid, {
         message: 'Invalid TIN'

modules/worker/back/models/worker.json

@@ -62,7 +62,23 @@
         },
         "isFreelance": {
             "type" : "boolean"
+        },
+        "fiDueDate": {
+            "type": "date"
+        },
+        "hasMachineryAuthorized": {
+            "type": "boolean"
+        },
+        "seniority": {
+            "type": "date"
+        },
+        "isDisable": {
+            "type": "boolean"
+        },
+        "isSsDiscounted": {
+            "type": "boolean"
         }
+
     },
     "relations": {
         "user": {

modules/worker/front/pda/index.html

@@ -1,50 +0,0 @@
-<div class="vn-w-md" ng-show="$ctrl.currentPDA">
-    <vn-card class="vn-pa-lg">
-        <vn-horizontal>
-            <vn-textfield
-                label="Current PDA"
-                ng-model="$ctrl.currentPDA.description"
-                disabled="true">
-                <append>
-                    <vn-icon-button
-                        icon="delete"
-                        vn-tooltip="Deallocate PDA"
-                        ng-click="$ctrl.deallocatePDA()"
-                        vn-acl="hr, productionAssi">
-                    </vn-icon-button>
-                </append>
-            </vn-textfield>
-        </vn-horizontal>
-    </vn-card>
-</div>
-<form name="form" ng-show="!$ctrl.currentPDA" ng-submit="$ctrl.allocatePDA()" class="vn-w-md">
-    <vn-card class="vn-pa-lg">
-            <vn-horizontal>
-                <vn-autocomplete
-                    vn-acl="hr, productionAssi"
-                    ng-model="$ctrl.newPDA"
-                    url="DeviceProductions"
-                    fields="['id', 'modelFk', 'serialNumber']"
-                    where="{'stateFk': 'idle'}"
-                    label="New PDA"
-                    order="id"
-                    value-field="id"
-                    show-field="serialNumber">
-                    <tpl-item>
-                        <div>
-                            ID: {{id}}
-                        </div>
-                        <div class="text-caption text-grey">
-                            {{modelFk}}, {{serialNumber}}
-                        </div>
-                    </tpl-item>
-                </vn-autocomplete>
-            </vn-horizontal>
-    </vn-card>
-    <vn-button-bar>
-        <vn-submit
-            disabled="!$ctrl.newPDA"
-            label="Assign">
-        </vn-submit>
-    </vn-button-bar>
-</form>

modules/worker/front/pda/index.js

@@ -1,53 +1,18 @@
 import ngModule from '../module';
 import Section from 'salix/components/section';
-import './style.scss';
 
 class Controller extends Section {
     constructor($element, $) {
         super($element, $);
-        const filter = {
-            where: {userFk: this.$params.id},
-            include: {relation: 'deviceProduction'}
-        };
-        this.$http.get('DeviceProductionUsers', {filter}).
-            then(res => {
-                if (res.data && res.data.length > 0)
-                    this.setCurrentPDA(res.data[0]);
-            });
     }
 
-    deallocatePDA() {
+    async $onInit() {
-        this.$http.post(`Workers/${this.$params.id}/deallocatePDA`, {pda: this.currentPDA.deviceProductionFk})
+        const url = await this.vnApp.getUrl(`worker/${this.$params.id}/pda`);
-            .then(() => {
+        this.$state.go('worker.card.summary', {id: this.$params.id});
-                this.vnApp.showSuccess(this.$t('PDA deallocated'));
+        window.location.href = url;
-                delete this.currentPDA;
-            });
-    }
-
-    allocatePDA() {
-        this.$http.post(`Workers/${this.$params.id}/allocatePDA`, {pda: this.newPDA})
-            .then(res => {
-                if (res.data)
-                    this.setCurrentPDA(res.data);
-
-                this.vnApp.showSuccess(this.$t('PDA allocated'));
-                delete this.newPDA;
-            });
-    }
-
-    setCurrentPDA(data) {
-        this.currentPDA = data;
-        this.currentPDA.description = [];
-        this.currentPDA.description.push(`ID: ${this.currentPDA.deviceProductionFk}`);
-        this.currentPDA.description.push(`${this.$t('Model')}: ${this.currentPDA.deviceProduction.modelFk}`);
-        this.currentPDA.description.push(`${this.$t('Serial Number')}: ${this.currentPDA.deviceProduction.serialNumber}`);
-        this.currentPDA.description = this.currentPDA.description.join(' ');
     }
 }
 
-Controller.$inject = ['$element', '$scope'];
-
 ngModule.vnComponent('vnWorkerPda', {
-    template: require('./index.html'),
+    controller: Controller
-    controller: Controller,
 });

modules/worker/front/pda/index.spec.js

@@ -1,72 +0,0 @@
-import './index';
-
-describe('Worker', () => {
-    describe('Component vnWorkerPda', () => {
-        let $httpBackend;
-        let $scope;
-        let $element;
-        let controller;
-
-        beforeEach(ngModule('worker'));
-
-        beforeEach(inject(($componentController, $rootScope, _$httpBackend_) => {
-            $httpBackend = _$httpBackend_;
-            $scope = $rootScope.$new();
-            $element = angular.element('<vn-worker-pda></vn-worker-pda>');
-            controller = $componentController('vnWorkerPda', {$element, $scope});
-            $httpBackend.expectGET(`DeviceProductionUsers`).respond();
-        }));
-
-        describe('deallocatePDA()', () => {
-            it('should make an HTTP Post query to deallocatePDA', () => {
-                jest.spyOn(controller.vnApp, 'showSuccess');
-                controller.currentPDA = {deviceProductionFk: 1};
-                controller.$params.id = 1;
-
-                $httpBackend
-                    .expectPOST(`Workers/${controller.$params.id}/deallocatePDA`,
-                        {pda: controller.currentPDA.deviceProductionFk})
-                    .respond();
-                controller.deallocatePDA();
-                $httpBackend.flush();
-
-                expect(controller.vnApp.showSuccess).toHaveBeenCalled();
-                expect(controller.currentPDA).toBeUndefined();
-            });
-        });
-
-        describe('allocatePDA()', () => {
-            it('should make an HTTP Post query to allocatePDA', () => {
-                jest.spyOn(controller.vnApp, 'showSuccess');
-                controller.newPDA = 4;
-                controller.$params.id = 1;
-
-                $httpBackend
-                    .expectPOST(`Workers/${controller.$params.id}/allocatePDA`,
-                        {pda: controller.newPDA})
-                    .respond();
-                controller.allocatePDA();
-                $httpBackend.flush();
-
-                expect(controller.vnApp.showSuccess).toHaveBeenCalled();
-                expect(controller.newPDA).toBeUndefined();
-            });
-        });
-
-        describe('setCurrentPDA()', () => {
-            it('should set CurrentPDA', () => {
-                const data = {
-                    deviceProductionFk: 1,
-                    deviceProduction: {
-                        modelFk: 1,
-                        serialNumber: 1
-                    }
-                };
-                controller.setCurrentPDA(data);
-
-                expect(controller.currentPDA).toBeDefined();
-                expect(controller.currentPDA.description).toBeDefined();
-            });
-        });
-    });
-});

modules/worker/front/pda/style.scss

@@ -1,6 +0,0 @@
-@import "./variables";
-
-.text-grey {
-    color: $color-font-light;
-}
-

myt.config.yml

@@ -227,7 +227,7 @@ localFixtures:
     - expeditionScan
     - expeditionState
     - expeditionStateType
-    - expeditionTruck
+    - roadmapStop
     - expense
     - genus
     - greuge

package.json

@@ -1,6 +1,6 @@
 {
     "name": "salix-back",
-    "version": "24.22.0",
+    "version": "24.24.0",
     "author": "Verdnatura Levante SL",
     "description": "Salix backend",
     "license": "GPL-3.0",