verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

Merge pull request 'fix: refs #8069 call moved upper than transaction start' (!3075) from 8069-Overstocking into dev
gitea/salix/pipeline/head This commit looks good Details 

Reviewed-on: #3075
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
This commit is contained in:
Pako Natek 2024-10-04 16:21:22 +00:00
parent 49305f77df cf29b1bd82
commit 4b497108dc
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
db/routines/hedera/procedures/order_confirmWithUser.sql
View File

@ -98,22 +98,8 @@ BEGIN
SELECT employeeFk INTO vUserFk FROM orderConfig; SELECT employeeFk INTO vUserFk FROM orderConfig;
END IF; END IF;
START TRANSACTION;
CALL order_checkEditable(vSelf);
CALL orderRow_updateOverstocking(vSelf); CALL orderRow_updateOverstocking(vSelf);
-- Check order is not empty
SELECT COUNT(*) > 0 INTO vHasRows
FROM orderRow
WHERE orderFk = vSelf
AND amount > 0;
IF NOT vHasRows THEN
CALL util.throw('ORDER_EMPTY');
END IF;
-- Check if any product has a quantity of 0 -- Check if any product has a quantity of 0
SELECT EXISTS ( SELECT EXISTS (
SELECT id SELECT id
@ -125,6 +111,20 @@ BEGIN
IF vHas0Amount THEN IF vHas0Amount THEN
CALL util.throw('Remove lines with quantity = 0 before confirming'); CALL util.throw('Remove lines with quantity = 0 before confirming');
END IF; END IF;
START TRANSACTION;
CALL order_checkEditable(vSelf);
-- Check order is not empty
SELECT COUNT(*) > 0 INTO vHasRows
FROM orderRow
WHERE orderFk = vSelf
AND amount > 0;
IF NOT vHasRows THEN
CALL util.throw('ORDER_EMPTY');
END IF;
-- Crea los tickets del pedido -- Crea los tickets del pedido
OPEN vDates; OPEN vDates;