From 506d6e06888d8666cf8e99625c3316393d1f07b3 Mon Sep 17 00:00:00 2001 From: Carlos Jimenez <=> Date: Wed, 24 Jan 2018 15:13:42 +0100 Subject: [PATCH] small file name refactor and client employee backend unit tests --- .../common/methods/client/specs/card.spec.js | 2 +- .../methods/client/specs/employee.spec.js | 39 +++++++++++++++++++ .../{totalGreuge.spec.js => total.spec.js} | 2 +- .../greuge/{totalGreuge.js => total.js} | 0 services/client/common/models/greuge.js | 2 +- 5 files changed, 42 insertions(+), 3 deletions(-) create mode 100644 services/client/common/methods/client/specs/employee.spec.js rename services/client/common/methods/greuge/specs/{totalGreuge.spec.js => total.spec.js} (93%) rename services/client/common/methods/greuge/{totalGreuge.js => total.js} (100%) diff --git a/services/client/common/methods/client/specs/card.spec.js b/services/client/common/methods/client/specs/card.spec.js index 6967a0e19..bc6451161 100644 --- a/services/client/common/methods/client/specs/card.spec.js +++ b/services/client/common/methods/client/specs/card.spec.js @@ -2,7 +2,7 @@ import app from '../../../../server/server'; import {catchErrors} from '../../../../../../services/utils/jasmineHelpers'; describe('Client card', () => { - it('should call the card() method to receive a formatd card', done => { + it('should call the card() method to receive a formatd card of Bruce Wayne', done => { let id = 1; let callback = (error, result) => { diff --git a/services/client/common/methods/client/specs/employee.spec.js b/services/client/common/methods/client/specs/employee.spec.js new file mode 100644 index 000000000..73958a40d --- /dev/null +++ b/services/client/common/methods/client/specs/employee.spec.js @@ -0,0 +1,39 @@ +import app from '../../../../server/server'; +import {catchErrors} from '../../../../../../services/utils/jasmineHelpers'; + +describe('Client employeeList', () => { + it('should call the employeeList()', done => { + let callback = (error, result) => { + if (error) return catchErrors(done)(error); + + expect(result).toEqual(jasmine.objectContaining([ + { + id: 4, + name: 'Bruce Banner' + }, + { + id: 3, + name: 'Charles Xavier' + }, + { + id: 1, + name: 'David Charles Haller' + }, + { + id: 2, + name: 'Hank Pym' + }, + { + id: 5, + name: 'Jessica Jones' + }, + { + id: 20, + name: 'Victor Stone' + } + ])); + done(); + }; + app.models.Client.employeeList(callback); + }); +}); diff --git a/services/client/common/methods/greuge/specs/totalGreuge.spec.js b/services/client/common/methods/greuge/specs/total.spec.js similarity index 93% rename from services/client/common/methods/greuge/specs/totalGreuge.spec.js rename to services/client/common/methods/greuge/specs/total.spec.js index 3a985fdce..846ce752e 100644 --- a/services/client/common/methods/greuge/specs/totalGreuge.spec.js +++ b/services/client/common/methods/greuge/specs/total.spec.js @@ -1,4 +1,4 @@ -import totalGreuge from '../totalGreuge'; +import totalGreuge from '../total'; import {catchErrors} from '../../../../../../services/utils/jasmineHelpers'; describe('Greuge totalGreuge()', () => { diff --git a/services/client/common/methods/greuge/totalGreuge.js b/services/client/common/methods/greuge/total.js similarity index 100% rename from services/client/common/methods/greuge/totalGreuge.js rename to services/client/common/methods/greuge/total.js diff --git a/services/client/common/models/greuge.js b/services/client/common/models/greuge.js index 9cf127d41..23177a7a7 100644 --- a/services/client/common/models/greuge.js +++ b/services/client/common/models/greuge.js @@ -1,6 +1,6 @@ module.exports = function(Self) { require('../methods/greuge/filter.js')(Self); - require('../methods/greuge/totalGreuge.js')(Self); + require('../methods/greuge/total.js')(Self); Self.validatesLengthOf('description', { max: 45,