From 509de4fa0aca935f6b302e8b2858e8656fd7fb08 Mon Sep 17 00:00:00 2001
From: Jorge Padawan <jorgebl@verdnatura.es>
Date: Tue, 12 Jan 2021 10:11:37 +0100
Subject: [PATCH] Fix for good practique code

---
 modules/account/front/summary/index.html  | 13 +++--
 modules/claim/front/summary/index.html    | 33 +++++------
 modules/client/front/summary/index.html   | 59 +++++++++----------
 modules/item/front/summary/index.html     | 70 ++++++++++++-----------
 modules/route/front/summary/index.html    | 10 ++--
 modules/supplier/front/summary/index.html | 40 ++++++-------
 modules/travel/front/summary/index.html   | 10 ++--
 modules/zone/front/summary/index.html     |  3 +-
 8 files changed, 122 insertions(+), 116 deletions(-)

diff --git a/modules/account/front/summary/index.html b/modules/account/front/summary/index.html
index 3f6798db9..41632aef6 100644
--- a/modules/account/front/summary/index.html
+++ b/modules/account/front/summary/index.html
@@ -1,6 +1,7 @@
 <vn-card class="summary">
     <h5>
-        <a ng-if="::summary.id"
+        <a 
+            ng-if="::summary.id"
             vn-tooltip="Go to the user"
             ui-sref="account.card.summary({id: {{::summary.id}}})"
             name="goToSummary">
@@ -12,15 +13,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isHr">
                 <a 
-                ui-sref="account.card.basicData({id:summary.id})"
-                target="_self">
+                    ui-sref="account.card.basicData({id:summary.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Basic Data</span>
                 </a>
             </h4>
             <h4
-            translate 
-            ng-show="!$ctrl.isHr">
-            Basic Data
+                translate 
+                ng-show="!$ctrl.isHr">
+                Basic Data
             </h4>
             <vn-label-value
                 label="Id" 
diff --git a/modules/claim/front/summary/index.html b/modules/claim/front/summary/index.html
index a5afc97ce..e9ec1e765 100644
--- a/modules/claim/front/summary/index.html
+++ b/modules/claim/front/summary/index.html
@@ -4,7 +4,8 @@
 </vn-crud-model>
 <vn-card class="summary">
     <h5>
-        <a ng-if="::$ctrl.summary.claim.id"
+        <a 
+            ng-if="::$ctrl.summary.claim.id"
             vn-tooltip="Go to the claim"
             ui-sref="claim.card.summary({id: {{::$ctrl.summary.claim.id}}})"
             name="goToSummary">
@@ -56,15 +57,15 @@
         <vn-auto>
             <h4 ng-show="$ctrl.isSalesPerson">
                 <a 
-                ui-sref="claim.card.detail({id:$ctrl.claim.id})"
-                target="_self">
+                    ui-sref="claim.card.detail({id:$ctrl.claim.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Detail</span>
                 </a>
             </h4>
             <h4 
-            ng-show="!$ctrl.isSalesPerson"
-            translate>
-            Detail
+                ng-show="!$ctrl.isSalesPerson"
+                translate>
+                Detail
             </h4>
             <vn-data-viewer data="::$ctrl.summary.salesClaimed">
                 <vn-table>
@@ -118,15 +119,15 @@
         <vn-auto>
             <h4 ng-show="$ctrl.isClaimManager">
                 <a 
-                ui-sref="claim.card.development({id:$ctrl.claim.id})"
-                target="_self">
+                    ui-sref="claim.card.development({id:$ctrl.claim.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Development</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isClaimManager">
-            Development
+                translate
+                ng-show="!$ctrl.isClaimManager">
+                Development
             </h4>
             <vn-data-viewer data="::$ctrl.summary.developments">
                 <vn-table>
@@ -160,15 +161,15 @@
         <vn-auto>
             <h4 ng-show="$ctrl.isClaimManager">
                 <a 
-                ui-sref="claim.card.action({id:$ctrl.claim.id})"
-                target="_self">
+                    ui-sref="claim.card.action({id:$ctrl.claim.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Action</span>
                 </a>
             </h4>
             <h4
-            translate 
-            ng-show="!$ctrl.isClaimManager">
-            Action
+                translate 
+                ng-show="!$ctrl.isClaimManager">
+                Action
             </h4>
             <vn-data-viewer data="::$ctrl.summary.actions">
                 <vn-table>
diff --git a/modules/client/front/summary/index.html b/modules/client/front/summary/index.html
index a56c3b680..3e8f4f705 100644
--- a/modules/client/front/summary/index.html
+++ b/modules/client/front/summary/index.html
@@ -14,15 +14,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isEmployee">
                 <a 
-                ui-sref="client.card.basicData({id:$ctrl.client.id})"
-                target="_self">
+                    ui-sref="client.card.basicData({id:$ctrl.client.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Basic data</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isEmployee">
-            Basic data
+                translate
+                ng-show="!$ctrl.isEmployee">
+                Basic data
             </h4>
             <vn-label-value label="Id" 
                 value="{{$ctrl.summary.id}}">
@@ -56,15 +56,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isEmployee">
                 <a 
-                ui-sref="client.card.fiscalData({id:$ctrl.client.id})"
-                target="_self">
+                    ui-sref="client.card.fiscalData({id:$ctrl.client.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Fiscal address</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isEmployee">
-               Fiscal address
+                translate
+                ng-show="!$ctrl.isEmployee">
+                Fiscal address
             </h4>
             <vn-label-value label="Social name" 
                 value="{{$ctrl.summary.socialName}}">
@@ -91,15 +91,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isEmployee">
                 <a 
-                ui-sref="client.card.fiscalData({id:$ctrl.client.id})"
-                target="_self">
+                    ui-sref="client.card.fiscalData({id:$ctrl.client.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Fiscal data</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isEmployee">
-            Fiscal data
+                translate
+                ng-show="!$ctrl.isEmployee">
+                Fiscal data
             </h4>
             <vn-vertical>
                 <vn-check
@@ -142,15 +142,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isEmployee">
                 <a 
-                ui-sref="client.card.billingData({id:$ctrl.client.id})"
-                target="_self">
+                    ui-sref="client.card.billingData({id:$ctrl.client.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Billing data</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isEmployee">
-            Billing data
+                translate
+                ng-show="!$ctrl.isEmployee">
+                Billing data
             </h4>
             <vn-label-value label="Pay method" 
                 value="{{$ctrl.summary.payMethod.name}}">
@@ -182,15 +182,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isEmployee">
                 <a 
-                ui-sref="client.card.address.index({id:$ctrl.client.id})"
-                target="_self">
+                    ui-sref="client.card.address.index({id:$ctrl.client.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Address</span>
                 </a>
             </h4>
             <h4
-            translate
-            ng-show="!$ctrl.isEmployee">
-            Address
+                translate
+                ng-show="!$ctrl.isEmployee">
+                Address
             </h4>
             <vn-label-value label="Name" 
                 value="{{$ctrl.summary.defaultAddress.nickname}}">
@@ -205,13 +205,14 @@
         <vn-one>
             <h4 ng-show="$ctrl.isEmployee">
                 <a 
-                ui-sref="client.card.webAccess({id:$ctrl.client.id})"
-                target="_self">
+                    ui-sref="client.card.webAccess({id:$ctrl.client.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Web access</span>
                 </a>
             </h4>
-            <h4 translate
-            ng-show="!$ctrl.isEmployee">Web access
+            <h4 
+                translate
+                ng-show="!$ctrl.isEmployee">Web access
             </h4>
             <vn-label-value label="User" 
                 value="{{$ctrl.summary.account.name}}">
diff --git a/modules/item/front/summary/index.html b/modules/item/front/summary/index.html
index 79c0d6bfb..59ceaebbe 100644
--- a/modules/item/front/summary/index.html
+++ b/modules/item/front/summary/index.html
@@ -27,15 +27,15 @@
         <vn-one name="basicData">
             <h4 ng-show="$ctrl.isBuyer">
                 <a 
-                ui-sref="item.card.basicData({id:$ctrl.item.id})"
-                target="_self">
+                    ui-sref="item.card.basicData({id:$ctrl.item.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Basic data</span>
                 </a>
             </h4>
             <h4
-            translate 
-            ng-show="!$ctrl.isBuyer">
-            Basic data
+                translate 
+                ng-show="!$ctrl.isBuyer">
+                Basic data
             </h4>
             <vn-label-value label="Name"
                 value="{{$ctrl.summary.item.name}}">
@@ -66,15 +66,15 @@
         <vn-one name="otherData">
             <h4 ng-show="$ctrl.isBuyer">
                 <a 
-                ui-sref="item.card.basicData({id:$ctrl.item.id})"
-                target="_self">
+                    ui-sref="item.card.basicData({id:$ctrl.item.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Other data</span>
                 </a>
             </h4>
             <h4
-            translate 
-            ng-show="!$ctrl.isBuyer">
-            Other data
+                translate 
+                ng-show="!$ctrl.isBuyer">
+                Other data
             </h4>
             <vn-label-value label="Intrastat code" 
                 value="{{$ctrl.summary.item.intrastat.id}}">
@@ -101,15 +101,15 @@
         <vn-one name="tags">
             <h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher">
                 <a 
-                ui-sref="item.card.tags({id:$ctrl.item.id})"
-                target="_self">
+                    ui-sref="item.card.tags({id:$ctrl.item.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Tags</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
-            Tags
+                translate
+                ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
+                Tags
             </h4>
             <vn-label-value
                 label="{{tag.priority}} {{tag.tag.name}}"
@@ -119,14 +119,16 @@
         </vn-one>
         <vn-one name="tax">
             <h4 ng-show="$ctrl.isBuyer || $ctrl.isAdministrative">
-                <a ui-sref="item.card.tax({id:$ctrl.item.id})">
+                <a 
+                    ui-sref="item.card.tax({id:$ctrl.item.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Tax</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isBuyer || !$ctrl.isAdministrative">
-            Tax
+                translate
+                ng-show="!$ctrl.isBuyer || !$ctrl.isAdministrative">
+                Tax
             </h4>
             <vn-label-value label="{{tax.country.country}}"
                 ng-repeat="tax in $ctrl.summary.item.taxes"
@@ -136,15 +138,15 @@
         <vn-one name="niche">
             <h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher">
                 <a 
-                ui-sref="item.card.niche({id:$ctrl.item.id})"
-                target="_self">
+                    ui-sref="item.card.niche({id:$ctrl.item.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Niche</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
-            Niche
+                translate
+                ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
+                Niche
             </h4>
             <vn-label-value label="{{niche.warehouse.name}}"
                 ng-repeat="niche in $ctrl.summary.niches"
@@ -154,15 +156,15 @@
         <vn-one name="botanical">
             <h4 ng-show="$ctrl.isBuyer">
                 <a 
-                ui-sref="item.card.botanical({id:$ctrl.item.id})"
-                target="_self">
+                    ui-sref="item.card.botanical({id:$ctrl.item.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Botanical</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isBuyer">
-            Botanical
+                translate
+                ng-show="!$ctrl.isBuyer">
+                Botanical
             </h4>
             <vn-label-value label="Botanical" 
                 value="{{$ctrl.summary.botanical.botanical}}">
@@ -177,15 +179,15 @@
         <vn-one name="barcode">
             <h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher">
                 <a 
-                ui-sref="item.card.itemBarcode({id:$ctrl.item.id})"
-                target="_self">
+                    ui-sref="item.card.itemBarcode({id:$ctrl.item.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Barcode</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
-            Barcode
+                translate
+                ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
+                Barcode
             </h4>
             <p ng-repeat="barcode in $ctrl.summary.item.itemBarcode track by $index">
                 <b>{{barcode.code}}</b>
diff --git a/modules/route/front/summary/index.html b/modules/route/front/summary/index.html
index 9bd83a14d..b284851a0 100644
--- a/modules/route/front/summary/index.html
+++ b/modules/route/front/summary/index.html
@@ -63,15 +63,15 @@
         <vn-auto>
             <h4 ng-show="$ctrl.isDelivery">
                 <a 
-                ui-sref="route.card.tickets({id:$ctrl.route.id})"
-                target="_self">
+                    ui-sref="route.card.tickets({id:$ctrl.route.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Ticket</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isDelivery">
-            Ticket
+                translate
+                ng-show="!$ctrl.isDelivery">
+                Ticket
             </h4>
             <vn-table model="model">
                 <vn-thead>
diff --git a/modules/supplier/front/summary/index.html b/modules/supplier/front/summary/index.html
index 9ac79fd27..b089f25e9 100644
--- a/modules/supplier/front/summary/index.html
+++ b/modules/supplier/front/summary/index.html
@@ -12,15 +12,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isAdministrative">
                 <a 
-                ui-sref="supplier.card.basicData({id:$ctrl.supplier.id})"
-                target="_self">
+                    ui-sref="supplier.card.basicData({id:$ctrl.supplier.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Basic data</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isAdministrative">
-            Basic data
+                translate
+                ng-show="!$ctrl.isAdministrative">
+                Basic data
             </h4>
             <vn-vertical>
                 <vn-label-value 
@@ -50,15 +50,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isAdministrative">
                 <a 
-                ui-sref="supplier.card.billingData({id:$ctrl.supplier.id})"
-                target="_self">
+                    ui-sref="supplier.card.billingData({id:$ctrl.supplier.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Billing data</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isAdministrative">
-            Billing data
+                translate
+                ng-show="!$ctrl.isAdministrative">
+                Billing data
             </h4>
             <vn-label-value 
                 label="Pay method" 
@@ -87,15 +87,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isAdministrative">
                 <a 
-                ui-sref="supplier.card.fiscalData({id:$ctrl.supplier.id})"
-                target="_self">
+                    ui-sref="supplier.card.fiscalData({id:$ctrl.supplier.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Fiscal data</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isAdministrative">
-            Fiscal data
+                translate
+                ng-show="!$ctrl.isAdministrative">
+                Fiscal data
             </h4>
             <vn-label-value 
                 label="Sage tax type" 
@@ -117,15 +117,15 @@
         <vn-one>
             <h4 ng-show="$ctrl.isAdministrative">
                 <a 
-                ui-sref="supplier.card.fiscalData({id:$ctrl.supplier.id})"
-                target="_self">
+                    ui-sref="supplier.card.fiscalData({id:$ctrl.supplier.id})"
+                    target="_self">
                     <span translate vn-tooltip="Go to">Fiscal address</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isAdministrative">
-            Fiscal address
+                translate
+                ng-show="!$ctrl.isAdministrative">
+                Fiscal address
             </h4>
             <vn-label-value 
                 label="Social name" 
diff --git a/modules/travel/front/summary/index.html b/modules/travel/front/summary/index.html
index b8db9946c..7c06f39fd 100644
--- a/modules/travel/front/summary/index.html
+++ b/modules/travel/front/summary/index.html
@@ -134,15 +134,15 @@
         <vn-auto ng-if="$ctrl.travelThermographs.length != 0">
             <h4 ng-show="$ctrl.isBuyer">
                 <a 
-                ui-sref="travel.card.thermograph.index({id:$ctrl.travelData.id})"
-                target="_self">
+                        ui-sref="travel.card.thermograph.index({id:$ctrl.travelData.id})"
+                        target="_self">
                     <span translate vn-tooltip="Go to">Thermograph</span>
                 </a>
             </h4>
             <h4 
-            translate
-            ng-show="!$ctrl.isBuyer">
-            Thermograph
+                translate
+                ng-show="!$ctrl.isBuyer">
+                Thermograph
             </h4>
             <vn-table>
                 <vn-thead>
diff --git a/modules/zone/front/summary/index.html b/modules/zone/front/summary/index.html
index d891fd9d1..2633ebbd2 100644
--- a/modules/zone/front/summary/index.html
+++ b/modules/zone/front/summary/index.html
@@ -37,7 +37,8 @@
     <vn-horizontal class="vn-pa-md">
         <vn-auto>
             <h4>
-                <a ui-sref="zone.card.warehouses({id:$ctrl.zone.id})">
+                <a 
+                    ui-sref="zone.card.warehouses({id:$ctrl.zone.id})">
                     <span translate vn-tooltip="Go to">Warehouse</span>
                 </a>
             </h4>