From 58d8176a428d858b3ae50557521c46e17073f640 Mon Sep 17 00:00:00 2001 From: Juan Ferrer Toribio Date: Thu, 15 Dec 2016 12:12:43 +0100 Subject: [PATCH] Errores al minificar login detectados --- @salix/core/src/inputAttrsNormalizer.js | 1 + @salix/core/src/spinner/spinner.js | 10 ++--- @salix/login/src/login/login.js | 56 +++++++++++-------------- 3 files changed, 30 insertions(+), 37 deletions(-) diff --git a/@salix/core/src/inputAttrsNormalizer.js b/@salix/core/src/inputAttrsNormalizer.js index 927fb10df2..05592f9a4a 100644 --- a/@salix/core/src/inputAttrsNormalizer.js +++ b/@salix/core/src/inputAttrsNormalizer.js @@ -6,6 +6,7 @@ export class InputAttrsNormalizer { $get(){ return { normalize: function(attrs) { + // FIXME: No siempre se pasan estos atributos, ej: searchbar /* if (!attrs.entity) throw new Error(`Attribute 'entity' not defined on input`); if (!attrs.field) diff --git a/@salix/core/src/spinner/spinner.js b/@salix/core/src/spinner/spinner.js index 03bbd9f5fe..768ff5a3f0 100644 --- a/@salix/core/src/spinner/spinner.js +++ b/@salix/core/src/spinner/spinner.js @@ -5,14 +5,14 @@ import * as util from '../util'; const _NAME = 'spinner'; export const NAME = util.getName(_NAME); -directive.$inject =[resolveFactory.NAME]; +directive.$inject = [resolveFactory.NAME]; export function directive (resolve){ return{ - require:'E', - template: function(_,attr){ - return resolve.getTemplate(_NAME, attr); + restrict: 'E', + template: function(_, attrs){ + return resolve.getTemplate(_NAME, attrs); } } } -_module.directive(NAME,directive); +_module.directive(NAME, directive); diff --git a/@salix/login/src/login/login.js b/@salix/login/src/login/login.js index b243a7e50e..c62a927dbd 100644 --- a/@salix/login/src/login/login.js +++ b/@salix/login/src/login/login.js @@ -5,16 +5,13 @@ import style from './login.scss' export const COMPONENT = { template: template, - controller: function ($http) - { + controller: function($http) { var self = this; - this.submit = function () - { + this.submit = function() { var model = this.model; - if (model && model.email && model.password) - { - setLoading (true); + if(model && model.email && model.password) { + setLoading(true); model.appId = window.location.href; $http.post('/account', this.model).then ( onLoginOk, @@ -22,25 +19,21 @@ export const COMPONENT = ); } else - showMessage ('Please insert your email and password'); + showMessage('Please insert your email and password'); }; - function onLoginOk (response) - { - setLoading (false); - //sessionStorage.setItem ('token', response.data.accessToken); + function onLoginOk (response) { + setLoading(false); window.location = response.data.location +'?access_token='+ response.data.accessToken; } - function onLoginErr (response) - { - setLoading (false); + function onLoginErr(response) { + setLoading(false); self.model.password = ''; var message; - switch (response.status) - { + switch(response.status) { case 401: message = 'Invalid credentials'; break; @@ -51,28 +44,27 @@ export const COMPONENT = message = 'Something went wrong'; } - showMessage (message); + showMessage(message); } - function $ (id) - { - return document.getElementById (id); + function $(id) { + return document.getElementById(id); } - function setLoading (isLoading) - { - var spinner = $('spinner').firstChild.MaterialSpinner; - - if (isLoading) - spinner.start (); + function setLoading(isLoading) { + // FIXME: Al minimificar MaterialSpinner es undefined +/* var spinner = $('spinner').firstChild.MaterialSpinner; + + if(isLoading) + spinner.start(); else - spinner.stop (); - } + spinner.stop(); +*/ } - function showMessage (message) - { + function showMessage(message) { + // FIXME: Al minimificar no muestra la barra var snackbar = $('snackbar').firstChild.MaterialSnackbar; - snackbar.showSnackbar ({message: message}); + snackbar.showSnackbar({message: message}); } }, controllerAs: 'login'