From 5a1c4ddea02f52c6e836246b70c1a5d0d459e082 Mon Sep 17 00:00:00 2001
From: pablone <pablone@verdnatura.es>
Date: Tue, 26 Dec 2023 08:20:13 +0100
Subject: [PATCH] refactor(ticketSms): refs #6259 ticketSmsToClientSms

---
 .../00-ticketSmsToClientSms.sql                  | 16 ----------------
 .../back/methods/ticket/specs/sendSms.spec.js    |  8 ++++----
 2 files changed, 4 insertions(+), 20 deletions(-)
 rename db/changes/{240001 => 240201}/00-ticketSmsToClientSms.sql (52%)

diff --git a/db/changes/240001/00-ticketSmsToClientSms.sql b/db/changes/240201/00-ticketSmsToClientSms.sql
similarity index 52%
rename from db/changes/240001/00-ticketSmsToClientSms.sql
rename to db/changes/240201/00-ticketSmsToClientSms.sql
index f2aa73863..cd3cf7dd3 100644
--- a/db/changes/240001/00-ticketSmsToClientSms.sql
+++ b/db/changes/240201/00-ticketSmsToClientSms.sql
@@ -7,19 +7,3 @@ INSERT INTO`vn`.`clientSms` (`clientFk`, `smsFk`, `ticketFk`)
 			JOIN `vn`.`ticket` `t` ON `t`.`id` = `s`.`ticketFk`;
 
 RENAME TABLE `vn`.`ticketSms` TO `vn`.`ticketSms__`;
-
-DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`clientSms_beforeInsert`
-	BEFORE INSERT ON `clientSms`
-	FOR EACH ROW
-BEGIN
-	DECLARE vTicketOwner INT;
-
-    SELECT clientFk INTO vTicketOwner
-        FROM ticket 
-        WHERE id = NEW.ticketFk;
-
-    IF NOT NEW.clientFk = vTicketOwner THEN
-        CALL util.throw('Unable to send an SMS ticket to a client who is not the owner');
-    END IF;
-END$$
\ No newline at end of file
diff --git a/modules/ticket/back/methods/ticket/specs/sendSms.spec.js b/modules/ticket/back/methods/ticket/specs/sendSms.spec.js
index 43507ec56..afc1ada54 100644
--- a/modules/ticket/back/methods/ticket/specs/sendSms.spec.js
+++ b/modules/ticket/back/methods/ticket/specs/sendSms.spec.js
@@ -14,10 +14,10 @@ describe('ticket sendSms()', () => {
 
             await models.Ticket.sendSms(ctx, id, destination, message, options);
 
-            const filter = {
-                ticketFk: id
-            };
-            const clientSms = await models.ClientSms.findOne(filter, options);
+            const clientSms = await models.ClientSms.findOne(
+                {where: {ticketFk: id}},
+                options
+            );
 
             expect(clientSms.ticketFk).toEqual(id);