verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refator: delete unnecessary transaction
gitea/salix/pipeline/head There was a failure building this commit Details

This commit is contained in:
Vicent Llopis 2022-10-04 08:19:09 +02:00
parent a486b1593b
commit 5c76437498
2 changed files with 19 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
modules/ticket/back/methods/ticket-request/getItemTypeWorker.js
View File

@ -28,40 +28,30 @@ module.exports = Self => {
if (typeof options == 'object')
Object.assign(myOptions, options);
if (!myOptions.transaction) {
tx = await Self.beginTransaction({});
myOptions.transaction = tx;
}
try {
const query =
`SELECT DISTINCT w.id, w.firstName, w.lastName, u.name, u.nickname
const query =
`SELECT DISTINCT u.nickname
FROM itemType it
JOIN worker w ON w.id = it.workerFk
JOIN account.user u ON u.id = w.id`;
let stmt = new ParameterizedSQL(query);
let stmt = new ParameterizedSQL(query);
if (filter.where) {
const value = filter.where.firstName;
const myFilter = {
where: {or: [
{'w.firstName': {like: `%${value}%`}},
{'w.lastName': {like: `%${value}%`}},
{'u.name': {like: `%${value}%`}},
{'u.nickname': {like: `%${value}%`}}
]}
};
if (filter.where) {
const value = filter.where.firstName;
const myFilter = {
where: {or: [
{'w.firstName': {like: `%${value}%`}},
{'w.lastName': {like: `%${value}%`}},
{'u.name': {like: `%${value}%`}},
{'u.nickname': {like: `%${value}%`}}
]}
};
stmt.merge(conn.makeSuffix(myFilter));
}
if (tx) await tx.commit();
return conn.executeStmt(stmt);
} catch (e) {
if (tx) await tx.rollback();
throw e;
stmt.merge(conn.makeSuffix(myFilter));
}
if (tx) await tx.commit();
return conn.executeStmt(stmt);
};
};

2
modules/ticket/back/methods/ticket-request/specs/getItemTypeWorkers.spec.js
View File

@ -16,6 +16,6 @@ describe('ticket-request getItemTypeWorker()', () => {
const result = await models.TicketRequest.getItemTypeWorker(ctx, filter);
expect(result.length).toEqual(2);
expect(result.length).toBeGreaterThan(1);
});
});