verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

refactor: change variables name
gitea/salix/pipeline/head There was a failure building this commit Details

This commit is contained in:
Vicent Llopis 2022-10-18 11:47:37 +02:00
parent 423454d19e
commit 5fce93abd5
4 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/ticket/back/methods/expedition/deleteExpeditions.js
View File

@ -4,7 +4,7 @@ module.exports = Self => {
description: 'Delete the selected expeditions',
accessType: 'WRITE',
accepts: [{
arg: 'expeditionsIds',
arg: 'expeditionIds',
type: ['number'],
required: true,
description: 'The expeditions ids to delete'
@ -19,7 +19,7 @@ module.exports = Self => {
}
});
Self.deleteExpeditions = async(expeditionsIds, options) => {
Self.deleteExpeditions = async(expeditionIds, options) => {
const models = Self.app.models;
const myOptions = {};
let tx;
@ -34,7 +34,7 @@ module.exports = Self => {
try {
const deletedExpeditions = await models.Expedition.destroyAll({
id: {inq: expeditionsIds}
id: {inq: expeditionIds}
}, myOptions);
if (tx) await tx.commit();

6
modules/ticket/back/methods/expedition/moveExpeditions.js
View File

@ -4,7 +4,7 @@ module.exports = Self => {
description: 'Move the selected expeditions to another ticket',
accessType: 'WRITE',
accepts: [{
arg: 'expeditionsIds',
arg: 'expeditionIds',
type: ['number'],
required: true,
description: 'The expeditions ids to nove'
@ -25,7 +25,7 @@ module.exports = Self => {
}
});
Self.moveExpeditions = async(expeditionsIds, ticketId, options) => {
Self.moveExpeditions = async(expeditionIds, ticketId, options) => {
const models = Self.app.models;
const myOptions = {};
let tx;
@ -40,7 +40,7 @@ module.exports = Self => {
try {
const promises = [];
for (let expeditionsId of expeditionsIds) {
for (let expeditionsId of expeditionIds) {
const expeditionToUpdate = await models.Expedition.findById(expeditionsId);
const expeditionUpdated = expeditionToUpdate.updateAttribute('ticketFk', ticketId, myOptions);
promises.push(expeditionUpdated);

4
modules/ticket/front/expedition/index.spec.js
View File

@ -63,7 +63,7 @@ describe('Ticket', () => {
it('should make a query and then call to the model refresh() method', () => {
jest.spyOn($scope.model, 'refresh');
const expectedParams = {expeditionsIds: [1, 2]};
const expectedParams = {expeditionIds: [1, 2]};
$httpBackend.expect('POST', 'Expeditions/deleteExpeditions', expectedParams).respond(200);
controller.onRemove();
$httpBackend.flush();
@ -97,7 +97,7 @@ describe('Ticket', () => {
const expectedResponse = {id: ticketIdToTransfer};
const expectedParams = {
expeditionsIds: [1, 2],
expeditionIds: [1, 2],
ticketId: 28
};
$httpBackend.expect('POST', 'Tickets/new', expectedTicket).respond(expectedResponse);

1
modules/ticket/front/expedition/locale/es.yml
View File

@ -3,3 +3,4 @@ Expedition removed: Expedición eliminada
Move: Mover
New ticket without route: Nuevo ticket sin ruta
New ticket with route: Nuevo ticket con ruta
Id route: Id ruta