From 649be482b500d4d4175d8ec342337b8b781484b0 Mon Sep 17 00:00:00 2001 From: joan <joan@verdnatura.es> Date: Fri, 13 May 2022 10:52:05 +0200 Subject: [PATCH] Updated changePassword() --- Jenkinsfile | 2 +- back/methods/account/change-password.js | 2 +- back/methods/account/specs/change-password.spec.js | 7 ++++--- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Jenkinsfile b/Jenkinsfile index 59806f497c..97fec5b48d 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -41,7 +41,7 @@ pipeline { } steps { nodejs('node-v14') { - sh 'npm install --no-audit' + sh 'npm install --no-audit --prefer-offline' sh 'gulp install --ci' } } diff --git a/back/methods/account/change-password.js b/back/methods/account/change-password.js index 8dbc88e3ee..25b63b9a8e 100644 --- a/back/methods/account/change-password.js +++ b/back/methods/account/change-password.js @@ -29,6 +29,6 @@ module.exports = Self => { Self.changePassword = async function(id, oldPassword, newPassword) { await Self.rawSql(`CALL account.user_changePassword(?, ?, ?)`, [id, oldPassword, newPassword]); - // await Self.app.models.UserAccount.syncById(id, newPassword); + await Self.app.models.UserAccount.syncById(id, newPassword); }; }; diff --git a/back/methods/account/specs/change-password.spec.js b/back/methods/account/specs/change-password.spec.js index 0cc550e9e4..2dbd426ee4 100644 --- a/back/methods/account/specs/change-password.spec.js +++ b/back/methods/account/specs/change-password.spec.js @@ -1,9 +1,10 @@ -const app = require('vn-loopback/server/server'); +const {models} = require('vn-loopback/server/server'); fdescribe('account changePassword()', () => { it('should throw an error when old password is wrong', async() => { - let req = app.models.Account.changePassword(null, 1, 'wrongOldPass', 'newPass'); + const response = models.Account.changePassword(1, 'wrongPassword', 'nightmare.9999'); - await expectAsync(req).toBeRejected(); + const error = new Error('ER_SIGNAL_EXCEPTION: Invalid password'); + await expectAsync(response).toBeRejectedWith(error); }); });