From cc0c8443bf0c4ff938a6f9a14ed44a3ade04812c Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 3 Jan 2024 08:06:20 +0100
Subject: [PATCH 1/3] refs #6613 perf: translate message error

---
 loopback/server/middleware/error-handler.js | 5 +++--
 loopback/util/forbiddenError.js             | 5 +++--
 loopback/util/salixError.js                 | 5 +++++
 loopback/util/user-error.js                 | 5 +++--
 4 files changed, 14 insertions(+), 6 deletions(-)
 create mode 100644 loopback/util/salixError.js

diff --git a/loopback/server/middleware/error-handler.js b/loopback/server/middleware/error-handler.js
index 725826ae7f..cc7b81618b 100644
--- a/loopback/server/middleware/error-handler.js
+++ b/loopback/server/middleware/error-handler.js
@@ -1,10 +1,11 @@
+const SalixError = require('../../util/salixError');
 const UserError = require('../../util/user-error');
 const logToConsole = require('strong-error-handler/lib/logger');
 
 module.exports = function() {
     return function(err, req, res, next) {
         // Thrown user errors
-        if (err instanceof UserError) {
+        if (err instanceof SalixError) {
             err.message = req.__(err.message, ...err.translateArgs);
             return next(err);
         }
@@ -13,7 +14,7 @@ module.exports = function() {
         if (err.statusCode == 422) {
             try {
                 let code;
-                let messages = err.details.messages;
+                let {messages} = err.details;
                 for (code in messages) break;
                 err.message = req.__(messages[code][0]);
                 return next(err);
diff --git a/loopback/util/forbiddenError.js b/loopback/util/forbiddenError.js
index 998cb45933..8f65610593 100644
--- a/loopback/util/forbiddenError.js
+++ b/loopback/util/forbiddenError.js
@@ -1,7 +1,8 @@
-module.exports = class ForbiddenError extends Error {
+const SalixError = require('./salixError');
+module.exports = class ForbiddenError extends SalixError {
     constructor(message, code, ...translateArgs) {
         super(message);
-        this.name = 'ForbiddenError';
+        this.name = ForbiddenError.name;
         this.statusCode = 403;
         this.code = code;
         this.translateArgs = translateArgs;
diff --git a/loopback/util/salixError.js b/loopback/util/salixError.js
new file mode 100644
index 0000000000..427b871abd
--- /dev/null
+++ b/loopback/util/salixError.js
@@ -0,0 +1,5 @@
+module.exports = class SalixError extends Error {
+    constructor(message) {
+        super(message);
+    }
+};
diff --git a/loopback/util/user-error.js b/loopback/util/user-error.js
index c2d01e0804..feee208b35 100644
--- a/loopback/util/user-error.js
+++ b/loopback/util/user-error.js
@@ -4,10 +4,11 @@
  * the final user, so they cannot contain sensitive data and must
  * be understandable by people who do not have a technical profile.
  */
-module.exports = class UserError extends Error {
+const SalixError = require('./salixError');
+module.exports = class UserError extends SalixError {
     constructor(message, code, ...translateArgs) {
         super(message);
-        this.name = 'UserError';
+        this.name = UserError.name;
         this.statusCode = 400;
         this.code = code;
         this.translateArgs = translateArgs;

From 107dded4114a6d027a172d5d4ea216df961d13e5 Mon Sep 17 00:00:00 2001
From: carlossa <carlossa@verdnatura.es>
Date: Mon, 15 Jan 2024 09:03:56 +0100
Subject: [PATCH 2/3] refs #6296 countryAddress

---
 modules/client/front/address/index/index.html | 10 +++++-----
 modules/client/front/address/index/index.js   |  8 +++++++-
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/modules/client/front/address/index/index.html b/modules/client/front/address/index/index.html
index 8fdfce2bb8..989ce13a90 100644
--- a/modules/client/front/address/index/index.html
+++ b/modules/client/front/address/index/index.html
@@ -42,14 +42,14 @@
                     translate-attr="{title: 'Set as default'}">
                 </vn-icon-button>
             </vn-none>
-            <vn-one 
+            <vn-one
                 style="overflow: hidden; min-width: 14em;">
                 <div class="ellipsize"><b>{{::address.nickname}} - #{{::address.id}}</b></div>
                 <div class="ellipsize" name="street">{{::address.street}}</div>
                 <div class="ellipsize">
-                    <span ng-show="::address.postalCode">{{::address.postalCode}} -</span> 
-                    <span ng-show="::address.city">{{::address.city}},</span> 
-                    {{::address.province.name}}
+                    <span ng-show="::address.city">{{::address.city}},</span>
+                    <span ng-show="::address.province.name">{{::address.province.name}},</span>
+                    {{::address.province.country.country}}
                 </div>
                 <div class="ellipsize">
                     {{::address.phone}}<span ng-if="::address.mobile">, </span>
@@ -72,7 +72,7 @@
                 class="vn-hide-narrow vn-px-md border-solid-left"
                 style="height: 6em; overflow: auto;">
                 <vn-one ng-repeat="observation in address.observations track by $index" ng-class="{'vn-pt-sm': $index}">
-                    <b>{{::observation.observationType.description}}:</b> 
+                    <b>{{::observation.observationType.description}}:</b>
                     <span>{{::observation.description}}</span>
                 </vn-one>
             </vn-vertical>
diff --git a/modules/client/front/address/index/index.js b/modules/client/front/address/index/index.js
index 608bbbc202..4bad9d4c84 100644
--- a/modules/client/front/address/index/index.js
+++ b/modules/client/front/address/index/index.js
@@ -33,7 +33,13 @@ class Controller extends Section {
                 }, {
                     relation: 'province',
                     scope: {
-                        fields: ['id', 'name']
+                        fields: ['id', 'name', 'countryFk'],
+                        include: {
+                            relation: 'country',
+                            scope: {
+                                fields: ['id', 'country']
+                            }
+                        }
                     }
                 }
             ]

From 75259984771994568b67a906ef36a2ad320e6656 Mon Sep 17 00:00:00 2001
From: carlossa <carlossa@verdnatura.es>
Date: Wed, 17 Jan 2024 14:13:09 +0100
Subject: [PATCH 3/3] refs #6296 postal code

---
 modules/client/front/address/index/index.html | 1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/client/front/address/index/index.html b/modules/client/front/address/index/index.html
index 989ce13a90..ef3da40519 100644
--- a/modules/client/front/address/index/index.html
+++ b/modules/client/front/address/index/index.html
@@ -47,6 +47,7 @@
                 <div class="ellipsize"><b>{{::address.nickname}} - #{{::address.id}}</b></div>
                 <div class="ellipsize" name="street">{{::address.street}}</div>
                 <div class="ellipsize">
+                    <span ng-show="::address.postalCode">{{::address.postalCode}} -</span>
                     <span ng-show="::address.city">{{::address.city}},</span>
                     <span ng-show="::address.province.name">{{::address.province.name}},</span>
                     {{::address.province.country.country}}