From 744171dd4c33af9e2bfd94e5d9cf06628471b99e Mon Sep 17 00:00:00 2001
From: guillermo <guillermo@verdnatura.es>
Date: Tue, 13 Feb 2024 09:41:26 +0100
Subject: [PATCH] fix: refs #6184 Requested changes

---
 modules/ticket/back/methods/ticket/saveSign.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/modules/ticket/back/methods/ticket/saveSign.js b/modules/ticket/back/methods/ticket/saveSign.js
index 3718dfcda..9c6e8181a 100644
--- a/modules/ticket/back/methods/ticket/saveSign.js
+++ b/modules/ticket/back/methods/ticket/saveSign.js
@@ -34,6 +34,7 @@ module.exports = Self => {
         const myOptions = {userId: ctx.req.accessToken.userId};
         let tx;
         let ticket;
+        let externalTickets = [];
 
         if (typeof options == 'object')
             Object.assign(myOptions, options);
@@ -89,7 +90,6 @@ module.exports = Self => {
         }
 
         try {
-            let externalTickets = [];
             for (const ticketId of tickets) {
                 ticket = await models.Ticket.findById(ticketId, {
                     include: [{
@@ -154,11 +154,10 @@ module.exports = Self => {
                 }
             }
             if (tx) await tx.commit();
-            await models.Route.cmrEmail(ctx, externalTickets);
-            return;
         } catch (e) {
-            if (tx && tx.isActive()) await tx.rollback();
+            if (tx) await tx.rollback();
             throw e;
         }
+        await models.Route.cmrEmail(ctx, externalTickets);
     };
 };