From 75293fbb9aa28d9fc13896c16c825abe27dae24f Mon Sep 17 00:00:00 2001
From: Sergio De la torre <sergiodt.verdnatura@gmail.com>
Date: Tue, 9 Apr 2024 07:38:28 +0200
Subject: [PATCH] refs #6276 hotFix:itemShelving_add

---
 .../vn/procedures/itemShelving_add.sql        |  1 -
 .../item-shelving/specs/upsertItem.spec.js    | 29 ++++++++++---------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/db/routines/vn/procedures/itemShelving_add.sql b/db/routines/vn/procedures/itemShelving_add.sql
index 2a4676b50..d4c31f09e 100644
--- a/db/routines/vn/procedures/itemShelving_add.sql
+++ b/db/routines/vn/procedures/itemShelving_add.sql
@@ -21,7 +21,6 @@ BEGIN
 	SELECT barcodeToItem(vBarcode) INTO vItemFk;
 	
 	SET vPacking = COALESCE(vPacking, GREATEST(vn.itemPacking(vBarcode,vWarehouseFk), 1));
-
 	SET vQuantity = vQuantity * vPacking;
 
 	IF (SELECT COUNT(*) FROM shelving WHERE code = vShelvingFk COLLATE utf8_unicode_ci) = 0 THEN
diff --git a/modules/item/back/methods/item-shelving/specs/upsertItem.spec.js b/modules/item/back/methods/item-shelving/specs/upsertItem.spec.js
index 9042b743d..8615b7b86 100644
--- a/modules/item/back/methods/item-shelving/specs/upsertItem.spec.js
+++ b/modules/item/back/methods/item-shelving/specs/upsertItem.spec.js
@@ -1,4 +1,4 @@
-const {models} = require('vn-loopback/server/server');
+const { models } = require('vn-loopback/server/server');
 const LoopBackContext = require('loopback-context');
 
 // #6276
@@ -8,11 +8,11 @@ describe('ItemShelving upsertItem()', () => {
     let options;
     let tx;
 
-    beforeEach(async() => {
+    beforeEach(async () => {
         ctx = {
             req: {
-                accessToken: {userId: 9},
-                headers: {origin: 'http://localhost'}
+                accessToken: { userId: 9 },
+                headers: { origin: 'http://localhost' }
             },
             args: {}
         };
@@ -21,36 +21,37 @@ describe('ItemShelving upsertItem()', () => {
             active: ctx.req
         });
 
-        options = {transaction: tx};
+        options = { transaction: tx };
         tx = await models.ItemShelving.beginTransaction({});
         options.transaction = tx;
     });
 
-    afterEach(async() => {
+    afterEach(async () => {
         await tx.rollback();
     });
 
-    xit('should add two new records', async() => {
+    it('should add two new records', async () => {
         const shelvingFk = 'ZPP';
         const items = [1, 1, 1, 2];
 
         await models.ItemShelving.upsertItem(ctx, shelvingFk, items, warehouseFk, options);
-        const itemShelvings = await models.ItemShelving.find({where: {shelvingFk}}, options);
+        const itemShelvings = await models.ItemShelving.find({ where: { shelvingFk } }, options);
 
         expect(itemShelvings.length).toEqual(2);
     });
 
-    xit('should update the visible items', async() => {
+    it('should update the visible items', async () => {
         const shelvingFk = 'GVC';
         const items = [2, 2];
-        const {visible: itemsBefore} = await models.ItemShelving.findOne({
-            where: {shelvingFk, itemFk: items[0]}
+        const { visible: visibleItemsBefore } = await models.ItemShelving.findOne({
+            where: { shelvingFk, itemFk: items[0] }
         }, options);
         await models.ItemShelving.upsertItem(ctx, shelvingFk, items, warehouseFk, options);
-        const {visible: itemsAfter} = await models.ItemShelving.findOne({
-            where: {shelvingFk, itemFk: items[0]}
+
+        const { visible: visibleItemsAfter } = await models.ItemShelving.findOne({
+            where: { shelvingFk, itemFk: items[0] }
         }, options);
 
-        expect(itemsAfter).toEqual(itemsBefore + 2);
+        expect(visibleItemsAfter).toEqual(visibleItemsBefore + 2);
     });
 });