From 78ee7e141d4c118099a6ecf2770771346cd296c0 Mon Sep 17 00:00:00 2001
From: pablone <pablone@verdnatura.es>
Date: Thu, 17 Oct 2024 08:40:25 +0200
Subject: [PATCH] fix: refs #7457 remove translate and use param definition for
 restriction

---
 loopback/locale/en.json                    | 3 +--
 loopback/locale/es.json                    | 3 +--
 loopback/locale/fr.json                    | 3 +--
 loopback/locale/pt.json                    | 3 +--
 modules/order/back/methods/order/filter.js | 7 ++-----
 5 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/loopback/locale/en.json b/loopback/locale/en.json
index 0f6457754..ea84cb6eb 100644
--- a/loopback/locale/en.json
+++ b/loopback/locale/en.json
@@ -240,6 +240,5 @@
 	"There is already a tray with the same height": "There is already a tray with the same height",
 	"The height must be greater than 50cm": "The height must be greater than 50cm",
 	"The maximum height of the wagon is 200cm": "The maximum height of the wagon is 200cm",
-    "The quantity claimed cannot be greater than the quantity of the line": "The quantity claimed cannot be greater than the quantity of the line",
-	"The from field is required": "The 'from' field is required"
+    "The quantity claimed cannot be greater than the quantity of the line": "The quantity claimed cannot be greater than the quantity of the line"
 }
diff --git a/loopback/locale/es.json b/loopback/locale/es.json
index 8118b6f65..9308fd4ec 100644
--- a/loopback/locale/es.json
+++ b/loopback/locale/es.json
@@ -382,6 +382,5 @@
 	"This buyer has already made a reservation for this date": "Este comprador ya ha hecho una reserva para esta fecha",
 	"No valid travel thermograph found": "No se encontró un termógrafo válido",
 	"The quantity claimed cannot be greater than the quantity of the line": "La cantidad reclamada no puede ser mayor que la cantidad de la línea",
-	"type cannot be blank": "Se debe rellenar el tipo",
-	"The from field is required": "El campo 'desde' es obligatorio"
+	"type cannot be blank": "Se debe rellenar el tipo"
 }
\ No newline at end of file
diff --git a/loopback/locale/fr.json b/loopback/locale/fr.json
index 5bc98c3dd..3f6cc69e7 100644
--- a/loopback/locale/fr.json
+++ b/loopback/locale/fr.json
@@ -362,6 +362,5 @@
 	"It has been invoiced but the PDF of refund not be generated": "Il a été facturé mais le PDF de remboursement n'a pas été généré",
 	"Cannot send mail": "Impossible d'envoyer le mail",
     "Original invoice not found": "Facture originale introuvable",
-    "The quantity claimed cannot be greater than the quantity of the line": "Le montant réclamé ne peut pas être supérieur au montant de la ligne",
-	"The from field is required": "Le champ de est requis"
+    "The quantity claimed cannot be greater than the quantity of the line": "Le montant réclamé ne peut pas être supérieur au montant de la ligne"
 }
diff --git a/loopback/locale/pt.json b/loopback/locale/pt.json
index 91dc372c3..a43f0e780 100644
--- a/loopback/locale/pt.json
+++ b/loopback/locale/pt.json
@@ -362,6 +362,5 @@
 	"It has been invoiced but the PDF of refund not be generated": "Foi faturado mas não foi gerado o PDF do reembolso",
     "Original invoice not found": "Fatura original não encontrada",
 	"Cannot send mail": "Não é possível enviar o email",
-    "The quantity claimed cannot be greater than the quantity of the line": "O valor reclamado não pode ser superior ao valor da linha",
-	"The from field is required": "O campo de origem é obrigatório"
+    "The quantity claimed cannot be greater than the quantity of the line": "O valor reclamado não pode ser superior ao valor da linha"
 }
diff --git a/modules/order/back/methods/order/filter.js b/modules/order/back/methods/order/filter.js
index 5b5fe8701..844adb51e 100644
--- a/modules/order/back/methods/order/filter.js
+++ b/modules/order/back/methods/order/filter.js
@@ -2,7 +2,6 @@
 const ParameterizedSQL = require('loopback-connector').ParameterizedSQL;
 const buildFilter = require('vn-loopback/util/filter').buildFilter;
 const mergeFilters = require('vn-loopback/util/filter').mergeFilters;
-const UserError = require('vn-loopback/util/user-error');
 
 module.exports = Self => {
     Self.remoteMethod('filter', {
@@ -23,7 +22,8 @@ module.exports = Self => {
             }, {
                 arg: 'from',
                 type: 'date',
-                description: 'The from date'
+                description: 'The from date',
+                required: true
             }, {
                 arg: 'to',
                 type: 'date',
@@ -84,9 +84,6 @@ module.exports = Self => {
             Object.assign(myOptions, options);
 
         const args = ctx.args;
-
-        if (!args.from)
-            throw new UserError('The from field is required');
         // Apply filter by team
         const teamMembersId = [];
         if (args.myTeam != null) {