From 84bacfd37993e1236d4818ce0e963b9c05c499b4 Mon Sep 17 00:00:00 2001
From: Bernat Exposito Domenech <bernat.verdnatura@gmail.com>
Date: Thu, 18 Jun 2020 10:10:42 +0200
Subject: [PATCH] add message before delete a line on a claim

---
 modules/claim/front/detail/index.html    |  7 ++++++-
 modules/claim/front/detail/index.js      | 22 ++++++++++++++--------
 modules/claim/front/detail/index.spec.js |  8 +++++---
 modules/claim/front/detail/locale/es.yml |  3 ++-
 4 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/modules/claim/front/detail/index.html b/modules/claim/front/detail/index.html
index 9af8fd328..56dbc3c53 100644
--- a/modules/claim/front/detail/index.html
+++ b/modules/claim/front/detail/index.html
@@ -69,7 +69,7 @@
                         vn-tooltip="Remove sale"
                         ng-if ="$ctrl.isRewritable"
                         icon="delete"
-                        ng-click="$ctrl.deleteClaimedSale($index)"
+                        ng-click="$ctrl.showDeleteConfirm($index)"
                         tabindex="-1">
                     </vn-icon-button>
                 </vn-td>
@@ -165,3 +165,8 @@
         </div>
     </div>
 </vn-popover>
+<vn-confirm 
+    vn-id="confirm"
+    question="Delete sale from claim?"
+    on-response="$ctrl.deleteClaimedSale($response)">
+</vn-confirm>
\ No newline at end of file
diff --git a/modules/claim/front/detail/index.js b/modules/claim/front/detail/index.js
index d84090e52..8237241df 100644
--- a/modules/claim/front/detail/index.js
+++ b/modules/claim/front/detail/index.js
@@ -73,14 +73,20 @@ class Controller extends Section {
         });
     }
 
-    deleteClaimedSale(index) {
-        let sale = this.salesClaimed[index];
-        let query = `ClaimBeginnings/${sale.id}`;
-        this.$http.delete(query).then(() => {
-            this.vnApp.showSuccess(this.$translate.instant('Data saved!'));
-            this.$.model.remove(index);
-            this.calculateTotals();
-        });
+    showDeleteConfirm(index) {
+        this.sale = this.salesClaimed[index];
+        this.$.confirm.show();
+    }
+
+    deleteClaimedSale(response) {
+        if (response === 'accept') {
+            let query = `ClaimBeginnings/${this.sale.id}`;
+            this.$http.delete(query).then(() => {
+                this.vnApp.showSuccess(this.$translate.instant('Data saved!'));
+                this.$.model.remove(this.sale);
+                this.calculateTotals();
+            });
+        }
     }
 
     setClaimedQuantity(id, claimedQuantity) {
diff --git a/modules/claim/front/detail/index.spec.js b/modules/claim/front/detail/index.spec.js
index 5004ba7a1..520f40f39 100644
--- a/modules/claim/front/detail/index.spec.js
+++ b/modules/claim/front/detail/index.spec.js
@@ -71,14 +71,16 @@ describe('claim', () => {
             });
         });
 
-        describe('deleteClaimedSale(index)', () => {
+        describe('deleteClaimedSale()', () => {
             it('should make a delete and call refresh and showSuccess', () => {
+                controller.sale = {id: 1};
                 jest.spyOn(controller.$.model, 'remove');
+                jest.spyOn(controller.vnApp, 'showSuccess');
                 $httpBackend.expectDELETE(`ClaimBeginnings/1`).respond({});
-                controller.deleteClaimedSale(0);
+                controller.deleteClaimedSale('accept');
                 $httpBackend.flush();
 
-                expect(controller.$.model.remove).toHaveBeenCalledWith(0);
+                expect(controller.vnApp.showSuccess).toHaveBeenCalledWith('Data saved!');
             });
         });
 
diff --git a/modules/claim/front/detail/locale/es.yml b/modules/claim/front/detail/locale/es.yml
index 9bbfd7e86..53f9e9b1d 100644
--- a/modules/claim/front/detail/locale/es.yml
+++ b/modules/claim/front/detail/locale/es.yml
@@ -7,4 +7,5 @@ Claimable sales from ticket: Lineas reclamables del ticket
 Detail: Detalles
 Add sale item: Añadir artículo
 Insuficient permisos: Permisos insuficientes
-Total claimed price: Precio total reclamado
\ No newline at end of file
+Total claimed price: Precio total reclamado
+Delete sale from claim?: ¿Borrar la linea de la reclamación?
\ No newline at end of file