From 8a655a70037da2f18e2ec043b92a0bfe6dcb3f7d Mon Sep 17 00:00:00 2001
From: gerard <gerard@verdnatura.es>
Date: Tue, 3 Jul 2018 15:00:16 +0200
Subject: [PATCH] Bug #378 Refactorizar marcar como reservado para que no
 utilice el crud

---
 client/ticket/src/create/index.spec.js        | 41 +++++++++++++++++++
 client/ticket/src/sale/index.html             |  7 ++--
 client/ticket/src/sale/index.js               | 27 ++++--------
 .../loopback/common/methods/sale/crudSale.js  |  3 --
 .../loopback/common/methods/sale/reserve.js   | 32 +++++++++++++++
 services/loopback/common/models/sale.js       |  2 +-
 services/loopback/common/models/sale.json     |  2 +-
 7 files changed, 87 insertions(+), 27 deletions(-)
 create mode 100644 client/ticket/src/create/index.spec.js
 delete mode 100644 services/loopback/common/methods/sale/crudSale.js
 create mode 100644 services/loopback/common/methods/sale/reserve.js

diff --git a/client/ticket/src/create/index.spec.js b/client/ticket/src/create/index.spec.js
new file mode 100644
index 000000000..468e648eb
--- /dev/null
+++ b/client/ticket/src/create/index.spec.js
@@ -0,0 +1,41 @@
+import './index.js';
+
+describe('Ticket', () => {
+    describe('Component vnTicketCreate', () => {
+        let $componentController;
+        let $scope;
+        let controller;
+        let $state;
+
+        beforeEach(() => {
+            angular.mock.module('ticket');
+        });
+
+        beforeEach(angular.mock.inject((_$componentController_, $rootScope, _$state_) => {
+            $componentController = _$componentController_;
+
+            $scope = $rootScope.$new();
+            $scope.card = {createTicket: () => {}};
+            $state = _$state_;
+            $state.go = () => {};
+            controller = $componentController('vnTicketCreate', {$scope: $scope, $state: $state});
+        }));
+
+        describe('onSubmit()', () => {
+            it(`should call createTicket()`, () => {
+                spyOn(controller.$.card, 'createTicket');
+                controller.onSubmit();
+
+                expect(controller.$.card.createTicket).toHaveBeenCalledWith();
+            });
+
+            xit(`should call go()`, () => {
+                spyOn(controller.$state, 'go');
+                controller.onSubmit();
+
+                expect(controller.$state.go).toHaveBeenCalledWith();
+            });
+        });
+    });
+});
+
diff --git a/client/ticket/src/sale/index.html b/client/ticket/src/sale/index.html
index b6b0566b7..598e6cb67 100644
--- a/client/ticket/src/sale/index.html
+++ b/client/ticket/src/sale/index.html
@@ -59,10 +59,11 @@
                 </thead>
                 <tbody>
                     <tr ng-repeat="sale in index.model.instances track by sale.id">
-                       <td  ng-show="sale.disponible" ><vn-icon icon="icon-reserved"></vn-icon></td>
+                       <td><vn-icon ng-show="sale.reserved" icon="icon-reserved"></vn-icon></td>
                          <!-- <td>
-                            <vn-icon icon="warning"></vn-icon>
-                            <vn-icon icon="icon-reserved"></vn-icon>
+                            <vn-icon ng-show="sale.disponible" icon="warning"></vn-icon>
+                            <vn-icon ng-show="sale.disponible" icon="warning"></vn-icon>
+                            <vn-icon ng-show="sale.disponible" icon="icon-reserved"></vn-icon>
                         </td> -->
                         <td number>
                             <vn-check 
diff --git a/client/ticket/src/sale/index.js b/client/ticket/src/sale/index.js
index 25af6251f..fb274fc6e 100644
--- a/client/ticket/src/sale/index.js
+++ b/client/ticket/src/sale/index.js
@@ -302,13 +302,6 @@ class Controller extends FilterTicketList {
         }
     }
 
-/**
- * Mark sale as reserved
- */
-    markAsReserved() {
-        this.setReserved(true);
-    }
-
 /**
  * Unmark sale as reserved
  */
@@ -317,21 +310,17 @@ class Controller extends FilterTicketList {
     }
 
 /**
- * Mark/Unmark sale as reserved from selected lines
- * @param {Boolean} reserved reserved
+ * Mark sale as reserved
  */
+    markAsReserved() {
+        this.setReserved(true);
+    }
+
     setReserved(reserved) {
-        let data = {
-            delete: [],
-            create: [],
-            update: this.getCheckedLines()
-        };
+        let sales = this.getCheckedLines();
+        let params = {sales: sales, ticketFk: this.ticket.id, reserved: reserved};
 
-        data.update.forEach(line => {
-            line.reserved = reserved;
-        });
-
-        this.$http.post(`/ticket/api/Sales/crudSale`, data).then(() => {
+        this.$http.post(`/ticket/api/Sales/reserve`, params).then(() => {
             this.$.index.accept();
         });
     }
diff --git a/services/loopback/common/methods/sale/crudSale.js b/services/loopback/common/methods/sale/crudSale.js
deleted file mode 100644
index b33d70fc5..000000000
--- a/services/loopback/common/methods/sale/crudSale.js
+++ /dev/null
@@ -1,3 +0,0 @@
-module.exports = Self => {
-    Self.installCrudModel('crudSale');
-};
diff --git a/services/loopback/common/methods/sale/reserve.js b/services/loopback/common/methods/sale/reserve.js
new file mode 100644
index 000000000..1370058c4
--- /dev/null
+++ b/services/loopback/common/methods/sale/reserve.js
@@ -0,0 +1,32 @@
+
+module.exports = Self => {
+    Self.remoteMethod('reserve', {
+        description: 'Change the state of a ticket',
+        accessType: '',
+        accepts: [{
+            arg: 'params',
+            type: 'object',
+            required: true,
+            description: '[sales IDs], actualTicketFk, reserved',
+            http: {source: 'body'}
+        }],
+        returns: {
+            type: 'string',
+            root: true
+        },
+        http: {
+            path: `/reserve`,
+            verb: 'post'
+        }
+    });
+
+    Self.reserve = async params => {
+        let thisTicketIsEditable = await Self.app.models.Ticket.isEditable(params.actualTicketFk);
+        if (!thisTicketIsEditable)
+            throw new Error(`The sales of this ticket can't be modified`);
+
+        for (let i = 0; i < params.sales.length; i++) {
+            await Self.app.models.Sale.update({id: params.sales[i].id}, {reserved: params.reserved});
+        }
+    };
+};
diff --git a/services/loopback/common/models/sale.js b/services/loopback/common/models/sale.js
index 9bd300860..47feb07d8 100644
--- a/services/loopback/common/models/sale.js
+++ b/services/loopback/common/models/sale.js
@@ -2,8 +2,8 @@ module.exports = Self => {
     require('../methods/sale/filter')(Self);
     require('../methods/sale/saleComponentFilter')(Self);
     require('../methods/sale/priceDifference')(Self);
-    require('../methods/sale/crudSale')(Self);
     require('../methods/sale/moveToTicket')(Self);
+    require('../methods/sale/reserve')(Self);
     require('../methods/sale/moveToNewTicket')(Self);
     require('../methods/sale/removes')(Self);
     require('../methods/sale/updateDiscount')(Self);
diff --git a/services/loopback/common/models/sale.json b/services/loopback/common/models/sale.json
index cc2569b89..a0978040c 100644
--- a/services/loopback/common/models/sale.json
+++ b/services/loopback/common/models/sale.json
@@ -25,7 +25,7 @@
             "type": "Number"
         },
         "reserved": {
-            "type": "Number"
+            "type": "boolean"
         },
         "isPicked": {
             "type": "Number"