Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 5475-email_2fa

CHANGELOG.md

@@ -5,18 +5,34 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [2316.01] - 2023-05-04
+## [2320.01] - 2023-05-25
 
 ### Added
 -
 
 ### Changed
-- (Artículo -> Precio fijado) Modificado el buscador superior por uno lateral
+-
 
 ### Fixed
 -
 
 
+
+## [2318.01] - 2023-05-08
+
+### Added
+- (Usuarios -> Histórico) Nueva sección
+- (Roles -> Histórico) Nueva sección
+- (General -> Traducciones) Correo de bienvenida a clientes al portugués y al francés
+
+### Changed
+- (Artículo -> Precio fijado) Modificado el buscador superior por uno lateral
+
+### Fixed
+- (Ticket -> Boxing) Arreglado selección de horas
+
+
+
 ## [2314.01] - 2023-04-20
 
 ### Added

Jenkinsfile

@@ -52,6 +52,7 @@ pipeline {
             }}}
             environment {
                 NODE_ENV = ""
+                TZ = 'Europe/Madrid'
             }
             parallel {
                 stage('Frontend') {

back/locale/account/en.yml

@@ -0,0 +1,17 @@
+name: account
+columns:
+    id: id
+    name: name
+    roleFk: role
+    nickname: nickname
+    lang: lang
+    password: password
+    bcryptPassword: bcrypt password
+    active: active
+    email: email
+    emailVerified: email verified
+    created: created
+    updated: updated
+    image: image
+    hasGrant: has grant
+    userFk: user

back/locale/account/es.yml

@@ -0,0 +1,17 @@
+name: cuenta
+columns:
+    id: id
+    name: nombre
+    roleFk: rol
+    nickname: apodo
+    lang: idioma
+    password: contraseña
+    bcryptPassword: contraseña bcrypt
+    active: activo
+    email: email
+    emailVerified: email verificado
+    created: creado
+    updated: actualizado
+    image: imagen
+    hasGrant: tiene permiso
+    userFk: usuario

back/methods/collection/setSaleQuantity.js

@@ -40,8 +40,7 @@ module.exports = Self => {
         try {
             const sale = await models.Sale.findById(saleId, null, myOptions);
             const saleUpdated = await sale.updateAttributes({
-                originalQuantity: sale.quantity,
-                quantity: quantity
+                quantity
             }, myOptions);
 
             if (tx) await tx.commit();

back/methods/collection/spec/setSaleQuantity.spec.js

@@ -30,7 +30,7 @@ describe('setSaleQuantity()', () => {
             await models.Collection.setSaleQuantity(saleId, newQuantity, options);
             const updateSale = await models.Sale.findById(saleId, null, options);
 
-            expect(updateSale.originalQuantity).toEqual(originalSale.quantity);
+            expect(updateSale.quantity).not.toEqual(originalSale.quantity);
             expect(updateSale.quantity).toEqual(newQuantity);
 
             await tx.rollback();

back/methods/image/scrub.js

@@ -0,0 +1,130 @@
+const fs = require('fs-extra');
+const path = require('path');
+const UserError = require('vn-loopback/util/user-error');
+
+module.exports = Self => {
+    Self.remoteMethod('scrub', {
+        description: 'Deletes images without database reference',
+        accessType: 'WRITE',
+        accepts: [
+            {
+                arg: 'collection',
+                type: 'string',
+                description: 'The collection name',
+                required: true
+            }, {
+                arg: 'remove',
+                type: 'boolean',
+                description: 'Delete instead of move images to trash'
+            }, {
+                arg: 'limit',
+                type: 'integer',
+                description: 'Maximum number of images to clean'
+            }, {
+                arg: 'dryRun',
+                type: 'boolean',
+                description: 'Simulate actions'
+            }, {
+                arg: 'skipLock',
+                type: 'boolean',
+                description: 'Wether to skip exclusive lock'
+            }
+        ],
+        returns: {
+            type: 'integer',
+            root: true
+        },
+        http: {
+            path: `/scrub`,
+            verb: 'POST'
+        }
+    });
+
+    Self.scrub = async function(collection, remove, limit, dryRun, skipLock) {
+        const $ = Self.app.models;
+
+        const env = process.env.NODE_ENV;
+        dryRun = dryRun || (env && env !== 'production');
+
+        const instance = await $.ImageCollection.findOne({
+            fields: ['id'],
+            where: {name: collection}
+        });
+        if (!instance)
+            throw new UserError('Collection does not exist');
+
+        const container = await $.ImageContainer.container(collection);
+        const rootPath = container.client.root;
+
+        let tx;
+        let opts;
+        const lockName = 'salix.Image.scrub';
+
+        if (!skipLock) {
+            tx = await Self.beginTransaction({timeout: null});
+            opts = {transaction: tx};
+
+            const [row] = await Self.rawSql(
+                `SELECT GET_LOCK(?, 10) hasLock`, [lockName], opts);
+            if (!row.hasLock)
+                throw new UserError('Cannot obtain exclusive lock');
+        }
+
+        try {
+            const now = Date.vnNew().toJSON();
+            const scrubDir = path.join(rootPath, '.scrub', now);
+
+            const collectionDir = path.join(rootPath, collection);
+            const sizes = await fs.readdir(collectionDir);
+            let cleanCount = 0;
+
+            mainLoop: for (const size of sizes) {
+                const sizeDir = path.join(collectionDir, size);
+                const scrubSizeDir = path.join(scrubDir, collection, size);
+                const images = await fs.readdir(sizeDir);
+                for (const image of images) {
+                    const imageName = path.parse(image).name;
+                    const count = await Self.count({
+                        collectionFk: collection,
+                        name: imageName
+                    }, opts);
+                    const exists = count > 0;
+                    let scrubDirCreated = false;
+                    if (!exists) {
+                        const srcFile = path.join(sizeDir, image);
+                        if (remove !== true) {
+                            if (!scrubDirCreated) {
+                                if (!dryRun)
+                                    await fs.mkdir(scrubSizeDir, {recursive: true});
+                                scrubDirCreated = true;
+                            }
+                            const dstFile = path.join(scrubSizeDir, image);
+                            if (!dryRun) await fs.rename(srcFile, dstFile);
+                        } else {
+                            try {
+                                if (!dryRun) await fs.unlink(srcFile);
+                            } catch (err) {
+                                console.error(err.message);
+                            }
+                        }
+
+                        cleanCount++;
+                        if (limit && cleanCount == limit)
+                            break mainLoop;
+                    }
+                }
+            }
+
+            return cleanCount;
+        } finally {
+            if (!skipLock) {
+                try {
+                    await Self.rawSql(`DO RELEASE_LOCK(?)`, [lockName], opts);
+                    await tx.rollback();
+                } catch (err) {
+                    console.error(err.message);
+                }
+            }
+        }
+    };
+};

back/methods/image/upload.js

@@ -12,13 +12,13 @@ module.exports = Self => {
                 type: 'Number',
                 description: 'The entity id',
                 required: true
-            },
-            {
+            }, {
                 arg: 'collection',
                 type: 'string',
                 description: 'The collection name',
                 required: true
-            }],
+            }
+        ],
         returns: {
             type: 'Object',
             root: true

back/models/image.js

@@ -5,6 +5,7 @@ const gm = require('gm');
 module.exports = Self => {
     require('../methods/image/download')(Self);
     require('../methods/image/upload')(Self);
+    require('../methods/image/scrub')(Self);
 
     Self.resize = async function({collectionName, srcFile, fileName, entityId}) {
         const models = Self.app.models;
@@ -29,13 +30,14 @@ module.exports = Self => {
         );
 
         // Insert image row
+        const imageName = path.parse(fileName).name;
         await models.Image.upsertWithWhere(
             {
-                name: fileName,
+                name: imageName,
                 collectionFk: collectionName
             },
             {
-                name: fileName,
+                name: imageName,
                 collectionFk: collectionName,
                 updated: Date.vnNow() / 1000,
             }
@@ -49,7 +51,7 @@ module.exports = Self => {
         if (entity) {
             await entity.updateAttribute(
                 collection.property,
-                fileName
+                imageName
             );
         }
 

back/tests.js

@@ -53,7 +53,7 @@ async function test() {
         const JunitReporter = require('jasmine-reporters');
         jasmine.addReporter(new JunitReporter.JUnitXmlReporter());
 
-        jasmine.jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;
+        jasmine.jasmine.DEFAULT_TIMEOUT_INTERVAL = 90000;
         jasmine.exitOnCompletion = true;
     }
 

db/.archive/225201/00-invoiceOut_new.sql

@@ -8,7 +8,7 @@ CREATE DEFINER=`root`@`localhost` PROCEDURE `vn`.`invoiceOut_new`(
 BEGIN
 /**
  * Creación de facturas emitidas.
- * requiere previamente tabla ticketToInvoice(id).
+ * requiere previamente tabla tmp.ticketToInvoice(id).
  *
  * @param vSerial serie a la cual se hace la factura
  * @param vInvoiceDate fecha de la factura
@@ -36,13 +36,13 @@ BEGIN
 
 	SELECT t.clientFk, t.companyFk
 			INTO vClient, vCompany
-		FROM ticketToInvoice tt
+		FROM tmp.ticketToInvoice tt
 			JOIN ticket t ON t.id = tt.id
 		LIMIT 1;
 
-	-- Eliminem de ticketToInvoice els tickets que no han de ser facturats
+	-- Eliminem de tmp.ticketToInvoice els tickets que no han de ser facturats
 	DELETE ti.*
-		FROM ticketToInvoice ti
+		FROM tmp.ticketToInvoice ti
 			JOIN ticket t ON t.id = ti.id
 			JOIN sale s ON s.ticketFk = t.id
 			JOIN item i ON i.id = s.itemFk
@@ -57,7 +57,7 @@ BEGIN
 
 	SELECT SUM(s.quantity * s.price * (100 - s.discount)/100), ts.id
 			INTO vIsAnySaleToInvoice, vIsAnyServiceToInvoice
-		FROM ticketToInvoice t
+		FROM tmp.ticketToInvoice t
 			LEFT JOIN sale s ON s.ticketFk = t.id
 			LEFT JOIN ticketService ts ON ts.ticketFk = t.id;
 
@@ -100,13 +100,13 @@ BEGIN
 			WHERE id = vNewInvoiceId;
 
 		UPDATE ticket t
-				JOIN ticketToInvoice ti ON ti.id = t.id
+				JOIN tmp.ticketToInvoice ti ON ti.id = t.id
 			SET t.refFk = vNewRef;
 
 		DROP TEMPORARY TABLE IF EXISTS tmp.updateInter;
 		CREATE TEMPORARY TABLE tmp.updateInter ENGINE = MEMORY
 			SELECT s.id,ti.id ticket_id,vWorker Id_Trabajador
-				FROM ticketToInvoice ti
+				FROM tmp.ticketToInvoice ti
 					LEFT JOIN ticketState ts ON ti.id = ts.ticket
 					JOIN state s
 				WHERE IFNULL(ts.alertLevel,0) < 3 and s.`code` = getAlert3State(ti.id);
@@ -116,7 +116,7 @@ BEGIN
 
 		INSERT INTO ticketLog (action, userFk, originFk, description)
 			SELECT 'UPDATE', account.myUser_getId(), ti.id, CONCAT('Crea factura ', vNewRef)
-				FROM ticketToInvoice ti;
+				FROM tmp.ticketToInvoice ti;
 
 		CALL invoiceExpenceMake(vNewInvoiceId);
 		CALL invoiceTaxMake(vNewInvoiceId,vTaxArea);
@@ -159,7 +159,7 @@ BEGIN
 				(KEY (ticketFk))
 				ENGINE = MEMORY
 				SELECT id ticketFk
-					FROM ticketToInvoice;
+					FROM tmp.ticketToInvoice;
 
 			CALL `ticket_getTax`('NATIONAL');
 
@@ -220,6 +220,6 @@ BEGIN
 
 	END IF;
 
-	DROP TEMPORARY TABLE `ticketToInvoice`;
+	DROP TEMPORARY TABLE `tmp`.`ticketToInvoice`;
 END$$
 DELIMITER ;

db/changes/230601/00-acl_receiptEmail.sql

@@ -0,0 +1,3 @@
+INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
+    VALUES
+        ('Receipt', 'receiptEmail', '*', 'ALLOW', 'ROLE', 'salesAssistant');

db/changes/231001/02-invoiceOut_new.sql

@@ -10,7 +10,7 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`invoiceOut_new`(
 BEGIN
 /**
  * Creación de facturas emitidas.
- * requiere previamente tabla ticketToInvoice(id).
+ * requiere previamente tabla tmp.ticketToInvoice(id).
  *
  * @param vSerial serie a la cual se hace la factura
  * @param vInvoiceDate fecha de la factura
@@ -49,7 +49,7 @@ BEGIN
 				vCompanyFk,
 				vMaxShipped,
 				vIsCorrectInvoiceDate
-		FROM ticketToInvoice tt
+		FROM tmp.ticketToInvoice tt
 			JOIN ticket t ON t.id = tt.id;
 
 	IF(vMaxShipped > vInvoiceDate) THEN
@@ -60,9 +60,9 @@ BEGIN
 		CALL util.throw('Exists an invoice with a previous date');
 	END IF;
 
-	-- Eliminem de ticketToInvoice els tickets que no han de ser facturats
+	-- Eliminem de tmp.ticketToInvoice els tickets que no han de ser facturats
 	DELETE ti.*
-		FROM ticketToInvoice ti
+		FROM tmp.ticketToInvoice ti
 			JOIN ticket t ON t.id = ti.id
 			JOIN sale s ON s.ticketFk = t.id
 			JOIN item i ON i.id = s.itemFk
@@ -77,11 +77,11 @@ BEGIN
 
 	SELECT SUM(s.quantity * s.price * (100 - s.discount)/100) <> 0
 		INTO vIsAnySaleToInvoice
-		FROM ticketToInvoice t
+		FROM tmp.ticketToInvoice t
 			JOIN sale s ON s.ticketFk = t.id;
 
 	SELECT COUNT(*) > 0 INTO vIsAnyServiceToInvoice
-		FROM ticketToInvoice t
+		FROM tmp.ticketToInvoice t
 			JOIN ticketService ts ON ts.ticketFk = t.id;
 
 	IF (vIsAnySaleToInvoice OR vIsAnyServiceToInvoice)
@@ -121,13 +121,13 @@ BEGIN
 			WHERE id = vNewInvoiceId;
 
 		UPDATE ticket t
-				JOIN ticketToInvoice ti ON ti.id = t.id
+				JOIN tmp.ticketToInvoice ti ON ti.id = t.id
 			SET t.refFk = vNewRef;
 
 		DROP TEMPORARY TABLE IF EXISTS tmp.updateInter;
 		CREATE TEMPORARY TABLE tmp.updateInter ENGINE = MEMORY
 			SELECT s.id,ti.id ticket_id,vWorker Id_Trabajador
-				FROM ticketToInvoice ti
+				FROM tmp.ticketToInvoice ti
 					LEFT JOIN ticketState ts ON ti.id = ts.ticket
 					JOIN state s
 				WHERE IFNULL(ts.alertLevel,0) < 3 and s.`code` = getAlert3State(ti.id);
@@ -137,7 +137,7 @@ BEGIN
 
 		INSERT INTO ticketLog (action, userFk, originFk, description)
 			SELECT 'UPDATE', account.myUser_getId(), ti.id, CONCAT('Crea factura ', vNewRef)
-				FROM ticketToInvoice ti;
+				FROM tmp.ticketToInvoice ti;
 
 		CALL invoiceExpenceMake(vNewInvoiceId);
 		CALL invoiceTaxMake(vNewInvoiceId,vTaxArea);
@@ -175,7 +175,7 @@ BEGIN
 				(KEY (ticketFk))
 				ENGINE = MEMORY
 				SELECT id ticketFk
-					FROM ticketToInvoice;
+					FROM tmp.ticketToInvoice;
 
 			CALL `ticket_getTax`('NATIONAL');
 
@@ -253,6 +253,6 @@ BEGIN
 			DROP TEMPORARY TABLE tmp.ticketServiceTax;
 		END IF;
 	END IF;
-	DROP TEMPORARY TABLE `ticketToInvoice`;
+	DROP TEMPORARY TABLE tmp.`ticketToInvoice`;
 END$$
 DELIMITER ;

db/changes/231205/00-printQueueArgs.sql

@@ -0,0 +1 @@
+ALTER TABLE `vn`.`printQueueArgs` MODIFY COLUMN value varchar(255) CHARACTER SET utf8mb3 COLLATE utf8mb3_unicode_ci NULL;

db/changes/231401/00-deviceProduction.sql

@@ -0,0 +1,5 @@
+DROP TRIGGER `vn`.`deviceProduction_afterInsert`;
+DROP TRIGGER `vn`.`deviceProduction_afterUpdate`;
+
+DROP TRIGGER `vn`.`deviceProductionUser_afterDelete`;
+

db/changes/231401/00-hotfixDelivery.sql

@@ -1,12 +1,5 @@
 DROP TABLE IF EXISTS `vn`.`dmsRecover`;
-
-ALTER TABLE `vn`.`delivery` DROP COLUMN addressFk;
-ALTER TABLE `vn`.`delivery` DROP CONSTRAINT delivery_ticketFk_FK;
-ALTER TABLE `vn`.`delivery` DROP COLUMN ticketFk;
-ALTER TABLE `vn`.`delivery` ADD ticketFk INT DEFAULT NULL;
-ALTER TABLE `vn`.`delivery` ADD CONSTRAINT delivery_ticketFk_FK FOREIGN KEY (`ticketFk`) REFERENCES `vn`.`ticket`(`id`);
-
-DROP PROCEDURE IF EXISTS vn.route_getTickets;
+DROP PROCEDURE IF EXISTS `vn`.`route_getTickets`;
 
 DELIMITER $$
 $$
@@ -17,14 +10,14 @@ BEGIN
  * de sus tickets.
  *
  * @param vRouteFk
- *
  * @select Información de los tickets
  */
-
-    SELECT
-            t.id Id,
+SELECT	*
+	FROM (
+		SELECT t.id Id,
 				t.clientFk Client,
 				a.id Address,
+				a.nickname ClientName,
 				t.packages Packages,
 				a.street AddressName,
 				a.postalCode PostalCode,
@@ -37,34 +30,48 @@ BEGIN
 				d.longitude Longitude,
 				d.latitude Latitude,
 				wm.mediaValue SalePersonPhone,
-            tob.Note Note,
-            t.isSigned Signed
+				tob.description Note,
+				t.isSigned Signed,
+				t.priority
 			FROM ticket t
 				JOIN client c ON t.clientFk = c.id
 				JOIN address a ON t.addressFk = a.id
-            LEFT JOIN delivery d ON t.id = d.ticketFk
+				LEFT JOIN delivery d ON d.ticketFk = t.id
 				LEFT JOIN workerMedia wm ON wm.workerFk = c.salesPersonFk
-            LEFT JOIN
-                (SELECT tob.description Note, t.id
+				LEFT JOIN(
+					SELECT tob.description, t.id
 						FROM ticketObservation tob
 							JOIN ticket t ON tob.ticketFk = t.id
 							JOIN observationType ot ON ot.id = tob.observationTypeFk
 						WHERE t.routeFk = vRouteFk
 							AND ot.code = 'delivery'
 				)tob ON tob.id = t.id
-            LEFT JOIN
-                (SELECT sub.ticketFk,
-                    CONCAT('(', GROUP_CONCAT(DISTINCT sub.itemPackingTypeFk ORDER BY sub.items DESC SEPARATOR ','), ') ') itemPackingTypeFk
-                    FROM (SELECT s.ticketFk , i.itemPackingTypeFk, COUNT(*) items
+				LEFT JOIN(
+					SELECT sub.ticketFk,
+							CONCAT('(',
+								GROUP_CONCAT(DISTINCT sub.itemPackingTypeFk
+									ORDER BY sub.items DESC SEPARATOR ','),
+								') ') itemPackingTypeFk
+						FROM (
+							SELECT s.ticketFk, i.itemPackingTypeFk, COUNT(*) items
 								FROM ticket t
 									JOIN sale s ON s.ticketFk = t.id
 									JOIN item i ON i.id = s.itemFk
 								WHERE t.routeFk = vRouteFk
-                        GROUP BY t.id,i.itemPackingTypeFk)sub
+								GROUP BY t.id, i.itemPackingTypeFk
+						)sub
 						GROUP BY sub.ticketFk
 				)sub2 ON sub2.ticketFk = t.id
 			WHERE t.routeFk = vRouteFk
-        GROUP BY t.id
-        ORDER BY t.priority;
+			ORDER BY d.id DESC
+			LIMIT 10000000000000000000
+	)sub3
+	GROUP BY sub3.id
+	ORDER BY sub3.priority;
 END$$
 DELIMITER ;
+
+ALTER TABLE `vn`.`delivery` DROP FOREIGN KEY delivery_ticketFk_FK;
+ALTER TABLE `vn`.`delivery` DROP COLUMN ticketFk;
+ALTER TABLE `vn`.`delivery` ADD ticketFk INT DEFAULT NULL;
+ALTER TABLE `vn`.`delivery` ADD CONSTRAINT delivery_ticketFk_FK FOREIGN KEY (`ticketFk`) REFERENCES `vn`.`ticket`(`id`);

db/changes/231402/00-negativeBases.sql

@@ -0,0 +1,3 @@
+UPDATE `salix`.`ACL`
+    SET model = 'InvoiceOut'
+    WHERE property IN ('negativeBases', 'negativeBasesCsv');

db/changes/231601/00-User.sql

@@ -1,21 +0,0 @@
-create or replace definer = root@localhost view User as
-select `account`.`user`.`id`                AS `id`,
-       `account`.`user`.`realm`             AS `realm`,
-       `account`.`user`.`name`              AS `name`,
-       `account`.`user`.`nickname`          AS `nickname`,
-       `account`.`user`.`bcryptPassword`    AS `password`,
-       `account`.`user`.`role`              AS `role`,
-       `account`.`user`.`active`            AS `active`,
-       `account`.`user`.`email`             AS `email`,
-       `account`.`user`.`emailVerified`     AS `emailVerified`,
-       `account`.`user`.`verificationToken` AS `verificationToken`,
-       `account`.`user`.`lang`              AS `lang`,
-       `account`.`user`.`lastPassChange`    AS `lastPassChange`,
-       `account`.`user`.`created`           AS `created`,
-       `account`.`user`.`updated`           AS `updated`,
-       `account`.`user`.`image`             AS `image`,
-       `account`.`user`.`recoverPass`       AS `recoverPass`,
-       `account`.`user`.`sync`              AS `sync`,
-       `account`.`user`.`hasGrant`          AS `hasGrant`
-from `account`.`user`;
-

db/changes/231601/00-authCode.sql

@@ -1,27 +0,0 @@
-create table `salix`.`authCode`
-(
-    userFk int UNSIGNED not null,
-    code   int          not null,
-    expires   TIMESTAMP  not null,
-    constraint authCode_pk
-        primary key (userFk),
-    constraint authCode_unique
-        unique (code),
-    constraint authCode_user_id_fk
-        foreign key (userFk) references `account`.`user` (id)
-            on update cascade on delete cascade
-);
-
-create table `salix`.`userAccess`
-(
-    userFk int UNSIGNED not null,
-    ip     VARCHAR(25)  not null,
-    agent  text         null,
-    platform  VARCHAR(25) null,
-    browser  VARCHAR(25) null,
-    constraint userAccess_pk
-        primary key (userFk),
-    constraint userAccess_user_null_fk
-        foreign key (userFk) references `account`.`user` (id)
-)
-    auto_increment = 0;

db/changes/231601/00-department.sql

@@ -1,24 +0,0 @@
-alter table `vn`.`department`
-    add `twoFactor` ENUM ('email') null comment 'Default user two-factor auth type';
-
-drop trigger `vn`.`department_afterUpdate`;
-
-DELIMITER $$
-$$
-create definer = root@localhost trigger department_afterUpdate
-    after update
-    on department
-    for each row
-BEGIN
-	IF !(OLD.parentFk <=> NEW.parentFk) THEN
-		UPDATE vn.department_recalc SET isChanged = TRUE;
-	END IF;
-
-	IF !(OLD.twoFactor <=> NEW.twoFactor) THEN
-		UPDATE account.user u
-                JOIN vn.workerDepartment wd ON wd.workerFk = u.id
-            SET u.twoFactor = NEW.twoFactor
-	    WHERE wd.departmentFk = NEW.id;
-	END IF;
-END;$$
-DELIMITER ;

db/changes/231801/00-aclClientInforma.sql

@@ -0,0 +1,3 @@
+INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
+VALUES ('ClientInforma', '*', 'READ', 'ALLOW', 'ROLE', 'employee'),
+    ('ClientInforma', '*', 'WRITE', 'ALLOW', 'ROLE', 'financial');

db/changes/231801/00-clientInforma.sql

@@ -0,0 +1,16 @@
+ALTER TABLE `vn`.`client` ADD rating INT UNSIGNED DEFAULT NULL NULL COMMENT 'información proporcionada por Informa';
+ALTER TABLE `vn`.`client` ADD recommendedCredit INT UNSIGNED DEFAULT NULL NULL COMMENT 'información proporcionada por Informa';
+
+CREATE TABLE `vn`.`clientInforma` (
+   `id` int(11) unsigned NOT NULL AUTO_INCREMENT,
+   `clientFk` int(11) NOT NULL,
+   `rating` int(10) unsigned DEFAULT NULL,
+   `recommendedCredit` int(10) unsigned DEFAULT NULL,
+   `workerFk` int(10) unsigned NOT NULL,
+   `created` timestamp NOT NULL DEFAULT current_timestamp(),
+   PRIMARY KEY (`id`),
+   KEY `informaWorkers_fk_idx` (`workerFk`),
+   KEY `informaClientFk` (`clientFk`),
+   CONSTRAINT `informa_ClienteFk` FOREIGN KEY (`clientFk`) REFERENCES `client` (`id`) ON DELETE CASCADE ON UPDATE CASCADE,
+   CONSTRAINT `informa_workers_fk` FOREIGN KEY (`workerFk`) REFERENCES `worker` (`id`) ON DELETE RESTRICT ON UPDATE CASCADE
+) ENGINE=InnoDB CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci COMMENT='información proporcionada por Informa, se actualiza desde el hook de client (salix)';

db/changes/231801/00-client_setRatingAcl.sql

@@ -0,0 +1,64 @@
+DELETE FROM `salix`.`ACL` WHERE id=7;
+
+INSERT INTO `salix`.`ACL` (model, property, accessType, permission, principalType, principalId)
+    VALUES
+        ('Client', 'setRating', 'WRITE', 'ALLOW', 'ROLE', 'financial');
+
+INSERT INTO `salix`.`ACL` (model, property, accessType, permission, principalType, principalId)
+	VALUES
+        ('Client', '*', 'READ', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'addressesPropagateRe', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'canBeInvoiced', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'canCreateTicket', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'consumption', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'createAddress', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'createWithUser', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'extendedListFilter', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'getAverageInvoiced', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'getCard', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'getDebt', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'getMana', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'transactions', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'hasCustomerRole', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'isValidClient', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'lastActiveTickets', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'sendSms', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'setPassword', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'summary', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'updateAddress', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'updateFiscalData', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'updateUser', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'uploadFile', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'campaignMetricsPdf', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'campaignMetricsEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'clientWelcomeHtml', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'clientWelcomeEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'printerSetupHtml', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'printerSetupEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'sepaCoreEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'letterDebtorPdf', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'letterDebtorStHtml', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'letterDebtorStEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'letterDebtorNdHtml', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'letterDebtorNdEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'clientDebtStatementPdf', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'clientDebtStatementHtml', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'clientDebtStatementEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'creditRequestPdf', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'creditRequestHtml', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'creditRequestEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'incotermsAuthorizationPdf', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'incotermsAuthorizationHtml', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'incotermsAuthorizationEmail', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'consumptionSendQueued', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'filter', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'getClientOrSupplierReference', '*', 'ALLOW', 'ROLE', 'employee'),
+        ('Client', 'upsert', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'create', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'replaceById', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'updateAttributes', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'updateAttributes', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'deleteById', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'replaceOrCreate', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'updateAll', '*', 'ALLOW', 'ROLE', 'employee'),
+		('Client', 'upsertWithWhere', '*', 'ALLOW', 'ROLE', 'employee');

db/changes/231801/00-deleteProcs_refund.sql

@@ -0,0 +1,2 @@
+DROP PROCEDURE `vn`.`refund`;
+DROP PROCEDURE `vn`.`ticket_doRefund`;

db/changes/231801/00-kkearEntryNotes.sql

@@ -0,0 +1 @@
+ALTER TABLE `vn`.`entry` DROP COLUMN `notes`;

db/changes/231801/00-newCompanyI18n.sql

@@ -0,0 +1,9 @@
+-- vn.companyI18n definition
+CREATE TABLE `vn`.`companyI18n` (
+  `companyFk` smallint(5) unsigned NOT NULL,
+  `lang` char(2) CHARACTER SET utf8mb3 NOT NULL,
+  `footnotes` longtext COLLATE utf8mb3_unicode_ci DEFAULT NULL,
+  PRIMARY KEY (`companyFk`,`lang`),
+  CONSTRAINT `companyI18n_FK` FOREIGN KEY (`companyFk`) REFERENCES `company` (`id`) ON UPDATE CASCADE
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci;
+

db/changes/231801/00-newTableWeb.sql

@@ -0,0 +1 @@
+ALTER TABLE `vn`.`company` ADD `web` varchar(100) NULL;

db/changes/231801/00-saleTracking.sql

@@ -0,0 +1,5 @@
+DROP PROCEDURE IF EXISTS `vn`.`sale_setQuantity`;
+DROP PROCEDURE IF EXISTS `vn`.`collection_updateSale`;
+DROP PROCEDURE IF EXISTS `vn`.`replaceMovimientosMark`;
+DROP PROCEDURE IF EXISTS `vn`.`saleTracking_Replace`;
+DROP PROCEDURE IF EXISTS `vn`.`sale_updateOriginalQuantity`;

db/changes/231801/00-updateIsVies.sql

@@ -0,0 +1,5 @@
+    UPDATE `vn`.`supplier` s
+            JOIN `vn`.`country` c ON c.id = s.countryFk
+        SET s.nif = MID(REPLACE(s.nif, ' ', ''), 3, LENGTH(REPLACE(s.nif, ' ', '')) - 1)
+        WHERE s.isVies = TRUE
+            AND c.code = LEFT(REPLACE(s.nif, ' ', ''), 2);

db/changes/231801/00-updateisViesClient.sql

@@ -0,0 +1,5 @@
+UPDATE IGNORE `vn`.`client` c
+        JOIN `vn`.`country` co ON co.id = c.countryFk
+    SET c.fi = MID(REPLACE(c.fi, ' ', ''), 3, LENGTH(REPLACE(c.fi, ' ', '')) - 1)
+    WHERE c.isVies = TRUE
+        AND co.code = LEFT(REPLACE(c.fi, ' ', ''), 2);

db/dump/fixtures.sql

@@ -173,10 +173,6 @@ INSERT INTO `vn`.`sector`(`id`, `description`, `warehouseFk`, `isPreviousPrepare
         (1, 'First sector',     1, 1, 'FIRST'),
         (2, 'Second sector',    2, 0, 'SECOND');
 
-INSERT INTO `vn`.`operator` (`workerFk`, `numberOfWagons`, `trainFk`, `itemPackingTypeFk`, `warehouseFk`, `sectorFk`, `labelerFk`)
- VALUES ('1106', '1', '1', 'H', '1', '1', '1'),
-		('1107', '1', '1', 'V', '1', '2', '1');
-
 INSERT INTO `vn`.`printer` (`id`, `name`, `path`, `isLabeler`, `sectorFk`, `ipAddress`)
     VALUES
         (1, 'printer1', 'path1', 0, 1   , NULL),
@@ -550,7 +546,8 @@ INSERT INTO `vn`.`supplier`(`id`, `name`, `nickname`,`account`,`countryFk`,`nif`
     VALUES
         (1,   'Plants SL',             'Plants nick',   4100000001, 1, '06089160W', 0, util.VN_CURDATE(), 1, 'supplier address 1', 'PONTEVEDRA', 1, 15214, 1, 1, 15, 4,  1, 1, 18, 'flowerPlants',  1, '400664487V'),
         (2,   'Farmer King',           'The farmer',    4000020002, 1, '87945234L', 0, util.VN_CURDATE(), 1, 'supplier address 2', 'GOTHAM',      2, 43022, 1, 2, 10, 93, 2, 8, 18, 'animals',       1, '400664487V'),
-        (442, 'Verdnatura Levante SL', 'Verdnatura',    5115000442, 1, '06815934E', 0, util.VN_CURDATE(), 1, 'supplier address 3', 'GOTHAM',      1, 43022, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V');
+        (442, 'Verdnatura Levante SL', 'Verdnatura',    5115000442, 1, '06815934E', 0, util.VN_CURDATE(), 1, 'supplier address 3', 'GOTHAM',      1, 43022, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V'),
+        (1381, 'Ornamentales',         'Ornamentales',  7185000440, 1, '03815934E', 0, util.VN_CURDATE(), 1, 'supplier address 4', 'GOTHAM',      1, 43022, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V');
 
 INSERT INTO `vn`.`supplierContact`(`id`, `supplierFk`, `phone`, `mobile`, `email`, `observation`, `name`)
     VALUES
@@ -1200,6 +1197,11 @@ INSERT INTO `vn`.`train`(`id`, `name`)
         (1, 'Train1'),
         (2, 'Train2');
 
+INSERT INTO `vn`.`operator` (`workerFk`, `numberOfWagons`, `trainFk`, `itemPackingTypeFk`, `warehouseFk`, `sectorFk`, `labelerFk`)
+    VALUES
+        ('1106', '1', '1', 'H', '1', '1', '1'),
+		('1107', '1', '1', 'V', '1', '1', '1');
+
 INSERT INTO `vn`.`collection`(`id`, `workerFk`, `stateFk`, `created`, `trainFk`)
     VALUES
         (1, 1106, 5, DATE_ADD(util.VN_CURDATE(),INTERVAL +1 DAY), 1),
@@ -1407,16 +1409,16 @@ INSERT INTO `vn`.`travel`(`id`,`shipped`, `landed`, `warehouseInFk`, `warehouseO
         (7, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 5, 4, 1, 50.00,  500,   'seventh travel',   2, 1),
         (8, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 5, 1, 1, 50.00,  500,   'eight travel',     1, 2);
 
-INSERT INTO `vn`.`entry`(`id`, `supplierFk`, `created`, `travelFk`, `isConfirmed`, `companyFk`, `invoiceNumber`, `reference`, `isExcludedFromAvailable`, `isRaid`, `notes`, `evaNotes`)
+INSERT INTO `vn`.`entry`(`id`, `supplierFk`, `created`, `travelFk`, `isConfirmed`, `companyFk`, `invoiceNumber`, `reference`, `isExcludedFromAvailable`, `isRaid`, `evaNotes`)
     VALUES
-        (1, 1, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1, 1, 442, 'IN2001', 'Movement 1', 0, 0, '',    ''),
-        (2, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 2, 0, 442, 'IN2002', 'Movement 2', 0, 0, 'this is the note two',    'observation two'),
-        (3, 1, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 3, 0, 442, 'IN2003', 'Movement 3', 0, 0, 'this is the note three',  'observation three'),
-        (4, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 2, 0, 69,  'IN2004', 'Movement 4', 0, 0, 'this is the note four',   'observation four'),
-        (5, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 5, 0, 442, 'IN2005', 'Movement 5', 0, 0, 'this is the note five',   'observation five'),
-        (6, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 6, 0, 442, 'IN2006', 'Movement 6', 0, 0, 'this is the note six',    'observation six'),
-        (7, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 7, 0, 442, 'IN2007', 'Movement 7', 0, 0, 'this is the note seven',  'observation seven'),
-        (8, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 7, 0, 442, 'IN2008', 'Movement 8', 1, 1, '',  '');
+        (1, 1, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 1, 1, 442, 'IN2001', 'Movement 1', 0, 0,    ''),
+        (2, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 2, 0, 442, 'IN2002', 'Movement 2', 0, 0,    'observation two'),
+        (3, 1, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 3, 0, 442, 'IN2003', 'Movement 3', 0, 0,  'observation three'),
+        (4, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 2, 0, 69,  'IN2004', 'Movement 4', 0, 0,   'observation four'),
+        (5, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 5, 0, 442, 'IN2005', 'Movement 5', 0, 0,   'observation five'),
+        (6, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 6, 0, 442, 'IN2006', 'Movement 6', 0, 0,    'observation six'),
+        (7, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 7, 0, 442, 'IN2007', 'Movement 7', 0, 0,  'observation seven'),
+        (8, 2, DATE_ADD(util.VN_CURDATE(), INTERVAL -1 MONTH), 7, 0, 442, 'IN2008', 'Movement 8', 1, 1,  '');
 
 INSERT INTO `bs`.`waste`(`buyer`, `year`, `week`, `family`, `itemFk`, `itemTypeFk`, `saleTotal`, `saleWaste`, `rate`)
     VALUES
@@ -2788,7 +2790,7 @@ INSERT INTO `vn`.`profileType` (`id`, `name`)
 
 INSERT INTO `salix`.`url` (`appName`, `environment`, `url`)
     VALUES
-        ('lilium', 'dev', 'http://localhost:8080/#/'),
+        ('lilium', 'dev', 'http://localhost:9000/#/'),
         ('salix', 'dev', 'http://localhost:5000/#!/');
 
 INSERT INTO `vn`.`report` (`id`, `name`, `paperSizeFk`, `method`)

db/dump/structure.sql

@@ -42776,7 +42776,7 @@ CREATE DEFINER=`root`@`localhost` FUNCTION `hasAnyNegativeBase`() RETURNS tinyin
 BEGIN
 
 /*	Calcula si existe alguna base imponible negativa
-*	Requiere la tabla temporal vn.ticketToInvoice(id)
+*	Requiere la tabla temporal tmp.ticketToInvoice(id)
 *
 *	returns BOOLEAN
 */
@@ -42787,7 +42787,7 @@ BEGIN
 		(KEY (ticketFk))
 		ENGINE = MEMORY
 		SELECT id ticketFk
-			FROM ticketToInvoice;
+			FROM tmp.ticketToInvoice;
 
 	CALL ticket_getTax(NULL);
 
@@ -55223,7 +55223,7 @@ DELIMITER ;;
 CREATE DEFINER=`root`@`localhost` PROCEDURE `invoiceExpenceMake`(IN vInvoice INT)
 BEGIN
 /* Inserta las partidas de gasto correspondientes a la factura
- * REQUIERE tabla ticketToInvoice
+ * REQUIERE tabla tmp.ticketToInvoice
  * @param vInvoice Numero de factura
  */
 	DELETE FROM invoiceOutExpence
@@ -55233,7 +55233,7 @@ BEGIN
 		SELECT vInvoice,
 			   expenceFk,
 			   SUM(ROUND(quantity * price * (100 - discount)/100,2)) amount
-			FROM ticketToInvoice t
+			FROM tmp.ticketToInvoice t
 				JOIN sale s ON s.ticketFk = t.id
 				JOIN item i ON i.id = s.itemFk
 			GROUP BY i.expenceFk
@@ -55243,7 +55243,7 @@ BEGIN
 		SELECT vInvoice,
 			   tst.expenceFk,
 			   SUM(ROUND(ts.quantity * ts.price ,2)) amount
-			FROM ticketToInvoice t
+			FROM tmp.ticketToInvoice t
 				JOIN ticketService ts ON ts.ticketFk = t.id
                 JOIN ticketServiceType tst ON tst.id = ts.ticketServiceTypeFk
             HAVING amount != 0;
@@ -55270,9 +55270,9 @@ BEGIN
 
 	SET vMaxTicketDate = vn2008.DAYEND(vMaxTicketDate);
 
-	DROP TEMPORARY TABLE IF EXISTS `ticketToInvoice`;
+	DROP TEMPORARY TABLE IF EXISTS `tmp`.`ticketToInvoice`;
 
-	CREATE TEMPORARY TABLE `ticketToInvoice`
+	CREATE TEMPORARY TABLE `tmp`.`ticketToInvoice`
 		(PRIMARY KEY  (`id`))
         ENGINE = MEMORY
 		SELECT Id_Ticket id FROM vn2008.Tickets WHERE (Fecha BETWEEN vMinDateTicket
@@ -55305,8 +55305,8 @@ BEGIN
 	SET vMinTicketDate = util.firstDayOfYear(vMaxTicketDate - INTERVAL 1 YEAR);
 	SET vMaxTicketDate = util.dayend(vMaxTicketDate);
 
-	DROP TEMPORARY TABLE IF EXISTS `ticketToInvoice`;
-	CREATE TEMPORARY TABLE `ticketToInvoice`
+	DROP TEMPORARY TABLE IF EXISTS `tmp`.`ticketToInvoice`;
+	CREATE TEMPORARY TABLE `tmp`.`ticketToInvoice`
 		(PRIMARY KEY  (`id`))
 		ENGINE = MEMORY
 		SELECT id FROM ticket t
@@ -55333,9 +55333,9 @@ DELIMITER ;;
 CREATE DEFINER=`root`@`localhost` PROCEDURE `invoiceFromTicket`(IN vTicket INT)
 BEGIN
 
-	DROP TEMPORARY TABLE IF EXISTS `ticketToInvoice`;
+	DROP TEMPORARY TABLE IF EXISTS `tmp`.`ticketToInvoice`;
 
-	CREATE TEMPORARY TABLE `ticketToInvoice`
+	CREATE TEMPORARY TABLE `tmp`.`ticketToInvoice`
 	(PRIMARY KEY  (`id`))
         ENGINE = MEMORY
         SELECT id FROM vn.ticket
@@ -55931,9 +55931,9 @@ BEGIN
 			JOIN invoiceOut io ON io.companyFk = s.id
 		WHERE io.id = vInvoiceFk;
 
-	DROP TEMPORARY TABLE IF EXISTS ticketToInvoice;
+	DROP TEMPORARY TABLE IF EXISTS tmp.ticketToInvoice;
 
-	CREATE TEMPORARY TABLE ticketToInvoice
+	CREATE TEMPORARY TABLE tmp.ticketToInvoice
         SELECT id
             FROM ticket
             WHERE refFk = vInvoiceRef;
@@ -56408,9 +56408,9 @@ BEGIN
 				JOIN client c ON c.id = io.clientFk
 			WHERE io.id = vInvoice;
 
-		DROP TEMPORARY TABLE IF EXISTS ticketToInvoice;
+		DROP TEMPORARY TABLE IF EXISTS tmp.ticketToInvoice;
 
-		CREATE TEMPORARY TABLE ticketToInvoice
+		CREATE TEMPORARY TABLE tmp.ticketToInvoice
 			SELECT id
 				FROM ticket
 				WHERE refFk = vInvoiceRef;
@@ -56456,7 +56456,7 @@ CREATE DEFINER=`root`@`localhost` PROCEDURE `invoiceOut_exportationFromClient`(
 	vCompanyFk INT)
 BEGIN
 /**
- * Genera tabla temporal ticketToInvoice necesaría para el proceso de facturación
+ * Genera tabla temporal tmp.ticketToInvoice necesaría para el proceso de facturación
  * Los abonos quedan excluidos en las exportaciones
  *
  * @param vMaxTicketDate Fecha hasta la cual cogerá tickets para facturar
@@ -56467,8 +56467,8 @@ BEGIN
 	SET vMinTicketDate = util.firstDayOfYear(vMaxTicketDate - INTERVAL 1 YEAR);
 	SET vMaxTicketDate = util.dayend(vMaxTicketDate);
 
-	DROP TEMPORARY TABLE IF EXISTS `ticketToInvoice`;
-	CREATE TEMPORARY TABLE `ticketToInvoice`
+	DROP TEMPORARY TABLE IF EXISTS `tmp`.`ticketToInvoice`;
+	CREATE TEMPORARY TABLE `tmp`.`ticketToInvoice`
 		(PRIMARY KEY  (`id`))
 		ENGINE = MEMORY
 		SELECT t.id
@@ -56503,7 +56503,7 @@ CREATE DEFINER=`root`@`localhost` PROCEDURE `invoiceOut_new`(
 BEGIN
 /**
  * Creación de facturas emitidas.
- * requiere previamente tabla ticketToInvoice(id).
+ * requiere previamente tabla tmp.ticketToInvoice(id).
  *
  * @param vSerial serie a la cual se hace la factura
  * @param vInvoiceDate fecha de la factura
@@ -56531,13 +56531,13 @@ BEGIN
 
 	SELECT t.clientFk, t.companyFk
 			INTO vClientFk, vCompanyFk
-		FROM ticketToInvoice tt
+		FROM tmp.ticketToInvoice tt
 			JOIN ticket t ON t.id = tt.id
 		LIMIT 1;
 
-	-- Eliminem de ticketToInvoice els tickets que no han de ser facturats
+	-- Eliminem de tmp.ticketToInvoice els tickets que no han de ser facturats
 	DELETE ti.*
-		FROM ticketToInvoice ti
+		FROM tmp.ticketToInvoice ti
 			JOIN ticket t ON t.id = ti.id
 			JOIN sale s ON s.ticketFk = t.id
 			JOIN item i ON i.id = s.itemFk
@@ -56552,7 +56552,7 @@ BEGIN
 
 	SELECT SUM(s.quantity * s.price * (100 - s.discount)/100), ts.id
 			INTO vIsAnySaleToInvoice, vIsAnyServiceToInvoice
-		FROM ticketToInvoice t
+		FROM tmp.ticketToInvoice t
 			LEFT JOIN sale s ON s.ticketFk = t.id
 			LEFT JOIN ticketService ts ON ts.ticketFk = t.id;
 
@@ -56593,13 +56593,13 @@ BEGIN
 			WHERE id = vNewInvoiceId;
 
 		UPDATE ticket t
-				JOIN ticketToInvoice ti ON ti.id = t.id
+				JOIN tmp.ticketToInvoice ti ON ti.id = t.id
 			SET t.refFk = vNewRef;
 
 		DROP TEMPORARY TABLE IF EXISTS tmp.updateInter;
 		CREATE TEMPORARY TABLE tmp.updateInter ENGINE = MEMORY
 			SELECT s.id,ti.id ticket_id,vWorker Id_Trabajador
-				FROM ticketToInvoice ti
+				FROM tmp.ticketToInvoice ti
 					LEFT JOIN ticketState ts ON ti.id = ts.ticket
 					JOIN state s
 				WHERE IFNULL(ts.alertLevel,0) < 3 and s.`code` = getAlert3State(ti.id);
@@ -56609,7 +56609,7 @@ BEGIN
 
 		INSERT INTO ticketLog (action, userFk, originFk, description)
 			SELECT 'UPDATE', account.myUser_getId(), ti.id, CONCAT('Crea factura ', vNewRef)
-				FROM ticketToInvoice ti;
+				FROM tmp.ticketToInvoice ti;
 
 		CALL invoiceExpenceMake(vNewInvoiceId);
 		CALL invoiceTaxMake(vNewInvoiceId,vTaxArea);
@@ -56647,7 +56647,7 @@ BEGIN
 				(KEY (ticketFk))
 				ENGINE = MEMORY
 				SELECT id ticketFk
-					FROM ticketToInvoice;
+					FROM tmp.ticketToInvoice;
 
 			CALL `ticket_getTax`('NATIONAL');
 
@@ -56725,7 +56725,7 @@ BEGIN
 			DROP TEMPORARY TABLE tmp.ticketServiceTax;
 		END IF;
 	END IF;
-	DROP TEMPORARY TABLE `ticketToInvoice`;
+	DROP TEMPORARY TABLE `tmp`.`ticketToInvoice`;
 END ;;
 DELIMITER ;
 /*!50003 SET sql_mode              = @saved_sql_mode */ ;
@@ -56876,7 +56876,7 @@ BEGIN
 		(KEY (ticketFk))
 		ENGINE = MEMORY
 		SELECT id ticketFk
-			FROM ticketToInvoice;
+			FROM tmp.ticketToInvoice;
 
 	CALL ticket_getTax(vTaxArea);
 
@@ -68689,7 +68689,7 @@ DELIMITER ;
 /*!50003 SET character_set_client  = @saved_cs_client */ ;
 /*!50003 SET character_set_results = @saved_cs_results */ ;
 /*!50003 SET collation_connection  = @saved_col_connection */ ;
-/*!50003 DROP PROCEDURE IF EXISTS `ticketToInvoiceByAddress` */;
+/*!50003 DROP PROCEDURE IF EXISTS `tmp`.`ticketToInvoiceByAddress` */;
 /*!50003 SET @saved_cs_client      = @@character_set_client */ ;
 /*!50003 SET @saved_cs_results     = @@character_set_results */ ;
 /*!50003 SET @saved_col_connection = @@collation_connection */ ;
@@ -68709,9 +68709,9 @@ BEGIN
 
 	SET vEnded = util.dayEnd(vEnded);
 
-    DROP TEMPORARY TABLE IF EXISTS vn.ticketToInvoice;
+    DROP TEMPORARY TABLE IF EXISTS tmp.ticketToInvoice;
 
-    CREATE TEMPORARY TABLE vn.ticketToInvoice
+    CREATE TEMPORARY TABLE tmp.ticketToInvoice
         SELECT id
             FROM vn.ticket
             WHERE addressFk = vAddress
@@ -68745,9 +68745,9 @@ BEGIN
 
 	SET vEnded = util.dayEnd(vEnded);
 
-    DROP TEMPORARY TABLE IF EXISTS vn.ticketToInvoice;
+    DROP TEMPORARY TABLE IF EXISTS tmp.ticketToInvoice;
 
-    CREATE TEMPORARY TABLE vn.ticketToInvoice
+    CREATE TEMPORARY TABLE tmp.ticketToInvoice
         SELECT id
             FROM vn.ticket
             WHERE clientFk = vClient
@@ -68808,9 +68808,9 @@ BEGIN
 			JOIN vn.client c ON c.id = io.clientFk
         WHERE io.id = vInvoice;
 
-	DROP TEMPORARY TABLE IF EXISTS vn.ticketToInvoice;
+	DROP TEMPORARY TABLE IF EXISTS tmp.ticketToInvoice;
 
-	CREATE TEMPORARY TABLE vn.ticketToInvoice
+	CREATE TEMPORARY TABLE tmp.ticketToInvoice
         SELECT id
             FROM vn.ticket
             WHERE refFk = vInvoiceRef;

db/export-data.sh

@@ -68,6 +68,7 @@ TABLES=(
     time
     volumeConfig
     workCenter
+    companyI18n
 )
 dump_tables ${TABLES[@]}
 

e2e/helpers/extensions.js

@@ -156,14 +156,14 @@ let actions = {
         await this.waitForSpinnerLoad();
     },
 
-    accessToSection: async function(state) {
+    accessToSection: async function(state, name = 'Others') {
         await this.waitForSelector('vn-left-menu');
         let nested = await this.evaluate(state => {
             return document.querySelector(`vn-left-menu li li > a[ui-sref="${state}"]`) != null;
         }, state);
 
         if (nested) {
-            let selector = 'vn-left-menu vn-item-section > vn-icon[icon=keyboard_arrow_down]';
+            let selector = `vn-left-menu li[name="${name}"]`;
             await this.evaluate(selector => {
                 document.querySelector(selector).scrollIntoViewIfNeeded();
             }, selector);
@@ -414,7 +414,7 @@ let actions = {
         const selector = 'vn-snackbar .shape.shown';
         await this.waitForSelector(selector);
 
-        let message = await this.evaluate(selector => {
+        const message = await this.evaluate(selector => {
             const shape = document.querySelector(selector);
             const message = {
                 text: shape.querySelector('.text').innerText
@@ -431,6 +431,8 @@ let actions = {
             return message;
         }, selector);
 
+        message.isSuccess = message.type == 'success';
+
         await this.hideSnackbar();
         return message;
     },
@@ -466,28 +468,6 @@ let actions = {
         }, selector);
     },
 
-    clearInput: async function(selector) {
-        await this.waitForSelector(selector);
-
-        let field = await this.evaluate(selector => {
-            return document.querySelector(`${selector} input`).closest('.vn-field').$ctrl.field;
-        }, selector);
-
-        if ((field != null && field != '') || field == '0') {
-            let coords = await this.evaluate(selector => {
-                let rect = document.querySelector(selector).getBoundingClientRect();
-                return {x: rect.x + (rect.width / 2), y: rect.y + (rect.height / 2), width: rect.width};
-            }, selector);
-            await this.mouse.move(coords.x, coords.y);
-            await this.waitForSelector(`${selector} [icon="clear"]`, {visible: true});
-            await this.waitToClick(`${selector} [icon="clear"]`);
-        }
-
-        await this.evaluate(selector => {
-            return document.querySelector(`${selector} input`).closest('.vn-field').$ctrl.field == '';
-        }, selector);
-    },
-
     autocompleteSearch: async function(selector, searchValue) {
         let builtSelector = await this.selectorFormater(selector);
 
@@ -519,9 +499,8 @@ let actions = {
 
     checkboxState: async function(selector) {
         await this.waitForSelector(selector);
-        return this.evaluate(selector => {
-            let checkbox = document.querySelector(selector);
-            switch (checkbox.$ctrl.field) {
+        const value = await this.getInputValue(selector);
+        switch (value) {
         case null:
             return 'intermediate';
         case true:
@@ -529,7 +508,6 @@ let actions = {
         default:
             return 'unchecked';
         }
-        }, selector);
     },
 
     isDisabled: async function(selector) {
@@ -622,6 +600,138 @@ let actions = {
 
     waitForContentLoaded: async function() {
         await this.waitForSpinnerLoad();
+    },
+
+    async getInputValue(selector) {
+        return this.evaluate(selector => {
+            const input = document.querySelector(selector);
+            return input.$ctrl.field;
+        }, selector);
+    },
+
+    async getValue(selector) {
+        return await this.waitToGetProperty(selector, 'value');
+    },
+
+    async innerText(selector) {
+        const element = await this.$(selector);
+        const handle = await element.getProperty('innerText');
+        return handle.jsonValue();
+    },
+
+    async setInput(selector, value) {
+        const input = await this.$(selector);
+        const tagName = (await input.evaluate(e => e.tagName)).toLowerCase();
+
+        switch (tagName) {
+        case 'vn-textfield':
+        case 'vn-datalist':
+        case 'vn-input-number':
+            await this.clearInput(selector);
+            if (value)
+                await this.write(selector, value.toString());
+            break;
+        case 'vn-autocomplete':
+            if (value)
+                await this.autocompleteSearch(selector, value.toString());
+            else
+                await this.clearInput(selector);
+            break;
+        case 'vn-date-picker':
+            if (value)
+                await this.pickDate(selector, value);
+            else
+                await this.clearInput(selector);
+            break;
+        case 'vn-input-time':
+            if (value)
+                await this.pickTime(selector, value);
+            else
+                await this.clearInput(selector);
+            break;
+        case 'vn-check':
+            for (let i = 0; i < 3; i++) {
+                if (await this.getInput(selector) == value) break;
+                await this.click(selector);
+            }
+            break;
+        }
+    },
+
+    async getInput(selector) {
+        const input = await this.$(selector);
+        const tagName = (await input.evaluate(e => e.tagName)).toLowerCase();
+        let el;
+        let value;
+
+        switch (tagName) {
+        case 'vn-textfield':
+        case 'vn-autocomplete':
+        case 'vn-input-time':
+        case 'vn-datalist':
+            el = await input.$('input');
+            value = await el.getProperty('value');
+            return value.jsonValue();
+        case 'vn-check':
+        case 'vn-input-number':
+            return await this.getInputValue(selector);
+        case 'vn-textarea':
+            el = await input.$('textarea');
+            value = await el.getProperty('value');
+            return value.jsonValue();
+        case 'vn-date-picker':
+            el = await input.$('input');
+            value = await el.getProperty('value');
+            if (value) {
+                const date = new Date(await value.jsonValue());
+                date.setUTCHours(0, 0, 0, 0);
+                return date;
+            } else
+                return null;
+        default:
+            value = await this.innerText(selector);
+            return value.jsonValue();
+        }
+    },
+
+    async clearInput(selector) {
+        await this.waitForSelector(selector);
+
+        let field = await this.evaluate(selector => {
+            return document.querySelector(`${selector} input`).closest('.vn-field').$ctrl.field;
+        }, selector);
+
+        if ((field != null && field != '') || field == '0') {
+            let coords = await this.evaluate(selector => {
+                let rect = document.querySelector(selector).getBoundingClientRect();
+                return {x: rect.x + (rect.width / 2), y: rect.y + (rect.height / 2), width: rect.width};
+            }, selector);
+            await this.mouse.move(coords.x, coords.y);
+            await this.waitForSelector(`${selector} [icon="clear"]`, {visible: true});
+            await this.waitToClick(`${selector} [icon="clear"]`);
+        }
+
+        await this.evaluate(selector => {
+            return document.querySelector(`${selector} input`).closest('.vn-field').$ctrl.field == '';
+        }, selector);
+    },
+
+    async fetchForm(selector, inputNames) {
+        const values = {};
+        for (const inputName of inputNames)
+            values[inputName] = await this.getInput(`${selector} [vn-name="${inputName}"]`);
+        return values;
+    },
+
+    async fillForm(selector, values) {
+        for (const inputName in values)
+            await this.setInput(`${selector} [vn-name="${inputName}"]`, values[inputName]);
+    },
+
+    async sendForm(selector, values) {
+        if (values) await this.fillForm(selector, values);
+        await this.click(`${selector} button[type=submit]`);
+        return await this.waitForSnackbar();
     }
 };
 
@@ -629,12 +739,14 @@ export function extendPage(page) {
     for (let name in actions) {
         page[name] = async(...args) => {
             try {
-                return actions[name].apply(page, args);
+                return await actions[name].apply(page, args);
             } catch (err) {
                 let stringArgs = args
-                    .map(i => typeof i == 'function' ? 'Function' : i)
+                    .map(i => typeof i == 'function' ? 'Function' : `'${i}'`)
                     .join(', ');
-                throw new Error(`.${name}(${stringArgs}): ${err.message}`);
+                const myErr = new Error(`${err.message}\n  at Page.${name}(${stringArgs})`);
+                myErr.stack = err.stack;
+                throw myErr;
             }
         };
     }

e2e/helpers/selectors.js

@@ -193,10 +193,6 @@ export default {
         saveNewPoscode: '#savePostcode',
         createButton: 'vn-client-create button[type=submit]'
     },
-    clientDescriptor: {
-        moreMenu: 'vn-client-descriptor vn-icon-button[icon=more_vert]',
-        simpleTicketButton: '.vn-menu [name="simpleTicket"]'
-    },
     clientBasicData: {
         name: 'vn-client-basic-data vn-textfield[ng-model="$ctrl.client.name"]',
         contact: 'vn-client-basic-data vn-textfield[ng-model="$ctrl.client.contact"]',
@@ -231,23 +227,6 @@ export default {
         saveButton: 'button[type=submit]',
         watcher: 'vn-client-fiscal-data vn-watcher'
     },
-    clientBillingData: {
-        payMethod: 'vn-client-billing-data vn-autocomplete[ng-model="$ctrl.client.payMethodFk"]',
-        IBAN: 'vn-client-billing-data vn-textfield[ng-model="$ctrl.client.iban"]',
-        dueDay: 'vn-client-billing-data vn-input-number[ng-model="$ctrl.client.dueDay"]',
-        receivedCoreLCRCheckbox: 'vn-client-billing-data vn-check[label="Received LCR"]',
-        receivedCoreVNLCheckbox: 'vn-client-billing-data vn-check[label="Received core VNL"]',
-        receivedB2BVNLCheckbox: 'vn-client-billing-data vn-check[label="Received B2B VNL"]',
-        swiftBic: 'vn-client-billing-data vn-autocomplete[ng-model="$ctrl.client.bankEntityFk"]',
-        newBankEntityButton: 'vn-client-billing-data vn-icon-button[vn-tooltip="New bank entity"] > button',
-        newBankEntityName: '.vn-dialog.shown vn-textfield[ng-model="$ctrl.data.name"]',
-        newBankEntityBIC: '.vn-dialog.shown vn-textfield[ng-model="$ctrl.data.bic"]',
-        newBankEntityCountry: '.vn-dialog.shown vn-autocomplete[ng-model="$ctrl.data.countryFk"]',
-        newBankEntityCode: '.vn-dialog.shown vn-textfield[ng-model="$ctrl.data.id"]',
-        acceptBankEntityButton: '.vn-dialog.shown button[response="accept"]',
-        saveButton: 'vn-client-billing-data button[type=submit]',
-        watcher: 'vn-client-billing-data vn-watcher'
-    },
     clientAddresses: {
         addressesButton: 'vn-left-menu a[ui-sref="client.card.address.index"]',
         createAddress: 'vn-client-address-index vn-float-button',
@@ -283,12 +262,6 @@ export default {
         cancelEditAddressButton: 'vn-client-address-edit > form > vn-button-bar > vn-button > button',
         watcher: 'vn-client-address-edit vn-watcher'
     },
-    clientWebAccess: {
-        enableWebAccessCheckbox: 'vn-check[label="Enable web access"]',
-        userName: 'vn-client-web-access vn-textfield[ng-model="$ctrl.account.name"]',
-        email: 'vn-client-web-access vn-textfield[ng-model="$ctrl.account.email"]',
-        saveButton: 'button[type=submit]'
-    },
     clientNotes: {
         addNoteFloatButton: 'vn-float-button',
         note: 'vn-textarea[ng-model="$ctrl.note.text"]',
@@ -312,30 +285,6 @@ export default {
     clientMandate: {
         firstMandateText: 'vn-client-mandate vn-card vn-table vn-tbody > vn-tr'
     },
-    clientLog: {
-        lastModificationPreviousValue: 'vn-client-log vn-tr table tr td.before',
-        lastModificationCurrentValue: 'vn-client-log vn-tr table tr td.after',
-        namePreviousValue: 'vn-client-log vn-tr table tr:nth-child(1) td.before',
-        nameCurrentValue: 'vn-client-log vn-tr table tr:nth-child(1) td.after',
-        activePreviousValue: 'vn-client-log vn-tr:nth-child(2) table tr:nth-child(2) td.before',
-        activeCurrentValue: 'vn-client-log vn-tr:nth-child(2) table tr:nth-child(2) td.after'
-
-    },
-    clientBalance: {
-        company: 'vn-client-balance-index vn-autocomplete[ng-model="$ctrl.companyId"]',
-        newPaymentButton: `vn-float-button`,
-        newPaymentBank: '.vn-dialog.shown vn-autocomplete[ng-model="$ctrl.bankFk"]',
-        newPaymentAmount: '.vn-dialog.shown vn-input-number[ng-model="$ctrl.amountPaid"]',
-        newDescription: 'vn-textfield[ng-model="$ctrl.receipt.description"]',
-        deliveredAmount: '.vn-dialog vn-input-number[ng-model="$ctrl.deliveredAmount"]',
-        refundAmount: '.vn-dialog vn-input-number[ng-model="$ctrl.amountToReturn"]',
-        saveButton: '.vn-dialog.shown [response="accept"]',
-        anyBalanceLine: 'vn-client-balance-index vn-tbody > vn-tr',
-        firstLineBalance: 'vn-client-balance-index vn-tbody > vn-tr:nth-child(1) > vn-td:nth-child(8)',
-        firstLineReference: 'vn-client-balance-index vn-tbody > vn-tr:nth-child(1) > vn-td-editable',
-        firstLineReferenceInput: 'vn-client-balance-index vn-tbody > vn-tr:nth-child(1) > vn-td-editable > div > field > vn-textfield',
-        compensationButton: 'vn-client-balance-index vn-icon-button[vn-dialog="send_compensation"]'
-    },
     webPayment: {
         confirmFirstPaymentButton: 'vn-client-web-payment vn-tr:nth-child(1) vn-icon-button[icon="done_all"]',
         firstPaymentConfirmed: 'vn-client-web-payment vn-tr:nth-child(1) vn-icon[icon="check"]'
@@ -481,10 +430,6 @@ export default {
         packingOut: 'vn-input-number[ng-model="$ctrl.item.packingOut"]',
         isActiveCheckbox: 'vn-check[label="Active"]',
         priceInKgCheckbox: 'vn-check[label="Price in kg"]',
-        newIntrastatButton: 'vn-item-basic-data vn-icon-button[vn-tooltip="New intrastat"] > button',
-        newIntrastatId: '.vn-dialog.shown vn-input-number[ng-model="$ctrl.newIntrastat.intrastatId"]',
-        newIntrastatDescription: '.vn-dialog.shown vn-textfield[ng-model="$ctrl.newIntrastat.description"]',
-        acceptIntrastatButton: '.vn-dialog.shown button[response="accept"]',
         submitBasicDataButton: `button[type=submit]`
     },
     itemTags: {
@@ -637,13 +582,6 @@ export default {
         saveButton: '.vn-dialog.shown [response="accept"]',
         expeditionRow: 'vn-ticket-expedition vn-table vn-tbody > vn-tr'
     },
-    ticketPackages: {
-        firstPackage: 'vn-autocomplete[label="Package"]',
-        firstQuantity: 'vn-ticket-package vn-horizontal:nth-child(1) vn-input-number[ng-model="package.quantity"]',
-        firstRemovePackageButton: 'vn-icon-button[vn-tooltip="Remove package"]',
-        addPackageButton: 'vn-icon-button[vn-tooltip="Add package"]',
-        savePackagesButton: `button[type=submit]`
-    },
     ticketSales: {
         setOk: 'vn-ticket-sale vn-tool-bar > vn-button[label="Ok"] > button',
         saleLine: 'vn-table div > vn-tbody > vn-tr vn-check',
@@ -755,6 +693,7 @@ export default {
         anyDocument: 'vn-ticket-dms-index > vn-data-viewer vn-tbody vn-tr'
     },
     ticketFuture: {
+        searchResult: 'vn-ticket-future tbody tr',
         openAdvancedSearchButton: 'vn-searchbar .append vn-icon[icon="arrow_drop_down"]',
         originDated: 'vn-date-picker[label="Origin date"]',
         futureDated: 'vn-date-picker[label="Destination date"]',
@@ -770,7 +709,6 @@ export default {
         problems: 'vn-check[label="With problems"]',
         tableButtonSearch: 'vn-button[vn-tooltip="Search"]',
         moveButton: 'vn-button[vn-tooltip="Future tickets"]',
-        acceptButton: '.vn-confirm.shown button[response="accept"]',
         firstCheck: 'tbody > tr:nth-child(1) > td > vn-check',
         multiCheck: 'vn-multi-check',
         tableId: 'vn-textfield[name="id"]',
@@ -888,15 +826,6 @@ export default {
         landedDatePicker: 'vn-date-picker[label="Landed"]',
         createButton: 'button[type=submit]'
     },
-    orderSummary: {
-        id: 'vn-order-summary vn-one:nth-child(1) > vn-label-value:nth-child(1) span',
-        alias: 'vn-order-summary vn-one:nth-child(1) > vn-label-value:nth-child(2) span',
-        consignee: 'vn-order-summary vn-one:nth-child(2) > vn-label-value:nth-child(6) span',
-        subtotal: 'vn-order-summary vn-one.taxes > p:nth-child(1)',
-        vat: 'vn-order-summary vn-one.taxes > p:nth-child(2)',
-        total: 'vn-order-summary vn-one.taxes > p:nth-child(3)',
-        sale: 'vn-order-summary vn-tbody > vn-tr',
-    },
     orderCatalog: {
         plantRealmButton: 'vn-order-catalog > vn-side-menu vn-icon[icon="icon-plant"]',
         type: 'vn-order-catalog vn-autocomplete[data="$ctrl.itemTypes"]',
@@ -914,14 +843,6 @@ export default {
         fifthFilterRemoveButton: 'vn-order-catalog > vn-side-menu .chips > vn-chip:nth-child(5) vn-icon[icon=cancel]',
         sixthFilterRemoveButton: 'vn-order-catalog > vn-side-menu .chips > vn-chip:nth-child(6) vn-icon[icon=cancel]',
     },
-    orderBasicData: {
-        client: 'vn-autocomplete[label="Client"]',
-        address: 'vn-autocomplete[label="Address"]',
-        agency: 'vn-autocomplete[label="Agency"]',
-        observation: 'vn-textarea[label="Notes"]',
-        saveButton: `button[type=submit]`,
-        acceptButton: '.vn-confirm.shown button[response="accept"]'
-    },
     orderLine: {
         orderSubtotal: 'vn-order-line .header :first-child',
         firstLineDeleteButton: 'vn-order-line vn-tbody > vn-tr:nth-child(1) vn-icon[icon="delete"]',
@@ -961,16 +882,6 @@ export default {
         goToRouteSummaryButton: 'vn-route-summary > vn-card > h5 > a',
 
     },
-    routeBasicData: {
-        worker: 'vn-route-basic-data vn-autocomplete[ng-model="$ctrl.route.workerFk"]',
-        vehicle: 'vn-route-basic-data vn-autocomplete[ng-model="$ctrl.route.vehicleFk"]',
-        kmStart: 'vn-route-basic-data vn-input-number[ng-model="$ctrl.route.kmStart"]',
-        kmEnd: 'vn-route-basic-data vn-input-number[ng-model="$ctrl.route.kmEnd"]',
-        createdDate: 'vn-route-basic-data vn-date-picker[ng-model="$ctrl.route.created"]',
-        startedHour: 'vn-route-basic-data vn-input-time[ng-model="$ctrl.route.started"]',
-        finishedHour: 'vn-route-basic-data vn-input-time[ng-model="$ctrl.route.finished"]',
-        saveButton: 'vn-route-basic-data button[type=submit]'
-    },
     routeTickets: {
         firstTicketPriority: 'vn-route-tickets vn-tr:nth-child(1) vn-input-number[ng-model="ticket.priority"]',
         firstTicketCheckbox: 'vn-route-tickets vn-tr:nth-child(1) vn-check',
@@ -1255,22 +1166,6 @@ export default {
         confirmed: 'vn-entry-summary vn-check[label="Confirmed"]',
         anyBuyLine: 'vn-entry-summary tr.dark-row'
     },
-    entryBasicData: {
-        reference: 'vn-entry-basic-data vn-textfield[ng-model="$ctrl.entry.reference"]',
-        invoiceNumber: 'vn-entry-basic-data vn-textfield[ng-model="$ctrl.entry.invoiceNumber"]',
-        notes: 'vn-entry-basic-data vn-textfield[ng-model="$ctrl.entry.notes"]',
-        observations: 'vn-entry-basic-data vn-textarea[ng-model="$ctrl.entry.observation"]',
-        supplier: 'vn-entry-basic-data vn-autocomplete[ng-model="$ctrl.entry.supplierFk"]',
-        currency: 'vn-entry-basic-data vn-autocomplete[ng-model="$ctrl.entry.currencyFk"]',
-        commission: 'vn-entry-basic-data vn-input-number[ng-model="$ctrl.entry.commission"]',
-        company: 'vn-entry-basic-data vn-autocomplete[ng-model="$ctrl.entry.companyFk"]',
-        ordered: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isOrdered"]',
-        confirmed: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isConfirmed"]',
-        inventory: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isExcludedFromAvailable"]',
-        raid: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isRaid"]',
-        booked: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isBooked"]',
-        save: 'vn-entry-basic-data button[type=submit]',
-    },
     entryDescriptor: {
         agency: 'vn-entry-descriptor div.body vn-label-value:nth-child(1) span',
         travelsQuicklink: 'vn-entry-descriptor vn-quick-link[icon="local_airport"] > a',
@@ -1361,18 +1256,6 @@ export default {
         notes: 'vn-supplier-basic-data vn-textarea[ng-model="$ctrl.supplier.note"]',
         saveButton: 'vn-supplier-basic-data button[type="submit"]',
     },
-    supplierFiscalData: {
-        socialName: 'vn-supplier-fiscal-data vn-textfield[ng-model="$ctrl.supplier.name"]',
-        taxNumber: 'vn-supplier-fiscal-data vn-textfield[ng-model="$ctrl.supplier.nif"]',
-        account: 'vn-supplier-fiscal-data vn-textfield[ng-model="$ctrl.supplier.account"]',
-        sageTaxType: 'vn-supplier-fiscal-data vn-autocomplete[ng-model="$ctrl.supplier.sageTaxTypeFk"]',
-        sageWihholding: 'vn-supplier-fiscal-data vn-autocomplete[ng-model="$ctrl.supplier.sageWithholdingFk"]',
-        postCode: 'vn-supplier-fiscal-data vn-datalist[ng-model="$ctrl.supplier.postCode"]',
-        city: 'vn-supplier-fiscal-data vn-datalist[ng-model="$ctrl.supplier.city"]',
-        province: 'vn-supplier-fiscal-data vn-autocomplete[ng-model="$ctrl.supplier.provinceFk"]',
-        country: 'vn-supplier-fiscal-data vn-autocomplete[ng-model="$ctrl.supplier.countryFk"]',
-        saveButton: 'vn-supplier-fiscal-data button[type="submit"]',
-    },
     supplierBillingData: {
         payMethod: 'vn-supplier-billing-data vn-autocomplete[ng-model="$ctrl.supplier.payMethodFk"]',
         payDem: 'vn-supplier-billing-data vn-autocomplete[ng-model="$ctrl.supplier.payDemFk"]',

e2e/paths/01-salix/03_smartTable_searchBar_integrations.spec.js

@@ -15,92 +15,55 @@ describe('SmartTable SearchBar integration', () => {
         await browser.close();
     });
 
-    describe('as filters in smart-table section', () => {
-        it('should search by type in searchBar', async() => {
+    it('should search by type in searchBar, reload page and have same results', async() => {
         await page.waitToClick(selectors.itemsIndex.openAdvancedSearchButton);
         await page.autocompleteSearch(selectors.itemsIndex.advancedSearchItemType, 'Anthurium');
         await page.waitToClick(selectors.itemsIndex.advancedSearchButton);
         await page.waitForNumberOfElements(selectors.itemsIndex.searchResult, 3);
-        });
 
-        it('should reload page and have same results', async() => {
         await page.reload({
             waitUntil: 'networkidle2'
         });
 
         await page.waitForNumberOfElements(selectors.itemsIndex.searchResult, 3);
-        });
 
-        it('should search by grouping in smartTable', async() => {
         await page.waitToClick(selectors.itemsIndex.advancedSmartTableButton);
         await page.write(selectors.itemsIndex.advancedSmartTableGrouping, '1');
         await page.keyboard.press('Enter');
         await page.waitForNumberOfElements(selectors.itemsIndex.searchResult, 2);
-        });
 
-        it('should now reload page and have same results', async() => {
         await page.reload({
             waitUntil: 'networkidle2'
         });
 
         await page.waitForNumberOfElements(selectors.itemsIndex.searchResult, 2);
     });
-    });
 
-    describe('as filters in section without smart-table', () => {
-        it('go to zone section', async() => {
+    it('should filter in section without smart-table and search in searchBar go to zone section', async() => {
         await page.loginAndModule('salesPerson', 'zone');
         await page.waitToClick(selectors.globalItems.searchButton);
-        });
 
-        it('should search in searchBar first time', async() => {
         await page.doSearch('A');
-            const count = await page.countElement(selectors.zoneIndex.searchResult);
+        const firstCount = await page.countElement(selectors.zoneIndex.searchResult);
 
-            expect(count).toEqual(7);
-        });
-
-        it('should search in searchBar second time', async() => {
         await page.doSearch('A');
-            const count = await page.countElement(selectors.zoneIndex.searchResult);
+        const secondCount = await page.countElement(selectors.zoneIndex.searchResult);
 
-            expect(count).toEqual(7);
+        expect(firstCount).toEqual(7);
+        expect(secondCount).toEqual(7);
     });
 
-        it('should search in searchBar third time', async() => {
-            await page.doSearch('A');
-            const count = await page.countElement(selectors.zoneIndex.searchResult);
-
-            expect(count).toEqual(7);
-        });
-    });
-
-    // #5573 - The amount of rows differs when loading from side menu
-    // https://redmine.verdnatura.es/issues/5573
-    xdescribe('as orders', () => {
-        it('should order by first id', async() => {
+    it('should order orders by first id and order by last id, reload page and have same order', async() => {
         await page.loginAndModule('developer', 'item');
         await page.accessToSection('item.fixedPrice');
+        await page.keyboard.press('Enter');
 
-            const result = await page.waitToGetProperty(selectors.itemFixedPrice.firstItemID, 'value');
+        await page.waitForTextInField(selectors.itemFixedPrice.firstItemID, '1');
 
-            expect(result).toEqual('1');
-        });
-
-        it('should order by last id', async() => {
         await page.waitToClick(selectors.itemFixedPrice.orderColumnId);
-            const result = await page.waitToGetProperty(selectors.itemFixedPrice.firstItemID, 'value');
-
-            expect(result).toEqual('3');
-        });
-
-        it('should reload page and have same order', async() => {
         await page.reload({
             waitUntil: 'networkidle2'
         });
-            const result = await page.waitToGetProperty(selectors.itemFixedPrice.firstItemID, 'value');
-
-            expect(result).toEqual('3');
-        });
+        await page.waitForTextInField(selectors.itemFixedPrice.firstItemID, '13');
     });
 });

e2e/paths/02-client/03_edit_fiscal_data.spec.js

@@ -171,100 +171,40 @@ describe('Client Edit fiscalData path', () => {
             expect(result).toEqual('SMASH');
         });
 
-        it('should confirm the fiscal id have been edited', async() => {
-            const result = await page.waitToGetProperty(selectors.clientFiscalData.fiscalId, 'value');
+        it('should confirm the fiscal data have been edited', async() => {
+            const fiscalId = await page.waitToGetProperty(selectors.clientFiscalData.fiscalId, 'value');
+            const address = await page.waitToGetProperty(selectors.clientFiscalData.address, 'value');
+            const postcode = await page.waitToGetProperty(selectors.clientFiscalData.postcode, 'value');
+            const sageTax = await page.waitToGetProperty(selectors.clientFiscalData.sageTax, 'value');
+            const sageTransaction = await page.waitToGetProperty(selectors.clientFiscalData.sageTransaction, 'value');
+            const city = await page.waitToGetProperty(selectors.clientFiscalData.city, 'value');
+            const province = await page.waitToGetProperty(selectors.clientFiscalData.province, 'value');
+            const country = await page.waitToGetProperty(selectors.clientFiscalData.country, 'value');
+            const active = await page.checkboxState(selectors.clientFiscalData.activeCheckbox);
+            const frozen = await page.checkboxState(selectors.clientFiscalData.frozenCheckbox);
+            const hasToInvoice = await page.checkboxState(selectors.clientFiscalData.hasToInvoiceCheckbox);
+            const vies = await page.checkboxState(selectors.clientFiscalData.viesCheckbox);
+            const notifyByMail = await page.checkboxState(selectors.clientFiscalData.notifyByMailCheckbox);
+            const invoiceByAddress = await page.checkboxState(selectors.clientFiscalData.invoiceByAddressCheckbox);
+            const equalizationTax = await page.checkboxState(selectors.clientFiscalData.equalizationTaxCheckbox);
+            const verifiedData = await page.checkboxState(selectors.clientFiscalData.verifiedDataCheckbox);
 
-            expect(result).toEqual('94980061C');
-        });
-
-        it('should confirm the address have been edited', async() => {
-            const result = await page.waitToGetProperty(selectors.clientFiscalData.address, 'value');
-
-            expect(result).toEqual('Somewhere edited');
-        });
-
-        it('should confirm the postcode have been edited', async() => {
-            const result = await page.waitToGetProperty(selectors.clientFiscalData.postcode, 'value');
-
-            expect(result).toContain('46000');
-        });
-
-        it('should confirm the sageTax have been edited', async() => {
-            const result = await page.waitToGetProperty(selectors.clientFiscalData.sageTax, 'value');
-
-            expect(result).toEqual('Operaciones no sujetas');
-        });
-
-        it('should confirm the sageTransaction have been edited', async() => {
-            const result = await page.waitToGetProperty(selectors.clientFiscalData.sageTransaction, 'value');
-
-            expect(result).toEqual('36: Regularización de inversiones');
-        });
-
-        it('should confirm the city have been autocompleted', async() => {
-            const result = await page.waitToGetProperty(selectors.clientFiscalData.city, 'value');
-
-            expect(result).toEqual('Valencia');
-        });
-
-        it(`should confirm the province have been autocompleted`, async() => {
-            const result = await page.waitToGetProperty(selectors.clientFiscalData.province, 'value');
-
-            expect(result).toContain('Province one');
-        });
-
-        it('should confirm the country have been autocompleted', async() => {
-            const result = await page.waitToGetProperty(selectors.clientFiscalData.country, 'value');
-
-            expect(result).toEqual('España');
-        });
-
-        it('should confirm active checkbox is unchecked', async() => {
-            const result = await page.checkboxState(selectors.clientFiscalData.activeCheckbox);
-
-            expect(result).toBe('unchecked');
-        });
-
-        it('should confirm frozen checkbox is checked', async() => {
-            const result = await page.checkboxState(selectors.clientFiscalData.frozenCheckbox);
-
-            expect(result).toBe('checked');
-        });
-
-        it('should confirm Has to invoice checkbox is unchecked', async() => {
-            const result = await page.checkboxState(selectors.clientFiscalData.hasToInvoiceCheckbox);
-
-            expect(result).toBe('unchecked');
-        });
-
-        it('should confirm Vies checkbox is checked', async() => {
-            const result = await page.checkboxState(selectors.clientFiscalData.viesCheckbox);
-
-            expect(result).toBe('checked');
-        });
-
-        it('should confirm Notify by email checkbox is unchecked', async() => {
-            const result = await page.checkboxState(selectors.clientFiscalData.notifyByMailCheckbox);
-
-            expect(result).toBe('unchecked');
-        });
-
-        it('should confirm invoice by address checkbox is checked', async() => {
-            const result = await page.checkboxState(selectors.clientFiscalData.invoiceByAddressCheckbox);
-
-            expect(result).toBe('checked');
-        });
-
-        it('should confirm Equalization tax checkbox is unchecked', async() => {
-            const result = await page.checkboxState(selectors.clientFiscalData.equalizationTaxCheckbox);
-
-            expect(result).toBe('unchecked');
-        });
-
-        it('should confirm Verified data checkbox is checked', async() => {
-            const result = await page.checkboxState(selectors.clientFiscalData.verifiedDataCheckbox);
-
-            expect(result).toBe('checked');
+            expect(fiscalId).toEqual('94980061C');
+            expect(address).toEqual('Somewhere edited');
+            expect(postcode).toContain('46000');
+            expect(sageTax).toEqual('Operaciones no sujetas');
+            expect(sageTransaction).toEqual('Regularización de inversiones');
+            expect(city).toEqual('Valencia');
+            expect(province).toContain('Province one');
+            expect(country).toEqual('España');
+            expect(active).toBe('unchecked');
+            expect(frozen).toBe('checked');
+            expect(hasToInvoice).toBe('unchecked');
+            expect(vies).toBe('checked');
+            expect(notifyByMail).toBe('unchecked');
+            expect(invoiceByAddress).toBe('checked');
+            expect(equalizationTax).toBe('unchecked');
+            expect(verifiedData).toBe('checked');
         });
 
         // confirm invoice by address checkbox gets checked if the EQtax differs between addresses step 1

e2e/paths/02-client/04_edit_billing_data.spec.js

@@ -1,6 +1,23 @@
-import selectors from '../../helpers/selectors';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    payMethod: 'vn-client-billing-data vn-autocomplete[ng-model="$ctrl.client.payMethodFk"]',
+    IBAN: 'vn-client-billing-data vn-textfield[ng-model="$ctrl.client.iban"]',
+    dueDay: 'vn-client-billing-data vn-input-number[ng-model="$ctrl.client.dueDay"]',
+    receivedCoreLCRCheckbox: 'vn-client-billing-data vn-check[label="Received LCR"]',
+    receivedCoreVNLCheckbox: 'vn-client-billing-data vn-check[label="Received core VNL"]',
+    receivedB2BVNLCheckbox: 'vn-client-billing-data vn-check[label="Received B2B VNL"]',
+    swiftBic: 'vn-client-billing-data vn-autocomplete[ng-model="$ctrl.client.bankEntityFk"]',
+    newBankEntityButton: 'vn-client-billing-data vn-icon-button[vn-tooltip="New bank entity"] > button',
+    newBankEntityName: '.vn-dialog.shown vn-textfield[ng-model="$ctrl.data.name"]',
+    newBankEntityBIC: '.vn-dialog.shown vn-textfield[ng-model="$ctrl.data.bic"]',
+    newBankEntityCountry: '.vn-dialog.shown vn-autocomplete[ng-model="$ctrl.data.countryFk"]',
+    newBankEntityCode: '.vn-dialog.shown vn-textfield[ng-model="$ctrl.data.id"]',
+    acceptBankEntityButton: '.vn-dialog.shown button[response="accept"]',
+    saveButton: 'vn-client-billing-data button[type=submit]',
+    watcher: 'vn-client-billing-data vn-watcher'
+};
+
 describe('Client Edit billing data path', () => {
     let browser;
     let page;
@@ -17,93 +34,72 @@ describe('Client Edit billing data path', () => {
     });
 
     it(`should attempt to edit the billing data without an IBAN but fail`, async() => {
-        await page.autocompleteSearch(selectors.clientBillingData.payMethod, 'PayMethod with IBAN');
-        await page.autocompleteSearch(selectors.clientBillingData.swiftBic, 'BBKKESMMMMM');
-        await page.clearInput(selectors.clientBillingData.dueDay);
-        await page.write(selectors.clientBillingData.dueDay, '60');
-        await page.waitForTextInField(selectors.clientBillingData.dueDay, '60');
-        await page.waitToClick(selectors.clientBillingData.receivedCoreLCRCheckbox);
-        await page.waitToClick(selectors.clientBillingData.receivedCoreVNLCheckbox);
-        await page.waitToClick(selectors.clientBillingData.receivedB2BVNLCheckbox);
-        await page.waitToClick(selectors.clientBillingData.saveButton);
+        await page.autocompleteSearch($.payMethod, 'PayMethod with IBAN');
+        await page.autocompleteSearch($.swiftBic, 'BBKKESMMMMM');
+        await page.clearInput($.dueDay);
+        await page.write($.dueDay, '60');
+        await page.waitForTextInField($.dueDay, '60');
+        await page.waitToClick($.receivedCoreLCRCheckbox);
+        await page.waitToClick($.receivedCoreVNLCheckbox);
+        await page.waitToClick($.receivedB2BVNLCheckbox);
+        await page.waitToClick($.saveButton);
         const message = await page.waitForSnackbar();
 
         expect(message.text).toContain('That payment method requires an IBAN');
     });
 
     it(`should create a new BIC code`, async() => {
-        await page.waitToClick(selectors.clientBillingData.newBankEntityButton);
-        await page.write(selectors.clientBillingData.newBankEntityName, 'Gotham City Bank');
-        await page.write(selectors.clientBillingData.newBankEntityBIC, 'GTHMCT');
-        await page.autocompleteSearch(selectors.clientBillingData.newBankEntityCountry, 'España');
-        await page.write(selectors.clientBillingData.newBankEntityCode, '9999');
-        await page.waitToClick(selectors.clientBillingData.acceptBankEntityButton);
+        await page.waitToClick($.newBankEntityButton);
+        await page.write($.newBankEntityName, 'Gotham City Bank');
+        await page.write($.newBankEntityBIC, 'GTHMCT');
+        await page.autocompleteSearch($.newBankEntityCountry, 'España');
+        await page.write($.newBankEntityCode, '9999');
+        await page.waitToClick($.acceptBankEntityButton);
         const message = await page.waitForSnackbar();
-        await page.waitForTextInField(selectors.clientBillingData.swiftBic, 'Gotham City Bank');
-        const newcode = await page.waitToGetProperty(selectors.clientBillingData.swiftBic, 'value');
-
-        expect(newcode).toEqual('GTHMCT Gotham City Bank');
+        await page.waitForTextInField($.swiftBic, 'GTHMCT');
+        const newcode = await page.waitToGetProperty($.swiftBic, 'value');
 
+        expect(newcode).toEqual('GTHMCT');
         expect(message.text).toContain('Data saved!');
     });
 
     it(`should confirm the IBAN pay method was sucessfully saved`, async() => {
-        const payMethod = await page.waitToGetProperty(selectors.clientBillingData.payMethod, 'value');
+        const payMethod = await page.waitToGetProperty($.payMethod, 'value');
 
         expect(payMethod).toEqual('PayMethod with IBAN');
     });
 
     it(`should clear the BIC code field, update the IBAN to see how he BIC code autocompletes`, async() => {
-        await page.write(selectors.clientBillingData.IBAN, 'ES9121000418450200051332');
+        await page.write($.IBAN, 'ES9121000418450200051332');
         await page.keyboard.press('Tab');
         await page.keyboard.press('Tab');
-        await page.waitForTextInField(selectors.clientBillingData.swiftBic, 'caixesbb');
-        let automaticCode = await page.waitToGetProperty(selectors.clientBillingData.swiftBic, 'value');
+        await page.waitForTextInField($.swiftBic, 'caixesbb');
+        let automaticCode = await page.waitToGetProperty($.swiftBic, 'value');
 
-        expect(automaticCode).toEqual('CAIXESBB Caixa Bank');
+        expect(automaticCode).toEqual('CAIXESBB');
     });
 
     it(`should save the form with all its new data`, async() => {
-        await page.waitForWatcherData(selectors.clientBillingData.watcher);
-        await page.waitToClick(selectors.clientBillingData.saveButton);
+        await page.waitForWatcherData($.watcher);
+        await page.waitToClick($.saveButton);
         const message = await page.waitForSnackbar();
 
         expect(message.text).toContain('Notification sent!');
     });
 
-    it('should confirm the due day have been edited', async() => {
-        const dueDate = await page.waitToGetProperty(selectors.clientBillingData.dueDay, 'value');
+    it('should confirm the billing data have been edited', async() => {
+        const dueDate = await page.waitToGetProperty($.dueDay, 'value');
+        const IBAN = await page.waitToGetProperty($.IBAN, 'value');
+        const swiftBic = await page.waitToGetProperty($.swiftBic, 'value');
+        const receivedCoreLCR = await page.checkboxState($.receivedCoreLCRCheckbox);
+        const receivedCoreVNL = await page.checkboxState($.receivedCoreVNLCheckbox);
+        const receivedB2BVNL = await page.checkboxState($.receivedB2BVNLCheckbox);
 
         expect(dueDate).toEqual('60');
-    });
-
-    it('should confirm the IBAN was saved', async() => {
-        const IBAN = await page.waitToGetProperty(selectors.clientBillingData.IBAN, 'value');
-
         expect(IBAN).toEqual('ES9121000418450200051332');
-    });
-
-    it('should confirm the swift / BIC code was saved', async() => {
-        const code = await page.waitToGetProperty(selectors.clientBillingData.swiftBic, 'value');
-
-        expect(code).toEqual('CAIXESBB Caixa Bank');
-    });
-
-    it('should confirm Received LCR checkbox is checked', async() => {
-        const result = await page.checkboxState(selectors.clientBillingData.receivedCoreLCRCheckbox);
-
-        expect(result).toBe('checked');
-    });
-
-    it('should confirm Received core VNL checkbox is unchecked', async() => {
-        const result = await page.checkboxState(selectors.clientBillingData.receivedCoreVNLCheckbox);
-
-        expect(result).toBe('unchecked');
-    });
-
-    it('should confirm Received B2B VNL checkbox is unchecked', async() => {
-        const result = await page.checkboxState(selectors.clientBillingData.receivedB2BVNLCheckbox);
-
-        expect(result).toBe('unchecked');
+        expect(swiftBic).toEqual('CAIXESBB');
+        expect(receivedCoreLCR).toBe('checked');
+        expect(receivedCoreVNL).toBe('unchecked');
+        expect(receivedB2BVNL).toBe('unchecked');
     });
 });

e2e/paths/02-client/07_edit_web_access.spec.js

@@ -1,88 +1,56 @@
-/* eslint max-len: ["error", { "code": 150 }]*/
-import selectors from '../../helpers/selectors';
 import getBrowser from '../../helpers/puppeteer';
 
-describe('Client Edit web access path', () => {
+const $ = {
+    enableWebAccess: 'vn-client-web-access vn-check[label="Enable web access"]',
+    userName: 'vn-client-web-access vn-textfield[ng-model="$ctrl.account.name"]',
+    email: 'vn-client-web-access vn-textfield[ng-model="$ctrl.account.email"]',
+    saveButton: 'vn-client-web-access button[type=submit]',
+    nameValue: 'vn-client-log .change:nth-child(1) .basic-json:nth-child(1) vn-json-value',
+    activeValue: 'vn-client-log .change:nth-child(2) .basic-json:nth-child(2) vn-json-value'
+};
+
+describe('Client web access path', () => {
     let browser;
     let page;
+
     beforeAll(async() => {
         browser = await getBrowser();
         page = browser.page;
         await page.loginAndModule('salesPerson', 'client');
         await page.accessToSearchResult('max');
-        await page.accessToSection('client.card.webAccess');
     });
 
     afterAll(async() => {
         await browser.close();
     });
 
-    it('should uncheck the Enable web access checkbox', async() => {
-        await page.waitToClick(selectors.clientWebAccess.enableWebAccessCheckbox);
-        await page.waitToClick(selectors.clientWebAccess.saveButton);
-        const message = await page.waitForSnackbar();
+    it('should modify and save web access attributes', async() => {
+        await page.accessToSection('client.card.webAccess');
+        await page.click($.enableWebAccess);
+        await page.click($.saveButton);
+        const enableMessage = await page.waitForSnackbar();
+        await page.overwrite($.userName, 'Legion');
+        await page.overwrite($.email, 'legion@marvel.com');
+        await page.click($.saveButton);
+        const modifyMessage = await page.waitForSnackbar();
 
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should update the name`, async() => {
-        await page.clearInput(selectors.clientWebAccess.userName);
-        await page.write(selectors.clientWebAccess.userName, 'Legion');
-        await page.waitToClick(selectors.clientWebAccess.saveButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should update the email`, async() => {
-        await page.clearInput(selectors.clientWebAccess.email);
-        await page.write(selectors.clientWebAccess.email, 'legion@marvel.com');
-        await page.waitToClick(selectors.clientWebAccess.saveButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should reload the section and confirm web access is now unchecked', async() => {
         await page.reloadSection('client.card.webAccess');
-        const result = await page.checkboxState(selectors.clientWebAccess.enableWebAccessCheckbox);
+        const hasAccess = await page.checkboxState($.enableWebAccess);
+        const userName = await page.getValue($.userName);
+        const email = await page.getValue($.email);
 
-        expect(result).toBe('unchecked');
-    });
-
-    it('should confirm web access name have been updated', async() => {
-        const result = await page.waitToGetProperty(selectors.clientWebAccess.userName, 'value');
-
-        expect(result).toEqual('Legion');
-    });
-
-    it('should confirm web access email have been updated', async() => {
-        const result = await page.waitToGetProperty(selectors.clientWebAccess.email, 'value');
-
-        expect(result).toEqual('legion@marvel.com');
-    });
-
-    it(`should navigate to the log section`, async() => {
         await page.accessToSection('client.card.log');
-    });
+        const logName = await page.innerText($.nameValue);
+        const logActive = await page.innerText($.activeValue);
 
-    it(`should confirm the last log shows the updated client name and no modifications on active checkbox`, async() => {
-        let namePreviousValue = await page
-            .waitToGetProperty(selectors.clientLog.namePreviousValue, 'innerText');
-        let nameCurrentValue = await page
-            .waitToGetProperty(selectors.clientLog.nameCurrentValue, 'innerText');
+        expect(enableMessage.type).toBe('success');
+        expect(modifyMessage.type).toBe('success');
 
-        expect(namePreviousValue).toEqual('MaxEisenhardt');
-        expect(nameCurrentValue).toEqual('Legion');
-    });
+        expect(hasAccess).toBe('unchecked');
+        expect(userName).toEqual('Legion');
+        expect(email).toEqual('legion@marvel.com');
 
-    it(`should confirm the penultimate log shows the updated active and no modifications on client name`, async() => {
-        let activePreviousValue = await page
-            .waitToGetProperty(selectors.clientLog.activePreviousValue, 'innerText');
-        let activeCurrentValue = await page
-            .waitToGetProperty(selectors.clientLog.activeCurrentValue, 'innerText');
-
-        expect(activePreviousValue).toEqual('✓');
-        expect(activeCurrentValue).toEqual('✗');
+        expect(logName).toEqual('Legion');
+        expect(logActive).toEqual('✗');
     });
 });

e2e/paths/02-client/14_balance.spec.js

@@ -1,6 +1,17 @@
 import selectors from '../../helpers/selectors';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    company: 'vn-client-balance-index vn-autocomplete[ng-model="$ctrl.companyId"]',
+    newPaymentButton: `vn-float-button`,
+    newPayment: '.vn-dialog.shown',
+    refundAmount: '.vn-dialog.shown [vn-name="amountToReturn"]',
+    saveButton: '.vn-dialog.shown [response="accept"]',
+    firstLineBalance: 'vn-client-balance-index vn-tbody > vn-tr:nth-child(1) > vn-td:nth-child(8)',
+    firstLineReference: 'vn-client-balance-index vn-tbody > vn-tr:nth-child(1) > vn-td-editable',
+    firstLineReferenceInput: 'vn-client-balance-index vn-tbody > vn-tr:nth-child(1) > vn-td-editable vn-textfield',
+};
+
 describe('Client balance path', () => {
     let browser;
     let page;
@@ -18,125 +29,100 @@ describe('Client balance path', () => {
     it('should now edit the local user config data', async() => {
         await page.waitToClick(selectors.globalItems.userMenuButton);
         await page.autocompleteSearch(selectors.globalItems.userLocalCompany, 'CCs');
-        const message = await page.waitForSnackbar();
+        const companyMessage = await page.waitForSnackbar();
 
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should access to the balance section to check the data shown matches the local settings', async() => {
         await page.accessToSection('client.card.balance.index');
-        let result = await page.waitToGetProperty(selectors.clientBalance.company, 'value');
+        const company = await page.getValue($.company);
 
-        expect(result).toEqual('CCs');
-    });
-
-    it('should now clear the user local settings', async() => {
         await page.waitToClick(selectors.globalItems.userMenuButton);
         await page.clearInput(selectors.globalItems.userConfigThirdAutocomplete);
         const message = await page.waitForSnackbar();
 
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should reload the section', async() => {
         await page.closePopup();
         await page.reloadSection('client.card.balance.index');
+
+        expect(companyMessage.isSuccess).toBeTrue();
+        expect(company).toEqual('CCs');
+        expect(message.isSuccess).toBeTrue();
     });
 
     it('should create a new payment that clears the debt', async() => {
-        await page.closePopup();
-        await page.waitToClick(selectors.clientBalance.newPaymentButton);
-        await page.autocompleteSearch(selectors.clientBalance.newPaymentBank, 'Cash');
-        await page.clearInput(selectors.clientBalance.newDescription);
-        await page.write(selectors.clientBalance.newDescription, 'Description');
-        await page.waitToClick(selectors.clientBalance.saveButton);
+        await page.waitToClick($.newPaymentButton);
+        await page.fillForm($.newPayment, {
+            bank: 'Cash',
+            description: 'Description',
+            viewReceipt: false
+        });
+        await page.respondToDialog('accept');
         const message = await page.waitForSnackbar();
 
-        expect(message.text).toContain('Data saved!');
+        expect(message.isSuccess).toBeTrue();
     });
 
-    it('should edit the 1st line reference', async() => {
-        await page.waitToClick(selectors.clientBalance.firstLineReference);
-        await page.write(selectors.clientBalance.firstLineReferenceInput, 'Miscellaneous payment');
+    it('should edit the 1st line reference and check data', async() => {
+        await page.waitToClick($.firstLineReference);
+        await page.write($.firstLineReferenceInput, 'Miscellaneous payment');
         await page.keyboard.press('Enter');
         const message = await page.waitForSnackbar();
 
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check balance is now 0, the reference was saved and the company is now VNL becouse the user local settings were removed', async() => {
         await page.waitForSpinnerLoad();
-        let company = await page
-            .waitToGetProperty(selectors.clientBalance.company, 'value');
-
-        let reference = await page
-            .waitToGetProperty(selectors.clientBalance.firstLineReference, 'innerText');
-
-        let firstBalanceLine = await page
-            .waitToGetProperty(selectors.clientBalance.firstLineBalance, 'innerText');
+        let company = await page.getValue($.company);
+        let reference = await page.innerText($.firstLineReference);
+        let firstBalanceLine = await page.innerText($.firstLineBalance);
 
+        expect(message.isSuccess).toBeTrue();
         expect(company).toEqual('VNL');
         expect(reference).toEqual('Miscellaneous payment');
         expect(firstBalanceLine).toContain('0.00');
     });
 
-    it('should create a new payment and check the cash comparison works correctly', async() => {
-        const amountPaid = '100';
-        const cashHanded = '500';
-        const expectedRefund = '400';
-
-        await page.waitToClick(selectors.clientBalance.newPaymentButton);
-        await page.write(selectors.clientBalance.newPaymentAmount, amountPaid);
-        await page.clearInput(selectors.clientBalance.newDescription);
-        await page.write(selectors.clientBalance.newDescription, 'Payment');
-        await page.write(selectors.clientBalance.deliveredAmount, cashHanded);
-        const refund = await page.waitToGetProperty(selectors.clientBalance.refundAmount, 'value');
-        await page.waitToClick(selectors.clientBalance.saveButton);
+    it('should create a new payment, check the cash comparison works correctly and balance value is -100', async() => {
+        await page.waitToClick($.newPaymentButton);
+        await page.fillForm($.newPayment, {
+            amountPaid: 100,
+            description: 'Payment',
+            deliveredAmount: 500,
+            viewReceipt: false
+        });
+        const refund = await page.getValue($.refundAmount);
+        await page.respondToDialog('accept');
         const message = await page.waitForSnackbar();
 
-        expect(refund).toEqual(expectedRefund);
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check the balance value is now -100', async() => {
-        let result = await page
-            .waitToGetProperty(selectors.clientBalance.firstLineBalance, 'innerText');
+        const result = await page.innerText($.firstLineBalance);
 
+        expect(refund).toEqual('400');
+        expect(message.isSuccess).toBeTrue();
         expect(result).toContain('-€100.00');
     });
 
     it('should create a new payment and check the cash exceeded the maximum', async() => {
-        const amountPaid = '1001';
-
-        await page.closePopup();
-        await page.waitToClick(selectors.clientBalance.newPaymentButton);
-        await page.autocompleteSearch(selectors.clientBalance.newPaymentBank, 'Cash');
-        await page.write(selectors.clientBalance.newPaymentAmount, amountPaid);
-        await page.clearInput(selectors.clientBalance.newDescription);
-        await page.write(selectors.clientBalance.newDescription, 'Payment');
-        await page.waitToClick(selectors.clientBalance.saveButton);
+        await page.waitToClick($.newPaymentButton);
+        await page.fillForm($.newPayment, {
+            bank: 'Cash',
+            amountPaid: 1001,
+            description: 'Payment'
+        });
+        await page.waitToClick($.saveButton);
         const message = await page.waitForSnackbar();
 
         expect(message.text).toContain('Amount exceeded');
     });
 
-    it('should create a new payment that sets the balance back to the original negative value', async() => {
+    it('should create a new payment that sets the balance back to negative value and check it', async() => {
         await page.closePopup();
-        await page.waitToClick(selectors.clientBalance.newPaymentButton);
-        await page.autocompleteSearch(selectors.clientBalance.newPaymentBank, 'Pay on receipt');
-        await page.overwrite(selectors.clientBalance.newPaymentAmount, '-150');
-        await page.clearInput(selectors.clientBalance.newDescription);
-        await page.write(selectors.clientBalance.newDescription, 'Description');
-        await page.waitToClick(selectors.clientBalance.saveButton);
+        await page.waitToClick($.newPaymentButton);
+
+        await page.fillForm($.newPayment, {
+            bank: 'Pay on receipt',
+            amountPaid: -150,
+            description: 'Description'
+        });
+        await page.respondToDialog('accept');
         const message = await page.waitForSnackbar();
 
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check balance is now 50', async() => {
-        let result = await page
-            .waitToGetProperty(selectors.clientBalance.firstLineBalance, 'innerText');
+        const result = await page.innerText($.firstLineBalance);
 
+        expect(message.isSuccess).toBeTrue();
         expect(result).toEqual('€50.00');
     });
 
@@ -149,12 +135,9 @@ describe('Client balance path', () => {
         await page.waitForState('client.index');
     });
 
-    it('should now search for the user Petter Parker', async() => {
+    it('should now search for the user Petter Parker not check the payment button is not present', async() => {
         await page.accessToSearchResult('Petter Parker');
         await page.accessToSection('client.card.balance.index');
-    });
-
-    it('should not be able to click the new payment button as it isnt present', async() => {
-        await page.waitForSelector(selectors.clientBalance.newPaymentButton, {hidden: true});
+        await page.waitForSelector($.newPaymentButton, {hidden: true});
     });
 });

e2e/paths/02-client/23_send_compensation.spec.js

@@ -1,6 +1,11 @@
-import selectors from '../../helpers/selectors';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    company: 'vn-client-balance-index vn-autocomplete[ng-model="$ctrl.companyId"]',
+    compensationButton: 'vn-client-balance-index vn-icon-button[vn-dialog="send_compensation"]',
+    saveButton: '.vn-dialog.shown [response="accept"]'
+};
+
 describe('Client Send balance compensation', () => {
     let browser;
     let page;
@@ -17,9 +22,9 @@ describe('Client Send balance compensation', () => {
     });
 
     it(`should click on send compensation button`, async() => {
-        await page.autocompleteSearch(selectors.clientBalance.company, 'VNL');
-        await page.waitToClick(selectors.clientBalance.compensationButton);
-        await page.waitToClick(selectors.clientBalance.saveButton);
+        await page.autocompleteSearch($.company, 'VNL');
+        await page.waitToClick($.compensationButton);
+        await page.waitToClick($.saveButton);
         const message = await page.waitForSnackbar();
 
         expect(message.text).toContain('Notification sent!');

e2e/paths/04-item/02_basic_data.spec.js

@@ -1,14 +1,23 @@
-import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    form: 'vn-item-basic-data form',
+    intrastatForm: '.vn-dialog.shown form',
+    newIntrastatButton: 'vn-item-basic-data vn-icon-button[vn-tooltip="New intrastat"] > button'
+};
+
 describe('Item Edit basic data path', () => {
     let browser;
     let page;
+
     beforeAll(async() => {
         browser = await getBrowser();
         page = browser.page;
         await page.loginAndModule('buyer', 'item');
         await page.accessToSearchResult('Melee weapon combat fist 15cm');
+    });
+
+    beforeEach(async() => {
         await page.accessToSection('item.card.basicData');
     });
 
@@ -16,124 +25,42 @@ describe('Item Edit basic data path', () => {
         await browser.close();
     });
 
-    it(`should check the descritor edit button is visible for buyer`, async() => {
-        await page.waitForSelector(selectors.itemDescriptor.editButton, {visible: true});
-    });
+    it(`should edit the item basic data and confirm the item data was edited`, async() => {
+        const values = {
+            name: 'Rose of Purity',
+            longName: 'RS Rose of Purity',
+            type: 'Anthurium',
+            intrastat: 'Coral y materiales similares',
+            origin: 'Spain',
+            relevancy: 1,
+            generic: 'Pallet',
+            isActive: false,
+            priceInKg: true,
+            isFragile: true,
+            packingOut: 5
+        };
 
-    it(`should edit the item basic data`, async() => {
-        await page.clearInput(selectors.itemBasicData.name);
-        await page.write(selectors.itemBasicData.name, 'Rose of Purity');
-        await page.clearInput(selectors.itemBasicData.longName);
-        await page.write(selectors.itemBasicData.longName, 'RS Rose of Purity');
-        await page.autocompleteSearch(selectors.itemBasicData.type, 'Anthurium');
-        await page.autocompleteSearch(selectors.itemBasicData.intrastat, 'Coral y materiales similares');
-        await page.autocompleteSearch(selectors.itemBasicData.origin, 'Spain');
-        await page.clearInput(selectors.itemBasicData.relevancy);
-        await page.write(selectors.itemBasicData.relevancy, '1');
-        await page.clearInput(selectors.itemBasicData.generic);
-        await page.autocompleteSearch(selectors.itemBasicData.generic, '16');
-        await page.waitToClick(selectors.itemBasicData.isActiveCheckbox);
-        await page.waitToClick(selectors.itemBasicData.priceInKgCheckbox);
-        await page.waitToClick(selectors.itemBasicData.isFragile);
-        await page.write(selectors.itemBasicData.packingOut, '5');
-        await page.waitToClick(selectors.itemBasicData.submitBasicDataButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should create a new intrastat`, async() => {
-        await page.waitToClick(selectors.itemBasicData.newIntrastatButton);
-        await page.write(selectors.itemBasicData.newIntrastatId, '588420239');
-        await page.write(selectors.itemBasicData.newIntrastatDescription, 'Tropical Flowers');
-        await page.waitToClick(selectors.itemBasicData.acceptIntrastatButton);
-        await page.waitForTextInField(selectors.itemBasicData.intrastat, 'Tropical Flowers');
-        let newcode = await page.waitToGetProperty(selectors.itemBasicData.intrastat, 'value');
-
-        expect(newcode).toEqual('588420239 Tropical Flowers');
-    });
-
-    it('should save with the new intrastat', async() => {
-        await page.waitToClick(selectors.itemBasicData.submitBasicDataButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should confirm the item name was edited`, async() => {
+        const message = await page.sendForm($.form, values);
         await page.reloadSection('item.card.basicData');
-        const result = await page.waitToGetProperty(selectors.itemBasicData.name, 'value');
+        const formValues = await page.fetchForm($.form, Object.keys(values));
 
-        expect(result).toEqual('Rose of Purity');
+        expect(message.isSuccess).toBeTrue();
+        expect(formValues).toEqual(values);
     });
 
-    it(`should confirm the item type was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBasicData.type, 'value');
-
-        expect(result).toEqual('Anthurium');
+    it(`should create a new intrastat and save it`, async() => {
+        await page.click($.newIntrastatButton);
+        await page.fillForm($.intrastatForm, {
+            id: '588420239',
+            description: 'Tropical Flowers'
         });
+        await page.respondToDialog('accept');
 
-    it(`should confirm the item intrastat was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBasicData.intrastat, 'value');
+        const message = await page.sendForm($.form);
+        await page.reloadSection('item.card.basicData');
+        const formValues = await page.fetchForm($.form, ['intrastat']);
 
-        expect(result).toEqual('588420239 Tropical Flowers');
-    });
-
-    it(`should confirm the item relevancy was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBasicData.relevancy, 'value');
-
-        expect(result).toEqual('1');
-    });
-
-    it(`should confirm the item origin was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBasicData.origin, 'value');
-
-        expect(result).toEqual('Spain');
-    });
-
-    it(`should confirm the item generic was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBasicData.generic, 'value');
-
-        expect(result).toEqual('16 - Pallet');
-    });
-
-    it(`should confirm the item long name was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBasicData.longName, 'value');
-
-        expect(result).toEqual('RS Rose of Purity');
-    });
-
-    it('should confirm isFragile checkbox is unchecked', async() => {
-        const result = await page
-            .checkboxState(selectors.itemBasicData.isFragile);
-
-        expect(result).toBe('checked');
-    });
-
-    it('should confirm isActive checkbox is unchecked', async() => {
-        const result = await page
-            .checkboxState(selectors.itemBasicData.isActiveCheckbox);
-
-        expect(result).toBe('unchecked');
-    });
-
-    it('should confirm the priceInKg checkbox is checked', async() => {
-        const result = await page
-            .checkboxState(selectors.itemBasicData.priceInKgCheckbox);
-
-        expect(result).toBe('checked');
-    });
-
-    it(`should confirm the item packingOut was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBasicData.packingOut, 'value');
-
-        expect(result).toEqual('5');
+        expect(message.isSuccess).toBeTrue();
+        expect(formValues).toEqual({intrastat: 'Tropical Flowers'});
     });
 });

e2e/paths/04-item/03_tax.spec.js

@@ -53,12 +53,4 @@ describe('Item edit tax path', () => {
 
         expect(firstVatType).toEqual('Reduced VAT');
     });
-
-    // # #2680 Undo changes button bugs
-    xit(`should now click the undo changes button and see the form is restored`, async() => {
-        await page.waitToClick(selectors.itemTax.undoChangesButton);
-        const firstVatType = await page.waitToGetProperty(selectors.itemTax.firstClass, 'value');
-
-        expect(firstVatType).toEqual('General VAT');
-    });
 });

e2e/paths/04-item/07_create.spec.js

@@ -1,6 +1,10 @@
 import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    form: 'vn-item-create form'
+};
+
 describe('Item Create', () => {
     let browser;
     let page;
@@ -14,13 +18,6 @@ describe('Item Create', () => {
         await browser.close();
     });
 
-    it(`should search for the item Infinity Gauntlet to confirm it isn't created yet`, async() => {
-        await page.doSearch('Infinity Gauntlet');
-        const resultsCount = await page.countElement(selectors.itemsIndex.searchResult);
-
-        expect(resultsCount).toEqual(0);
-    });
-
     it('should access to the create item view by clicking the create floating button', async() => {
         await page.waitToClick(selectors.itemsIndex.createItemButton);
         await page.waitForState('item.create');
@@ -37,44 +34,32 @@ describe('Item Create', () => {
     });
 
     it('should throw an error when insert an invalid priority', async() => {
-        await page.write(selectors.itemCreateView.temporalName, 'Infinity Gauntlet');
-        await page.autocompleteSearch(selectors.itemCreateView.type, 'Crisantemo');
-        await page.autocompleteSearch(selectors.itemCreateView.intrastat, 'Coral y materiales similares');
-        await page.autocompleteSearch(selectors.itemCreateView.origin, 'Holand');
-        await page.clearInput(selectors.itemCreateView.priority);
-        await page.waitToClick(selectors.itemCreateView.createButton);
-        const message = await page.waitForSnackbar();
+        const values = {
+            name: 'Infinity Gauntlet',
+            type: 'Crisantemo',
+            intrastat: 'Coral y materiales similares',
+            origin: 'Holand',
+            priority: null
+        };
+        const message = await page.sendForm($.form, values);
 
         expect(message.text).toContain('Valid priorities');
     });
 
     it('should create the Infinity Gauntlet item', async() => {
-        await page.autocompleteSearch(selectors.itemCreateView.priority, '2');
-        await page.waitToClick(selectors.itemCreateView.createButton);
-        const message = await page.waitForSnackbar();
+        const values = {
+            name: 'Infinity Gauntlet',
+            type: 'Crisantemo',
+            intrastat: 'Coral y materiales similares',
+            origin: 'Holand',
+            priority: '2'
+        };
 
-        expect(message.text).toContain('Data saved!');
-    });
+        await page.fillForm($.form, values);
+        const formValues = await page.fetchForm($.form, Object.keys(values));
+        const message = await page.sendForm($.form);
 
-    it('should confirm Infinity Gauntlet item was created', async() => {
-        let result = await page
-            .waitToGetProperty(selectors.itemBasicData.name, 'value');
-
-        expect(result).toEqual('Infinity Gauntlet');
-
-        result = await page
-            .waitToGetProperty(selectors.itemBasicData.type, 'value');
-
-        expect(result).toEqual('Crisantemo');
-
-        result = await page
-            .waitToGetProperty(selectors.itemBasicData.intrastat, 'value');
-
-        expect(result).toEqual('5080000 Coral y materiales similares');
-
-        result = await page
-            .waitToGetProperty(selectors.itemBasicData.origin, 'value');
-
-        expect(result).toEqual('Holand');
+        expect(message.isSuccess).toBeTrue();
+        expect(formValues).toEqual(values);
     });
 });

e2e/paths/04-item/13_fixedPrice.spec.js

@@ -1,6 +1,8 @@
 import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = selectors.itemFixedPrice;
+
 describe('Item fixed prices path', () => {
     let browser;
     let page;
@@ -22,63 +24,63 @@ describe('Item fixed prices path', () => {
     });
 
     it('should filter using all the fields', async() => {
-        await page.write(selectors.itemFixedPrice.generalSearchFilter, 'item');
+        await page.write($.generalSearchFilter, 'item');
         await page.keyboard.press('Enter');
 
         expect(httpRequest).toContain('search=item');
 
-        await page.click(selectors.itemFixedPrice.chip);
-        await page.click(selectors.itemFixedPrice.reignFilter);
+        await page.click($.chip);
+        await page.click($.reignFilter);
 
         expect(httpRequest).toContain('categoryFk');
 
-        await page.autocompleteSearch(selectors.itemFixedPrice.typeFilter, 'Alstroemeria');
+        await page.autocompleteSearch($.typeFilter, 'Alstroemeria');
 
         expect(httpRequest).toContain('typeFk');
 
-        await page.click(selectors.itemFixedPrice.chip);
-        await page.autocompleteSearch(selectors.itemFixedPrice.buyerFilter, 'buyerNick');
+        await page.click($.chip);
+        await page.autocompleteSearch($.buyerFilter, 'buyerNick');
 
         expect(httpRequest).toContain('buyerFk');
 
-        await page.click(selectors.itemFixedPrice.chip);
-        await page.autocompleteSearch(selectors.itemFixedPrice.warehouseFilter, 'Algemesi');
+        await page.click($.chip);
+        await page.autocompleteSearch($.warehouseFilter, 'Algemesi');
 
         expect(httpRequest).toContain('warehouseFk');
 
-        await page.click(selectors.itemFixedPrice.chip);
-        await page.click(selectors.itemFixedPrice.mineFilter);
+        await page.click($.chip);
+        await page.click($.mineFilter);
 
         expect(httpRequest).toContain('mine=true');
 
-        await page.click(selectors.itemFixedPrice.chip);
-        await page.click(selectors.itemFixedPrice.hasMinPriceFilter);
+        await page.click($.chip);
+        await page.click($.hasMinPriceFilter);
 
         expect(httpRequest).toContain('hasMinPrice=true');
 
-        await page.click(selectors.itemFixedPrice.chip);
-        await page.click(selectors.itemFixedPrice.addTag);
-        await page.autocompleteSearch(selectors.itemFixedPrice.tagFilter, 'Color');
-        await page.autocompleteSearch(selectors.itemFixedPrice.tagValueFilter, 'Brown');
+        await page.click($.chip);
+        await page.click($.addTag);
+        await page.autocompleteSearch($.tagFilter, 'Color');
+        await page.autocompleteSearch($.tagValueFilter, 'Brown');
 
         expect(httpRequest).toContain('tags');
 
-        await page.click(selectors.itemFixedPrice.chip);
+        await page.click($.chip);
     });
 
     it('should click on the add new fixed price button', async() => {
-        await page.waitToClick(selectors.itemFixedPrice.add);
-        await page.waitForSelector(selectors.itemFixedPrice.fourthFixedPrice);
+        await page.waitToClick($.add);
+        await page.waitForSelector($.fourthFixedPrice);
     });
 
     it('should fill the fixed price data', async() => {
         const now = Date.vnNew();
-        await page.autocompleteSearch(selectors.itemFixedPrice.fourthWarehouse, 'Warehouse one');
-        await page.writeOnEditableTD(selectors.itemFixedPrice.fourthGroupingPrice, '1');
-        await page.writeOnEditableTD(selectors.itemFixedPrice.fourthPackingPrice, '1');
-        await page.write(selectors.itemFixedPrice.fourthMinPrice, '1');
-        await page.pickDate(selectors.itemFixedPrice.fourthStarted, now);
-        await page.pickDate(selectors.itemFixedPrice.fourthEnded, now);
+        await page.autocompleteSearch($.fourthWarehouse, 'Warehouse one');
+        await page.writeOnEditableTD($.fourthGroupingPrice, '1');
+        await page.writeOnEditableTD($.fourthPackingPrice, '1');
+        await page.write($.fourthMinPrice, '1');
+        await page.pickDate($.fourthStarted, now);
+        await page.pickDate($.fourthEnded, now);
         const message = await page.waitForSnackbar();
 
         expect(message.text).toContain('Data saved!');
@@ -87,7 +89,7 @@ describe('Item fixed prices path', () => {
     it('should reload the section and check the created price has the expected ID', async() => {
         await page.goto(`http://localhost:5000/#!/item/fixed-price`);
 
-        const result = await page.waitToGetProperty(selectors.itemFixedPrice.fourthItemID, 'value');
+        const result = await page.waitToGetProperty($.fourthItemID, 'value');
 
         expect(result).toContain('13');
     });

e2e/paths/05-ticket/01-sale/02_edit_sale.spec.js

@@ -246,6 +246,7 @@ describe('Ticket Edit sale path', () => {
     it('should select the third sale and create a claim of it', async() => {
         await page.accessToSearchResult('16');
         await page.accessToSection('ticket.card.sale');
+        await page.waitToClick(selectors.ticketSales.firstSaleCheckbox);
         await page.waitToClick(selectors.ticketSales.thirdSaleCheckbox);
         await page.waitToClick(selectors.ticketSales.moreMenu);
         await page.waitToClick(selectors.ticketSales.moreMenuCreateClaim);
@@ -315,7 +316,7 @@ describe('Ticket Edit sale path', () => {
     it('should confirm the transfered quantity is the correct one', async() => {
         const result = await page.waitToGetProperty(selectors.ticketSales.secondSaleQuantityCell, 'innerText');
 
-        expect(result).toContain('20');
+        expect(result).toContain('10');
     });
 
     it('should go back to the original ticket sales section', async() => {
@@ -424,20 +425,6 @@ describe('Ticket Edit sale path', () => {
         expect(result).toBeFalsy();
     });
 
-    // tickets no longer update their totals instantly, a task performed ever 5-10 mins does it. disabled this test until it changes.
-    xit('should update all sales discount', async() => {
-        await page.closePopup();
-        await page.waitToClick(selectors.ticketSales.moreMenu);
-        await page.waitToClick(selectors.ticketSales.moreMenuUpdateDiscount);
-        await page.waitForSelector(selectors.ticketSales.moreMenuUpdateDiscountInput);
-        await page.type(selectors.ticketSales.moreMenuUpdateDiscountInput, '100');
-        await page.keyboard.press('Enter');
-        await page.waitForTextInElement(selectors.ticketSales.totalImport, '0.00');
-        const result = await page.waitToGetProperty(selectors.ticketSales.totalImport, 'innerText');
-
-        expect(result).toContain('0.00');
-    });
-
     it('should log in as Production role and go to a target ticket summary', async() => {
         await page.loginAndModule('production', 'ticket');
         await page.accessToSearchResult('13');

e2e/paths/05-ticket/04_packages.spec.js

@@ -1,6 +1,13 @@
-import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    firstPackage: 'vn-autocomplete[label="Package"]',
+    firstQuantity: 'vn-ticket-package vn-horizontal:nth-child(1) vn-input-number[ng-model="package.quantity"]',
+    firstRemovePackageButton: 'vn-icon-button[vn-tooltip="Remove package"]',
+    addPackageButton: 'vn-icon-button[vn-tooltip="Add package"]',
+    savePackagesButton: `button[type=submit]`
+};
+
 describe('Ticket Create packages path', () => {
     let browser;
     let page;
@@ -18,19 +25,19 @@ describe('Ticket Create packages path', () => {
     });
 
     it(`should attempt create a new package but receive an error if package is blank`, async() => {
-        await page.waitToClick(selectors.ticketPackages.firstRemovePackageButton);
-        await page.waitToClick(selectors.ticketPackages.addPackageButton);
-        await page.write(selectors.ticketPackages.firstQuantity, '99');
-        await page.waitToClick(selectors.ticketPackages.savePackagesButton);
+        await page.waitToClick($.firstRemovePackageButton);
+        await page.waitToClick($.addPackageButton);
+        await page.write($.firstQuantity, '99');
+        await page.waitToClick($.savePackagesButton);
         const message = await page.waitForSnackbar();
 
         expect(message.text).toContain('Package cannot be blank');
     });
 
     it(`should delete the first package and receive and error to save a new one with blank quantity`, async() => {
-        await page.clearInput(selectors.ticketPackages.firstQuantity);
-        await page.autocompleteSearch(selectors.ticketPackages.firstPackage, 'Container medical box 1m');
-        await page.waitToClick(selectors.ticketPackages.savePackagesButton);
+        await page.clearInput($.firstQuantity);
+        await page.autocompleteSearch($.firstPackage, 'Container medical box 1m');
+        await page.waitToClick($.savePackagesButton);
         const message = await page.waitForSnackbar();
 
         expect(message.text).toContain('Some fields are invalid');
@@ -40,15 +47,15 @@ describe('Ticket Create packages path', () => {
         const result = await page
             .evaluate(selector => {
                 return document.querySelector(`${selector} input`).checkValidity();
-            }, selectors.ticketPackages.firstQuantity);
+            }, $.firstQuantity);
 
         expect(result).toBeTruthy();
     });
 
     it(`should create a new package with correct data`, async() => {
-        await page.clearInput(selectors.ticketPackages.firstQuantity);
-        await page.write(selectors.ticketPackages.firstQuantity, '-99');
-        await page.waitToClick(selectors.ticketPackages.savePackagesButton);
+        await page.clearInput($.firstQuantity);
+        await page.write($.firstQuantity, '-99');
+        await page.waitToClick($.savePackagesButton);
         const message = await page.waitForSnackbar();
 
         expect(message.text).toContain('Data saved!');
@@ -56,15 +63,15 @@ describe('Ticket Create packages path', () => {
 
     it(`should confirm the first select is the expected one`, async() => {
         await page.reloadSection('ticket.card.package');
-        await page.waitForTextInField(selectors.ticketPackages.firstPackage, 'Container medical box 1m');
-        const result = await page.waitToGetProperty(selectors.ticketPackages.firstPackage, 'value');
+        await page.waitForTextInField($.firstPackage, 'Container medical box 1m');
+        const result = await page.waitToGetProperty($.firstPackage, 'value');
 
-        expect(result).toEqual('7 : Container medical box 1m');
+        expect(result).toEqual('Container medical box 1m');
     });
 
     it(`should confirm quantity is just a number and the string part was ignored by the imput number`, async() => {
-        await page.waitForTextInField(selectors.ticketPackages.firstQuantity, '-99');
-        const result = await page.waitToGetProperty(selectors.ticketPackages.firstQuantity, 'value');
+        await page.waitForTextInField($.firstQuantity, '-99');
+        const result = await page.waitToGetProperty($.firstQuantity, 'value');
 
         expect(result).toEqual('-99');
     });

e2e/paths/05-ticket/15_create_ticket_from_client.spec.js

@@ -1,6 +1,11 @@
-import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    form: 'vn-ticket-create-card',
+    moreMenu: 'vn-client-descriptor vn-icon-button[icon=more_vert]',
+    simpleTicketButton: '.vn-menu [name="simpleTicket"]'
+};
+
 describe('Ticket create from client path', () => {
     let browser;
     let page;
@@ -16,20 +21,17 @@ describe('Ticket create from client path', () => {
         await browser.close();
     });
 
-    it('should click the create simple ticket on the descriptor menu', async() => {
-        await page.waitToClick(selectors.clientDescriptor.moreMenu);
-        await page.waitToClick(selectors.clientDescriptor.simpleTicketButton);
+    it('should create simple ticket and check if the client details are the expected ones', async() => {
+        await page.waitToClick($.moreMenu);
+        await page.waitToClick($.simpleTicketButton);
         await page.waitForState('ticket.create');
-    });
 
-    it('should check if the client details are the expected ones', async() => {
-        const client = await page
-            .waitToGetProperty(selectors.createTicketView.client, 'value');
+        const values = {
+            client: 'Petter Parker',
+            address: 'Petter Parker'
+        };
+        const formValues = await page.fetchForm($.form, Object.keys(values));
 
-        const address = await page
-            .waitToGetProperty(selectors.createTicketView.address, 'value');
-
-        expect(client).toContain('Petter Parker');
-        expect(address).toContain('20 Ingram Street');
+        expect(formValues).toEqual(values);
     });
 });

e2e/paths/05-ticket/18_index_payout.spec.js

@@ -1,5 +1,10 @@
 import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
+const $ = {
+    newPayment: '.vn-dialog.shown',
+    anyBalanceLine: 'vn-client-balance-index vn-tbody > vn-tr',
+    firstLineReference: 'vn-client-balance-index vn-tbody > vn-tr:nth-child(1) > vn-td-editable'
+};
 
 describe('Ticket index payout path', () => {
     let browser;
@@ -8,17 +13,14 @@ describe('Ticket index payout path', () => {
     beforeAll(async() => {
         browser = await getBrowser();
         page = browser.page;
+        await page.loginAndModule('administrative', 'ticket');
+        await page.waitForState('ticket.index');
     });
 
     afterAll(async() => {
         await browser.close();
     });
 
-    it('should navigate to the ticket index', async() => {
-        await page.loginAndModule('administrative', 'ticket');
-        await page.waitForState('ticket.index');
-    });
-
     it('should check the second ticket from a client and 1 of another', async() => {
         await page.waitToClick(selectors.globalItems.searchButton);
         await page.waitToClick(selectors.ticketsIndex.thirdTicketCheckbox);
@@ -42,27 +44,27 @@ describe('Ticket index payout path', () => {
         await page.waitForSelector(selectors.ticketsIndex.payoutCompany);
     });
 
-    it('should fill the company and bank to perform a payout', async() => {
-        await page.autocompleteSearch(selectors.ticketsIndex.payoutCompany, 'VNL');
-        await page.autocompleteSearch(selectors.ticketsIndex.payoutBank, 'cash');
-        await page.write(selectors.clientBalance.newPaymentAmount, '100');
-        await page.write(selectors.ticketsIndex.payoutDescription, 'Payment');
-        await page.waitToClick(selectors.ticketsIndex.submitPayout);
+    it('should fill the company and bank to perform a payout  and check a new balance line was entered', async() => {
+        await page.fillForm($.newPayment, {
+            company: 'VNL',
+            bank: 'cash',
+            amountPaid: 100,
+            description: 'Payment',
+            viewReceipt: false
+        });
+        await page.respondToDialog('accept');
         const message = await page.waitForSnackbar();
 
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should navigate to the client balance section and check a new balance line was entered', async() => {
         await page.waitToClick(selectors.globalItems.homeButton);
         await page.selectModule('client');
         await page.accessToSearchResult('1101');
         await page.accessToSection('client.card.balance.index');
-        await page.waitForSelector(selectors.clientBalance.anyBalanceLine);
-        const count = await page.countElement(selectors.clientBalance.anyBalanceLine);
-        const reference = await page.waitToGetProperty(selectors.clientBalance.firstLineReference, 'innerText');
+        await page.waitForSelector($.anyBalanceLine);
+        const count = await page.countElement($.anyBalanceLine);
+        const reference = await page.innerText($.firstLineReference);
 
+        expect(message.isSuccess).toBeTrue();
         expect(count).toEqual(4);
-        expect(reference).toContain('Cash, Albaran: 7, 8Payment');
+        expect(reference).toContain('Payment');
     });
 });

e2e/paths/05-ticket/21_future.spec.js

@@ -1,7 +1,8 @@
 import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
-describe('Ticket Future path', () => {
+// 'https:// redmine.verdnatura.es/issues/5642'
+xdescribe('Ticket Future path', () => {
     let browser;
     let page;
     let httpRequest;
@@ -44,94 +45,67 @@ describe('Ticket Future path', () => {
         expect(message.text).toContain('originDated is a required argument');
     });
 
-    it('should search with the required data', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.waitToClick(selectors.ticketFuture.submit);
+    // it('should search with the required data', async() => {
+    //     await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
+    //     await page.waitToClick(selectors.ticketFuture.submit);
 
-        expect(httpRequest).toBeDefined();
-    });
-
-    it('should search with the origin IPT', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-
-        await page.autocompleteSearch(selectors.ticketFuture.ipt, 'H');
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toContain('ipt=H');
-    });
-
-    it('should search with the destination IPT', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-
-        await page.clearInput(selectors.ticketFuture.ipt);
-
-        await page.autocompleteSearch(selectors.ticketFuture.futureIpt, 'H');
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toContain('futureIpt=H');
-    });
-
-    it('should search with the origin grouped state', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-
-        await page.clearInput(selectors.ticketFuture.futureIpt);
-
-        await page.autocompleteSearch(selectors.ticketFuture.state, 'Free');
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toContain('state=FREE');
-    });
-
-    it('should search with the destination grouped state', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-
-        await page.clearInput(selectors.ticketFuture.state);
-
-        await page.autocompleteSearch(selectors.ticketFuture.futureState, 'Free');
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toContain('futureState=FREE');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.futureState);
-        await page.waitToClick(selectors.ticketFuture.submit);
-    });
-
-    it('should search in smart-table with an ID Origin', async() => {
-        await page.waitToClick(selectors.ticketFuture.tableButtonSearch);
-        await page.write(selectors.ticketFuture.tableId, '1');
-        await page.keyboard.press('Enter');
-
-        expect(httpRequest).toContain('id');
-        await page.waitToClick(selectors.ticketFuture.tableButtonSearch);
-    });
-
-    it('should search in smart-table with an IPT Destination', async() => {
-        await page.waitToClick(selectors.ticketFuture.tableButtonSearch);
-        await page.autocompleteSearch(selectors.ticketFuture.tableFutureIpt, 'H');
-
-        expect(httpRequest).toContain('futureIpt');
-        await page.waitToClick(selectors.ticketFuture.tableButtonSearch);
-    });
-
-    it('should search in smart-table with an ID Destination', async() => {
-        await page.waitToClick(selectors.ticketFuture.tableButtonSearch);
-        await page.write(selectors.ticketFuture.tableFutureId, '1');
-        await page.keyboard.press('Enter');
-
-        expect(httpRequest).toContain('futureId');
-        await page.waitToClick(selectors.ticketFuture.tableButtonSearch);
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.waitToClick(selectors.ticketFuture.submit);
-    });
-
-    it('should check the three last tickets and move to the future', async() => {
-        await page.waitToClick(selectors.ticketFuture.multiCheck);
-        await page.waitToClick(selectors.ticketFuture.firstCheck);
-        await page.waitToClick(selectors.ticketFuture.moveButton);
-        await page.waitToClick(selectors.ticketFuture.acceptButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Tickets moved successfully!');
-    });
+    //     expect(httpRequest).toBeDefined();
+    // });
+
+    // it('should search with the origin IPT', async() => {
+    //     await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
+
+    //     await page.autocompleteSearch(selectors.ticketFuture.ipt, 'H');
+    //     await page.waitToClick(selectors.ticketFuture.submit);
+
+    //     expect(httpRequest).toContain('ipt=H');
+    // });
+
+    // it('should search with the destination IPT', async() => {
+    //     await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
+
+    //     await page.clearInput(selectors.ticketFuture.ipt);
+
+    //     await page.autocompleteSearch(selectors.ticketFuture.futureIpt, 'H');
+    //     await page.waitToClick(selectors.ticketFuture.submit);
+
+    //     expect(httpRequest).toContain('futureIpt=H');
+    // });
+
+    // it('should search with the origin grouped state', async() => {
+    //     await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
+
+    //     await page.clearInput(selectors.ticketFuture.futureIpt);
+
+    //     await page.autocompleteSearch(selectors.ticketFuture.state, 'Free');
+    //     await page.waitToClick(selectors.ticketFuture.submit);
+
+    //     expect(httpRequest).toContain('state=FREE');
+    // });
+
+    // it('should search with the destination grouped state', async() => {
+    //     await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
+
+    //     await page.clearInput(selectors.ticketFuture.state);
+
+    //     await page.autocompleteSearch(selectors.ticketFuture.futureState, 'Free');
+    //     await page.waitToClick(selectors.ticketFuture.submit);
+
+    //     expect(httpRequest).toContain('futureState=FREE');
+
+    //     await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
+    //     await page.clearInput(selectors.ticketFuture.futureState);
+    //     await page.waitToClick(selectors.ticketFuture.submit);
+    // });
+
+    // it('should check the three last tickets and move to the future', async() => {
+    //     await page.waitForNumberOfElements(selectors.ticketFuture.searchResult, 4);
+    //     await page.waitToClick(selectors.ticketFuture.multiCheck);
+    //     await page.waitToClick(selectors.ticketFuture.firstCheck);
+    //     await page.waitToClick(selectors.ticketFuture.moveButton);
+    //     await page.waitToClick(selectors.globalItems.acceptButton);
+    //     const message = await page.waitForSnackbar();
+
+    //     expect(message.text).toContain('Tickets moved successfully!');
+    // });
 });

e2e/paths/05-ticket/22_advance.spec.js

@@ -1,7 +1,8 @@
 import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
-describe('Ticket Advance path', () => {
+// 'https:// redmine.verdnatura.es/issues/5642'
+xdescribe('Ticket Advance path', () => {
     let browser;
     let page;
     let httpRequest;
@@ -45,65 +46,43 @@ describe('Ticket Advance path', () => {
         expect(message.text).toContain('dateFuture is a required argument');
     });
 
-    it('should search with the required data', async() => {
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.waitToClick(selectors.ticketAdvance.submit);
+    // it('should search with the required data', async() => {
+    //     await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
+    //     await page.waitToClick(selectors.ticketAdvance.submit);
 
-        expect(httpRequest).toBeDefined();
-    });
-
-    it('should search with the origin IPT', async() => {
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.autocompleteSearch(selectors.ticketAdvance.futureIpt, 'H');
-        await page.waitToClick(selectors.ticketAdvance.submit);
-
-        expect(httpRequest).toContain('futureIpt=H');
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketAdvance.futureIpt);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-    });
-
-    it('should search with the destination IPT', async() => {
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.autocompleteSearch(selectors.ticketAdvance.ipt, 'H');
-        await page.waitToClick(selectors.ticketAdvance.submit);
-
-        expect(httpRequest).toContain('ipt=H');
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketAdvance.ipt);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-    });
-
-    it('should search in smart-table with an IPT Origin', async() => {
-        await page.waitToClick(selectors.ticketAdvance.tableButtonSearch);
-        await page.autocompleteSearch(selectors.ticketAdvance.tableFutureIpt, 'V');
-
-        expect(httpRequest).toContain('futureIpt');
-
-        await page.waitToClick(selectors.ticketAdvance.tableButtonSearch);
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-    });
-
-    it('should search in smart-table with an IPT Destination', async() => {
-        await page.waitToClick(selectors.ticketAdvance.tableButtonSearch);
-        await page.autocompleteSearch(selectors.ticketAdvance.tableIpt, 'V');
-
-        expect(httpRequest).toContain('ipt');
-
-        await page.waitToClick(selectors.ticketAdvance.tableButtonSearch);
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-    });
-
-    it('should check the first ticket and move to the present', async() => {
-        await page.waitToClick(selectors.ticketAdvance.firstCheck);
-        await page.waitToClick(selectors.ticketAdvance.moveButton);
-        await page.waitToClick(selectors.ticketAdvance.acceptButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Tickets moved successfully!');
-    });
+    //     expect(httpRequest).toBeDefined();
+    // });
+
+    // it('should search with the origin IPT', async() => {
+    //     await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
+    //     await page.autocompleteSearch(selectors.ticketAdvance.futureIpt, 'H');
+    //     await page.waitToClick(selectors.ticketAdvance.submit);
+
+    //     expect(httpRequest).toContain('futureIpt=H');
+
+    //     await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
+    //     await page.clearInput(selectors.ticketAdvance.futureIpt);
+    //     await page.waitToClick(selectors.ticketAdvance.submit);
+    // });
+
+    // it('should search with the destination IPT', async() => {
+    //     await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
+    //     await page.autocompleteSearch(selectors.ticketAdvance.ipt, 'H');
+    //     await page.waitToClick(selectors.ticketAdvance.submit);
+
+    //     expect(httpRequest).toContain('ipt=H');
+
+    //     await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
+    //     await page.clearInput(selectors.ticketAdvance.ipt);
+    //     await page.waitToClick(selectors.ticketAdvance.submit);
+    // });
+
+    // it('should check the first ticket and move to the present', async() => {
+    //     await page.waitToClick(selectors.ticketAdvance.firstCheck);
+    //     await page.waitToClick(selectors.ticketAdvance.moveButton);
+    //     await page.waitToClick(selectors.ticketAdvance.acceptButton);
+    //     const message = await page.waitForSnackbar();
+
+    //     expect(message.text).toContain('Tickets moved successfully!');
+    // });
 });

e2e/paths/07-order/01_summary.spec.js

@@ -1,6 +1,15 @@
-import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    id: 'vn-order-summary vn-one:nth-child(1) > vn-label-value:nth-child(1) span',
+    alias: 'vn-order-summary vn-one:nth-child(1) > vn-label-value:nth-child(2) span',
+    consignee: 'vn-order-summary vn-one:nth-child(2) > vn-label-value:nth-child(6) span',
+    subtotal: 'vn-order-summary vn-one.taxes > p:nth-child(1)',
+    vat: 'vn-order-summary vn-one.taxes > p:nth-child(2)',
+    total: 'vn-order-summary vn-one.taxes > p:nth-child(3)',
+    sale: 'vn-order-summary vn-tbody > vn-tr',
+};
+
 describe('Order summary path', () => {
     let browser;
     let page;
@@ -15,49 +24,23 @@ describe('Order summary path', () => {
         await browser.close();
     });
 
-    it('should reach the order summary section', async() => {
+    it('should reach the order summary section and check data', async() => {
         await page.waitForState('order.card.summary');
-    });
 
-    it('should check the summary contains the order id', async() => {
-        const result = await page.waitToGetProperty(selectors.orderSummary.id, 'innerText');
+        const id = await page.innerText($.id);
+        const alias = await page.innerText($.alias);
+        const consignee = await page.innerText($.consignee);
+        const subtotal = await page.innerText($.subtotal);
+        const vat = await page.innerText($.vat);
+        const total = await page.innerText($.total);
+        const sale = await page.countElement($.sale);
 
-        expect(result).toEqual('16');
-    });
-
-    it('should check the summary contains the order alias', async() => {
-        const result = await page.waitToGetProperty(selectors.orderSummary.alias, 'innerText');
-
-        expect(result).toEqual('Many places');
-    });
-
-    it('should check the summary contains the order consignee', async() => {
-        const result = await page.waitToGetProperty(selectors.orderSummary.consignee, 'innerText');
-
-        expect(result).toEqual('address 26 - Gotham (Province one)');
-    });
-
-    it('should check the summary contains the order subtotal', async() => {
-        const result = await page.waitToGetProperty(selectors.orderSummary.subtotal, 'innerText');
-
-        expect(result.length).toBeGreaterThan(1);
-    });
-
-    it('should check the summary contains the order vat', async() => {
-        const result = await page.waitToGetProperty(selectors.orderSummary.vat, 'innerText');
-
-        expect(result.length).toBeGreaterThan(1);
-    });
-
-    it('should check the summary contains the order total', async() => {
-        const result = await page.waitToGetProperty(selectors.orderSummary.total, 'innerText');
-
-        expect(result.length).toBeGreaterThan(1);
-    });
-
-    it('should check the summary contains the order sales', async() => {
-        const result = await page.countElement(selectors.orderSummary.sale);
-
-        expect(result).toBeGreaterThan(0);
+        expect(id).toEqual('16');
+        expect(alias).toEqual('Many places');
+        expect(consignee).toEqual('address 26 - Gotham (Province one)');
+        expect(subtotal.length).toBeGreaterThan(1);
+        expect(vat.length).toBeGreaterThan(1);
+        expect(total.length).toBeGreaterThan(1);
+        expect(sale).toBeGreaterThan(0);
     });
 });

e2e/paths/07-order/02_basic_data.spec.js

@@ -1,6 +1,13 @@
 import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    form: 'vn-order-basic-data form',
+    observation: 'vn-order-basic-data form [vn-name="note"]',
+    saveButton: `vn-order-basic-data form button[type=submit]`,
+    acceptButton: '.vn-confirm.shown button[response="accept"]'
+};
+
 describe('Order edit basic data path', () => {
     let browser;
     let page;
@@ -20,90 +27,43 @@ describe('Order edit basic data path', () => {
 
     describe('when confirmed order', () => {
         it('should not be able to change the client', async() => {
-            await page.autocompleteSearch(selectors.orderBasicData.client, 'Tony Stark');
-            await page.autocompleteSearch(selectors.orderBasicData.address, 'Tony Stark');
-            await page.waitToClick(selectors.orderBasicData.saveButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain(`You can't make changes on the basic data of an confirmed order or with rows`);
-        });
+            const message = await page.sendForm($.form, {
+                client: 'Tony Stark',
+                address: 'Tony Stark',
             });
 
-    describe('when order with rows', () => {
-        it('should now navigate to order index', async() => {
-            const orderId = '16';
-
-            await page.waitToClick(selectors.orderDescriptor.returnToModuleIndexButton);
-            await page.waitToClick(selectors.globalItems.acceptButton);
-            await page.waitForContentLoaded();
-            await page.accessToSearchResult(orderId);
-            await page.accessToSection('order.card.basicData');
-            await page.waitForSelector(selectors.orderBasicData.observation, {visible: true});
-            await page.waitForState('order.card.basicData');
-        });
-
-        it('should not be able to change anything', async() => {
-            await page.write(selectors.orderBasicData.observation, 'observation');
-            await page.waitToClick(selectors.orderBasicData.saveButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain(`You can't make changes on the basic data of an confirmed order or with rows`);
+            expect(message.text).toContain(`You can't make changes on the basic data`);
         });
     });
 
     describe('when new order', () => {
-        it('should navigate to the order index and click the new order button', async() => {
+        it('should create an order and edit its basic data', async() => {
             await page.waitToClick(selectors.globalItems.returnToModuleIndexButton);
-            await page.waitToClick(selectors.orderBasicData.acceptButton);
+            await page.waitToClick($.acceptButton);
             await page.waitForContentLoaded();
             await page.waitToClick(selectors.ordersIndex.createOrderButton);
             await page.waitForState('order.create');
-        });
 
-        it('should now create a new one', async() => {
             await page.autocompleteSearch(selectors.createOrderView.client, 'Jessica Jones');
             await page.pickDate(selectors.createOrderView.landedDatePicker);
             await page.autocompleteSearch(selectors.createOrderView.agency, 'Other agency');
             await page.waitToClick(selectors.createOrderView.createButton);
             await page.waitForState('order.card.catalog');
-        });
 
-        it('should navigate to the basic data section of the new order', async() => {
             await page.accessToSection('order.card.basicData');
-            await page.waitForState('order.card.basicData');
-        });
 
-        it('should be able to modify all the properties', async() => {
-            await page.autocompleteSearch(selectors.orderBasicData.client, 'Tony Stark');
-            await page.autocompleteSearch(selectors.orderBasicData.address, 'Tony Stark');
-            await page.autocompleteSearch(selectors.orderBasicData.agency, 'Other agency');
-            await page.write(selectors.orderBasicData.observation, 'my observation');
-            await page.waitToClick(selectors.orderBasicData.saveButton);
-            const message = await page.waitForSnackbar();
+            const values = {
+                client: 'Tony Stark',
+                address: 'Tony Stark',
+                agencyMode: 'Other agency'
+            };
 
-            expect(message.text).toContain('Data saved!');
-        });
-
-        it('should now confirm the client have been edited', async() => {
+            const message = await page.sendForm($.form, values);
             await page.reloadSection('order.card.basicData');
-            const result = await page
-                .waitToGetProperty(selectors.orderBasicData.client, 'value');
+            const formValues = await page.fetchForm($.form, Object.keys(values));
 
-            expect(result).toEqual('1104: Tony Stark');
-        });
-
-        it('should now confirm the agency have been edited', async() => {
-            const result = await page
-                .waitToGetProperty(selectors.orderBasicData.agency, 'value');
-
-            expect(result).toEqual('Other agency');
-        });
-
-        it('should now confirm the observations have been edited', async() => {
-            const result = await page
-                .waitToGetProperty(selectors.orderBasicData.observation, 'value');
-
-            expect(result).toEqual('my observation');
+            expect(message.isSuccess).toBeTrue();
+            expect(formValues).toEqual(values);
         });
     });
 });

e2e/paths/08-route/02_basic_data.spec.js

@@ -1,4 +1,3 @@
-import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
 describe('Route basic Data path', () => {
@@ -17,47 +16,27 @@ describe('Route basic Data path', () => {
         await browser.close();
     });
 
-    it('should edit the route basic data', async() => {
+    it('should edit the route basic data and confirm the route was edited', async() => {
         const nextMonth = Date.vnNew();
         nextMonth.setMonth(nextMonth.getMonth() + 1);
+        nextMonth.setUTCHours(0, 0, 0, 0);
 
-        await page.autocompleteSearch(selectors.routeBasicData.worker, 'adminBossNick');
-        await page.autocompleteSearch(selectors.routeBasicData.vehicle, '1111-IMK');
-        await page.pickDate(selectors.routeBasicData.createdDate, nextMonth);
-        await page.clearInput(selectors.routeBasicData.kmStart);
-        await page.write(selectors.routeBasicData.kmStart, '1');
-        await page.clearInput(selectors.routeBasicData.kmEnd);
-        await page.write(selectors.routeBasicData.kmEnd, '2');
-        await page.type(`${selectors.routeBasicData.startedHour} input`, '0800');
-        await page.type(`${selectors.routeBasicData.finishedHour} input`, '1230');
-        await page.waitToClick(selectors.routeBasicData.saveButton);
-        const message = await page.waitForSnackbar();
+        const form = 'vn-route-basic-data form';
+        const values = {
+            worker: 'adminBossNick',
+            vehicle: '1111-IMK',
+            created: nextMonth,
+            kmStart: 1,
+            kmEnd: 2,
+            started: '08:00',
+            finished: '12:30',
+        };
 
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should confirm the worker was edited', async() => {
+        const message = await page.sendForm(form, values);
         await page.reloadSection('route.card.basicData');
-        const worker = await page.waitToGetProperty(selectors.routeBasicData.worker, 'value');
+        const formValues = await page.fetchForm(form, Object.keys(values));
 
-        expect(worker).toEqual('adminBoss - adminBossNick');
-    });
-
-    it('should confirm the vehicle was edited', async() => {
-        const vehicle = await page.waitToGetProperty(selectors.routeBasicData.vehicle, 'value');
-
-        expect(vehicle).toEqual('1111-IMK');
-    });
-
-    it('should confirm the km start was edited', async() => {
-        const kmStart = await page.waitToGetProperty(selectors.routeBasicData.kmStart, 'value');
-
-        expect(kmStart).toEqual('1');
-    });
-
-    it('should confirm the km end was edited', async() => {
-        const kmEnd = await page.waitToGetProperty(selectors.routeBasicData.kmEnd, 'value');
-
-        expect(kmEnd).toEqual('2');
+        expect(message.isSuccess).toBeTrue();
+        expect(formValues).toEqual(values);
     });
 });

e2e/paths/08-route/04_tickets.spec.js

@@ -57,11 +57,4 @@ describe('Route tickets path', () => {
     it('should now count how many tickets are in route to find one less', async() => {
         await page.waitForNumberOfElements(selectors.routeTickets.anyTicket, 0);
     });
-
-    // #2862 updateVolume() route descriptor no actualiza volumen
-    xit('should confirm the route volume on the descriptor has been updated by the changes made', async() => {
-        const result = await page.waitToGetProperty(selectors.routeDescriptor.volume, 'innerText');
-
-        expect(result).toEqual('0 / 50 m³');
-    });
 });

e2e/paths/09-invoice-in/04_tax.spec.js

@@ -17,55 +17,36 @@ describe('InvoiceIn tax path', () => {
         await browser.close();
     });
 
-    it('should add a new tax', async() => {
+    it('should add a new tax and check it', async() => {
         await page.waitToClick(selectors.invoiceInTax.addTaxButton);
         await page.autocompleteSearch(selectors.invoiceInTax.thirdExpense, '6210000567');
         await page.write(selectors.invoiceInTax.thirdTaxableBase, '100');
-        await page.autocompleteSearch(selectors.invoiceInTax.thirdTaxType, '6');
+        await page.autocompleteSearch(selectors.invoiceInTax.thirdTaxType, 'H.P. IVA');
         await page.autocompleteSearch(selectors.invoiceInTax.thirdTransactionType, 'Operaciones exentas');
         await page.waitToClick(selectors.invoiceInTax.saveButton);
         const message = await page.waitForSnackbar();
 
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should navigate to the summary and check the taxable base sum is correct', async() => {
         await page.waitToClick(selectors.invoiceInDescriptor.summaryIcon);
         await page.waitForState('invoiceIn.card.summary');
-        const result = await page.waitToGetProperty(selectors.invoiceInSummary.totalTaxableBase, 'innerText');
+        const total = await page.waitToGetProperty(selectors.invoiceInSummary.totalTaxableBase, 'innerText');
 
-        expect(result).toEqual('Taxable base €1,323.16');
-    });
-
-    it('should navigate back to tax section, check the reciently added line contains the expected expense', async() => {
         await page.accessToSection('invoiceIn.card.tax');
-        const result = await page.waitToGetProperty(selectors.invoiceInTax.thirdExpense, 'value');
 
-        expect(result).toEqual('6210000567: Alquiler VNH');
-    });
+        const thirdExpense = await page.waitToGetProperty(selectors.invoiceInTax.thirdExpense, 'value');
+        const thirdTaxableBase = await page.waitToGetProperty(selectors.invoiceInTax.thirdTaxableBase, 'value');
+        const thirdTaxType = await page.waitToGetProperty(selectors.invoiceInTax.thirdTaxType, 'value');
+        const thirdTransactionType = await page.waitToGetProperty(selectors.invoiceInTax.thirdTransactionType, 'value');
+        const thirdRate = await page.waitToGetProperty(selectors.invoiceInTax.thirdRate, 'value');
 
-    it('should check the reciently added line contains the expected taxable base', async() => {
-        const result = await page.waitToGetProperty(selectors.invoiceInTax.thirdTaxableBase, 'value');
+        expect(message.text).toContain('Data saved!');
 
-        expect(result).toEqual('100');
-    });
+        expect(total).toEqual('Taxable base €1,323.16');
 
-    it('should check the reciently added line contains the expected tax type', async() => {
-        const result = await page.waitToGetProperty(selectors.invoiceInTax.thirdTaxType, 'value');
-
-        expect(result).toEqual('6: H.P. IVA 4% CEE');
-    });
-
-    it('should check the reciently added line contains the expected transaction type', async() => {
-        const result = await page.waitToGetProperty(selectors.invoiceInTax.thirdTransactionType, 'value');
-
-        expect(result).toEqual('37: Operaciones exentas');
-    });
-
-    it('should check the reciently added line contains the expected rate', async() => {
-        const result = await page.waitToGetProperty(selectors.invoiceInTax.thirdRate, 'value');
-
-        expect(result).toEqual('€4.00');
+        expect(thirdExpense).toEqual('6210000567');
+        expect(thirdTaxableBase).toEqual('100');
+        expect(thirdTaxType).toEqual('H.P. IVA 4% CEE');
+        expect(thirdTransactionType).toEqual('Operaciones exentas');
+        expect(thirdRate).toEqual('€4.00');
     });
 
     it('should delete the added line', async() => {

e2e/paths/09-invoice-in/05_serial.spec.js

@@ -35,7 +35,7 @@ describe('InvoiceIn serial path', () => {
     });
 
     it('should go to index and check if the search-panel has the correct params', async() => {
-        await page.click(selectors.invoiceInSerial.goToIndex);
+        await page.waitToClick(selectors.invoiceInSerial.goToIndex);
         const params = await page.$$(selectors.invoiceInIndex.topbarSearchParams);
         const serial = await params[0].getProperty('title');
         const isBooked = await params[1].getProperty('title');

e2e/paths/09-invoice-out/03_manualInvoice.spec.js

@@ -15,49 +15,39 @@ describe('InvoiceOut manual invoice path', () => {
         await browser.close();
     });
 
-    it('should open the manual invoice form', async() => {
+    it('should create an invoice from a ticket', async() => {
         await page.waitToClick(selectors.invoiceOutIndex.createInvoice);
         await page.waitForSelector(selectors.invoiceOutIndex.manualInvoiceForm);
-    });
 
-    it('should create an invoice from a ticket', async() => {
         await page.autocompleteSearch(selectors.invoiceOutIndex.manualInvoiceTicket, '15');
         await page.autocompleteSearch(selectors.invoiceOutIndex.manualInvoiceSerial, 'Global nacional');
         await page.autocompleteSearch(selectors.invoiceOutIndex.manualInvoiceTaxArea, 'national');
         await page.waitToClick(selectors.invoiceOutIndex.saveInvoice);
         const message = await page.waitForSnackbar();
 
+        await page.waitForState('invoiceOut.card.summary');
+
         expect(message.text).toContain('Data saved!');
     });
 
-    it(`should have been redirected to the created invoice summary`, async() => {
-        await page.waitForState('invoiceOut.card.summary');
-    });
-
-    it(`should navigate back to the invoiceOut index`, async() => {
+    it(`should create another invoice from a client`, async() => {
         await page.waitToClick(selectors.globalItems.applicationsMenuButton);
         await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
         await page.waitToClick(selectors.globalItems.invoiceOutButton);
         await page.waitForSelector(selectors.invoiceOutIndex.topbarSearch);
         await page.waitForState('invoiceOut.index');
-    });
 
-    it('should now open the manual invoice form', async() => {
         await page.waitToClick(selectors.invoiceOutIndex.createInvoice);
         await page.waitForSelector(selectors.invoiceOutIndex.manualInvoiceForm);
-    });
 
-    it('should create an invoice from a client', async() => {
         await page.autocompleteSearch(selectors.invoiceOutIndex.manualInvoiceClient, 'Max Eisenhardt');
         await page.autocompleteSearch(selectors.invoiceOutIndex.manualInvoiceSerial, 'Global nacional');
         await page.autocompleteSearch(selectors.invoiceOutIndex.manualInvoiceTaxArea, 'national');
         await page.waitToClick(selectors.invoiceOutIndex.saveInvoice);
         const message = await page.waitForSnackbar();
 
+        await page.waitForState('invoiceOut.card.summary');
+
         expect(message.text).toContain('Data saved!');
     });
-
-    it(`should have been redirected to the created invoice summary`, async() => {
-        await page.waitForState('invoiceOut.card.summary');
-    });
 });

e2e/paths/09-invoice-out/04_globalInvoice.spec.js

@@ -18,7 +18,6 @@ describe('InvoiceOut global invoice path', () => {
     });
 
     let invoicesBeforeOneClient;
-    let invoicesBeforeAllClients;
     let now = Date.vnNew();
 
     it('should count the amount of invoices listed before globla invoces are made', async() => {
@@ -27,13 +26,10 @@ describe('InvoiceOut global invoice path', () => {
         expect(invoicesBeforeOneClient).toBeGreaterThanOrEqual(4);
     });
 
-    it('should open the global invoice form', async() => {
-        await page.accessToSection('invoiceOut.global-invoicing');
-    });
-
     it('should create a global invoice for charles xavier today', async() => {
+        await page.accessToSection('invoiceOut.global-invoicing');
         await page.waitToClick(selectors.invoiceOutGlobalInvoicing.oneClient);
-        await page.autocompleteSearch(selectors.invoiceOutGlobalInvoicing.clientId, '1108');
+        await page.autocompleteSearch(selectors.invoiceOutGlobalInvoicing.clientId, 'Charles Xavier');
         await page.pickDate(selectors.invoiceOutGlobalInvoicing.invoiceDate, now);
         await page.pickDate(selectors.invoiceOutGlobalInvoicing.maxShipped, now);
         await page.autocompleteSearch(selectors.invoiceOutGlobalInvoicing.printer, '1');

e2e/paths/09-invoice-out/05_negative_bases.spec.js

@@ -1,6 +1,6 @@
 import getBrowser from '../../helpers/puppeteer';
 
-describe('InvoiceIn negative bases path', () => {
+describe('InvoiceOut negative bases path', () => {
     let browser;
     let page;
     const httpRequests = [];
@@ -9,11 +9,11 @@ describe('InvoiceIn negative bases path', () => {
         browser = await getBrowser();
         page = browser.page;
         page.on('request', req => {
-            if (req.url().includes(`InvoiceIns/negativeBases`))
+            if (req.url().includes(`InvoiceOuts/negativeBases`))
                 httpRequests.push(req.url());
         });
-        await page.loginAndModule('administrative', 'invoiceIn');
-        await page.accessToSection('invoiceIn.negative-bases');
+        await page.loginAndModule('administrative', 'invoiceOut');
+        await page.accessToSection('invoiceOut.negative-bases');
     });
 
     afterAll(async() => {

e2e/paths/10-travel/01_create.spec.js

@@ -4,9 +4,6 @@ import getBrowser from '../../helpers/puppeteer';
 describe('Travel create path', () => {
     let browser;
     let page;
-    const date = Date.vnNew();
-    const day = 15;
-    date.setDate(day);
 
     beforeAll(async() => {
         browser = await getBrowser();
@@ -18,60 +15,28 @@ describe('Travel create path', () => {
         await browser.close();
     });
 
-    it('should open the create travel form by clicking on the "new" button', async() => {
+    it('should create a new travel and check it was created with the correct data', async() => {
+        const date = Date.vnNew();
+        date.setDate(15);
+        date.setUTCHours(0, 0, 0, 0);
+
         await page.waitToClick(selectors.travelIndex.newTravelButton);
         await page.waitForState('travel.create');
-    });
 
-    it('should fill the reference, agency and ship date then save the form', async() => {
-        await page.write(selectors.travelIndex.reference, 'Testing reference');
-        await page.autocompleteSearch(selectors.travelIndex.agency, 'inhouse pickup');
-        await page.pickDate(selectors.travelIndex.shipDate, date); // this line autocompletes another 3 fields
-        await page.waitForTimeout(1000);
-        await page.waitToClick(selectors.travelIndex.save);
+        const values = {
+            reference: 'Testing reference',
+            agencyMode: 'inhouse pickup',
+            shipped: date,
+            landed: date,
+            warehouseOut: 'Warehouse One',
+            warehouseIn: 'Warehouse Five'
+        };
 
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check the user was redirected to the travel basic data upon creation', async() => {
+        const message = await page.sendForm('vn-travel-create form', values);
         await page.waitForState('travel.card.basicData');
-    });
+        const formValues = await page.fetchForm('vn-travel-basic-data form', Object.keys(values));
 
-    it('should check the travel was created with the correct reference', async() => {
-        const reference = await page.waitToGetProperty(selectors.travelBasicData.reference, 'value');
-
-        expect(reference).toContain('Testing reference');
-    });
-
-    it('should check the travel was created with the correct agency', async() => {
-        const agency = await page.waitToGetProperty(selectors.travelBasicData.agency, 'value');
-
-        expect(agency).toContain('inhouse pickup');
-    });
-
-    it('should check the travel was created with the correct shiping date', async() => {
-        const shipDate = await page.waitToGetProperty(selectors.travelBasicData.shippedDate, 'value');
-
-        expect(shipDate).toContain(day);
-    });
-
-    it('should check the travel was created with the correct landing date', async() => {
-        const landingDate = await page.waitToGetProperty(selectors.travelBasicData.deliveryDate, 'value');
-
-        expect(landingDate).toContain(day);
-    });
-
-    it('should check the travel was created with the correct warehouseOut', async() => {
-        const warehouseOut = await page.waitToGetProperty(selectors.travelBasicData.outputWarehouse, 'value');
-
-        expect(warehouseOut).toContain('Warehouse One');
-    });
-
-    it('should check the travel was created with the correct warehouseIn', async() => {
-        const warehouseIn = await page.waitToGetProperty(selectors.travelBasicData.inputWarehouse, 'value');
-
-        expect(warehouseIn).toContain('Warehouse Five');
+        expect(message.isSuccess).toBeTrue();
+        expect(formValues).toEqual(values);
     });
 });

e2e/paths/12-entry/03_latestBuys.spec.js

@@ -42,20 +42,6 @@ describe('Entry lastest buys path', () => {
         expect(httpRequests.find(req => req.includes(('typeFk')))).toBeDefined();
     });
 
-    it('should filter by from date', async() => {
-        await page.pickDate(selectors.entryLatestBuys.fromInput, new Date());
-        await page.waitToClick(selectors.entryLatestBuys.chip);
-
-        expect(httpRequests.find(req => req.includes(('from')))).toBeDefined();
-    });
-
-    it('should filter by to date', async() => {
-        await page.pickDate(selectors.entryLatestBuys.toInput, new Date());
-        await page.waitToClick(selectors.entryLatestBuys.chip);
-
-        expect(httpRequests.find(req => req.includes(('to')))).toBeDefined();
-    });
-
     it('should filter by sales person', async() => {
         await page.autocompleteSearch(selectors.entryLatestBuys.salesPersonInput, 'buyerNick');
         await page.waitToClick(selectors.entryLatestBuys.chip);

e2e/paths/12-entry/04_create.spec.js

@@ -21,8 +21,8 @@ describe('Entry create path', () => {
     });
 
     it('should fill the form to create a valid entry then redirect to basic Data', async() => {
-        await page.autocompleteSearch(selectors.entryIndex.newEntrySupplier, '2');
-        await page.autocompleteSearch(selectors.entryIndex.newEntryTravel, 'Warehouse Three');
+        await page.autocompleteSearch(selectors.entryIndex.newEntrySupplier, 'The farmer');
+        await page.autocompleteSearch(selectors.entryIndex.newEntryTravel, 'Warehouse');
         await page.autocompleteSearch(selectors.entryIndex.newEntryCompany, 'ORN');
 
         await page.waitToClick(selectors.entryIndex.saveNewEntry);

e2e/paths/12-entry/05_basicData.spec.js

@@ -1,6 +1,22 @@
-import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
+const $ = {
+    reference: 'vn-entry-basic-data vn-textfield[ng-model="$ctrl.entry.reference"]',
+    invoiceNumber: 'vn-entry-basic-data vn-textfield[ng-model="$ctrl.entry.invoiceNumber"]',
+    notes: 'vn-entry-basic-data vn-textfield[ng-model="$ctrl.entry.notes"]',
+    observations: 'vn-entry-basic-data vn-textarea[ng-model="$ctrl.entry.observation"]',
+    supplier: 'vn-entry-basic-data vn-autocomplete[ng-model="$ctrl.entry.supplierFk"]',
+    currency: 'vn-entry-basic-data vn-autocomplete[ng-model="$ctrl.entry.currencyFk"]',
+    commission: 'vn-entry-basic-data vn-input-number[ng-model="$ctrl.entry.commission"]',
+    company: 'vn-entry-basic-data vn-autocomplete[ng-model="$ctrl.entry.companyFk"]',
+    ordered: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isOrdered"]',
+    confirmed: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isConfirmed"]',
+    inventory: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isExcludedFromAvailable"]',
+    raid: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isRaid"]',
+    booked: 'vn-entry-basic-data vn-check[ng-model="$ctrl.entry.isBooked"]',
+    save: 'vn-entry-basic-data button[type=submit]',
+};
+
 describe('Entry basic data path', () => {
     let browser;
     let page;
@@ -17,105 +33,49 @@ describe('Entry basic data path', () => {
         await browser.close();
     });
 
-    it('should edit the basic data', async() => {
-        await page.write(selectors.entryBasicData.reference, 'new movement 8');
-        await page.write(selectors.entryBasicData.invoiceNumber, 'new movement 8');
-        await page.write(selectors.entryBasicData.notes, 'new notes');
-        await page.write(selectors.entryBasicData.observations, ' edited');
-        await page.autocompleteSearch(selectors.entryBasicData.supplier, 'Plants nick');
-        await page.autocompleteSearch(selectors.entryBasicData.currency, 'eur');
-        await page.clearInput(selectors.entryBasicData.commission);
-        await page.write(selectors.entryBasicData.commission, '100');
-        await page.autocompleteSearch(selectors.entryBasicData.company, 'CCs');
-        await page.waitToClick(selectors.entryBasicData.ordered);
-        await page.waitToClick(selectors.entryBasicData.confirmed);
-        await page.waitToClick(selectors.entryBasicData.inventory);
-        await page.waitToClick(selectors.entryBasicData.raid);
-        await page.waitToClick(selectors.entryBasicData.booked);
-        await page.waitToClick(selectors.entryBasicData.save);
-
+    it('should edit the basic data and confirm the reference was edited', async() => {
+        await page.write($.reference, 'new movement 8');
+        await page.write($.invoiceNumber, 'new movement 8');
+        await page.write($.observations, ' edited');
+        await page.autocompleteSearch($.supplier, 'Plants nick');
+        await page.autocompleteSearch($.currency, 'eur');
+        await page.clearInput($.commission);
+        await page.write($.commission, '100');
+        await page.autocompleteSearch($.company, 'CCs');
+        await page.waitToClick($.ordered);
+        await page.waitToClick($.confirmed);
+        await page.waitToClick($.inventory);
+        await page.waitToClick($.raid);
+        await page.waitToClick($.booked);
+        await page.waitToClick($.save);
         const message = await page.waitForSnackbar();
 
+        await page.reloadSection('entry.card.basicData');
+        const reference = await page.waitToGetProperty($.reference, 'value');
+        const supplier = await page.waitToGetProperty($.supplier, 'value');
+        const invoiceNumber = await page.waitToGetProperty($.invoiceNumber, 'value');
+        const observations = await page.waitToGetProperty($.observations, 'value');
+        const currency = await page.waitToGetProperty($.currency, 'value');
+        const commission = await page.waitToGetProperty($.commission, 'value');
+        const company = await page.waitToGetProperty($.company, 'value');
+        const ordered = await page.checkboxState($.ordered);
+        const confirmed = await page.checkboxState($.confirmed);
+        const inventory = await page.checkboxState($.inventory);
+        const raid = await page.checkboxState($.raid);
+        const booked = await page.checkboxState($.booked);
+
         expect(message.text).toContain('Data saved!');
-    });
-
-    it('should confirm the reference was edited', async() => {
-        await page.reloadSection('entry.card.basicData');
-        const result = await page.waitToGetProperty(selectors.entryBasicData.reference, 'value');
-
-        expect(result).toEqual('new movement 8');
-    });
-
-    it('should confirm the invoiceNumber was edited', async() => {
-        await page.reloadSection('entry.card.basicData');
-        const result = await page.waitToGetProperty(selectors.entryBasicData.invoiceNumber, 'value');
-
-        expect(result).toEqual('new movement 8');
-    });
-
-    it('should confirm the note was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBasicData.notes, 'value');
-
-        expect(result).toEqual('new notes');
-    });
-
-    it('should confirm the observation was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBasicData.observations, 'value');
-
-        expect(result).toEqual('observation two edited');
-    });
-
-    it('should confirm the supplier was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBasicData.supplier, 'value');
-
-        expect(result).toEqual('1 - Plants nick');
-    });
-
-    it('should confirm the currency was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBasicData.currency, 'value');
-
-        expect(result).toEqual('EUR');
-    });
-
-    it('should confirm the commission was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBasicData.commission, 'value');
-
-        expect(result).toEqual('100');
-    });
-
-    it('should confirm the company was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBasicData.company, 'value');
-
-        expect(result).toEqual('CCs');
-    });
-
-    it('should confirm ordered was edited', async() => {
-        const result = await page.checkboxState(selectors.entryBasicData.ordered);
-
-        expect(result).toBe('checked');
-    });
-
-    it('should confirm confirmed was edited', async() => {
-        const result = await page.checkboxState(selectors.entryBasicData.confirmed);
-
-        expect(result).toBe('checked');
-    });
-
-    it('should confirm inventory was edited', async() => {
-        const result = await page.checkboxState(selectors.entryBasicData.inventory);
-
-        expect(result).toBe('checked');
-    });
-
-    it('should confirm raid was edited', async() => {
-        const result = await page.checkboxState(selectors.entryBasicData.raid);
-
-        expect(result).toBe('checked');
-    });
-
-    it('should confirm booked was edited', async() => {
-        const result = await page.checkboxState(selectors.entryBasicData.booked);
-
-        expect(result).toBe('checked');
+        expect(reference).toEqual('new movement 8');
+        expect(supplier).toEqual('Plants nick');
+        expect(invoiceNumber).toEqual('new movement 8');
+        expect(observations).toEqual('observation two edited');
+        expect(currency).toEqual('EUR');
+        expect(commission).toEqual('100');
+        expect(company).toEqual('CCs');
+        expect(ordered).toBe('checked');
+        expect(confirmed).toBe('checked');
+        expect(inventory).toBe('checked');
+        expect(raid).toBe('checked');
+        expect(booked).toBe('checked');
     });
 });

e2e/paths/12-entry/07_buys.spec.js

@@ -86,40 +86,47 @@ describe('Entry import, create and edit buys path', () => {
         await page.waitForNumberOfElements(selectors.entryBuys.anyBuyLine, 2);
     });
 
-    it('should edit the newest buy', async() => {
+    it('should edit the newest buy and check data', async() => {
         await page.clearInput(selectors.entryBuys.secondBuyPackingPrice);
         await page.waitForTimeout(250);
         await page.write(selectors.entryBuys.secondBuyPackingPrice, '100');
+        await page.keyboard.press('Enter');
         await page.waitForSnackbar();
 
         await page.clearInput(selectors.entryBuys.secondBuyGroupingPrice);
         await page.waitForTimeout(250);
         await page.write(selectors.entryBuys.secondBuyGroupingPrice, '200');
+        await page.keyboard.press('Enter');
         await page.waitForSnackbar();
 
         await page.clearInput(selectors.entryBuys.secondBuyPrice);
         await page.waitForTimeout(250);
         await page.write(selectors.entryBuys.secondBuyPrice, '300');
+        await page.keyboard.press('Enter');
         await page.waitForSnackbar();
 
         await page.clearInput(selectors.entryBuys.secondBuyGrouping);
         await page.waitForTimeout(250);
         await page.write(selectors.entryBuys.secondBuyGrouping, '400');
+        await page.keyboard.press('Enter');
         await page.waitForSnackbar();
 
         await page.clearInput(selectors.entryBuys.secondBuyPacking);
         await page.waitForTimeout(250);
         await page.write(selectors.entryBuys.secondBuyPacking, '500');
+        await page.keyboard.press('Enter');
         await page.waitForSnackbar();
 
         await page.clearInput(selectors.entryBuys.secondBuyWeight);
         await page.waitForTimeout(250);
         await page.write(selectors.entryBuys.secondBuyWeight, '600');
+        await page.keyboard.press('Enter');
         await page.waitForSnackbar();
 
         await page.clearInput(selectors.entryBuys.secondBuyStickers);
         await page.waitForTimeout(250);
         await page.write(selectors.entryBuys.secondBuyStickers, '700');
+        await page.keyboard.press('Enter');
         await page.waitForSnackbar();
 
         await page.autocompleteSearch(selectors.entryBuys.secondBuyPackage, '94');
@@ -128,60 +135,28 @@ describe('Entry import, create and edit buys path', () => {
         await page.clearInput(selectors.entryBuys.secondBuyQuantity);
         await page.waitForTimeout(250);
         await page.write(selectors.entryBuys.secondBuyQuantity, '800');
-    });
+        await page.keyboard.press('Enter');
 
-    it('should reload the section and check the packing price is as expected', async() => {
         await page.reloadSection('entry.card.buy.index');
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyPackingPrice, 'value');
 
-        expect(result).toEqual('100');
-    });
+        const secondBuyPackingPrice = await page.getValue(selectors.entryBuys.secondBuyPackingPrice);
+        const secondBuyGroupingPrice = await page.getValue(selectors.entryBuys.secondBuyGroupingPrice);
+        const secondBuyPrice = await page.getValue(selectors.entryBuys.secondBuyPrice);
+        const secondBuyGrouping = await page.getValue(selectors.entryBuys.secondBuyGrouping);
+        const secondBuyPacking = await page.getValue(selectors.entryBuys.secondBuyPacking);
+        const secondBuyWeight = await page.getValue(selectors.entryBuys.secondBuyWeight);
+        const secondBuyStickers = await page.getValue(selectors.entryBuys.secondBuyStickers);
+        const secondBuyPackage = await page.getValue(selectors.entryBuys.secondBuyPackage);
+        const secondBuyQuantity = await page.getValue(selectors.entryBuys.secondBuyQuantity);
 
-    it('should reload the section and check the grouping price is as expected', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyGroupingPrice, 'value');
-
-        expect(result).toEqual('200');
-    });
-
-    it('should reload the section and check the price is as expected', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyPrice, 'value');
-
-        expect(result).toEqual('300');
-    });
-
-    it('should reload the section and check the grouping is as expected', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyGrouping, 'value');
-
-        expect(result).toEqual('400');
-    });
-
-    it('should reload the section and check the packing is as expected', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyPacking, 'value');
-
-        expect(result).toEqual('500');
-    });
-
-    it('should reload the section and check the weight is as expected', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyWeight, 'value');
-
-        expect(result).toEqual('600');
-    });
-
-    it('should reload the section and check the stickers are as expected', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyStickers, 'value');
-
-        expect(result).toEqual('700');
-    });
-
-    it('should reload the section and check the package is as expected', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyPackage, 'value');
-
-        expect(result).toEqual('94');
-    });
-
-    it('should reload the section and check the quantity is as expected', async() => {
-        const result = await page.waitToGetProperty(selectors.entryBuys.secondBuyQuantity, 'value');
-
-        expect(result).toEqual('800');
+        expect(secondBuyPackingPrice).toEqual('100');
+        expect(secondBuyGroupingPrice).toEqual('200');
+        expect(secondBuyPrice).toEqual('300');
+        expect(secondBuyGrouping).toEqual('400');
+        expect(secondBuyPacking).toEqual('500');
+        expect(secondBuyWeight).toEqual('600');
+        expect(secondBuyStickers).toEqual('700');
+        expect(secondBuyPackage).toEqual('94');
+        expect(secondBuyQuantity).toEqual('800');
     });
 });

e2e/paths/13-supplier/03_fiscal_data.spec.js

@@ -1,4 +1,3 @@
-import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
 describe('Supplier fiscal data path', () => {
@@ -10,102 +9,48 @@ describe('Supplier fiscal data path', () => {
         page = browser.page;
         await page.loginAndModule('administrative', 'supplier');
         await page.accessToSearchResult('2');
-        await page.accessToSection('supplier.card.fiscalData');
     });
 
     afterAll(async() => {
         await browser.close();
     });
 
-    it('should attempt to edit the fiscal data but fail as the tax number is invalid', async() => {
-        await page.clearInput(selectors.supplierFiscalData.city);
-        await page.clearInput(selectors.supplierFiscalData.province);
-        await page.clearInput(selectors.supplierFiscalData.country);
-        await page.clearInput(selectors.supplierFiscalData.postCode);
-        await page.write(selectors.supplierFiscalData.city, 'Valencia');
-        await page.waitForTimeout(1000); // must repeat this action twice or fails. also #2699 may be a cool solution to this.
-        await page.clearInput(selectors.supplierFiscalData.city);
-        await page.write(selectors.supplierFiscalData.city, 'Valencia');
-        await page.clearInput(selectors.supplierFiscalData.socialName);
-        await page.write(selectors.supplierFiscalData.socialName, 'Farmer King SL');
-        await page.clearInput(selectors.supplierFiscalData.taxNumber);
-        await page.write(selectors.supplierFiscalData.taxNumber, 'Wrong tax number');
-        await page.clearInput(selectors.supplierFiscalData.account);
-        await page.write(selectors.supplierFiscalData.account, '0123456789');
-        await page.autocompleteSearch(selectors.supplierFiscalData.sageWihholding, 'retencion estimacion objetiva');
-        await page.autocompleteSearch(selectors.supplierFiscalData.sageTaxType, 'operaciones no sujetas');
+    it('should attempt to edit the fiscal data and check data is saved', async() => {
+        await page.accessToSection('supplier.card.fiscalData');
 
-        await page.waitToClick(selectors.supplierFiscalData.saveButton);
-        const message = await page.waitForSnackbar();
+        const form = 'vn-supplier-fiscal-data form';
+        const values = {
+            province: null,
+            country: null,
+            postcode: null,
+            city: 'Valencia',
+            socialName: 'Farmer King SL',
+            taxNumber: 'Wrong tax number',
+            account: '0123456789',
+            sageWithholding: 'retencion estimacion objetiva',
+            sageTaxType: 'operaciones no sujetas'
+        };
 
-        expect(message.text).toContain('Invalid Tax number');
+        const errorMessage = await page.sendForm(form, values);
+        const message = await page.sendForm(form, {
+            taxNumber: '12345678Z'
         });
 
-    it('should save the changes as the tax number is valid this time', async() => {
-        await page.clearInput(selectors.supplierFiscalData.taxNumber);
-        await page.write(selectors.supplierFiscalData.taxNumber, '12345678Z');
-
-        await page.waitToClick(selectors.supplierFiscalData.saveButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should reload the section', async() => {
         await page.reloadSection('supplier.card.fiscalData');
-    });
+        const formValues = await page.fetchForm(form, Object.keys(values));
 
-    it('should check the socialName was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.socialName, 'value');
-
-        expect(result).toEqual('Farmer King SL');
-    });
-
-    it('should check the taxNumber was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.taxNumber, 'value');
-
-        expect(result).toEqual('12345678Z');
-    });
-
-    it('should check the account was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.account, 'value');
-
-        expect(result).toEqual('0123456789');
-    });
-
-    it('should check the sageWihholding was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.sageWihholding, 'value');
-
-        expect(result).toEqual('RETENCION ESTIMACION OBJETIVA');
-    });
-
-    it('should check the sageTaxType was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.sageTaxType, 'value');
-
-        expect(result).toEqual('Operaciones no sujetas');
-    });
-
-    it('should check the postCode was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.postCode, 'value');
-
-        expect(result).toEqual('46000');
-    });
-
-    it('should check the city was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.city, 'value');
-
-        expect(result).toEqual('Valencia');
-    });
-
-    it('should check the province was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.province, 'value');
-
-        expect(result).toEqual('Province one (España)');
-    });
-
-    it('should check the country was edited', async() => {
-        const result = await page.waitToGetProperty(selectors.supplierFiscalData.country, 'value');
-
-        expect(result).toEqual('España');
+        expect(errorMessage.text).toContain('Invalid Tax number');
+        expect(message.isSuccess).toBeTrue();
+        expect(formValues).toEqual({
+            province: 'Province one',
+            country: 'España',
+            postcode: '46000',
+            city: 'Valencia',
+            socialName: 'Farmer King SL',
+            taxNumber: '12345678Z',
+            account: '0123456789',
+            sageWithholding: 'RETENCION ESTIMACION OBJETIVA',
+            sageTaxType: 'Operaciones no sujetas'
+        });
     });
 });

front/core/components/autocomplete/index.js

@@ -174,7 +174,6 @@ export default class Autocomplete extends Field {
 
     refreshDisplayed() {
         let display = '';
-        let hasTemplate = this.$transclude && this.$transclude.isSlotFilled('tplItem');
 
         if (this._selection && this.showField) {
             if (this.multiple && Array.isArray(this._selection)) {
@@ -182,19 +181,8 @@ export default class Autocomplete extends Field {
                     if (display.length > 0) display += ', ';
                     display += item[this.showField];
                 }
-            } else {
+            } else
                 display = this._selection[this.showField];
-                if (hasTemplate) {
-                    let template = this.$transclude(() => {}, null, 'tplItem');
-                    const element = template[0];
-                    const description = element.querySelector('.text-secondary');
-                    if (description) description.remove();
-
-                    const displayElement = angular.element(element);
-                    const displayText = displayElement.text();
-                    display = this.$interpolate(displayText)(this._selection);
-                }
-            }
         }
 
         this.input.value = display;

front/core/components/avatar/index.html

@@ -0,0 +1,5 @@
+<div class="letter">
+    {{::$ctrl.val && $ctrl.val.charAt(0).toUpperCase()}}
+</div>
+<div class="image" ng-transclude>
+</div>

front/core/components/avatar/index.js

@@ -0,0 +1,63 @@
+import ngModule from '../../module';
+import Component from 'core/lib/component';
+import './style.scss';
+
+/**
+ * Displays colored avatar based on value.
+ *
+ * @property {*} val The value
+ */
+export default class Avatar extends Component {
+    get val() {
+        return this._val;
+    }
+
+    set val(value) {
+        this._val = value;
+
+        const val = value || '';
+        let hash = 0;
+        for (let i = 0; i < val.length; i++)
+            hash += val.charCodeAt(i);
+        const color = '#' + colors[hash % colors.length];
+
+        const el = this.element;
+        el.style.backgroundColor = color;
+        el.title = val;
+    }
+}
+
+ngModule.vnComponent('vnAvatar', {
+    template: require('./index.html'),
+    controller: Avatar,
+    bindings: {
+        val: '@?'
+    },
+    transclude: true
+});
+
+const colors = [
+    'e2553d', // Coral
+    'FFA07A', // Salmon
+    'FFDAB9', // Peach
+    'a17077', // Pink
+    'bf0e99', // Pink light
+    '52a500', // Green chartreuse
+    '00aeae', // Cian
+    'b754cf', // Purple middle
+    '8a69cd', // Blue lavender
+    '1fa8a1', // Green ocean
+    'DC143C', // Red crimson
+    '5681cf', // Blue steel
+    'FF1493', // Ping intense
+    '02ba02', // Green lime
+    '1E90FF', // Blue sky
+    '8B008B', // Purple dark
+    'cc7000', // Orange bright
+    '00b5b8', // Turquoise
+    '8B0000', // Red dark
+    '008080', // Green bluish
+    '2F4F4F', // Gray board
+    '7e7e7e', // Gray
+    '5d5d5d', // Gray dark
+];

front/core/components/avatar/style.scss

@@ -0,0 +1,32 @@
+@import "variables";
+
+vn-avatar {
+    display: block;
+    border-radius: 50%;
+    overflow: hidden;
+    height: 36px;
+    width: 36px;
+    font-size: 22px;
+    background-color: $color-main;
+    position: relative;
+
+    & > * {
+        width: 100%;
+        height: 100%;
+    }
+    & > .letter {
+        display: flex;
+        align-items: center;
+        justify-content: center;
+    }
+    & > .image {
+        position: absolute;
+        top: 0;
+        left: 0;
+
+        & > img {
+            width: 100%;
+            height: 100%;
+        }
+    }
+}

front/core/components/field/index.js

@@ -20,7 +20,7 @@ export default class Field extends FormInput {
         super.$onInit();
 
         if (this.info) this.classList.add('has-icons');
-        this.input.addEventListener('change', event =>
+        this.element.addEventListener('change', event =>
             this.onChange(event));
     }
 
@@ -166,7 +166,7 @@ export default class Field extends FormInput {
         if (event.defaultPrevented) return;
         event.preventDefault();
         this.field = null;
-        this.input.dispatchEvent(new Event('change'));
+        this.element.dispatchEvent(new Event('change'));
     }
 
     buildInput(type) {

front/core/components/index.js

@@ -17,6 +17,7 @@ import './pagination/pagination';
 import './searchbar/searchbar';
 import './scroll-up/scroll-up';
 import './autocomplete';
+import './avatar';
 import './button';
 import './button-menu';
 import './calendar';
@@ -32,6 +33,7 @@ import './float-button';
 import './icon-menu';
 import './icon-button';
 import './input-number';
+import './json-value';
 import './label-value';
 import './range';
 import './input-time';

front/core/components/json-value/index.js

@@ -0,0 +1,73 @@
+import ngModule from '../../module';
+import Component from 'core/lib/component';
+import './style.scss';
+
+const maxStrLen = 50;
+
+/**
+ * Displays pretty JSON value.
+ *
+ * @property {*} value The value
+ */
+export default class Controller extends Component {
+    get value() {
+        return this._value;
+    }
+
+    set value(value) {
+        const wasEmpty = this._value === undefined;
+        this._value = value;
+
+        let text;
+        let cssClass;
+        const type = typeof value;
+
+        if (value == null) {
+            text = '∅';
+            cssClass = 'null';
+        } else {
+            cssClass = type;
+            switch (type) {
+            case 'boolean':
+                text = value ? '✓' : '✗';
+                cssClass = value ? 'true' : 'false';
+                break;
+            case 'string':
+                text = value.length <= maxStrLen
+                    ? value
+                    : value.substring(0, maxStrLen) + '...';
+                break;
+            case 'object':
+                if (value instanceof Date) {
+                    const hasZeroTime =
+                        value.getHours() === 0 &&
+                        value.getMinutes() === 0 &&
+                        value.getSeconds() === 0;
+                    const format = hasZeroTime ? 'dd/MM/yyyy' : 'dd/MM/yyyy HH:mm:ss';
+                    text = this.$filter('date')(value, format);
+                } else
+                    text = value;
+                break;
+            default:
+                text = value;
+            }
+        }
+
+        const el = this.element;
+        el.textContent = text;
+        el.title = type == 'string' && value.length > maxStrLen ? value : '';
+
+        cssClass = `json-${cssClass}`;
+        if (wasEmpty)
+            el.classList.add(cssClass);
+        else
+            el.classList.replace(this.className, cssClass);
+    }
+}
+
+ngModule.vnComponent('vnJsonValue', {
+    controller: Controller,
+    bindings: {
+        value: '<?'
+    }
+});

front/core/components/json-value/index.spec.js

@@ -0,0 +1,79 @@
+import './index';
+
+describe('Component vnJsonValue', () => {
+    let controller;
+    let $scope;
+    let $element;
+    let el;
+
+    beforeEach(ngModule('vnCore'));
+
+    beforeEach(inject(($componentController, $rootScope) => {
+        $scope = $rootScope.$new();
+        $element = angular.element('<vn-json-value></vn-json-value>');
+        controller = $componentController('vnJsonValue', {$element, $scope});
+        el = controller.element;
+    }));
+
+    describe('set value()', () => {
+        it('should display null symbol when value is null equivalent', () => {
+            controller.value = null;
+
+            expect(el.textContent).toEqual('∅');
+            expect(el.className).toContain('json-null');
+        });
+
+        it('should display ballot when value is false', () => {
+            controller.value = false;
+
+            expect(el.textContent).toEqual('✗');
+            expect(el.className).toContain('json-false');
+        });
+
+        it('should display check when value is true', () => {
+            controller.value = true;
+
+            expect(el.textContent).toEqual('✓');
+            expect(el.className).toContain('json-true');
+        });
+
+        it('should display string when value is an string', () => {
+            controller.value = 'Foo';
+
+            expect(el.textContent).toEqual('Foo');
+            expect(el.className).toContain('json-string');
+        });
+
+        it('should display only date when value is date with time set to zero', () => {
+            const date = Date.vnNew();
+            date.setHours(0, 0, 0, 0);
+            controller.value = date;
+
+            expect(el.textContent).toEqual('01/01/2001');
+            expect(el.className).toContain('json-object');
+        });
+
+        it('should display full date without time when value is date with time', () => {
+            const date = Date.vnNew();
+            date.setHours(15, 45);
+            controller.value = date;
+
+            expect(el.textContent).toEqual('01/01/2001 15:45:00');
+            expect(el.className).toContain('json-object');
+        });
+
+        it('should display object when value is an object', () => {
+            controller.value = {foo: 'bar'};
+
+            expect(el.textContent).toEqual('[object Object]');
+            expect(el.className).toContain('json-object');
+        });
+
+        it('should display number when value is a number', () => {
+            controller.value = 2050;
+
+            expect(el.textContent).toEqual('2050');
+            expect(el.className).toContain('json-number');
+        });
+    });
+});

front/core/components/json-value/style.scss

@@ -0,0 +1,23 @@
+vn-json-value {
+    display: inline;
+
+    &.json-string {
+        color: #d172cc;
+    }
+    &.json-object {
+        color: #d1a572;
+    }
+    &.json-number {
+        color: #85d0ff;
+    }
+    &.json-true {
+        color: #7dc489;
+    }
+    &.json-false {
+        color: #c74949;
+    }
+    &.json-null {
+        color: #cd7c7c;
+        font-style: italic;
+    }
+}

front/core/components/popover/index.spec.js

@@ -36,30 +36,6 @@ describe('Component vnPopover', () => {
 
             expect(controller.emit).not.toHaveBeenCalledWith('open');
         });
-
-        // #1615 migrar karma a jest (this doesn't work anymore, needs fixing)
-        xit(`should check that popover is visible into the screen`, () => {
-            $parent.css({
-                backgroundColor: 'red',
-                position: 'absolute',
-                width: '50px',
-                height: '50px',
-                top: '0',
-                left: '100px'
-            });
-            controller.show($parent[0]);
-
-            let rect = controller.popover.getBoundingClientRect();
-            let style = controller.window.getComputedStyle(controller.element);
-
-            expect(style.visibility).toEqual('visible');
-            expect(style.display).not.toEqual('none');
-
-            expect(0).toBeLessThanOrEqual(rect.top);
-            expect(0).toBeLessThanOrEqual(rect.left);
-            expect(controller.window.innerHeight).toBeGreaterThan(rect.bottom);
-            expect(controller.window.innerWidth).toBeGreaterThan(rect.right);
-        });
     });
 
     describe('hide()', () => {

front/core/components/table/style.scss

@@ -41,10 +41,15 @@ vn-table {
         display: table-row;
         height: 48px;
     }
-    vn-thead, .vn-thead,
-    vn-tbody, .vn-tbody,
-    vn-tfoot, .vn-tfoot,
-    thead, tbody, tfoot {
+    & > thead,
+    & > tbody,
+    & > tfoot,
+    & > vn-thead,
+    & > vn-tbody,
+    & > vn-tfoot,
+    & > .vn-thead,
+    & > .vn-tbody,
+    & > .vn-tfoot {
         & > * {
             display: table-row;
 
@@ -111,14 +116,14 @@ vn-table {
             color: inherit;
         }
     }
-    a.vn-tbody {
+    & > a.vn-tbody {
         &.clickable {
             @extend %clickable;
         }
     }
-    vn-tbody > *,
-    .vn-tbody > *,
-    tbody > * {
+    & > vn-tbody > *,
+    & > .vn-tbody > *,
+    & > tbody > * {
         border-bottom: $border-thin;
 
         &:last-child {

front/core/styles/variables.scss

@@ -2,7 +2,6 @@
 
 $font-size: 11pt;
 $menu-width: 256px;
-$right-menu-width: 318px;
 $topbar-height: 56px;
 $mobile-width: 800px;
 $float-spacing: 20px;

front/salix/components/layout/style.scss

@@ -88,13 +88,13 @@ vn-layout {
     }
     &.right-menu {
         & > vn-topbar > .end {
-            width: 80px + $right-menu-width;
+            width: 80px + $menu-width;
         }
         & > .main-view {
-            padding-right: $right-menu-width;
+            padding-right: $menu-width;
         }
         [fixed-bottom-right] {
-            right: $right-menu-width;
+            right: $menu-width;
         }
     }
     & > .main-view {

front/salix/components/log/index.html

@@ -3,71 +3,212 @@
     url="{{$ctrl.url}}"
     filter="$ctrl.filter"
     link="{originFk: $ctrl.originId}"
-    where="{changedModel: $ctrl.changedModel,
-    changedModelId: $ctrl.changedModelId}"
+    where="{changedModel: $ctrl.changedModel, changedModelId: $ctrl.changedModelId}"
     data="$ctrl.logs"
-    limit="20"
+    order="creationDate DESC, id DESC"
+    limit="20">
+</vn-crud-model>
+<vn-crud-model
+    url="{{$ctrl.url}}/{{$ctrl.originId}}/models"
+    data="models"
+    order="changedModel"
     auto-load="true">
 </vn-crud-model>
-<vn-data-viewer model="model" class="vn-w-xl">
-    <vn-card>
-        <vn-table model="model">
-            <vn-thead>
-                <vn-tr>
-                    <vn-th field="creationDate">Date</vn-th>
-                    <vn-th field="userFk" shrink>User</vn-th>
-                    <vn-th field="changedModel" ng-if="$ctrl.showModelName" shrink>Model</vn-th>
-                    <vn-th field="action" shrink>Action</vn-th>
-                    <vn-th field="changedModelValue" ng-if="$ctrl.showModelName">Name</vn-th>
-                    <vn-th expand>Changes</vn-th>
-                </vn-tr>
-            </vn-thead>
-            <vn-tbody>
-                <vn-tr ng-repeat="log in $ctrl.logs">
-                    <vn-td shrink-datetime>
-                        {{::log.creationDate | date:'dd/MM/yyyy HH:mm'}}
-                    </vn-td>
-                    <vn-td>
-                        <span ng-class="{'link': log.user.worker.id, 'value': !log.user.worker.id}"
-                            ng-click="$ctrl.showWorkerDescriptor($event, log.user.worker.id)"
-                            translate>{{::log.user.name || 'System' | translate}}
-                        </span>
-                    </vn-td>
-                    <vn-td ng-if="$ctrl.showModelName">
-                        {{::log.changedModel}}
-                    </vn-td>
-                    <vn-td shrink translate>
-                        {{::$ctrl.actionsText[log.action]}}
-                    </vn-td>
-                    <vn-td ng-if="$ctrl.showModelName">
-                        {{::log.changedModelValue}}
-                    </vn-td>
-                    <vn-td expand>
-                        <table class="attributes">
-                            <thead>
-                                <tr>
-                                    <th translate class="field">Field</th>
-                                    <th translate>Before</th>
-                                    <th translate>After</th>
-                                </tr>
-                            </thead>
-                            <tbody>
-                                <tr ng-repeat="prop in ::log.props">
-                                    <td class="field">{{prop.name}}</td>
-                                    <td class="before">{{prop.old}}</td>
-                                    <td class="after">{{prop.new}}</td>
-                                </tr>
-                            </tbody>
-                        </table>
-                        <div ng-if="log.description != null">
-                            {{::log.description}}
+<vn-data-viewer model="model" class="vn-w-md vn-px-sm">
+    <div class="change vn-mb-sm" ng-repeat="log in $ctrl.logs">
+        <div class="user-wrapper">
+            <vn-avatar class="vn-mt-xs"
+                ng-class="::{system: !log.user}"
+                val="{{::log.user ? log.user.nickname : 'System'}}"
+                ng-click="$ctrl.showWorkerDescriptor($event, log)">
+                <img
+                    ng-if="::log.user.image"
+                    ng-src="/api/Images/user/160x160/{{::log.userFk}}/download?access_token={{::$ctrl.vnToken.token}}">
+                </img>
+            </vn-avatar>
+            <div class="arrow bg-panel"></div>
+            <div class="line"></div>
+        </div>
+        <vn-card class="detail vn-pa-sm">
+            <div class="header vn-mb-sm">
+                <div
+                    class="date text-secondary text-caption"
+                    title="{{::log.creationDate | date:'dd/MM/yyyy HH:mm'}}">
+                    {{::$ctrl.relativeDate(log.creationDate)}}
+                </div>
+                <span class="chip" ng-class="::$ctrl.actionsClass[log.action]" translate>
+                    {{::$ctrl.actionsText[log.action]}}
+                </span>
+            </div>
+            <div
+                class="model vn-mb-sm"
+                title="{{::log.changedModelValue}}"
+                ng-if="::log.changedModel || log.changedModelValue">
+                <span class="model-name"
+                    ng-if="::$ctrl.showModelName"
+                    title="{{::log.changedModel}}">
+                    {{::log.changedModelI18n}}
+                </span>
+                <span class="model-id"
+                    ng-if="::log.changedModelId">
+                    #{{::log.changedModelId}}
+                </span>
+                <span class="model-value">
+                    {{::log.changedModelValue}}
+                </span>
+            </div>
+            <div class="changes"
+                ng-class="::log.props.length ? 'props' : 'no-props'"
+                vn-id="changes">
+                <vn-icon icon="visibility"
+                    class="expand-button"
+                    ng-click="$ctrl.toggleAttributes(log, changes, true)">
+                </vn-icon>
+                <vn-icon icon="visibility_off"
+                    class="shrink-button"
+                    ng-click="$ctrl.toggleAttributes(log, changes, false)">
+                </vn-icon>
+                <div class="changes-wrapper">
+                    <span ng-if="::log.props.length"
+                        class="attributes">
+                        <span ng-if="!log.expand" ng-repeat="prop in ::log.props"
+                            class="basic-json">
+                            <span class="json-field"
+                                title="{{::prop.name}}">
+                                {{::prop.nameI18n}}:
+                            </span>
+                            <vn-json-value value="::$ctrl.mainVal(prop, log.action)"></vn-json-value><span ng-if="::!$last">,</span>
+                        </span>
+                        <div ng-if="log.expand"
+                            class="expanded-json">
+                            <div ng-repeat="prop in ::log.props">
+                                <span class="json-field"
+                                    title="{{::prop.name}}">
+                                    {{::prop.nameI18n}}:
+                                </span>
+                                <vn-json-value value="::$ctrl.mainVal(prop, log.action)"></vn-json-value>
+                                <span ng-if="::log.action == 'update'">
+                                    ← <vn-json-value value="::prop.old"></vn-json-value>
+                                </span>
+                            </div>
+                        </div>
+                    </span>
+                    <span ng-if="::!log.props.length"
+                        class="description">
+                        {{::log.description}}
+                    </span>
+                    <span ng-if="::!log.description && !log.props.length"
+                        class="no-changes"
+                        translate>
+                        No changes
+                    </span>
                 </div>
-                    </vn-td>
-                </vn-tr>
-            </vn-tbody>
-        </vn-table>
-        <vn-pagination model="model"></vn-pagination>
             </vn-card>
+        </div>
+    </div>
 </vn-data-viewer>
+<vn-side-menu side="right">
+    <form vn-vertical
+        ng-model-options="{updateOn: 'change blur'}"
+        class="vn-pa-md filter">
+        <vn-textfield
+            label="Name"
+            ng-model="filter.changedModelValue">
+        </vn-textfield>
+        <vn-vertical>
+            <vn-radio
+                label="All"
+                val="all"
+                ng-model="filter.who">
+            </vn-radio>
+            <vn-radio
+                label="User"
+                val="user"
+                ng-model="filter.who">
+            </vn-radio>
+            <vn-radio
+                label="System"
+                val="system"
+                ng-model="filter.who">
+            </vn-radio>
+        </div>
+        <vn-autocomplete
+            ng-show="filter.who != 'system'"
+            label="User"
+            ng-model="filter.userFk"
+            value-field="id"
+            show-field="nickname"
+            fields="['id', 'name', 'nickname', 'image']"
+            search-function="$ctrl.searchUser($search)"
+            url="{{$ctrl.url}}/{{$ctrl.originId}}/editors"
+            order="nickname">
+            <tpl-item>
+                <div style="display: flex;">
+                    <vn-avatar
+                        class="vn-mr-sm"
+                        val="{{::nickname}}">
+                        <img
+                            ng-if="::image"
+                            ng-src="/api/Images/user/160x160/{{::id}}/download?access_token={{::$ctrl.vnToken.token}}">
+                        </img>
+                    </vn-avatar>
+                    <div>
+                        <div>{{::nickname}}</div>
+                        <div class="text-secondary text-caption">{{::name}}</div>
+                    </div>
+                </div>
+            </tpl-item>
+        </vn-autocomplete>
+        <vn-autocomplete
+            label="Model"
+            ng-model="filter.changedModel"
+            value-field="changedModel"
+            show-field="changedModel"
+            data="models">
+        </vn-autocomplete>
+        <vn-textfield
+            label="Id"
+            ng-model="filter.changedModelId">
+        </vn-textfield>
+        <vn-vertical>
+            <vn-check
+                label="Creates"
+                ng-model="filter.actions.insert">
+            </vn-check>
+            <vn-check
+                label="Updates"
+                ng-model="filter.actions.update">
+            </vn-check>
+            <vn-check
+                label="Deletes"
+                ng-model="filter.actions.delete">
+            </vn-check>
+            <vn-check
+                label="Views"
+                ng-model="filter.actions.select">
+            </vn-check>
+        </div>
+        <vn-date-picker
+            label="Date"
+            ng-model="filter.from">
+        </vn-date-picker>
+        <vn-date-picker
+            label="To"
+            ng-model="filter.to">
+        </vn-date-picker>
+        <vn-button-bar vn-vertical class="vn-mt-sm">
+            <vn-button
+                label="Filter"
+                ng-click="$ctrl.applyFilter(filter)">
+            </vn-button>
+            <vn-button
+                label="Reset"
+                class="flat"
+                ng-click="$ctrl.resetFilter()"
+                ng-if="model.userFilter">
+            </vn-button>
+        </vn-button-bar>
+    </form>
+</vn-side-menu>
 <vn-worker-descriptor-popover vn-id="workerDescriptor">
 </vn-worker-descriptor-popover>

front/salix/components/log/index.js

@@ -13,11 +13,17 @@ export default class Controller extends Section {
             delete: 'Deletes',
             select: 'Views'
         };
+        this.actionsClass = {
+            insert: 'success',
+            update: 'warning',
+            delete: 'alert',
+            select: 'notice'
+        };
         this.filter = {
             include: [{
                 relation: 'user',
                 scope: {
-                    fields: ['name'],
+                    fields: ['nickname', 'name', 'image'],
                     include: {
                         relation: 'worker',
                         scope: {
@@ -27,6 +33,20 @@ export default class Controller extends Section {
                 },
             }],
         };
+
+        this.dateFilter = this.$filter('date');
+        this.lang = this.$translate.use();
+        this.today = Date.vnNew();
+        this.today.setHours(0, 0, 0, 0);
+    }
+
+    $postLink() {
+        this.resetFilter();
+        this.$.$watch(
+            () => this.$.filter,
+            () => this.applyFilter(),
+            true
+        );
     }
 
     get logs() {
@@ -42,6 +62,7 @@ export default class Controller extends Section {
             const oldValues = log.oldInstance || empty;
             const newValues = log.newInstance || empty;
             const locale = validations[log.changedModel]?.locale || empty;
+            log.changedModelI18n = locale.name || log.changedModel;
 
             let props = Object.keys(oldValues).concat(Object.keys(newValues));
             props = [...new Set(props)];
@@ -49,9 +70,10 @@ export default class Controller extends Section {
             log.props = [];
             for (const prop of props) {
                 log.props.push({
-                    name: locale[prop] || prop,
-                    old: this.formatValue(oldValues[prop]),
-                    new: this.formatValue(newValues[prop])
+                    name: prop,
+                    nameI18n: locale.columns?.[prop] || prop,
+                    old: this.castJsonValue(oldValues[prop]),
+                    new: this.castJsonValue(newValues[prop])
                 });
             }
         }
@@ -61,36 +83,115 @@ export default class Controller extends Section {
         return !(this.changedModel && this.changedModelId);
     }
 
-    formatValue(value) {
-        let type = typeof value;
-
-        if (type === 'string' && validDate.test(value)) {
-            value = new Date(value);
-            type = typeof value;
+    castJsonValue(value) {
+        return typeof value === 'string' && validDate.test(value)
+            ? new Date(value)
+            : value;
     }
 
-        switch (type) {
-        case 'boolean':
-            return value ? '✓' : '✗';
-        case 'object':
-            if (value instanceof Date) {
-                const hasZeroTime =
-                    value.getHours() === 0 &&
-                    value.getMinutes() === 0 &&
-                    value.getSeconds() === 0;
-                const format = hasZeroTime ? 'dd/MM/yyyy' : 'dd/MM/yyyy HH:mm:ss';
-                return this.$filter('date')(value, format);
+    mainVal(prop, action) {
+        return action == 'delete' ? prop.old : prop.new;
     }
+
+    toggleAttributes(log, changesEl, force) {
+        log.expand = force;
+        changesEl.classList.toggle('expanded', force);
+    }
+
+    relativeDate(dateVal) {
+        if (dateVal == null) return '';
+        const date = new Date(dateVal);
+        const dateZeroTime = new Date(dateVal);
+        dateZeroTime.setHours(0, 0, 0, 0);
+        const diff = Math.trunc((this.today.getTime() - dateZeroTime.getTime()) / (1000 * 3600 * 24));
+
+        let format;
+        if (diff == 0)
+            format = `'${this.$t('today')}'`;
+        else if (diff == 1)
+            format = `'${this.$t('yesterday')}'`;
+        else if (diff > 1 && diff < 7)
+            format = `'${date.toLocaleDateString(this.lang, {weekday: 'short'})}'`;
+        else if (this.today.getFullYear() == date.getFullYear())
+            format = `d '${date.toLocaleDateString(this.lang, {month: 'short'})}'`;
         else
-                return value;
+            format = `dd/MM/yyyy`;
+
+        return this.dateFilter(date, `${format} HH:mm`);
+    }
+
+    resetFilter() {
+        this.$.filter = {who: 'all'};
+    }
+
+    applyFilter() {
+        const filter = this.$.filter;
+
+        function getParam(prop, value) {
+            if (value == null || value == '') return null;
+            switch (prop) {
+            case 'changedModelValue':
+                return {[prop]: {like: `%${value}%`}};
+            case 'who':
+                switch (value) {
+                case 'all':
+                    return null;
+                case 'user':
+                    return {userFk: {neq: null}};
+                case 'system':
+                    return {userFk: null};
+                }
+            case 'actions':
+                const inq = [];
+                for (const action in value) {
+                    if (value[action])
+                        inq.push(action);
+                }
+                return inq.length ? {action: {inq}} : null;
+            case 'from':
+                if (filter.to) {
+                    return {creationDate: {gte: value}};
+                } else {
+                    const to = new Date(value);
+                    to.setHours(23, 59, 59, 999);
+                    return {creationDate: {between: [value, to]}};
+                }
+            case 'to':
+                const to = new Date(value);
+                to.setHours(23, 59, 59, 999);
+                return {creationDate: {lte: to}};
+            case 'userFk':
+                return filter.who != 'system'
+                    ? {[prop]: value} : null;
             default:
-            return value;
+                return {[prop]: value};
             }
         }
 
-    showWorkerDescriptor(event, workerId) {
-        if (!workerId) return;
-        this.$.workerDescriptor.show(event.target, workerId);
+        const and = [];
+        for (const prop in filter) {
+            const param = getParam(prop, filter[prop]);
+            if (param) and.push(param);
+        }
+
+        const lbFilter = and.length ? {where: {and}} : null;
+        return this.$.model.applyFilter(lbFilter);
+    }
+
+    searchUser(search) {
+        if (/^[0-9]+$/.test(search)) {
+            return {id: search};
+        } else {
+            return {or: [
+                {name: search},
+                {nickname: {like: `%${search}%`}}
+            ]}
+        }
+    }
+
+    showWorkerDescriptor(event, log) {
+        if (log.user?.worker)
+            this.$.workerDescriptor.show(event.target, log.userFk);
     }
 }
 

front/salix/components/log/index.spec.js

@@ -0,0 +1,97 @@
+import './index';
+
+describe('Salix Component vnLog', () => {
+    let controller;
+    let $scope;
+    let $element;
+
+    beforeEach(ngModule('salix'));
+
+    beforeEach(inject(($componentController, $rootScope) => {
+        $scope = $rootScope.$new();
+        $element = angular.element('<vn-log></vn-log>');
+        controller = $componentController('vnLog', {$element, $scope});
+    }));
+
+    describe('relativeDate()', () => {
+        let date;
+
+        beforeEach(() => {
+            date = Date.vnNew();
+        });
+
+        it('should return empty string when date is null', () => {
+            const ret = controller.relativeDate(null);
+
+            expect(ret).toEqual('');
+        });
+
+        it('should return empty string when date is undefined', () => {
+            const ret = controller.relativeDate(undefined);
+
+            expect(ret).toEqual('');
+        });
+
+        it('should return today and time when date is today', () => {
+            const ret = controller.relativeDate(date);
+
+            expect(ret).toEqual('today 12:00');
+        });
+
+        it('should return yesterday and time when date is yesterday', () => {
+            date.setDate(date.getDate() - 1);
+            const ret = controller.relativeDate(date);
+
+            expect(ret).toEqual('yesterday 12:00');
+        });
+
+        it('should return abreviated weekday name and time when date is on past week', () => {
+            date.setDate(date.getDate() - 3);
+            const ret = controller.relativeDate(date);
+
+            expect(ret).toEqual('Fri 12:00');
+        });
+
+        it('should return abreviated month name, day number and time when date is on this year', () => {
+            date.setDate(date.getDate() + 20);
+            const ret = controller.relativeDate(date);
+
+            expect(ret).toEqual('21 Jan 12:00');
+        });
+
+        it('should return abreviated month name, day number, year and time when date is on different year', () => {
+            date.setDate(date.getDate() - 20);
+            const ret = controller.relativeDate(date);
+
+            expect(ret).toEqual('12/12/2000 12:00');
+        });
+
+        it('should convert to date and return string when date is not a Date class instance', () => {
+            const ret = controller.relativeDate(date.toJSON());
+
+            expect(ret).toEqual('today 12:00');
+        });
+    });
+
+    describe('castJsonValue()', () => {
+        it('should return date when string has valid JSON date format', () => {
+            const now = Date.vnNew();
+
+            const ret = controller.castJsonValue(now.toJSON());
+
+            expect(ret).toBeInstanceOf(Date);
+        });
+
+        it('should return same value when is string with invalid JSON date format', () => {
+            const ret = controller.castJsonValue('Foo');
+
+            expect(ret).toEqual('Foo');
+        });
+
+        it('should return same value when is not an string', () => {
+            const ret = controller.castJsonValue(1001);
+
+            expect(ret).toEqual(1001);
+        });
+    });
+});

front/salix/components/log/locale/es.yml

@@ -13,3 +13,6 @@ Views: Visualiza
 System: Sistema
 note: nota
 Changes: Cambios
+No changes: No hay cambios
+today: hoy
+yesterday: ayer

front/salix/components/log/style.scss

@@ -1,66 +1,152 @@
 @import "variables";
 
 vn-log {
-    vn-td {
-        vertical-align: initial !important;
-    }
-    .changes {
-        display: none;
-    }
-    .label {
-        color: $color-font-secondary;
-    }
-    .value {
-        color: $color-font;
-    }
+    .change {
+        display: flex;
 
-    @media screen and (max-width: 1570px) {
-        vn-table .expendable {
+        & > .user-wrapper {
+            position: relative;
+            padding-right: 10px;
+
+            & > vn-avatar {
+                cursor: pointer;
+
+                &.system {
+                    background-color: $color-main !important;
+                }
+            }
+            & > .arrow {
+                height: 8px;
+                width: 8px;
+                position: absolute;
+                transform: rotateY(0deg) rotate(45deg);
+                top: 18px;
+                right: -4px;
+                z-index: 1;
+            }
+            & > .line {
+                position: absolute;
+                background-color: $color-main;
+                width: 2px;
+                left: 17px;
+                z-index: -1;
+                top: 44px;
+                bottom: -8px;
+            }
+        }
+        &:last-child > .user-wrapper > .line {
             display: none;
         }
+        .detail {
+            position: relative;
+            flex-grow: 1;
+            width: 100%;
+            border-radius: 2px;
+            overflow: hidden;
+
+            & > .header {
+                overflow: hidden;
+                text-overflow: ellipsis;
+                white-space: nowrap;
+
+                & > .chip {
+                    padding: 2px 4px;
+                    border-radius: 4px;
+                    display: inline-block;
+                    color: $color-font-bg;
+
+                    &.notice {
+                        background-color: $color-notice-medium;
+                    }
+                    &.success {
+                        background-color: $color-success-medium;
+                    }
+                    &.warning {
+                        background-color: $color-main-medium;
+                    }
+                    &.alert {
+                        background-color: lighten($color-alert, 5%);
+                    }
+                }
+                .date {
+                    float: right;
+                }
+            }
+            & > .model {
+                overflow: hidden;
+                text-overflow: ellipsis;
+                white-space: nowrap;
+
+                & > .model-name {
+                    text-transform: capitalize;
+                }
+                & > .model-value {
+                    font-style: italic;
+                    color: #c7bd2b;
+                }
+                & > .model-id {
+                    color: $color-font-secondary;
+                    font-size: .9em;
+                }
+            }
+        }
+    }
     .changes {
-            padding-top: 10px;
+        overflow: hidden;
+        background-color: rgba(255, 255, 255, .05);
+        border-radius: 4px;
+        color: $color-font-secondary;
+        transition: max-height 150ms ease-in-out;
+        max-height: 28px;
+        position: relative;
+
+        & > .expand-button,
+        & > .shrink-button {
+            display: none;
+        }
+        &.props {
+            padding-right: 24px;
+
+            & > .expand-button,
+            & > .shrink-button {
+                position: absolute;
+                top: 6px;
+                right: 8px;
+                font-size: inherit;
+                float: right;
+                cursor: pointer;
+            }
+            & > .expand-button {
                 display: block;
             }
-    }
-    .attributes {
-        width: 100%;
+            &.expanded {
+                max-height: 500px;
+                padding-right: 0;
 
-        tr {
-            height: 10px;
-
-            & > td {
-                padding: 2px;
+                & > .changes-wrapper {
+                    text-overflow: initial;
+                    white-space: initial;
                 }
-            & > td.field,
-            & > th.field {
-                width: 20%;
-                color: gray;
+                & > .shrink-button {
+                    display: block;
                 }
-            & > td.before,
-            & > th.before,
-            & > td.after,
-            & > th.after {
-                width: 40%;
-                white-space: pre-line;
+                & > .expand-button {
+                    display: none;
                 }
             }
         }
-}
-.ellipsis {
-    white-space: nowrap;
+        & > .changes-wrapper {
+            padding: 4px 6px;
             overflow: hidden;
-    max-width: 400px;
             text-overflow: ellipsis;
-    display: inline-block;
+            white-space: nowrap;
+
+            & > .no-changes {
+                font-style: italic;
+            }
+            .json-field {
+                text-transform: capitalize;
+            }
         }
-.no-ellipsize,
-[no-ellipsize] {
-    text-overflow: '';
-    white-space: normal;
-    overflow: auto;
     }
-.alignSpan {
-    overflow: hidden;
-    display: inline-block;
 }

loopback/common/methods/log/editors.js

@@ -0,0 +1,40 @@
+const mergeFilters = require('vn-loopback/util/filter').mergeFilters;
+
+module.exports = Self => {
+    Self.remoteMethod('editors', {
+        description: 'Get the list of entity editors',
+        accepts: [
+            {
+                arg: 'id',
+                type: 'integer',
+                description: 'The model id',
+                required: true
+            }, {
+                arg: 'filter',
+                type: 'Object',
+                description: 'The user filter object'
+            }
+        ],
+        returns: {
+            type: [Self],
+            root: true
+        },
+        http: {
+            path: `/:id/editors`,
+            verb: 'GET'
+        }
+    });
+
+    Self.editors = async(id, filter) => {
+        const res = await Self.find({
+            fields: ['userFk'],
+            where: {originFk: id}
+        });
+        const userIds = new Set(res.map(x => x.userFk));
+
+        filter = mergeFilters(filter, {
+            where: {id: {inq: [...userIds]}}
+        });
+        return await Self.app.models.VnUser.find(filter);
+    };
+};

loopback/common/methods/log/models.js

@@ -0,0 +1,44 @@
+const mergeFilters = require('vn-loopback/util/filter').mergeFilters;
+
+module.exports = Self => {
+    Self.remoteMethod('models', {
+        description: 'Get the list of entity models',
+        accepts: [
+            {
+                arg: 'id',
+                type: 'integer',
+                description: 'The model id',
+                required: true
+            }, {
+                arg: 'filter',
+                type: 'Object',
+                description: 'The filter object'
+            }
+        ],
+        returns: {
+            type: [Self],
+            root: true
+        },
+        http: {
+            path: `/:id/models`,
+            verb: 'GET'
+        }
+    });
+
+    Self.models = async(id, filter) => {
+        filter = mergeFilters(filter, {
+            fields: ['changedModel'],
+            where: {
+                originFk: id,
+                changedModel: {neq: null}
+            }
+        });
+        const res = await Self.find(filter);
+
+        const set = new Set();
+        return res.filter(x => set.has(x.changedModel)
+            ? false
+            : set.add(x.changedModel)
+        );
+    };
+};

loopback/common/models/log.js

@@ -0,0 +1,10 @@
+
+module.exports = function(Self) {
+    Object.assign(Self, {
+        setup() {
+            Self.super_.setup.call(this);
+            require('../methods/log/editors')(this);
+            require('../methods/log/models')(this);
+        }
+    });
+};

loopback/common/models/log.json

@@ -0,0 +1,4 @@
+{
+  "name": "Log",
+  "base": "VnModel"
+}

loopback/common/models/vn-model.js

@@ -21,19 +21,21 @@ module.exports = function(Self) {
                 let orgBeginTransaction = this.beginTransaction;
                 this.beginTransaction = function(options, cb) {
                     options = options || {};
-                    if (!options.timeout)
-                        options.timeout = 120000;
+                    if (options.timeout === undefined)
+                        options.timeout = 120 * 1000;
                     return orgBeginTransaction.call(this, options, cb);
                 };
             });
 
             // Register field ACL validation
-            /* this.beforeRemote('prototype.patchAttributes', ctx => this.checkUpdateAcls(ctx));
+            /*
+            this.beforeRemote('prototype.patchAttributes', ctx => this.checkUpdateAcls(ctx));
             this.beforeRemote('updateAll', ctx => this.checkUpdateAcls(ctx));
             this.beforeRemote('patchOrCreate', ctx => this.checkInsertAcls(ctx));
             this.beforeRemote('create', ctx => this.checkInsertAcls(ctx));
             this.beforeRemote('replaceById', ctx => this.checkInsertAcls(ctx));
-            this.beforeRemote('replaceOrCreate', ctx => this.checkInsertAcls(ctx)); */
+            this.beforeRemote('replaceOrCreate', ctx => this.checkInsertAcls(ctx));
+            */
 
             this.remoteMethod('crud', {
                 description: `Create, update or/and delete instances from model with a single request`,

loopback/locale/en.json

@@ -156,6 +156,20 @@
 	"Component cost not set": "Componente coste no está estabecido",
 	"Tickets with associated refunds can't be deleted. This ticket is associated with refund Nº 2": "Tickets with associated refunds can't be deleted. This ticket is associated with refund Nº 2",
 	"Description cannot be blank": "Description cannot be blank",
+	"company": "Company",
+	"country": "Country",
+	"clientId": "Id client",
+	"clientSocialName": "Client",
+	"amount": "Amount",
+	"taxableBase": "Taxable base",
+	"ticketFk": "Id ticket",
+	"isActive": "Active",
+	"hasToInvoice": "Invoice",
+	"isTaxDataChecked": "Data checked",
+	"comercialId": "Id Comercial",
+	"comercialName": "Comercial",
 	"Added observation": "Added observation",
-	"Comment added to client": "Comment added to client"
+	"Comment added to client": "Comment added to client",
+	"This ticket is already a refund": "This ticket is already a refund",
+	"A claim with that sale already exists": "A claim with that sale already exists"
 }

loopback/locale/es.json

@@ -272,10 +272,25 @@
 	"Tickets with associated refunds": "No se pueden borrar tickets con abonos asociados. Este ticket está asociado al abono Nº {{id}}",
 	"Not exist this branch": "La rama no existe",
 	"This ticket cannot be signed because it has not been boxed": "Este ticket no puede firmarse porque no ha sido encajado",
+	"Collection does not exist": "La colección no existe",
+	"Cannot obtain exclusive lock": "No se puede obtener un bloqueo exclusivo",
 	"Insert a date range": "Inserte un rango de fechas",
 	"Added observation": "{{user}} añadió esta observacion: {{text}}",
 	"Comment added to client": "Observación añadida al cliente {{clientFk}}",
 	"Invalid auth code": "Código de verificación incorrecto",
 	"Invalid or expired verification code": "Código de verificación incorrecto o expirado",
-	"Cannot create a new claimBeginning from a different ticket": "No se puede crear una línea de reclamación de un ticket diferente al origen"
+	"Cannot create a new claimBeginning from a different ticket": "No se puede crear una línea de reclamación de un ticket diferente al origen",
+	"company": "Compañía",
+	"country": "País",
+	"clientId": "Id cliente",
+	"clientSocialName": "Cliente",
+	"amount": "Importe",
+	"taxableBase": "Base",
+	"ticketFk": "Id ticket",
+	"isActive": "Activo",
+	"hasToInvoice": "Facturar",
+	"isTaxDataChecked": "Datos comprobados",
+	"comercialId": "Id comercial",
+	"comercialName": "Comercial",
+	"Invalid NIF for VIES": "Invalid NIF for VIES"
 }

loopback/server/datasources.json

@@ -15,7 +15,7 @@
         "legacyUtcDateProcessing": false,
         "timezone": "local",
         "connectTimeout": 40000,
-        "acquireTimeout": 60000,
+        "acquireTimeout": 90000,
         "waitForConnections": true
     },
     "osticket": {

modules/account/back/locale/mail/en.yml

@@ -0,0 +1,7 @@
+name: mail
+columns:
+    id: id
+    receiver: receiver
+    replyTo: reply to
+    subject: subject
+    body: body

modules/account/back/locale/mail/es.yml

@@ -0,0 +1,7 @@
+name: mail
+columns:
+    id: id
+    receiver: receptor
+    replyTo: responder a
+    subject: asunto
+    body: cuerpo

modules/account/back/models/role-log.json

@@ -1,6 +1,6 @@
 {
 	"name": "RoleLog",
-	"base": "VnModel",
+	"base": "Log",
 	"options": {
 		"mysql": {
 			"table": "account.roleLog"