From 8eb14a8bdc9245145905f2bd808ac9ca8999b72f Mon Sep 17 00:00:00 2001
From: joan <joan@verdnatura.es>
Date: Tue, 24 Nov 2020 14:56:10 +0100
Subject: [PATCH] 2588 - No ellipsize on summary notes or address

---
 front/core/components/label-value/style.scss |  7 +++++++
 modules/client/front/summary/index.html      | 14 +++++++-------
 modules/invoiceOut/front/summary/index.html  |  2 +-
 modules/order/front/basic-data/index.html    |  2 +-
 modules/order/front/summary/index.html       | 17 ++++++++++-------
 modules/supplier/front/summary/index.html    |  8 ++++----
 modules/ticket/front/summary/index.html      |  8 ++++----
 modules/worker/front/summary/index.html      |  2 +-
 8 files changed, 35 insertions(+), 25 deletions(-)

diff --git a/front/core/components/label-value/style.scss b/front/core/components/label-value/style.scss
index 10f3c016c..d50feffd0 100644
--- a/front/core/components/label-value/style.scss
+++ b/front/core/components/label-value/style.scss
@@ -6,4 +6,11 @@ vn-label-value > section {
         color: $color-font-secondary;
         font-size: 1.2rem
     }
+}
+
+vn-label-value[no-ellipsize] > section,
+vn-label-value.no-ellipsize > section {
+    text-overflow: '';
+    white-space: normal;
+    overflow: auto;
 }
\ No newline at end of file
diff --git a/modules/client/front/summary/index.html b/modules/client/front/summary/index.html
index 775911717..50bdd226c 100644
--- a/modules/client/front/summary/index.html
+++ b/modules/client/front/summary/index.html
@@ -28,7 +28,7 @@
             <vn-label-value label="Mobile" 
                 value="{{$ctrl.summary.mobile}}">
             </vn-label-value>
-            <vn-label-value label="Email" ellipsize="false"
+            <vn-label-value label="Email" no-ellipsize
                 value="{{$ctrl.summary.email}}">
             </vn-label-value>
             <vn-label-value label="Sales person">
@@ -50,9 +50,6 @@
             <vn-label-value label="NIF / CIF" 
                 value="{{$ctrl.summary.fi}}">
             </vn-label-value>
-            <vn-label-value label="Street" ellipsize="false"
-                value="{{$ctrl.summary.street}}">
-            </vn-label-value>
             <vn-label-value label="City" 
                 value="{{$ctrl.summary.city}}">
             </vn-label-value>
@@ -65,6 +62,9 @@
             <vn-label-value label="Country" 
                 value="{{$ctrl.summary.country.country}}">
             </vn-label-value>
+            <vn-label-value label="Street" no-ellipsize
+                value="{{$ctrl.summary.street}}">
+            </vn-label-value>
         </vn-one>
         <vn-one>
             <h4 translate>Fiscal data</h4>
@@ -140,12 +140,12 @@
             <vn-label-value label="Name" 
                 value="{{$ctrl.summary.defaultAddress.nickname}}">
             </vn-label-value>
-            <vn-label-value label="Street" ellipsize="false"
-                value="{{$ctrl.summary.defaultAddress.street}}">
-            </vn-label-value>
             <vn-label-value label="City" 
                 value="{{$ctrl.summary.defaultAddress.city}}">
             </vn-label-value>
+            <vn-label-value label="Street" no-ellipsize
+                value="{{$ctrl.summary.defaultAddress.street}}">
+            </vn-label-value>
         </vn-one>
         <vn-one>
             <h4 translate>Web access</h4>
diff --git a/modules/invoiceOut/front/summary/index.html b/modules/invoiceOut/front/summary/index.html
index e0fdd8bd2..452ec23db 100644
--- a/modules/invoiceOut/front/summary/index.html
+++ b/modules/invoiceOut/front/summary/index.html
@@ -74,7 +74,7 @@
                                 {{ticket.nickname}}
                             </span>
                        </vn-td>
-                        <vn-td expand>{{ticket.shipped | date: 'dd/MM/yyyy' | dashIfEmpty}</vn-td>
+                        <vn-td expand>{{ticket.shipped | date: 'dd/MM/yyyy' | dashIfEmpty}}</vn-td>
                         <vn-td number>{{ticket.total | currency: 'EUR': 2}}</vn-td>
                     </vn-tr>
                 </vn-tbody>
diff --git a/modules/order/front/basic-data/index.html b/modules/order/front/basic-data/index.html
index 8945de2b7..63fb5c1b9 100644
--- a/modules/order/front/basic-data/index.html
+++ b/modules/order/front/basic-data/index.html
@@ -59,7 +59,7 @@
         <vn-horizontal>
             <vn-textarea
                 vn-one
-                label="Observation" 
+                label="Notes" 
                 ng-model="$ctrl.order.note"
                 rule>
             </vn-textarea>
diff --git a/modules/order/front/summary/index.html b/modules/order/front/summary/index.html
index 8f78ce460..6a19b12e3 100644
--- a/modules/order/front/summary/index.html
+++ b/modules/order/front/summary/index.html
@@ -31,12 +31,12 @@
                     {{$ctrl.summary.address.nickname}}
                 </span>
             </vn-label-value>
-            <vn-check label="Confirmed" disabled="true"
-                ng-model="$ctrl.summary.isConfirmed">
-            </vn-check>
             <vn-label-value label="Company" 
                 value="{{$ctrl.summary.address.companyFk}}">
             </vn-label-value>
+            <vn-check label="Confirmed" disabled="true"
+                ng-model="$ctrl.summary.isConfirmed">
+            </vn-check>
         </vn-one>
         <vn-one>
             <vn-label-value label="Created" 
@@ -45,18 +45,21 @@
             <vn-label-value label="Confirmed" 
                 value="{{$ctrl.summary.confirmed | date: 'dd/MM/yyyy HH:mm'}}">
             </vn-label-value>
-            <vn-label-value label="Address" 
-                value="{{$ctrl.formattedAddress}}">
+            <vn-label-value label="Landed" 
+                value="{{$ctrl.summary.landed | date: 'dd/MM/yyyy HH:mm'}}">
             </vn-label-value>
             <vn-label-value label="Phone" 
-                value="{{$ctrl.summary.address.phone}}">
+            value="{{$ctrl.summary.address.phone}}">
             </vn-label-value>
             <vn-label-value label="Created from" 
                 value="{{$ctrl.summary.sourceApp}}">
             </vn-label-value>
+            <vn-label-value label="Address" no-ellipsize
+                value="{{$ctrl.formattedAddress}}">
+            </vn-label-value>
         </vn-one>
         <vn-one>
-            <vn-label-value label="{{'Notes'}}"
+            <vn-label-value label="Notes" no-ellipsize
                 value="{{$ctrl.summary.note}}">
             </vn-label-value>
         </vn-one>
diff --git a/modules/supplier/front/summary/index.html b/modules/supplier/front/summary/index.html
index c0731a1c1..14168f253 100644
--- a/modules/supplier/front/summary/index.html
+++ b/modules/supplier/front/summary/index.html
@@ -20,6 +20,10 @@
                     label="Alias" 
                     value="{{::$ctrl.summary.nickname}}">
                 </vn-label-value>
+                <vn-label-value no-ellipsize
+                    label="Notes" 
+                    value="{{::$ctrl.summary.note}}">
+                </vn-label-value>
                 <vn-check
                     label="Verified" 
                     ng-model="$ctrl.summary.isSerious" 
@@ -30,10 +34,6 @@
                     ng-model="$ctrl.summary.isActive" 
                     disabled="true">
                 </vn-check>
-                <vn-label-value 
-                    label="Notes" 
-                    value="{{::$ctrl.summary.note}}">
-                </vn-label-value>
             </vn-vertical>
         </vn-one>
         <vn-one>
diff --git a/modules/ticket/front/summary/index.html b/modules/ticket/front/summary/index.html
index 2faefadf2..803734c74 100644
--- a/modules/ticket/front/summary/index.html
+++ b/modules/ticket/front/summary/index.html
@@ -70,9 +70,6 @@
             <vn-label-value label="Package size" 
                 value="{{$ctrl.summary.packages}}">
             </vn-label-value>
-            <vn-label-value label="Address" 
-                value="{{$ctrl.formattedAddress}}">
-            </vn-label-value>
             <vn-label-value label="Address phone"
                 ng-if="$ctrl.summary.address.phone != null" 
                 value="{{$ctrl.summary.address.phone}}">
@@ -89,9 +86,12 @@
                 ng-if="$ctrl.summary.client.mobile != null"
                 value="{{$ctrl.summary.client.mobile}}">
             </vn-label-value>
+            <vn-label-value label="Address" no-ellipsize
+                value="{{$ctrl.formattedAddress}}">
+            </vn-label-value>
         </vn-two>
         <vn-one class="notes">
-            <vn-label-value
+            <vn-label-value no-ellipsize
                 label="{{note.observationType.description}}"
                 ng-repeat="note in $ctrl.summary.notes track by note.id"
                 value="{{note.description}}">
diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html
index e44d2a5d1..e816f6cf2 100644
--- a/modules/worker/front/summary/index.html
+++ b/modules/worker/front/summary/index.html
@@ -14,7 +14,7 @@
             <vn-label-value label="Id" 
                 value="{{worker.id}}">
             </vn-label-value>
-            <vn-label-value label="Email" 
+            <vn-label-value label="Email" no-ellipsize
                 value="{{worker.user.emailUser.email}}">
             </vn-label-value>
             <vn-label-value label="Department"