From 7abeebeecbe42852a288742bdb360a61b335f729 Mon Sep 17 00:00:00 2001 From: Carlos Jimenez <=> Date: Wed, 22 Aug 2018 12:55:15 +0200 Subject: [PATCH 1/3] #503 client/item/src/index/index.js Front unit test --- client/item/src/index/index.spec.js | 63 +++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 client/item/src/index/index.spec.js diff --git a/client/item/src/index/index.spec.js b/client/item/src/index/index.spec.js new file mode 100644 index 000000000..5da3ee154 --- /dev/null +++ b/client/item/src/index/index.spec.js @@ -0,0 +1,63 @@ +import './index.js'; + +describe('Item', () => { + describe('Component vnItemIndex', () => { + let $componentController; + let $state; + let controller; + let $httpBackend; + + beforeEach(() => { + angular.mock.module('item'); + }); + + beforeEach(angular.mock.inject((_$componentController_, _$state_, _$httpBackend_) => { + $componentController = _$componentController_; + $state = _$state_; + $httpBackend = _$httpBackend_; + $httpBackend.when('GET', /\/locale\/\w+\/[a-z]{2}\.json/).respond({}); + controller = $componentController('vnItemIndex', {$state: $state}); + })); + + describe('onCloneAccept()', () => { + it('should do nothing if response is not ACCEPT', () => { + spyOn(controller.$state, 'go'); + + let response = 'ERROR!'; + controller.itemSelected = 'check me'; + + controller.onCloneAccept(response); + + expect(controller.$state.go).not.toHaveBeenCalledWith(); + expect(controller.itemSelected).toEqual('check me'); + }); + + it('should do nothing if response is ACCEPT but itemSelected is not defined in the controller', () => { + spyOn(controller.$state, 'go'); + + let response = 'ACCEPT'; + controller.itemSelected = undefined; + + controller.onCloneAccept(response); + + expect(controller.$state.go).not.toHaveBeenCalledWith(); + expect(controller.itemSelected).toBeUndefined(); + }); + + it('should perform a post query and then call go() then update itemSelected in the controller', () => { + spyOn(controller.$state, 'go'); + + let response = 'ACCEPT'; + controller.itemSelected = {id: 1}; + + $httpBackend.when('POST', `/item/api/Items/1/clone`).respond({id: 99}); + $httpBackend.expect('POST', `/item/api/Items/1/clone`); + controller.onCloneAccept(response); + $httpBackend.flush(); + + expect(controller.$state.go).toHaveBeenCalledWith('item.card.tags', {id: 99}); + expect(controller.itemSelected).toBeNull(); + }); + }); + }); +}); From 997c4c52f94764284ec7f22b5787bc4a4c15f4b8 Mon Sep 17 00:00:00 2001 From: Joan Date: Wed, 22 Aug 2018 13:28:01 +0200 Subject: [PATCH 2/3] added backend summary test #520 --- client/client/src/locale/es.yml | 1 + client/client/src/summary/locale/es.yml | 3 +- .../methods/client/specs/summary.spec.js | 46 +++++++++++++++++++ 3 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 services/loopback/common/methods/client/specs/summary.spec.js diff --git a/client/client/src/locale/es.yml b/client/client/src/locale/es.yml index eded7cd4d..2c3fe8fa3 100644 --- a/client/client/src/locale/es.yml +++ b/client/client/src/locale/es.yml @@ -21,6 +21,7 @@ Sent: Enviado Worker: Trabajador Send: Enviar Sample: Plantilla +Credit: Crédito # Sections Clients: Clientes diff --git a/client/client/src/summary/locale/es.yml b/client/client/src/summary/locale/es.yml index f0bfe6870..c07925f9e 100644 --- a/client/client/src/summary/locale/es.yml +++ b/client/client/src/summary/locale/es.yml @@ -5,4 +5,5 @@ Mana: Maná Risk: Riesgo Secured credit: Crédito asegurado Average invoiced: Consumo medio -Sales person: Comercial \ No newline at end of file +Sales person: Comercial +Recovery: Recobro \ No newline at end of file diff --git a/services/loopback/common/methods/client/specs/summary.spec.js b/services/loopback/common/methods/client/specs/summary.spec.js new file mode 100644 index 000000000..c70d56642 --- /dev/null +++ b/services/loopback/common/methods/client/specs/summary.spec.js @@ -0,0 +1,46 @@ +const app = require(`${servicesDir}/client/server/server`); + +describe('client summary()', () => { + it('should return a summary object containing data', async() => { + let result = await app.models.Client.summary(101); + + expect(result.id).toEqual(101); + expect(result.name).toEqual('Bruce Wayne'); + }); + + it('should return a summary object containing mana', async() => { + let result = await app.models.Client.summary(101); + + expect(result.mana.mana).toEqual(260); + }); + + it('should return a summary object containing debt', async() => { + let result = await app.models.Client.summary(101); + + expect(result.debt.debt).toEqual(1389.9); + }); + + it('should return a summary object containing averageInvoiced', async() => { + let result = await app.models.Client.summary(101); + + expect(result.averageInvoiced.invoiced).toEqual(1500); + }); + + it('should return a summary object containing totalGreuge', async() => { + let result = await app.models.Client.summary(101); + + expect(result.totalGreuge).toEqual(203.71); + }); + + it('should return a summary object without containing active recoveries', async() => { + let result = await app.models.Client.summary(101); + + expect(result.recovery).toEqual(null); + }); + + it('should return a summary object containing active recoveries', async() => { + let result = await app.models.Client.summary(102); + + expect(result.recovery.id).toEqual(3); + }); +}); From 7db3a96adc14b66675f27709db9f95210d19a335 Mon Sep 17 00:00:00 2001 From: Carlos Jimenez <=> Date: Wed, 22 Aug 2018 13:29:54 +0200 Subject: [PATCH 3/3] #504 client/item/src/search-panel/index.js Front unit test --- client/item/src/search-panel/index.spec.js | 52 ++++++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 client/item/src/search-panel/index.spec.js diff --git a/client/item/src/search-panel/index.spec.js b/client/item/src/search-panel/index.spec.js new file mode 100644 index 000000000..0309e1824 --- /dev/null +++ b/client/item/src/search-panel/index.spec.js @@ -0,0 +1,52 @@ +import './index.js'; + +describe('Item', () => { + describe('Component vnItemSearchPanel', () => { + let $componentController; + let $element; + let controller; + let $httpBackend; + + beforeEach(() => { + angular.mock.module('item'); + }); + + beforeEach(angular.mock.inject((_$componentController_, _$httpBackend_) => { + $componentController = _$componentController_; + $element = angular.element(`
`); + $httpBackend = _$httpBackend_; + $httpBackend.when('GET', /\/locale\/\w+\/[a-z]{2}\.json/).respond({}); + controller = $componentController('vnItemSearchPanel', {$element: $element}); + })); + + describe('getSourceTable()', () => { + it(`should return null if there's no selection`, () => { + let selection = null; + let result = controller.getSourceTable(selection); + + expect(result).toBeNull(); + }); + + it(`should return null if there's a selection but its isFree property is truthy`, () => { + let selection = {isFree: true}; + let result = controller.getSourceTable(selection); + + expect(result).toBeNull(); + }); + + it(`should return the formated sourceTable concatenated to a path`, () => { + let selection = {sourceTable: 'hello guy'}; + let result = controller.getSourceTable(selection); + + expect(result).toEqual('/api/Hello guys'); + }); + + it(`should return a path if there's no sourceTable and the selection has an id`, () => { + let selection = {id: 99}; + let result = controller.getSourceTable(selection); + + expect(result).toEqual(`/api/ItemTags/filterItemTags/${selection.id}`); + }); + }); + }); +});