From 925565d3d24037bb53d209823db0b5cef12bc83c Mon Sep 17 00:00:00 2001
From: vicent <vicent@verdnatura.es>
Date: Wed, 26 Oct 2022 08:23:36 +0200
Subject: [PATCH] =?UTF-8?q?refator:=20borrada=20variable=20global=20y=20a?=
 =?UTF-8?q?=C3=B1adida=20Promesa=20al=20array?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 modules/ticket/back/methods/ticket/updateDiscount.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/modules/ticket/back/methods/ticket/updateDiscount.js b/modules/ticket/back/methods/ticket/updateDiscount.js
index 7e7c4e06d..a60d732b1 100644
--- a/modules/ticket/back/methods/ticket/updateDiscount.js
+++ b/modules/ticket/back/methods/ticket/updateDiscount.js
@@ -133,20 +133,20 @@ module.exports = Self => {
                     }
                 }, myOptions);
 
-                let newComponent;
+                let deletedComponent;
                 if (oldComponent) {
                     const filter = {
                         saleFk: sale.id,
                         componentFk: oldComponent.componentFk
                     };
-                    await models.SaleComponent.destroyAll(filter, myOptions);
+                    deletedComponent = await models.SaleComponent.destroyAll(filter, myOptions);
                 }
 
-                await createSaleComponent(sale.id, value, componentId, myOptions);
+                const newComponent = await createSaleComponent(sale.id, value, componentId, myOptions);
 
                 const updatedSale = sale.updateAttribute('discount', newDiscount, myOptions);
 
-                promises.push(newComponent, updatedSale);
+                promises.push(newComponent, updatedSale, deletedComponent);
 
                 const change = `${oldDiscount}% ➔ *${newDiscount}%*`;
                 changesMade += `\r\n-${sale.itemFk}: ${sale.concept} (${sale.quantity}) ${change}`;
@@ -193,7 +193,7 @@ module.exports = Self => {
     async function createSaleComponent(saleId, value, componentId, myOptions) {
         const models = Self.app.models;
 
-        newComponent = models.SaleComponent.create({
+        return models.SaleComponent.create({
             saleFk: saleId,
             value: value,
             componentFk: componentId