diff --git a/back/methods/mrw-config/createShipment.js b/back/methods/mrw-config/createShipment.js index 06b5f0117..b18040a3d 100644 --- a/back/methods/mrw-config/createShipment.js +++ b/back/methods/mrw-config/createShipment.js @@ -25,12 +25,15 @@ module.exports = Self => { Self.createShipment = async(expeditionFk, options) => { const myOptions = {}; + let tx; if (typeof options == 'object') Object.assign(myOptions, options); - if (!myOptions.transaction) - myOptions.transaction = await Self.beginTransaction({}); + if (!myOptions.transaction) { + tx = await Self.beginTransaction({}); + myOptions.transaction = tx; + } const models = Self.app.models; const mrw = await models.MrwConfig.findOne(null, myOptions); @@ -88,10 +91,10 @@ module.exports = Self => { try { await models.Expedition.updateAll({id: expeditionFk}, {externalId: shipmentId}, myOptions); - await myOptions.transaction.commit(); + if (tx) await tx.commit(); } catch (error) { - await myOptions.transaction.rollback(); - throw new UserError(`Cant update the expedition`); + if (tx) await tx.rollback(); + throw new UserError(`Cant update `); } return file; }; diff --git a/back/methods/mrw-config/specs/createShipment.spec.js b/back/methods/mrw-config/specs/createShipment.spec.js index e7bba524a..5aa69bac0 100644 --- a/back/methods/mrw-config/specs/createShipment.spec.js +++ b/back/methods/mrw-config/specs/createShipment.spec.js @@ -31,7 +31,7 @@ const expedition1 = { let tx; let options; -describe('MRWConfig createShipment()', () => { +fdescribe('MRWConfig createShipment()', () => { beforeEach(async() => { options = tx = undefined; tx = await models.MrwConfig.beginTransaction({});