From 9536fdba583decd85c81809814edaa5ee935737e Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Fri, 29 Sep 2023 10:10:58 +0200
Subject: [PATCH] ref #6119 refactor

---
 front/core/components/link-phone/index.html   | 27 ++++++++++---------
 front/core/components/link-phone/index.js     |  4 ---
 modules/client/front/summary/index.html       |  4 +--
 modules/order/front/summary/index.html        |  1 -
 .../route/front/roadmap/summary/index.html    |  1 -
 modules/ticket/front/summary/index.html       |  4 ---
 modules/worker/front/descriptor/index.html    |  2 --
 modules/worker/front/summary/index.html       |  3 ---
 8 files changed, 16 insertions(+), 30 deletions(-)

diff --git a/front/core/components/link-phone/index.html b/front/core/components/link-phone/index.html
index fc520cefd..2789ab75c 100644
--- a/front/core/components/link-phone/index.html
+++ b/front/core/components/link-phone/index.html
@@ -1,13 +1,14 @@
-<a 
-    ng-if="$ctrl.phoneNumber" 
-    href="tel:{{$ctrl.phoneNumber}}"
->
-    <vn-icon
-        flat
-        round
-        icon="phone"
-        title="MicroSIP"
-        ng-click="$event.stopPropagation();"
-    >
-    </vn-icon>
-</a>
\ No newline at end of file
+<span ng-if="$ctrl.phoneNumber">
+    {{$ctrl.phoneNumber}}
+    <a href="tel:{{$ctrl.phoneNumber}}">
+        <vn-icon
+            flat
+            round
+            icon="phone"
+            title="MicroSIP"
+            ng-click="$event.stopPropagation();"
+        >
+        </vn-icon>
+    </a>
+</span>
+<span ng-if="!$ctrl.phoneNumber">-</span>
diff --git a/front/core/components/link-phone/index.js b/front/core/components/link-phone/index.js
index d5c828f21..6f3eec5b1 100644
--- a/front/core/components/link-phone/index.js
+++ b/front/core/components/link-phone/index.js
@@ -3,8 +3,6 @@ import './style.scss';
 class Controller {
     constructor() {
         this.phoneNumber = null;
-        this.icon = true;
-        this.showNumber = true;
     }
 }
 
@@ -13,7 +11,5 @@ ngModule.vnComponent('vnLinkPhone', {
     controller: Controller,
     bindings: {
         phoneNumber: '<',
-        icon: '<?',
-        showNumber: '<?',
     }
 });
diff --git a/modules/client/front/summary/index.html b/modules/client/front/summary/index.html
index e8418b860..a42e192d0 100644
--- a/modules/client/front/summary/index.html
+++ b/modules/client/front/summary/index.html
@@ -46,14 +46,14 @@
                 value="{{$ctrl.summary.contact}}">
             </vn-label-value>
             <vn-label-value label="Phone">
-                {{$ctrl.summary.phone | dashIfEmpty}}
+                
                 <vn-link-phone
                 phone-number="$ctrl.summary.phone"
                 ></vn-link-phone>
                 
             </vn-label-value>
             <vn-label-value label="Mobile">
-                {{$ctrl.summary.mobile | dashIfEmpty}}
+                
                 <vn-link-phone
                 phone-number="$ctrl.summary.mobile"
                 ></vn-link-phone>
diff --git a/modules/order/front/summary/index.html b/modules/order/front/summary/index.html
index e9bdf33b2..218359992 100644
--- a/modules/order/front/summary/index.html
+++ b/modules/order/front/summary/index.html
@@ -49,7 +49,6 @@
                 value="{{$ctrl.summary.landed | date: 'dd/MM/yyyy HH:mm'}}">
             </vn-label-value>
             <vn-label-value label="Phone">
-                {{$ctrl.summary.address.phone | dashIfEmpty}}
                 <vn-link-phone
                     phone-number="$ctrl.summary.address.phone"
                 ></vn-link-phone>
diff --git a/modules/route/front/roadmap/summary/index.html b/modules/route/front/roadmap/summary/index.html
index aea7e717b..9fab0bf87 100644
--- a/modules/route/front/roadmap/summary/index.html
+++ b/modules/route/front/roadmap/summary/index.html
@@ -26,7 +26,6 @@
             <vn-label-value
                 label="Phone"
             >
-                {{summary.phone | dashIfEmpty}}
                 <vn-link-phone
                 phone-number="summary.phone"
                 ></vn-link-phone>
diff --git a/modules/ticket/front/summary/index.html b/modules/ticket/front/summary/index.html
index 4a92daa39..3c60352a7 100644
--- a/modules/ticket/front/summary/index.html
+++ b/modules/ticket/front/summary/index.html
@@ -84,7 +84,6 @@
             <vn-label-value label="Address phone"
                 ng-if="$ctrl.summary.address.phone != null"
                >
-               {{$ctrl.summary.address.phone | dashIfEmpty}}
                <vn-link-phone
                     phone-number="$ctrl.summary.address.phone"
                ></vn-link-phone>
@@ -92,21 +91,18 @@
             <vn-label-value label="Address mobile"
                 ng-if="$ctrl.summary.address.mobile != null"
             >
-                {{$ctrl.summary.address.mobile | dashIfEmpty}}
                 <vn-link-phone
                     phone-number="$ctrl.summary.address.mobile"
                 ></vn-link-phone>
             </vn-label-value>
             <vn-label-value label="Client phone"
                 ng-if="$ctrl.summary.client.phone != null">
-                {{$ctrl.summary.client.phone | dashIfEmpty}}
                 <vn-link-phone
                     phone-number="$ctrl.summary.client.phone"
                 ></vn-link-phone>
             </vn-label-value>
             <vn-label-value label="Client mobile"
                 ng-if="$ctrl.summary.client.mobile != null">
-                {{$ctrl.summary.client.mobile | dashIfEmpty}}
                 <vn-link-phone
                     phone-number="$ctrl.summary.client.mobile"
                 ></vn-link-phone>
diff --git a/modules/worker/front/descriptor/index.html b/modules/worker/front/descriptor/index.html
index 4a5fb894e..2dfa41ee3 100644
--- a/modules/worker/front/descriptor/index.html
+++ b/modules/worker/front/descriptor/index.html
@@ -38,7 +38,6 @@
             <vn-label-value
                 label="Phone"
             >
-            {{$ctrl.worker.phone | dashIfEmpty}}
                 <vn-link-phone
                     phone-number="$ctrl.worker.phone"
                 ></vn-link-phone>
@@ -46,7 +45,6 @@
             <vn-label-value
                 label="Extension"
             > 
-            {{$ctrl.worker.sip.extension | dashIfEmpty}}
                 <vn-link-phone
                     phone-number="$ctrl.worker.sip.extension"
                 ></vn-link-phone>
diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html
index 1826f30a8..2372634bc 100644
--- a/modules/worker/front/summary/index.html
+++ b/modules/worker/front/summary/index.html
@@ -43,20 +43,17 @@
                 </span>
             </vn-label-value>
             <vn-label-value label="Mobile extension">
-                {{worker.mobileExtension | dashIfEmpty}}
                 <vn-link-phone
                     phone-number="worker.mobileExtension"
                 ></vn-link-phone>
             </vn-label-value>
             <vn-label-value label="Business phone">
-                {{worker.phone | dashIfEmpty}}
                 <vn-link-phone
                     phone-number="worker.phone"
                 ></vn-link-phone>
             </vn-label-value>
             <vn-label-value label="Personal phone"
             >
-            {{worker.client.phone | dashIfEmpty}}
             <vn-link-phone
                 phone-number="worker.client.phone"
             ></vn-link-phone>