From 98e2483565754146a05fe7dd3f2a2773b13ceba3 Mon Sep 17 00:00:00 2001
From: jgallego <jgallego@verdnatura.es>
Date: Sun, 29 Dec 2024 09:38:51 +0100
Subject: [PATCH] feat: refs #8167 update locale and improve invoicing logic
 with error handling

---
 loopback/locale/en.json                              |  9 +++++----
 .../back/methods/invoiceOut/clientsToInvoice.js      | 12 ++++++++----
 .../invoiceOut/specs/clientsToInvoice.spec.js        |  4 ++--
 .../back/methods/ticket/specs/makeInvoice.spec.js    |  4 +++-
 4 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/loopback/locale/en.json b/loopback/locale/en.json
index e6ec52d63..80da13ae5 100644
--- a/loopback/locale/en.json
+++ b/loopback/locale/en.json
@@ -246,8 +246,9 @@
 	"ticketLostExpedition": "The ticket [{{ticketId}}]({{{ticketUrl}}}) has the following lost expedition:{{ expeditionId }}",
 	"The raid information is not correct": "The raid information is not correct",
 	"Payment method is required": "Payment method is required",
-    "Sales already moved": "Sales already moved",
-    "Holidays to past days not available": "Holidays to past days not available",
+	"Sales already moved": "Sales already moved",
+	"Holidays to past days not available": "Holidays to past days not available",
 	"Price cannot be blank": "Price cannot be blank",
-    "There are tickets to be invoiced": "There are tickets to be invoiced"
-}
+	"There are tickets to be invoiced": "There are tickets to be invoiced",
+	"The address of the customer must have information about Incoterms and Customs Agent": "The address of the customer must have information about Incoterms and Customs Agent"
+}
\ No newline at end of file
diff --git a/modules/invoiceOut/back/methods/invoiceOut/clientsToInvoice.js b/modules/invoiceOut/back/methods/invoiceOut/clientsToInvoice.js
index 5526d214a..7befdcbeb 100644
--- a/modules/invoiceOut/back/methods/invoiceOut/clientsToInvoice.js
+++ b/modules/invoiceOut/back/methods/invoiceOut/clientsToInvoice.js
@@ -1,3 +1,5 @@
+const UserError = require('vn-loopback/util/user-error');
+
 module.exports = Self => {
     Self.remoteMethodCtx('clientsToInvoice', {
         description: 'Get the clients to make global invoicing',
@@ -47,7 +49,12 @@ module.exports = Self => {
         }
 
         try {
-            // Packaging liquidation
+            const clientCanBeInvoiced =
+                await Self.app.models.Client.canBeInvoiced(clientId, companyFk, myOptions);
+
+            if (!clientCanBeInvoiced)
+                throw new UserError(`This client can't be invoiced`);
+
             const vIsAllInvoiceable = false;
             await Self.rawSql('CALL ticketPackaging_add(?, ?, ?, ?)', [
                 clientId,
@@ -71,9 +78,6 @@ module.exports = Self => {
                         AND t.shipped BETWEEN ? AND util.dayEnd(?)
                         AND (t.clientFk = ? OR ? IS NULL )
                         AND t.companyFk = ?
-                        AND c.hasToInvoice
-                        AND c.isTaxDataChecked
-                        AND c.isActive
                         AND NOT t.isDeleted
                     GROUP BY IF(c.hasToInvoiceByAddress, a.id, c.id)
                     HAVING SUM(t.totalWithVat) > 0;`;
diff --git a/modules/invoiceOut/back/methods/invoiceOut/specs/clientsToInvoice.spec.js b/modules/invoiceOut/back/methods/invoiceOut/specs/clientsToInvoice.spec.js
index 470690c5a..df0566c54 100644
--- a/modules/invoiceOut/back/methods/invoiceOut/specs/clientsToInvoice.spec.js
+++ b/modules/invoiceOut/back/methods/invoiceOut/specs/clientsToInvoice.spec.js
@@ -4,11 +4,11 @@ describe('InvoiceOut clientsToInvoice()', () => {
     const userId = 1;
     const clientId = 1101;
     const companyFk = 442;
-    const maxShipped = new Date();
+    const maxShipped = Date.vnNew();
     maxShipped.setMonth(11);
     maxShipped.setDate(31);
     maxShipped.setHours(23, 59, 59, 999);
-    const invoiceDate = new Date();
+    const invoiceDate = Date.vnNew();
     const activeCtx = {
         getLocale: () => {
             return 'en';
diff --git a/modules/ticket/back/methods/ticket/specs/makeInvoice.spec.js b/modules/ticket/back/methods/ticket/specs/makeInvoice.spec.js
index 88812dc92..f9e4bcac0 100644
--- a/modules/ticket/back/methods/ticket/specs/makeInvoice.spec.js
+++ b/modules/ticket/back/methods/ticket/specs/makeInvoice.spec.js
@@ -77,6 +77,8 @@ describe('ticket makeInvoice()', () => {
             await tx.rollback();
         }
 
-        expect(error.message).toEqual(`The address of the customer must have information about Incoterms and Customs Agent`);
+        expect(error.message).toEqual(
+            `The address of the customer must have information about Incoterms and Customs Agent`
+        );
     });
 });