From 98ee9bbaf320684102e08f91fee8813abf5c7417 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Mon, 25 Sep 2023 12:54:31 +0200
Subject: [PATCH] ref #5914 back test added

---
 ...rInvoiceACL.sql => 00-transferInvoice.sql} |  6 ++-
 .../invoiceOut/specs/transferinvoice.spec.js  | 43 +++++++++++++++++++
 .../methods/invoiceOut/transferInvoice.js     |  7 +--
 3 files changed, 52 insertions(+), 4 deletions(-)
 rename db/changes/234001/{00-transferInvoiceACL.sql => 00-transferInvoice.sql} (76%)
 create mode 100644 modules/invoiceOut/back/methods/invoiceOut/specs/transferinvoice.spec.js

diff --git a/db/changes/234001/00-transferInvoiceACL.sql b/db/changes/234001/00-transferInvoice.sql
similarity index 76%
rename from db/changes/234001/00-transferInvoiceACL.sql
rename to db/changes/234001/00-transferInvoice.sql
index 2bf4ec6888..f0608327a7 100644
--- a/db/changes/234001/00-transferInvoiceACL.sql
+++ b/db/changes/234001/00-transferInvoice.sql
@@ -3,4 +3,8 @@ INSERT INTO `salix`.`ACL` (model, property, accessType, permission, principalTyp
         ('CplusRectificationType', '*', 'READ', 'ALLOW', 'ROLE', 'administrative'),
         ('CplusInvoiceType477', '*', 'READ', 'ALLOW', 'ROLE', 'administrative'),
         ('InvoiceCorrectionType', '*', 'READ', 'ALLOW', 'ROLE', 'administrative'),
-        ('InvoiceOut', 'transferInvoice', 'WRITE', 'ALLOW', 'ROLE', 'administrative');
\ No newline at end of file
+        ('InvoiceOut', 'transferInvoice', 'WRITE', 'ALLOW', 'ROLE', 'administrative');
+
+INSERT INTO `vn`.`invoiceCorrectionType` (description)
+    VALUES
+        ('Error en el cálculo del IVA')
\ No newline at end of file
diff --git a/modules/invoiceOut/back/methods/invoiceOut/specs/transferinvoice.spec.js b/modules/invoiceOut/back/methods/invoiceOut/specs/transferinvoice.spec.js
new file mode 100644
index 0000000000..cea4ffaccd
--- /dev/null
+++ b/modules/invoiceOut/back/methods/invoiceOut/specs/transferinvoice.spec.js
@@ -0,0 +1,43 @@
+const models = require('vn-loopback/server/server').models;
+
+describe('InvoiceOut tranferInvoice()', () => {
+    const userId = 5;
+    const ctx = {req: {accessToken: userId}};
+    ctx.args = {
+        id: '1',
+        ref: 'T1111111',
+        newClientFk: 1,
+        cplusRectificationId: 1,
+        cplusInvoiceType477Id: 1,
+        invoiceCorrectionTypeId: 1
+    };
+    it('should return the id of the created issued invoice', async() => {
+        const tx = await models.InvoiceOut.beginTransaction({});
+        const options = {transaction: tx};
+        try {
+            const result = await models.InvoiceOut.transferInvoice(
+                ctx,
+                options);
+
+            expect(result).toBeDefined();
+            await tx.rollback();
+        } catch (e) {
+            await tx.rollback();
+            throw e;
+        }
+    });
+
+    it('should throw an UserError when it is the same client', async() => {
+        const tx = await models.InvoiceOut.beginTransaction({});
+        const options = {transaction: tx};
+        try {
+            ctx.args.newClientFk = 1101;
+            await models.InvoiceOut.transferInvoice(
+                ctx,
+                options);
+        } catch (e) {
+            expect(e.message).toBe(`Select a different client`);
+            await tx.rollback();
+        }
+    });
+});
diff --git a/modules/invoiceOut/back/methods/invoiceOut/transferInvoice.js b/modules/invoiceOut/back/methods/invoiceOut/transferInvoice.js
index c4f6e9445d..8a0609b8d2 100644
--- a/modules/invoiceOut/back/methods/invoiceOut/transferInvoice.js
+++ b/modules/invoiceOut/back/methods/invoiceOut/transferInvoice.js
@@ -97,9 +97,10 @@ module.exports = Self => {
                 invoiceCorrectionTypeFk: args.invoiceCorrectionTypeId
             }, myOptions);
 
-            if (tx) await tx.commit();
-
-            await models.InvoiceOut.makePdfAndNotify(ctx, invoiceId, null);
+            if (tx) {
+                await tx.commit();
+                await models.InvoiceOut.makePdfAndNotify(ctx, invoiceId, null);
+            }
 
             return invoiceId;
         } catch (e) {