From 9d75ba0bc56bfe17aa8ab4c849200deff2785ce4 Mon Sep 17 00:00:00 2001
From: Jon <jon@verdnatura.es>
Date: Wed, 8 May 2024 14:12:10 +0200
Subject: [PATCH] refactor: refs #6739 default params

---
 .../front/descriptor-menu/index.html          | 20 ++----------
 .../invoiceOut/front/descriptor-menu/index.js | 31 ++++++++++++-------
 2 files changed, 22 insertions(+), 29 deletions(-)

diff --git a/modules/invoiceOut/front/descriptor-menu/index.html b/modules/invoiceOut/front/descriptor-menu/index.html
index 18ebdda3c..573694807 100644
--- a/modules/invoiceOut/front/descriptor-menu/index.html
+++ b/modules/invoiceOut/front/descriptor-menu/index.html
@@ -1,15 +1,3 @@
-<vn-crud-model
-    auto-load="true"
-    url="CplusRectificationTypes"
-    data="cplusRectificationTypes"
-    order="description">
-</vn-crud-model>
-<vn-crud-model
-    auto-load="true"
-    url="SiiTypeInvoiceOuts"
-    data="siiTypeInvoiceOuts"
-    where="{code: {like: 'R%'}}">
-</vn-crud-model>
 <vn-crud-model
     auto-load="true"
     url="InvoiceCorrectionTypes"
@@ -211,15 +199,14 @@
                     vn-one
                     vn-id="cplusRectificationType"
                     required="true"
-                    data="cplusRectificationTypes"
+                    data="$ctrl.cplusRectificationTypes"
                     show-field="description"
                     value-field="id"
                     ng-model="$ctrl.cplusRectificationType"
-                    ng-init="$ctrl.cplusRectificationType = (cplusRectificationTypes.length > 0 ? cplusRectificationTypes[1].id : null)"
                     search-function="{or: [{id: $search}, {description: {like: '%'+ $search +'%'}}]}"
                     label="Rectificative type">
                     <tpl-item>
-                        {{::description}}
+                    {{ ::description}}
                     </tpl-item>
                 </vn-autocomplete>
             </vn-horizontal>
@@ -227,13 +214,12 @@
                 <vn-autocomplete
                     vn-one
                     vn-id="siiTypeInvoiceOut"
-                    data="siiTypeInvoiceOuts"
+                    data="$ctrl.siiTypeInvoiceOuts"
                     show-field="description"
                     value-field="id"
                     fields="['id','code','description']"
                     required="true"
                     ng-model="$ctrl.siiTypeInvoiceOut"
-                    ng-init="$ctrl.siiTypeInvoiceOut = (siiTypeInvoiceOuts.length > 0 ? siiTypeInvoiceOuts[3].id : null)"
                     label="Class">
                     <tpl-item>
                         {{::code}} - {{::description}}
diff --git a/modules/invoiceOut/front/descriptor-menu/index.js b/modules/invoiceOut/front/descriptor-menu/index.js
index c29e4b788..8047e1c14 100644
--- a/modules/invoiceOut/front/descriptor-menu/index.js
+++ b/modules/invoiceOut/front/descriptor-menu/index.js
@@ -8,6 +8,16 @@ class Controller extends Section {
         this.vnReport = vnReport;
         this.vnEmail = vnEmail;
         this.checked = true;
+        this.$http.get(`CplusRectificationTypes`, {filter: {order: 'description'}})
+            .then(res => {
+                this.cplusRectificationTypes = res.data;
+                this.cplusRectificationType = res.data.filter(type => type.description == 'I – Por diferencias')[0].id;
+            });
+        this.$http.get(`SiiTypeInvoiceOuts`, {filter: {where: {code: {like: 'R%'}}}})
+            .then(res => {
+                this.siiTypeInvoiceOuts = res.data;
+                this.siiTypeInvoiceOut = res.data.filter(type => type.code == 'R4')[0].id;
+            });
     }
 
     get invoiceOut() {
@@ -149,23 +159,20 @@ class Controller extends Section {
             checked: this.checked
         };
 
-        const transferInvoiceRequest = () => {
-            this.$http.post(`InvoiceOuts/transferInvoice`, params).then(res => {
-                const invoiceId = res.data;
-                this.vnApp.showSuccess(this.$t('Transferred invoice'));
-                this.$state.go('invoiceOut.card.summary', {id: invoiceId});
-            });
-        };
-
         this.$http.get(`Clients/${this.clientId}`).then(response => {
             const clientData = response.data;
             const hasToInvoiceByAddress = clientData.hasToInvoiceByAddress;
 
             if (this.checked && hasToInvoiceByAddress) {
-                if (window.confirm('El cliente destino tiene marcado facturar por consignatario, ¿desea continuar?'))
-                    transferInvoiceRequest();
-            } else
-                transferInvoiceRequest();
+                if (!window.confirm('El cliente destino tiene marcado facturar por consignatario, ¿desea continuar?'))
+                    return;
+            }
+
+            this.$http.post(`InvoiceOuts/transferInvoice`, params).then(res => {
+                const invoiceId = res.data;
+                this.vnApp.showSuccess(this.$t('Transferred invoice'));
+                this.$state.go('invoiceOut.card.summary', {id: invoiceId});
+            });
         });
     }
 }