From 9f92bc4b4c5e72bc63385605a115f6d464416dac Mon Sep 17 00:00:00 2001
From: guillermo <guillermo@verdnatura.es>
Date: Fri, 10 Nov 2023 11:43:42 +0100
Subject: [PATCH] fix: refs #6023 Rollback privileges.js

---
 back/methods/vn-user/privileges.js | 66 ++++++++++++------------------
 1 file changed, 27 insertions(+), 39 deletions(-)

diff --git a/back/methods/vn-user/privileges.js b/back/methods/vn-user/privileges.js
index 0520fd5c2..08cfaaae8 100644
--- a/back/methods/vn-user/privileges.js
+++ b/back/methods/vn-user/privileges.js
@@ -40,56 +40,44 @@ module.exports = Self => {
         const userId = ctx.req.accessToken.userId;
 
         const myOptions = {};
-        let tx;
 
         if (typeof options == 'object')
             Object.assign(myOptions, options);
 
-        if (!myOptions.transaction) {
-            tx = await Self.beginTransaction({});
-            myOptions.transaction = tx;
-        };
+        const user = await Self.findById(userId, {fields: ['hasGrant']}, myOptions);
 
-        try {
-            const user = await Self.findById(userId, {fields: ['hasGrant']}, myOptions);
-
-            const userToUpdate = await Self.findById(id, {
-                fields: ['id', 'name', 'hasGrant', 'roleFk', 'password', 'email'],
-                include: {
-                    relation: 'role',
-                    scope: {
-                        fields: ['name']
-                    }
+        const userToUpdate = await Self.findById(id, {
+            fields: ['id', 'name', 'hasGrant', 'roleFk', 'password', 'email'],
+            include: {
+                relation: 'role',
+                scope: {
+                    fields: ['name']
                 }
-            }, myOptions);
+            }
+        }, myOptions);
 
-            if (!user.hasGrant)
-                throw new UserError(`You don't have grant privilege`);
+        if (!user.hasGrant)
+            throw new UserError(`You don't have grant privilege`);
 
-            const hasRoleFromUser = await Self.hasRole(userId, userToUpdate.role().name, myOptions);
+        const hasRoleFromUser = await Self.hasRole(userId, userToUpdate.role().name, myOptions);
 
-            if (!hasRoleFromUser)
+        if (!hasRoleFromUser)
+            throw new UserError(`You don't own the role and you can't assign it to another user`);
+
+        if (hasGrant != null)
+            userToUpdate.hasGrant = hasGrant;
+
+        if (roleFk) {
+            const role = await models.Role.findById(roleFk, {fields: ['name']}, myOptions);
+            const hasRole = await Self.hasRole(userId, role.name, myOptions);
+
+            if (!hasRole)
                 throw new UserError(`You don't own the role and you can't assign it to another user`);
 
-            if (hasGrant != null)
-                userToUpdate.hasGrant = hasGrant;
+            userToUpdate.roleFk = roleFk;
+        }
 
-            if (roleFk) {
-                const role = await models.Role.findById(roleFk, {fields: ['name']}, myOptions);
-                const hasRole = await Self.hasRole(userId, role.name, myOptions);
-
-                if (!hasRole)
-                    throw new UserError(`You don't own the role and you can't assign it to another user`);
-
-                userToUpdate.roleFk = roleFk;
-            }
-
-            await userToUpdate.save(myOptions);
-            await models.Account.sync(userToUpdate.name, null, null, myOptions);
-            if (tx) await tx.commit();
-        } catch (err) {
-            if (tx) await tx.rollback();
-            throw err;
-        };
+        await userToUpdate.save(userToUpdate);
+        await models.Account.sync(userToUpdate.name);
     };
 };