From a0c1388cf0da88ab53a057cd2c0e5334f36ff8ef Mon Sep 17 00:00:00 2001
From: Joan <joan@verdnatura.es>
Date: Thu, 27 Sep 2018 08:46:58 +0200
Subject: [PATCH] fixed billing data

---
 .../methods/client/updateBillingData.js       | 42 +++++++++----------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/services/loopback/common/methods/client/updateBillingData.js b/services/loopback/common/methods/client/updateBillingData.js
index e0abcbb25..e2aee0c41 100644
--- a/services/loopback/common/methods/client/updateBillingData.js
+++ b/services/loopback/common/methods/client/updateBillingData.js
@@ -30,34 +30,34 @@ module.exports = Self => {
 
     Self.updateBillingData = async(ctx, params, id) => {
         let userId = ctx.req.accessToken.userId;
-        let isAdministrative = await Self.app.models.Account.hasRole(userId, 'administrative');
 
-        let client = await Self.app.models.Client.findOne({where: {id: id}});
-
-        if (!isAdministrative && client.isTaxDataChecked)
-            throw new UserError(`You don't have enough privileges to do that`);
-
-        let validUpdateParams = [
+        let data = filterAttributes(params, [
             'payMethodFk',
             'dueDay',
             'iban',
             'hasLcr',
             'hasCoreVnl',
-            'hasSepaVnl'
-        ];
+            'hasSepaVnl']);
 
-        for (const key in params) {
-            if (validUpdateParams.indexOf(key) === -1)
-                throw new UserError(`You don't have enough privileges to do that`);
-        }
+        if (!Object.keys(data).length) return;
 
-        return client.updateAttributes({
-            payMethodFk: params.payMethodFk,
-            dueDay: params.dueDay,
-            iban: params.iban,
-            hasLcr: params.hasLcr,
-            hasCoreVnl: params.hasCoreVnl,
-            hasSepaVnl: params.hasSepaVnl
-        });
+        let isAdministrative = await Self.app.models.Account.hasRole(userId, 'administrative');
+        let client = await Self.app.models.Client.findOne({where: {id: id}});
+
+        if (!isAdministrative && client.isTaxDataChecked)
+            throw new UserError(`You don't have enough privileges to do that`);
+
+        return client.updateAttributes(data);
     };
+
+    function filterAttributes(params, allowed) {
+        let newParams = {};
+
+        Object.keys(params).forEach(attribute => {
+            if (allowed.indexOf(attribute) > -1)
+                newParams[attribute] = params[attribute];
+        });
+
+        return newParams;
+    }
 };