From 879c9b8877664f4ee15d91fdd6897d5382ac44bb Mon Sep 17 00:00:00 2001
From: Gerard <gerard@verdnatura.es>
Date: Mon, 4 Feb 2019 12:24:47 +0100
Subject: [PATCH 1/2] #1093 ticket.descriptor ha dejado de funcionar en el
 modulo item

---
 .../item/front/ticket-descriptor/addStowaway.js   |  8 +++-----
 modules/item/front/ticket-descriptor/index.html   |  5 +++--
 modules/item/front/ticket-descriptor/index.js     | 15 ++++++++++++---
 .../front/ticket-descriptor/removeStowaway.js     |  8 +++-----
 modules/ticket/front/card/index.html              |  2 +-
 5 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/modules/item/front/ticket-descriptor/addStowaway.js b/modules/item/front/ticket-descriptor/addStowaway.js
index b1e530850..514d46503 100644
--- a/modules/item/front/ticket-descriptor/addStowaway.js
+++ b/modules/item/front/ticket-descriptor/addStowaway.js
@@ -20,7 +20,7 @@ class Controller {
         let params = {id: this.possibleStowaways[index].id, shipFk: this.ticket.id};
         this.$http.post(`/api/Stowaways/`, params)
             .then(() => {
-                this.card.reload();
+                this.cardReload();
                 this.vnApp.showSuccess(this.$translate.instant('Data saved!'));
             });
     }
@@ -40,9 +40,7 @@ ngModule.component('vnAddStowaway', {
     template: require('./addStowaway.html'),
     controller: Controller,
     bindings: {
-        ticket: '<'
-    },
-    require: {
-        card: '^vnTicketCard'
+        ticket: '<',
+        cardReload: '&?'
     }
 });
diff --git a/modules/item/front/ticket-descriptor/index.html b/modules/item/front/ticket-descriptor/index.html
index 1dd69d7b8..3e23a2175 100644
--- a/modules/item/front/ticket-descriptor/index.html
+++ b/modules/item/front/ticket-descriptor/index.html
@@ -100,6 +100,7 @@
                 show-field="id"
                 value-field="id"
                 vn-tooltip="Ship stowaways"
+                tooltip-position="up"
                 data="$ctrl.ticket.ship"
                 on-change="$ctrl.goToTicket(value)">
             </vn-button-menu>
@@ -152,5 +153,5 @@
     question="You are going to delete this ticket"
     message="Continue anyway?">
 </vn-confirm>
-<vn-add-stowaway vn-id="addStowaway" ticket="$ctrl.ticket"></vn-add-stowaway>
-<vn-remove-stowaway vn-id="removeStowaway" ticket="$ctrl.ticket"></vn-remove-stowaway>
\ No newline at end of file
+<vn-add-stowaway vn-id="addStowaway" card-reload="$ctrl.cardReload()" ticket="$ctrl.ticket"></vn-add-stowaway>
+<vn-remove-stowaway vn-id="removeStowaway" card-reload="$ctrl.cardReload()" ticket="$ctrl.ticket"></vn-remove-stowaway>
\ No newline at end of file
diff --git a/modules/item/front/ticket-descriptor/index.js b/modules/item/front/ticket-descriptor/index.js
index 91e323ff8..948994701 100644
--- a/modules/item/front/ticket-descriptor/index.js
+++ b/modules/item/front/ticket-descriptor/index.js
@@ -11,7 +11,7 @@ class Controller {
         this.moreOptions = [
             {callback: this.showAddTurnDialog, name: 'Add turn', show: true},
             {callback: this.showDeleteTicketDialog, name: 'Delete ticket', show: true},
-            {callback: this.showAddStowaway, name: 'Add stowaway', show: true},
+            {callback: this.showAddStowaway, name: 'Add stowaway', show: () => this.isTicketModule()},
             {callback: this.showRemoveStowaway, name: 'Remove stowaway', show: () => this.shouldShowRemoveStowaway()},
             /* callback: this.showChangeShipped, name: 'Change shipped hour', show: true} */
         ];
@@ -37,8 +37,16 @@ class Controller {
         }
     }
 
+    isTicketModule() {
+        let path = this.$state.getCurrentPath();
+        if (path[1].state.name === 'ticket')
+            return true;
+
+        return false;
+    }
+
     shouldShowRemoveStowaway() {
-        if (!this._ticket)
+        if (!this._ticket || !this.isTicketModule())
             return false;
 
         return (this._ticket.stowaway || (this._ticket.ship && this._ticket.ship.length > 0));
@@ -157,7 +165,8 @@ Controller.$inject = ['$state', '$scope', '$http', 'vnApp', '$translate'];
 ngModule.component('vnTicketDescriptor', {
     template: require('./index.html'),
     bindings: {
-        ticket: '<'
+        ticket: '<',
+        cardReload: '&'
     },
     controller: Controller
 });
diff --git a/modules/item/front/ticket-descriptor/removeStowaway.js b/modules/item/front/ticket-descriptor/removeStowaway.js
index 6d4e966bf..9553a8a66 100644
--- a/modules/item/front/ticket-descriptor/removeStowaway.js
+++ b/modules/item/front/ticket-descriptor/removeStowaway.js
@@ -46,7 +46,7 @@ class Controller {
     deleteStowaway(response) {
         if (response === 'ACCEPT') {
             this.$http.delete(`/api/Stowaways/${this.stowawayToDelete.id}`).then(res => {
-                this.card.reload();
+                this.cardReload();
                 this.vnApp.showSuccess(this.$translate.instant('Data saved!'));
             });
         }
@@ -72,9 +72,7 @@ ngModule.component('vnRemoveStowaway', {
     template: require('./removeStowaway.html'),
     controller: Controller,
     bindings: {
-        ticket: '<'
-    },
-    require: {
-        card: '^vnTicketCard'
+        ticket: '<',
+        cardReload: '&?'
     }
 });
diff --git a/modules/ticket/front/card/index.html b/modules/ticket/front/card/index.html
index ca8c7d88b..99f8933f3 100644
--- a/modules/ticket/front/card/index.html
+++ b/modules/ticket/front/card/index.html
@@ -1,6 +1,6 @@
 <vn-main-block>
     <div class="left-menu">
-        <vn-ticket-descriptor ticket="$ctrl.ticket"></vn-ticket-descriptor>
+        <vn-ticket-descriptor ticket="$ctrl.ticket" card-reload="$ctrl.reload()"></vn-ticket-descriptor>
         <vn-left-menu></vn-left-menu>
     </div>
     <div class="content-block" ui-view></div>

From 3869742fd7a3bc08fae68eaca4cc273361879129 Mon Sep 17 00:00:00 2001
From: Gerard <gerard@verdnatura.es>
Date: Mon, 4 Feb 2019 12:41:38 +0100
Subject: [PATCH 2/2] =?UTF-8?q?#1088=20ticket.descriptor=20a=C3=B1adir=20p?=
 =?UTF-8?q?olizon=20interval=20server=20error?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 modules/ticket/back/methods/ticket/getPossibleStowaways.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/modules/ticket/back/methods/ticket/getPossibleStowaways.js b/modules/ticket/back/methods/ticket/getPossibleStowaways.js
index 4ff5fa9d5..581a0a9c3 100644
--- a/modules/ticket/back/methods/ticket/getPossibleStowaways.js
+++ b/modules/ticket/back/methods/ticket/getPossibleStowaways.js
@@ -20,6 +20,10 @@ module.exports = Self => {
 
     Self.getPossibleStowaways = async ticketFk => {
         let ship = await Self.app.models.Ticket.findById(ticketFk);
+
+        if (!ship || !ship.shipped)
+            return [];
+
         let lowestDate = new Date(ship.shipped.getTime());
         lowestDate.setHours(0, 0, -1, 0);