From e4595da2a7bb438f1233c0d8eb5bce3ea53e872c Mon Sep 17 00:00:00 2001
From: Juan Ferrer Toribio <juan.ferrer.toribio@gmail.com>
Date: Wed, 14 Feb 2018 10:03:00 +0100
Subject: [PATCH] E2E test partially fixed

---
 .../src/components/main-menu/main-menu.html   | 19 ++++++++++---------
 e2e/helpers/extensions.js                     | 16 ++++++++--------
 e2e/helpers/selectors.js                      |  1 -
 gulpfile.js                                   |  2 +-
 services/loopback/common/locale/en.json       |  3 ++-
 5 files changed, 21 insertions(+), 20 deletions(-)

diff --git a/client/salix/src/components/main-menu/main-menu.html b/client/salix/src/components/main-menu/main-menu.html
index 4bd1f950f..116aab0c9 100644
--- a/client/salix/src/components/main-menu/main-menu.html
+++ b/client/salix/src/components/main-menu/main-menu.html
@@ -1,14 +1,5 @@
 <div style="position: fixed; top: 0; right: 0; padding: .8em 1.5em; z-index: 10;">
     <vn-icon icon="apps" id="apps" translate-attr="{title: 'Applications'}"></vn-icon>
-    <ul for="langs" class="mdl-menu mdl-js-menu mdl-menu--bottom-right" pad-small>
-        <li
-            ng-repeat="lang in ::$ctrl.langs"
-            class="mdl-menu__item"
-            ng-click="$ctrl.onChangeLangClick(lang)">
-            <span>{{::lang}}</span>
-        </li>
-    </ul>
-    <vn-icon icon="language" id="langs" translate-attr="{title: 'Change language'}"></vn-icon>
     <ul for="apps" class="mdl-menu mdl-js-menu mdl-menu--bottom-right" pad-small>
         <li ng-repeat="mod in ::$ctrl.modules" class="mdl-menu__item" ui-sref="{{::mod.route.state}}">
             <vn-icon ng-if="::mod.icon && !mod.icon.startsWith('/')" icon="{{::mod.icon}}"></vn-icon>
@@ -16,6 +7,16 @@
             <span translate="{{::mod.name}}"></span>
         </li>
     </ul>
+    <vn-icon id="lang-button" icon="language" translate-attr="{title: 'Change language'}"></vn-icon>
+    <ul id="langs" for="lang-button" class="mdl-menu mdl-js-menu mdl-menu--bottom-right" pad-small>
+        <li
+            ng-repeat="lang in ::$ctrl.langs"
+            name="{{::lang}}"
+            class="mdl-menu__item"
+            ng-click="$ctrl.onChangeLangClick(lang)">
+            <span>{{::lang}}</span>
+        </li>
+    </ul>
     <vn-icon icon="exit_to_app" translate-attr="{title: 'Logout'}" ng-click="$ctrl.onLogoutClick()"></vn-icon>
 <!--
     TODO: Keep it commented until they are functional
diff --git a/e2e/helpers/extensions.js b/e2e/helpers/extensions.js
index a90d4f410..f7a568d82 100644
--- a/e2e/helpers/extensions.js
+++ b/e2e/helpers/extensions.js
@@ -128,17 +128,17 @@ Nightmare.action('waitForTextInElement', function(selector, name, done) {
 });
 
 Nightmare.action('changeLanguageToEnglish', function(done) {
-    this.wait(selectors.globalItems.languageButton)
+    this.wait('#lang-button')
     .evaluate(selector => {
         return document.querySelector(selector).title;
-    }, selectors.globalItems.languageButton)
-    .then(result => {
-        if (result === 'Cambiar idioma') {
-            this.click(selectors.globalItems.languageButton)
-            .then(done);
-        }
-        if (result === 'Change language') {
+    }, '#lang-button')
+    .then(title => {
+        if (title === 'Change language') {
             this.then(done);
+        } else {
+            this.click('#lang-button')
+            .click('#langs > li[name="en"]')
+            .then(done);
         }
     });
 });
diff --git a/e2e/helpers/selectors.js b/e2e/helpers/selectors.js
index 2aaa6ddd4..013d34627 100644
--- a/e2e/helpers/selectors.js
+++ b/e2e/helpers/selectors.js
@@ -10,7 +10,6 @@ export default {
     globalItems: {
         topBar: `${components.vnTopbar}`,
         logOutButton: `${components.vnIcon}[icon="exit_to_app"]`,
-        languageButton: `${components.vnIcon}[icon="language"]`,
         snackbarIsActive: '.mdl-snackbar--active > .mdl-snackbar__text',
         applicationsMenuButton: `${components.vnIcon}[icon="apps"]`,
         applicationsMenuVisible: `${components.vnMainMenu} .is-visible > div`,
diff --git a/gulpfile.js b/gulpfile.js
index 4a4c29ec2..05bcc6b76 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -52,7 +52,7 @@ gulp.task('services', async () => {
 });
 
 /**
- * Starts all backend services.
+ * Starts backend services.
  */
 gulp.task('services-only', async () => {
     const services = await getServices();
diff --git a/services/loopback/common/locale/en.json b/services/loopback/common/locale/en.json
index 18e98b233..ce4eb95f2 100644
--- a/services/loopback/common/locale/en.json
+++ b/services/loopback/common/locale/en.json
@@ -4,5 +4,6 @@
 	"Unable to mark the equivalence surcharge": "Unable to mark the equivalence surcharge",
 	"The default consignee can not be unchecked": "The default consignee can not be unchecked",
 	"Unable to default a disabled consignee": "Unable to default a disabled consignee",
-	"El método de pago seleccionado requiere que se especifique el IBAN": "El método de pago seleccionado requiere que se especifique el IBAN"
+	"El método de pago seleccionado requiere que se especifique el IBAN": "El método de pago seleccionado requiere que se especifique el IBAN",
+	"Ya existe un usuario con ese nombre": "Ya existe un usuario con ese nombre"
 }
\ No newline at end of file