From a995d80b46270d82e76f841f648f0f35c8222c6a Mon Sep 17 00:00:00 2001
From: guillermo <guillermo@verdnatura.es>
Date: Tue, 20 Aug 2024 10:58:26 +0200
Subject: [PATCH] feat: refs #3199 Requested changes

---
 .../vn/procedures/ticket_recalcByScope.sql    | 25 +++++++++++--------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/db/routines/vn/procedures/ticket_recalcByScope.sql b/db/routines/vn/procedures/ticket_recalcByScope.sql
index 1541b532e..9199325ee 100644
--- a/db/routines/vn/procedures/ticket_recalcByScope.sql
+++ b/db/routines/vn/procedures/ticket_recalcByScope.sql
@@ -14,22 +14,26 @@ BEGIN
 	DECLARE vTicketFk INT;
 
 	DECLARE cTickets CURSOR FOR
+		SELECT DISTINCT t.id
+			FROM ticket t
+				LEFT JOIN tItemCalc tic ON tic.id = t.id
+			WHERE t.refFk IS NULL
+				AND ((vScope = 'client' AND t.clientFk = vId)
+					OR (vScope = 'address' AND t.addressFk = vId)
+					OR (vScope = 'item' AND tic.id)
+				);
+
+	DECLARE CONTINUE HANDLER FOR NOT FOUND SET vDone = TRUE;
+
+	CREATE OR REPLACE TEMPORARY TABLE tItemCalc
 		SELECT DISTINCT t.id
 			FROM ticket t
 				JOIN sale s ON s.ticketFk = t.id
 				JOIN itemTaxCountry itc ON itc.itemFk = s.itemFk
 			WHERE t.refFk IS NULL
-				AND (
-					(vScope = 'client' AND t.clientFk = vId)
-					OR (vScope = 'address' AND t.addressFk = vId)
-					OR (vScope = 'item' AND itc.itemFk = vId)
-				);
-
-	DECLARE CONTINUE HANDLER FOR NOT FOUND
-		SET vDone = TRUE;
+				AND (vScope = 'item' AND itc.itemFk = vId);
 
 	OPEN cTickets;
-
 	myLoop: LOOP
 		SET vDone = FALSE;
 		FETCH cTickets INTO vTicketFk;
@@ -40,7 +44,8 @@ BEGIN
 
 		CALL ticket_recalc(vTicketFk, NULL);
 	END LOOP;
-
 	CLOSE cTickets;
+
+	DROP TEMPORARY TABLE tItemCalc;
 END$$
 DELIMITER ;