Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 4649-bookEntriesIncorrectly_notification

db/changes/225201/00-ticket_canbePostponed.sql

@@ -0,0 +1,73 @@
+DROP PROCEDURE IF EXISTS `vn`.`ticket_canbePostponed`;
+
+DELIMITER $$
+$$
+CREATE DEFINER=`root`@`localhost` PROCEDURE `vn`.`ticket_canbePostponed`(vOriginDated DATE, vFutureDated DATE, vWarehouseFk INT)
+BEGIN
+/**
+ * Devuelve un listado de tickets susceptibles de fusionarse con otros tickets en el futuro
+ *
+ * @param vOriginDated Fecha en cuestión
+ * @param vFutureDated Fecha en el futuro a sondear
+ * @param vWarehouseFk Identificador de vn.warehouse
+ */
+	DROP TEMPORARY TABLE IF EXISTS tmp.filter;
+	CREATE TEMPORARY TABLE tmp.filter
+        (INDEX (id))
+	SELECT 	sv.ticketFk id,
+			sub2.id futureId,
+			GROUP_CONCAT(DISTINCT i.itemPackingTypeFk ORDER BY i.itemPackingTypeFk) ipt,
+			CAST(sum(litros) AS DECIMAL(10,0)) liters,
+			CAST(count(*) AS DECIMAL(10,0)) `lines`,
+			st.name state,
+			sub2.iptd futureIpt,
+			sub2.state futureState,
+			t.clientFk,
+			t.warehouseFk,
+			ts.alertLevel,
+			t.shipped,
+			sub2.shipped futureShipped,
+			t.workerFk,
+			st.code stateCode,
+			sub2.code futureStateCode
+		FROM vn.saleVolume sv
+			JOIN vn.sale s ON s.id = sv.saleFk
+			JOIN vn.item i ON i.id = s.itemFk
+			JOIN vn.ticket t ON t.id = sv.ticketFk
+			JOIN vn.address a ON a.id = t.addressFk
+			JOIN vn.province p ON p.id = a.provinceFk
+			JOIN vn.country c ON c.id = p.countryFk
+			JOIN vn.ticketState ts ON ts.ticketFk = t.id
+			JOIN vn.state st ON st.id = ts.stateFk
+			JOIN vn.alertLevel al ON al.id = ts.alertLevel
+			LEFT JOIN vn.ticketParking tp ON tp.ticketFk = t.id
+			LEFT JOIN (
+				SELECT *
+					FROM (
+						SELECT
+							t.addressFk,
+							t.id,
+							t.shipped,
+							st.name state,
+							st.code code,
+							GROUP_CONCAT(DISTINCT i.itemPackingTypeFk ORDER BY i.itemPackingTypeFk) iptd
+							FROM vn.ticket t
+								JOIN vn.ticketState ts ON ts.ticketFk = t.id
+								JOIN vn.state st ON st.id = ts.stateFk
+								JOIN vn.sale s ON s.ticketFk = t.id
+								JOIN vn.item i ON i.id = s.itemFk
+							WHERE t.shipped BETWEEN vFutureDated
+											AND util.dayend(vFutureDated)
+								AND t.warehouseFk = vWarehouseFk
+							GROUP BY t.id
+					) sub
+					GROUP BY sub.addressFk
+				) sub2 ON sub2.addressFk = t.addressFk AND t.id != sub2.id
+		WHERE t.shipped BETWEEN vOriginDated AND util.dayend(vOriginDated)
+			AND t.warehouseFk = vWarehouseFk
+			AND al.code = 'FREE'
+			AND tp.ticketFk IS NULL
+		GROUP BY sv.ticketFk
+		HAVING futureId;
+END$$
+DELIMITER ;

e2e/helpers/selectors.js

@@ -735,18 +735,16 @@ export default {
     },
     ticketFuture: {
         openAdvancedSearchButton: 'vn-searchbar .append vn-icon[icon="arrow_drop_down"]',
-        originDated: 'vn-date-picker[label="Origin ETD"]',
+        originDated: 'vn-date-picker[label="Origin date"]',
-        futureDated: 'vn-date-picker[label="Destination ETD"]',
+        futureDated: 'vn-date-picker[label="Destination date"]',
-        shipped: 'vn-date-picker[label="Origin date"]',
-        tfShipped: 'vn-date-picker[label="Destination date"]',
         linesMax: 'vn-textfield[label="Max Lines"]',
         litersMax: 'vn-textfield[label="Max Liters"]',
         ipt: 'vn-autocomplete[label="Origin IPT"]',
-        tfIpt: 'vn-autocomplete[label="Destination IPT"]',
+        futureIpt: 'vn-autocomplete[label="Destination IPT"]',
         tableIpt: 'vn-autocomplete[name="ipt"]',
-        tableTfIpt: 'vn-autocomplete[name="tfIpt"]',
+        tableFutureIpt: 'vn-autocomplete[name="futureIpt"]',
         state: 'vn-autocomplete[label="Origin Grouped State"]',
-        tfState: 'vn-autocomplete[label="Destination Grouped State"]',
+        futureState: 'vn-autocomplete[label="Destination Grouped State"]',
         warehouseFk: 'vn-autocomplete[label="Warehouse"]',
         problems: 'vn-check[label="With problems"]',
         tableButtonSearch: 'vn-button[vn-tooltip="Search"]',
@@ -755,9 +753,9 @@ export default {
         firstCheck: 'tbody > tr:nth-child(1) > td > vn-check',
         multiCheck: 'vn-multi-check',
         tableId: 'vn-textfield[name="id"]',
-        tableTfId: 'vn-textfield[name="ticketFuture"]',
+        tableFutureId: 'vn-textfield[name="futureId"]',
-        tableLiters: 'vn-textfield[name="litersMax"]',
+        tableLiters: 'vn-textfield[name="liters"]',
-        tableLines: 'vn-textfield[name="linesMax"]',
+        tableLines: 'vn-textfield[name="lines"]',
         submit: 'vn-submit[label="Search"]',
         table: 'tbody > tr:not(.empty-rows)'
     },

e2e/paths/05-ticket/21_future.spec.js

@@ -16,9 +16,6 @@ describe('Ticket Future path', () => {
         await browser.close();
     });
 
-    const now = new Date();
-    const tomorrow = new Date(now.getDate() + 1);
-
     it('should show errors snackbar because of the required data', async() => {
         await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
         await page.clearInput(selectors.ticketFuture.warehouseFk);
@@ -27,20 +24,6 @@ describe('Ticket Future path', () => {
 
         expect(message.text).toContain('warehouseFk is a required argument');
 
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.litersMax);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('litersMax is a required argument');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.linesMax);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('linesMax is a required argument');
-
         await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
         await page.clearInput(selectors.ticketFuture.futureDated);
         await page.waitToClick(selectors.ticketFuture.submit);
@@ -62,44 +45,13 @@ describe('Ticket Future path', () => {
         await page.waitForNumberOfElements(selectors.ticketFuture.table, 4);
     });
 
-    it('should search with the origin shipped today', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.pickDate(selectors.ticketFuture.shipped, now);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        await page.waitForNumberOfElements(selectors.ticketFuture.table, 4);
-    });
-
-    it('should search with the origin shipped tomorrow', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.pickDate(selectors.ticketFuture.shipped, tomorrow);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        await page.waitForNumberOfElements(selectors.ticketFuture.table, 0);
-    });
-
-    it('should search with the destination shipped today', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.shipped);
-        await page.pickDate(selectors.ticketFuture.tfShipped, now);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        await page.waitForNumberOfElements(selectors.ticketFuture.table, 4);
-    });
-
-    it('should search with the destination shipped tomorrow', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.pickDate(selectors.ticketFuture.tfShipped, tomorrow);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        await page.waitForNumberOfElements(selectors.ticketFuture.table, 0);
-    });
-
     it('should search with the origin IPT', async() => {
         await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
 
-        await page.clearInput(selectors.ticketFuture.shipped);
-        await page.clearInput(selectors.ticketFuture.tfShipped);
         await page.clearInput(selectors.ticketFuture.ipt);
-        await page.clearInput(selectors.ticketFuture.tfIpt);
+        await page.clearInput(selectors.ticketFuture.futureIpt);
         await page.clearInput(selectors.ticketFuture.state);
-        await page.clearInput(selectors.ticketFuture.tfState);
+        await page.clearInput(selectors.ticketFuture.futureState);
 
         await page.autocompleteSearch(selectors.ticketFuture.ipt, 'Horizontal');
         await page.waitToClick(selectors.ticketFuture.submit);
@@ -109,14 +61,12 @@ describe('Ticket Future path', () => {
     it('should search with the destination IPT', async() => {
         await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
 
-        await page.clearInput(selectors.ticketFuture.shipped);
-        await page.clearInput(selectors.ticketFuture.tfShipped);
         await page.clearInput(selectors.ticketFuture.ipt);
-        await page.clearInput(selectors.ticketFuture.tfIpt);
+        await page.clearInput(selectors.ticketFuture.futureIpt);
         await page.clearInput(selectors.ticketFuture.state);
-        await page.clearInput(selectors.ticketFuture.tfState);
+        await page.clearInput(selectors.ticketFuture.futureState);
 
-        await page.autocompleteSearch(selectors.ticketFuture.tfIpt, 'Horizontal');
+        await page.autocompleteSearch(selectors.ticketFuture.futureIpt, 'Horizontal');
         await page.waitToClick(selectors.ticketFuture.submit);
         await page.waitForNumberOfElements(selectors.ticketFuture.table, 0);
     });
@@ -124,12 +74,10 @@ describe('Ticket Future path', () => {
     it('should search with the origin grouped state', async() => {
         await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
 
-        await page.clearInput(selectors.ticketFuture.shipped);
-        await page.clearInput(selectors.ticketFuture.tfShipped);
         await page.clearInput(selectors.ticketFuture.ipt);
-        await page.clearInput(selectors.ticketFuture.tfIpt);
+        await page.clearInput(selectors.ticketFuture.futureIpt);
         await page.clearInput(selectors.ticketFuture.state);
-        await page.clearInput(selectors.ticketFuture.tfState);
+        await page.clearInput(selectors.ticketFuture.futureState);
 
         await page.autocompleteSearch(selectors.ticketFuture.state, 'Free');
         await page.waitToClick(selectors.ticketFuture.submit);
@@ -139,24 +87,20 @@ describe('Ticket Future path', () => {
     it('should search with the destination grouped state', async() => {
         await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
 
-        await page.clearInput(selectors.ticketFuture.shipped);
-        await page.clearInput(selectors.ticketFuture.tfShipped);
         await page.clearInput(selectors.ticketFuture.ipt);
-        await page.clearInput(selectors.ticketFuture.tfIpt);
+        await page.clearInput(selectors.ticketFuture.futureIpt);
         await page.clearInput(selectors.ticketFuture.state);
-        await page.clearInput(selectors.ticketFuture.tfState);
+        await page.clearInput(selectors.ticketFuture.futureState);
 
-        await page.autocompleteSearch(selectors.ticketFuture.tfState, 'Free');
+        await page.autocompleteSearch(selectors.ticketFuture.futureState, 'Free');
         await page.waitToClick(selectors.ticketFuture.submit);
         await page.waitForNumberOfElements(selectors.ticketFuture.table, 0);
 
         await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.shipped);
-        await page.clearInput(selectors.ticketFuture.tfShipped);
         await page.clearInput(selectors.ticketFuture.ipt);
-        await page.clearInput(selectors.ticketFuture.tfIpt);
+        await page.clearInput(selectors.ticketFuture.futureIpt);
         await page.clearInput(selectors.ticketFuture.state);
-        await page.clearInput(selectors.ticketFuture.tfState);
+        await page.clearInput(selectors.ticketFuture.futureState);
 
         await page.waitToClick(selectors.ticketFuture.submit);
         await page.waitForNumberOfElements(selectors.ticketFuture.table, 4);
@@ -176,7 +120,7 @@ describe('Ticket Future path', () => {
 
     it('should search in smart-table with an ID Destination', async() => {
         await page.waitToClick(selectors.ticketFuture.tableButtonSearch);
-        await page.write(selectors.ticketFuture.tableTfId, '12');
+        await page.write(selectors.ticketFuture.tableFutureId, '12');
         await page.keyboard.press('Enter');
         await page.waitForNumberOfElements(selectors.ticketFuture.table, 5);
 
@@ -199,7 +143,7 @@ describe('Ticket Future path', () => {
 
     it('should search in smart-table with an IPT Destination', async() => {
         await page.waitToClick(selectors.ticketFuture.tableButtonSearch);
-        await page.autocompleteSearch(selectors.ticketFuture.tableTfIpt, 'Vertical');
+        await page.autocompleteSearch(selectors.ticketFuture.tableFutureIpt, 'Vertical');
         await page.waitForNumberOfElements(selectors.ticketFuture.table, 1);
 
         await page.waitToClick(selectors.ticketFuture.tableButtonSearch);

front/core/components/smart-table/index.js

@@ -147,7 +147,7 @@ export default class SmartTable extends Component {
         for (const column of this.columns) {
             if (viewConfig.configuration[column.field] == false) {
                 const baseSelector = `smart-table[view-config-id="${this.viewConfigId}"] table`;
-                selectors.push(`${baseSelector} thead > tr > th:nth-child(${column.index + 1})`);
+                selectors.push(`${baseSelector} thead > tr:not([second-header]) > th:nth-child(${column.index + 1})`);
                 selectors.push(`${baseSelector} tbody > tr > td:nth-child(${column.index + 1})`);
             }
         }
@@ -235,7 +235,7 @@ export default class SmartTable extends Component {
     }
 
     registerColumns() {
-        const header = this.element.querySelector('thead > tr');
+        const header = this.element.querySelector('thead > tr:not([second-header])');
         if (!header) return;
         const columns = header.querySelectorAll('th');
 
@@ -254,7 +254,7 @@ export default class SmartTable extends Component {
     }
 
     emptyDataRows() {
-        const header = this.element.querySelector('thead > tr');
+        const header = this.element.querySelector('thead > tr:not([second-header])');
         const columns = header.querySelectorAll('th');
         const tbody = this.element.querySelector('tbody');
         if (tbody) {
@@ -333,7 +333,7 @@ export default class SmartTable extends Component {
     }
 
     displaySearch() {
-        const header = this.element.querySelector('thead > tr');
+        const header = this.element.querySelector('thead > tr:not([second-header])');
         if (!header) return;
 
         const tbody = this.element.querySelector('tbody');

front/core/components/smart-table/table.scss

@@ -8,6 +8,16 @@ smart-table table {
     & > thead {
         border-bottom: $border;
 
+        & > tr[second-header] {
+            & > th
+            {
+                text-align: center;
+                border-bottom-style: groove;
+                font-weight: bold;
+                text-transform: uppercase;
+            }
+        }
+
         & > * > th {
             font-weight: normal;
         }
@@ -60,6 +70,9 @@ smart-table table {
                         vertical-align: middle;
                     }
                 }
+                &[separator]{
+                    border-left-style: groove;
+                }
                 vn-icon.bright, i.bright {
                     color: #f7931e;
                 }

front/salix/components/index.js

@@ -19,3 +19,4 @@ import './user-popover';
 import './upload-photo';
 import './bank-entity';
 import './log';
+import './sendSms';

front/salix/components/sendSms/index.js

@@ -1,19 +1,26 @@
-import ngModule from '../module';
+import ngModule from '../../module';
-import Component from 'core/lib/component';
 import './style.scss';
+import Dialog from '../../../core/components/dialog';
+
+export default class sendSmsDialog extends Dialog {
+    constructor($element, $scope, $http, $translate, vnApp) {
+        super($element, $scope, $http, $translate, vnApp);
+
+        new CustomEvent('openSmsDialog', {
+            detail: {
+                this: this
+            }
+        });
+    }
 
-class Controller extends Component {
     open() {
         this.$.SMSDialog.show();
     }
 
     charactersRemaining() {
-        const element = this.$.message;
+        const element = this.sms.message;
-        const value = element.input.value;
-
         const maxLength = 160;
-        const textAreaLength = new Blob([value]).size;
+        return maxLength - element.length;
-        return maxLength - textAreaLength;
     }
 
     onResponse() {
@@ -25,23 +32,19 @@ class Controller extends Component {
             if (this.charactersRemaining() < 0)
                 throw new Error(`The message it's too long`);
 
-            this.$http.post(`Tickets/${this.sms.ticketId}/sendSms`, this.sms).then(res => {
+            return this.onSend({$sms: this.sms});
-                this.vnApp.showMessage(this.$t('SMS sent!'));
-
-                if (res.data) this.emit('send', {response: res.data});
-            });
         } catch (e) {
             this.vnApp.showError(this.$t(e.message));
             return false;
         }
-        return true;
     }
 }
 
-ngModule.vnComponent('vnTicketSms', {
+ngModule.vnComponent('vnSmsDialog', {
     template: require('./index.html'),
-    controller: Controller,
+    controller: sendSmsDialog,
     bindings: {
         sms: '<',
+        onSend: '&',
     }
 });

loopback/locale/en.json

@@ -140,7 +140,7 @@
 	"You don't have grant privilege": "You don't have grant privilege",
 	"You don't own the role and you can't assign it to another user": "You don't own the role and you can't assign it to another user",
     "Email verify": "Email verify",
-	"Ticket merged": "Ticket [{{id}}]({{{fullPath}}}) ({{{originDated}}}) merged with [{{tfId}}]({{{fullPathFuture}}}) ({{{futureDated}}})",
+	"Ticket merged": "Ticket [{{originId}}]({{{originFullPath}}}) ({{{originDated}}}) merged with [{{destinationId}}]({{{destinationFullPath}}}) ({{{destinationDated}}})",
     "Sale(s) blocked, please contact production": "Sale(s) blocked, please contact production",
     "Receipt's bank was not found": "Receipt's bank was not found",
     "This receipt was not compensated": "This receipt was not compensated",

loopback/locale/es.json

@@ -241,7 +241,7 @@
 	"Claim pickup order sent": "Reclamación Orden de recogida enviada [{{claimId}}]({{{claimUrl}}}) al cliente *{{clientName}}*",
 	"You don't have grant privilege": "No tienes privilegios para dar privilegios",
 	"You don't own the role and you can't assign it to another user": "No eres el propietario del rol y no puedes asignarlo a otro usuario",
-	"Ticket merged": "Ticket [{{id}}]({{{fullPath}}}) ({{{originDated}}}) fusionado con [{{tfId}}]({{{fullPathFuture}}}) ({{{futureDated}}})",
+	"Ticket merged": "Ticket [{{originId}}]({{{originFullPath}}}) ({{{originDated}}}) fusionado con [{{destinationId}}]({{{destinationFullPath}}}) ({{{destinationDated}}})",
 	"Already has this status": "Ya tiene este estado",
 	"There aren't records for this week": "No existen registros para esta semana",
 	"Empty data source": "Origen de datos vacio",

modules/client/front/descriptor/index.html

@@ -113,10 +113,11 @@
         </div>
     </slot-body>
 </vn-descriptor-content>
-<vn-client-sms
+<vn-sms-dialog
     vn-id="sms"
+    on-send="$ctrl.onSmsSend($sms)"
     sms="$ctrl.newSMS">
-</vn-client-sms>
+</vn-sms-dialog>
 <vn-worker-descriptor-popover 
     vn-id="workerDescriptor">
 </vn-worker-descriptor-popover>

modules/client/front/descriptor/index.js

@@ -39,6 +39,11 @@ class Controller extends Descriptor {
         };
         this.$.sms.open();
     }
+
+    onSmsSend(sms) {
+        return this.$http.post(`Clients/${this.id}/sendSms`, sms)
+            .then(() => this.vnApp.showSuccess(this.$t('SMS sent')));
+    }
 }
 
 ngModule.vnComponent('vnClientDescriptor', {

modules/client/front/index.js

@@ -35,7 +35,6 @@ import './sample/index';
 import './sample/create';
 import './web-payment';
 import './log';
-import './sms';
 import './postcode';
 import './postcode/province';
 import './postcode/city';

modules/client/front/sms/index.js

@@ -1,49 +0,0 @@
-import ngModule from '../module';
-import Section from 'salix/components/section';
-import './style.scss';
-
-class Controller extends Section {
-    open() {
-        this.$.SMSDialog.show();
-    }
-
-    charactersRemaining() {
-        const element = this.$.message;
-        const value = element.input.value;
-
-        const maxLength = 160;
-        const textAreaLength = new Blob([value]).size;
-        return maxLength - textAreaLength;
-    }
-
-    onResponse() {
-        try {
-            if (!this.sms.destination)
-                throw new Error(`The destination can't be empty`);
-            if (!this.sms.message)
-                throw new Error(`The message can't be empty`);
-            if (this.charactersRemaining() < 0)
-                throw new Error(`The message it's too long`);
-
-            this.$http.post(`Clients/${this.$params.id}/sendSms`, this.sms).then(res => {
-                this.vnApp.showMessage(this.$t('SMS sent!'));
-
-                if (res.data) this.emit('send', {response: res.data});
-            });
-        } catch (e) {
-            this.vnApp.showError(this.$t(e.message));
-            return false;
-        }
-        return true;
-    }
-}
-
-Controller.$inject = ['$element', '$scope', '$http', '$translate', 'vnApp'];
-
-ngModule.vnComponent('vnClientSms', {
-    template: require('./index.html'),
-    controller: Controller,
-    bindings: {
-        sms: '<',
-    }
-});

modules/client/front/sms/index.spec.js

@@ -1,74 +0,0 @@
-import './index';
-
-describe('Client', () => {
-    describe('Component vnClientSms', () => {
-        let controller;
-        let $httpBackend;
-        let $element;
-
-        beforeEach(ngModule('client'));
-
-        beforeEach(inject(($componentController, $rootScope, _$httpBackend_) => {
-            $httpBackend = _$httpBackend_;
-            let $scope = $rootScope.$new();
-            $element = angular.element('<vn-dialog></vn-dialog>');
-            controller = $componentController('vnClientSms', {$element, $scope});
-            controller.client = {id: 1101};
-            controller.$params = {id: 1101};
-            controller.$.message = {
-                input: {
-                    value: 'My SMS'
-                }
-            };
-        }));
-
-        describe('onResponse()', () => {
-            it('should perform a POST query and show a success snackbar', () => {
-                let params = {destinationFk: 1101, destination: 111111111, message: 'My SMS'};
-                controller.sms = {destinationFk: 1101, destination: 111111111, message: 'My SMS'};
-
-                jest.spyOn(controller.vnApp, 'showMessage');
-                $httpBackend.expect('POST', `Clients/1101/sendSms`, params).respond(200, params);
-
-                controller.onResponse();
-                $httpBackend.flush();
-
-                expect(controller.vnApp.showMessage).toHaveBeenCalledWith('SMS sent!');
-            });
-
-            it('should call onResponse without the destination and show an error snackbar', () => {
-                controller.sms = {destinationFk: 1101, message: 'My SMS'};
-
-                jest.spyOn(controller.vnApp, 'showError');
-
-                controller.onResponse('accept');
-
-                expect(controller.vnApp.showError).toHaveBeenCalledWith(`The destination can't be empty`);
-            });
-
-            it('should call onResponse without the message and show an error snackbar', () => {
-                controller.sms = {destinationFk: 1101, destination: 222222222};
-
-                jest.spyOn(controller.vnApp, 'showError');
-
-                controller.onResponse('accept');
-
-                expect(controller.vnApp.showError).toHaveBeenCalledWith(`The message can't be empty`);
-            });
-        });
-
-        describe('charactersRemaining()', () => {
-            it('should return the characters remaining in a element', () => {
-                controller.$.message = {
-                    input: {
-                        value: 'My message 0€'
-                    }
-                };
-
-                let result = controller.charactersRemaining();
-
-                expect(result).toEqual(145);
-            });
-        });
-    });
-});

modules/invoiceOut/back/methods/invoiceOut/downloadZip.js

@@ -9,31 +9,43 @@ module.exports = Self => {
         accepts: [
             {
                 arg: 'ids',
-                type: ['number'],
+                type: 'string',
-                description: 'The invoice ids'
+                description: 'The invoices ids',
             }
         ],
-        returns: {
+        returns: [
-            arg: 'base64',
+            {
-            type: 'string',
+                arg: 'body',
+                type: 'file',
                 root: true
-        },
+            }, {
+                arg: 'Content-Type',
+                type: 'string',
+                http: {target: 'header'}
+            }, {
+                arg: 'Content-Disposition',
+                type: 'string',
+                http: {target: 'header'}
+            }
+        ],
         http: {
             path: '/downloadZip',
-            verb: 'POST'
+            verb: 'GET'
         }
     });
 
     Self.downloadZip = async function(ctx, ids, options) {
         const models = Self.app.models;
         const myOptions = {};
+        const zip = new JSZip();
 
         if (typeof options == 'object')
             Object.assign(myOptions, options);
 
-        const zip = new JSZip();
-        let totalSize = 0;
         const zipConfig = await models.ZipConfig.findOne(null, myOptions);
+        let totalSize = 0;
+        ids = ids.split(',');
+
         for (let id of ids) {
             if (zipConfig && totalSize > zipConfig.maxSize) throw new UserError('Files are too large');
             const invoiceOutPdf = await models.InvoiceOut.download(ctx, id, myOptions);
@@ -44,8 +56,10 @@ module.exports = Self => {
             totalSize += sizeInMegabytes;
             zip.file(fileName, body);
         }
-        const base64 = await zip.generateAsync({type: 'base64'});
+
-        return base64;
+        const stream = zip.generateNodeStream({streamFiles: true});
+
+        return [stream, 'application/zip', `filename="download.zip"`];
     };
 
     function extractFileName(str) {

modules/invoiceOut/back/methods/invoiceOut/specs/downloadZip.spec.js

@@ -3,7 +3,7 @@ const UserError = require('vn-loopback/util/user-error');
 
 describe('InvoiceOut downloadZip()', () => {
     const userId = 9;
-    const invoiceIds = [1, 2];
+    const invoiceIds = '1,2';
     const ctx = {
         req: {
 

modules/invoiceOut/front/index/index.js

@@ -29,13 +29,13 @@ export default class Controller extends Section {
             window.open(url, '_blank');
         } else {
             const invoiceOutIds = this.checked;
-            const params = {
+            const invoicesIds = invoiceOutIds.join(',');
-                ids: invoiceOutIds
+            const serializedParams = this.$httpParamSerializer({
-            };
+                access_token: this.vnToken.token,
-            this.$http.post(`InvoiceOuts/downloadZip`, params)
+                ids: invoicesIds
-                .then(res => {
-                    location.href = 'data:application/zip;base64,' + res.data;
             });
+            const url = `api/InvoiceOuts/downloadZip?${serializedParams}`;
+            window.open(url, '_blank');
         }
     }
 }

modules/ticket/back/locale/ticket/en.yml

@@ -20,3 +20,4 @@ routeFk: route
 companyFk: company
 agencyModeFk: agency
 ticketFk: ticket
+mergedTicket: merged ticket

modules/ticket/back/locale/ticket/es.yml

@@ -20,3 +20,4 @@ routeFk: ruta
 companyFk: empresa
 agencyModeFk: agencia
 ticketFk: ticket
+mergedTicket: ticket fusionado

modules/ticket/back/methods/ticket/getTicketsFuture.js

@@ -20,18 +20,6 @@ module.exports = Self => {
                 description: 'The date to probe',
                 required: true
             },
-            {
-                arg: 'litersMax',
-                type: 'number',
-                description: 'Maximum volume of tickets to catapult',
-                required: true
-            },
-            {
-                arg: 'linesMax',
-                type: 'number',
-                description: 'Maximum number of lines of tickets to catapult',
-                required: true
-            },
             {
                 arg: 'warehouseFk',
                 type: 'number',
@@ -39,15 +27,15 @@ module.exports = Self => {
                 required: true
             },
             {
-                arg: 'shipped',
+                arg: 'litersMax',
-                type: 'date',
+                type: 'number',
-                description: 'Origin shipped',
+                description: 'Maximum volume of tickets to catapult',
                 required: false
             },
             {
-                arg: 'tfShipped',
+                arg: 'linesMax',
-                type: 'date',
+                type: 'number',
-                description: 'Destination shipped',
+                description: 'Maximum number of lines of tickets to catapult',
                 required: false
             },
             {
@@ -57,7 +45,7 @@ module.exports = Self => {
                 required: false
             },
             {
-                arg: 'tfIpt',
+                arg: 'futureIpt',
                 type: 'string',
                 description: 'Destination Item Packaging Type',
                 required: false
@@ -69,7 +57,7 @@ module.exports = Self => {
                 required: false
             },
             {
-                arg: 'tfId',
+                arg: 'futureId',
                 type: 'number',
                 description: 'Destination id',
                 required: false
@@ -81,7 +69,7 @@ module.exports = Self => {
                 required: false
             },
             {
-                arg: 'tfState',
+                arg: 'futureState',
                 type: 'string',
                 description: 'Destination state',
                 required: false
@@ -120,20 +108,20 @@ module.exports = Self => {
             switch (param) {
             case 'id':
                 return {'f.id': value};
-                case 'tfId':
+            case 'lines':
-                    return { 'f.ticketFuture': value };
+                return {'f.lines': {lte: value}};
-                case 'shipped':
+            case 'liters':
-                    return { 'f.shipped': value };
+                return {'f.liters': {lte: value}};
-                case 'tfShipped':
+            case 'futureId':
-                    return { 'f.tfShipped': value };
+                return {'f.futureId': value};
             case 'ipt':
                 return {'f.ipt': value};
-                case 'tfIpt':
+            case 'futureIpt':
-                    return { 'f.tfIpt': value };
+                return {'f.futureIpt': value};
             case 'state':
-                    return { 'f.code': { like: `%${value}%` } };
+                return {'f.stateCode': {like: `%${value}%`}};
-                case 'tfState':
+            case 'futureState':
-                    return { 'f.tfCode': { like: `%${value}%` } };
+                return {'f.futureStateCode': {like: `%${value}%`}};
             }
         });
 
@@ -142,8 +130,8 @@ module.exports = Self => {
         let stmt;
 
         stmt = new ParameterizedSQL(
-            `CALL vn.ticket_canbePostponed(?,?,?,?,?)`,
+            `CALL vn.ticket_canbePostponed(?,?,?)`,
-            [args.originDated, args.futureDated, args.litersMax, args.linesMax, args.warehouseFk]);
+            [args.originDated, args.futureDated, args.warehouseFk]);
 
         stmts.push(stmt);
 
@@ -153,7 +141,7 @@ module.exports = Self => {
             CREATE TEMPORARY TABLE tmp.sale_getProblems
             (INDEX (ticketFk))
             ENGINE = MEMORY
-            SELECT f.id ticketFk, f.clientFk, f.warehouseFk, f.shipped
+            SELECT f.id ticketFk, f.clientFk, f.warehouseFk, f.shipped, f.lines, f.liters
             FROM tmp.filter f
             LEFT JOIN alertLevel al ON al.id = f.alertLevel
             WHERE (al.code = 'FREE' OR f.alertLevel IS NULL)`);
@@ -200,9 +188,8 @@ module.exports = Self => {
             ]
         };
 
-        if (hasWhere) {
+        if (hasWhere)
             filter = mergeFilters(filter, {where: problems});
-        }
 
         stmt.merge(conn.makeWhere(filter.where));
         stmt.merge(conn.makeOrderBy(filter.order));

modules/ticket/back/methods/ticket/merge.js

@@ -40,19 +40,32 @@ module.exports = Self => {
 
         try {
             for (let ticket of tickets) {
-                const fullPath = `${origin}/#!/ticket/${ticket.id}/summary`;
+                const originFullPath = `${origin}/#!/ticket/${ticket.originId}/summary`;
-                const fullPathFuture = `${origin}/#!/ticket/${ticket.ticketFuture}/summary`;
+                const destinationFullPath = `${origin}/#!/ticket/${ticket.destinationId}/summary`;
                 const message = $t('Ticket merged', {
-                    originDated: dateUtil.toString(new Date(ticket.originETD)),
+                    originDated: dateUtil.toString(new Date(ticket.originShipped)),
-                    futureDated: dateUtil.toString(new Date(ticket.destETD)),
+                    destinationDated: dateUtil.toString(new Date(ticket.destinationShipped)),
-                    id: ticket.id,
+                    originId: ticket.originId,
-                    tfId: ticket.ticketFuture,
+                    destinationId: ticket.destinationId,
-                    fullPath,
+                    originFullPath,
-                    fullPathFuture
+                    destinationFullPath
                 });
-                if (!ticket.id || !ticket.ticketFuture) continue;
+                if (!ticket.originId || !ticket.destinationId) continue;
-                await models.Sale.updateAll({ticketFk: ticket.id}, {ticketFk: ticket.ticketFuture}, myOptions);
+
-                await models.Ticket.setDeleted(ctx, ticket.id, myOptions);
+                const ticketDestinationLogRecord = {
+                    originFk: ticket.destinationId,
+                    userFk: ctx.req.accessToken.userId,
+                    action: 'update',
+                    changedModel: 'Ticket',
+                    changedModelId: ticket.destinationId,
+                    changedModelValue: ticket.destinationId,
+                    oldInstance: {},
+                    newInstance: {mergedTicket: ticket.originId}
+                };
+
+                await models.TicketLog.create(ticketDestinationLogRecord, myOptions);
+                await models.Sale.updateAll({ticketFk: ticket.originId}, {ticketFk: ticket.destinationId}, myOptions);
+                await models.Ticket.setDeleted(ctx, ticket.originId, myOptions);
                 await models.Chat.sendCheckingPresence(ctx, ticket.workerFk, message);
             }
             if (tx)

modules/ticket/back/methods/ticket/specs/getTicketsFuture.spec.js

@@ -1,9 +1,8 @@
 const models = require('vn-loopback/server/server').models;
 
-describe('TicketFuture getTicketsFuture()', () => {
+describe('ticket getTicketsFuture()', () => {
     const today = new Date();
     today.setHours(0, 0, 0, 0);
-    const tomorrow = new Date(today.getDate() + 1);
 
     it('should return the tickets passing the required data', async() => {
         const tx = await models.Ticket.beginTransaction({});
@@ -14,8 +13,6 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
             };
 
@@ -39,8 +36,6 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
                 problems: true
             };
@@ -66,8 +61,6 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
                 problems: false
             };
@@ -93,8 +86,6 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
                 problems: null
             };
@@ -111,114 +102,6 @@ describe('TicketFuture getTicketsFuture()', () => {
         }
     });
 
-    it('should return the tickets matching the correct origin shipped', async () => {
-        const tx = await models.Ticket.beginTransaction({});
-
-        try {
-            const options = { transaction: tx };
-
-            const args = {
-                originDated: today,
-                futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
-                warehouseFk: 1,
-                shipped: today
-            };
-
-            const ctx = { req: { accessToken: { userId: 9 } }, args };
-            const result = await models.Ticket.getTicketsFuture(ctx, options);
-
-            expect(result.length).toEqual(4);
-
-            await tx.rollback();
-        } catch (e) {
-            await tx.rollback();
-            throw e;
-        }
-    });
-
-    it('should return the tickets matching the an incorrect origin shipped', async () => {
-        const tx = await models.Ticket.beginTransaction({});
-
-        try {
-            const options = { transaction: tx };
-
-            const args = {
-                originDated: today,
-                futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
-                warehouseFk: 1,
-                shipped: tomorrow
-            };
-
-            const ctx = { req: { accessToken: { userId: 9 } }, args };
-            const result = await models.Ticket.getTicketsFuture(ctx, options);
-
-            expect(result.length).toEqual(0);
-
-            await tx.rollback();
-        } catch (e) {
-            await tx.rollback();
-            throw e;
-        }
-    });
-
-    it('should return the tickets matching the correct destination shipped', async () => {
-        const tx = await models.Ticket.beginTransaction({});
-
-        try {
-            const options = { transaction: tx };
-
-            const args = {
-                originDated: today,
-                futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
-                warehouseFk: 1,
-                tfShipped: today
-            };
-
-            const ctx = { req: { accessToken: { userId: 9 } }, args };
-            const result = await models.Ticket.getTicketsFuture(ctx, options);
-
-            expect(result.length).toEqual(4);
-
-            await tx.rollback();
-        } catch (e) {
-            await tx.rollback();
-            throw e;
-        }
-    });
-
-    it('should return the tickets matching the an incorrect destination shipped', async () => {
-        const tx = await models.Ticket.beginTransaction({});
-
-        try {
-            const options = { transaction: tx };
-
-            const args = {
-                originDated: today,
-                futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
-                warehouseFk: 1,
-                tfShipped: tomorrow
-            };
-
-            const ctx = { req: { accessToken: { userId: 9 } }, args };
-            const result = await models.Ticket.getTicketsFuture(ctx, options);
-
-            expect(result.length).toEqual(0);
-
-            await tx.rollback();
-        } catch (e) {
-            await tx.rollback();
-            throw e;
-        }
-    });
-
     it('should return the tickets matching the OK State in origin date', async() => {
         const tx = await models.Ticket.beginTransaction({});
 
@@ -228,10 +111,8 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
-                state: "OK"
+                state: 'OK'
             };
 
             const ctx = {req: {accessToken: {userId: 9}}, args};
@@ -255,10 +136,8 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
-                tfState: "OK"
+                futureState: 'OK'
             };
 
             const ctx = {req: {accessToken: {userId: 9}}, args};
@@ -282,8 +161,6 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
                 ipt: null
             };
@@ -309,8 +186,6 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
                 ipt: 0
             };
@@ -336,10 +211,8 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
-                tfIpt: null
+                futureIpt: null
             };
 
             const ctx = {req: {accessToken: {userId: 9}}, args};
@@ -363,10 +236,8 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
-                tfIpt: 0
+                futureIpt: 0
             };
 
             const ctx = {req: {accessToken: {userId: 9}}, args};
@@ -390,8 +261,6 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
                 id: 13
             };
@@ -417,10 +286,8 @@ describe('TicketFuture getTicketsFuture()', () => {
             const args = {
                 originDated: today,
                 futureDated: today,
-                litersMax: 9999,
-                linesMax: 9999,
                 warehouseFk: 1,
-                tfId: 12
+                futureId: 12
             };
 
             const ctx = {req: {accessToken: {userId: 9}}, args};
@@ -434,5 +301,4 @@ describe('TicketFuture getTicketsFuture()', () => {
             throw e;
         }
     });
-
 });

modules/ticket/back/methods/ticket/specs/merge.spec.js

@@ -3,11 +3,11 @@ const LoopBackContext = require('loopback-context');
 
 describe('ticket merge()', () => {
     const tickets = [{
-        id: 13,
+        originId: 13,
-        ticketFuture: 12,
+        destinationId: 12,
-        workerFk: 1,
+        originShipped: new Date(),
-        originETD: new Date(),
+        destinationShipped: new Date(),
-        destETD: new Date()
+        workerFk: 1
     }];
 
     const activeCtx = {
@@ -39,9 +39,9 @@ describe('ticket merge()', () => {
 
             await models.Ticket.merge(ctx, tickets, options);
 
-            const createdTicketLog = await models.TicketLog.find({ where: { originFk: tickets[0].id } }, options);
+            const createdTicketLog = await models.TicketLog.find({where: {originFk: tickets[0].originId}}, options);
-            const deletedTicket = await models.Ticket.findOne({ where: { id: tickets[0].id } }, options);
+            const deletedTicket = await models.Ticket.findOne({where: {id: tickets[0].originId}}, options);
-            const salesTicketFuture = await models.Sale.find({ where: { ticketFk: tickets[0].ticketFuture } }, options);
+            const salesTicketFuture = await models.Sale.find({where: {ticketFk: tickets[0].destinationId}}, options);
             const chatNotificationAfterMerge = await models.Chat.find();
 
             expect(createdTicketLog.length).toEqual(1);

modules/ticket/back/model-config.json

@@ -94,8 +94,5 @@
     },
     "TicketConfig": {
         "dataSource": "vn"
-    },
-    "TicketFuture": {
-        "dataSource": "vn"
     }
 }

modules/ticket/back/models/ticket-future.json

@@ -1,12 +0,0 @@
-{
-    "name": "TicketFuture",
-    "base": "PersistedModel",
-    "acls": [
-      {
-          "accessType": "READ",
-          "principalType": "ROLE",
-          "principalId": "employee",
-          "permission": "ALLOW"
-      }
-    ]
-  }

modules/ticket/back/models/ticket-methods.js

@@ -33,7 +33,7 @@ module.exports = function(Self) {
     require('../methods/ticket/closeByTicket')(Self);
     require('../methods/ticket/closeByAgency')(Self);
     require('../methods/ticket/closeByRoute')(Self);
-    require('../methods/ticket-future/getTicketsFuture')(Self);
+    require('../methods/ticket/getTicketsFuture')(Self);
     require('../methods/ticket/merge')(Self);
     require('../methods/ticket/isRoleAdvanced')(Self);
     require('../methods/ticket/collectionLabel')(Self);

modules/ticket/front/descriptor-menu/index.html

@@ -280,10 +280,11 @@
 </vn-dialog>
 
 <!-- Send SMS popup -->
-<vn-ticket-sms
+<vn-sms-dialog
     vn-id="sms"
+    on-send="$ctrl.onSmsSend($sms)"
     sms="$ctrl.newSMS">
-</vn-ticket-sms>
+</vn-sms-dialog>
 
 <!-- Make invoice confirmation dialog -->
 <vn-confirm

modules/ticket/front/descriptor-menu/index.js

@@ -239,6 +239,7 @@ class Controller extends Section {
             destinationFk: this.ticket.clientFk,
             destination: phone
         }, params);
+
         this.$.sms.open();
     }
 
@@ -294,6 +295,11 @@ class Controller extends Section {
             this.$state.go('ticket.card.sale', {id: refundTicket.id});
         });
     }
+
+    onSmsSend(sms) {
+        return this.$http.post(`Tickets/${this.id}/sendSms`, sms)
+            .then(() => this.vnApp.showSuccess(this.$t('SMS sent')));
+    }
 }
 
 Controller.$inject = ['$element', '$scope', 'vnReport', 'vnEmail'];

modules/ticket/front/descriptor-menu/index.spec.js

@@ -261,11 +261,8 @@ describe('Ticket Component vnTicketDescriptorMenu', () => {
     describe('showSMSDialog()', () => {
         it('should set the destionationFk and destination properties and then call the sms open() method', () => {
             controller.$.sms = {open: () => {}};
-            jest.spyOn(controller.$.sms, 'open');
-
             controller.showSMSDialog();
 
-            expect(controller.$.sms.open).toHaveBeenCalledWith();
             expect(controller.newSMS).toEqual({
                 destinationFk: ticket.clientFk,
                 destination: ticket.address.mobile,

modules/ticket/front/future-search-panel/index.html

@@ -4,43 +4,26 @@
             <vn-date-picker
                 vn-one
                 label="Origin date"
-                ng-model="filter.shipped"
+                ng-model="filter.originDated"
-                on-change="$ctrl.from = value">
+                required="true">
             </vn-date-picker>
             <vn-date-picker
                 vn-one
                 label="Destination date"
-                ng-model="filter.tfShipped">
-            </vn-date-picker>
-        </vn-horizontal>
-        <vn-horizontal class="vn-px-lg">
-            <vn-date-picker
-                vn-one
-                label="Origin ETD"
-                ng-model="filter.originDated"
-                required="true"
-                info="ETD">
-            </vn-date-picker>
-            <vn-date-picker
-                vn-one
-                label="Destination ETD"
                 ng-model="filter.futureDated"
-                required="true"
+                required="true">
-                info="ETD">
             </vn-date-picker>
         </vn-horizontal>
         <vn-horizontal class="vn-px-lg">
-            <vn-textfield
-                vn-one
-                label="Max Lines"
-                ng-model="filter.linesMax"
-                required="true">
-            </vn-textfield>
             <vn-textfield
                 vn-one
                 label="Max Liters"
-                ng-model="filter.litersMax"
+                ng-model="filter.litersMax">
-                required="true">
+            </vn-textfield>
+            <vn-textfield
+                vn-one
+                label="Max Lines"
+                ng-model="filter.linesMax">
             </vn-textfield>
         </vn-horizontal>
         <vn-horizontal class="vn-px-lg">
@@ -48,22 +31,22 @@
                 data="$ctrl.itemPackingTypes"
                 label="Origin IPT"
                 value-field="code"
-                show-field="name"
+                show-field="description"
                 ng-model="filter.ipt"
                 info="IPT">
                 <tpl-item>
-                    {{name}}
+                    {{description}}
                 </tpl-item>
             </vn-autocomplete>
             <vn-autocomplete vn-one
                 data="$ctrl.itemPackingTypes"
                 label="Destination IPT"
                 value-field="code"
-                show-field="name"
+                show-field="description"
-                ng-model="filter.tfIpt"
+                ng-model="filter.futureIpt"
                 info="IPT">
                 <tpl-item>
-                    {{name}}
+                    {{description}}
                 </tpl-item>
             </vn-autocomplete>
         </vn-horizontal>
@@ -83,7 +66,7 @@
                 label="Destination Grouped State"
                 value-field="code"
                 show-field="name"
-                ng-model="filter.tfState">
+                ng-model="filter.futureState">
                 <tpl-item>
                     {{name}}
                 </tpl-item>

modules/ticket/front/future-search-panel/index.js

@@ -28,9 +28,8 @@ class Controller extends SearchPanel {
         this.$http.get('ItemPackingTypes').then(res => {
             for (let ipt of res.data) {
                 itemPackingTypes.push({
-                    id: ipt.id,
+                    description: this.$t(ipt.description),
                     code: ipt.code,
-                    name: this.$t(ipt.code)
                 });
             }
             this.itemPackingTypes = itemPackingTypes;

modules/ticket/front/future-search-panel/locale/en.yml

@@ -1,9 +1 @@
 Future tickets: Tickets a futuro
-FREE: Free
-DELIVERED: Delivered
-ON_PREPARATION: On preparation
-PACKED: Packed
-F: Fruits and vegetables
-V: Vertical
-H: Horizontal
-P: Feed

modules/ticket/front/future-search-panel/locale/es.yml

@@ -11,13 +11,4 @@ With problems: Con problemas
 Warehouse: Almacén
 Origin Grouped State: Estado agrupado origen
 Destination Grouped State: Estado agrupado destino
-FREE: Libre
-DELIVERED: Servido
-ON_PREPARATION: En preparacion
-PACKED: Encajado
-F: Frutas y verduras
-V: Vertical
-H: Horizontal
-P: Pienso
-ETD: Tiempo estimado de entrega
 IPT: Encajado

modules/ticket/front/future/index.html

@@ -1,7 +1,7 @@
 <vn-crud-model
     vn-id="model"
     url="Tickets/getTicketsFuture"
-    limit="20">
+    auto-load="false">
 </vn-crud-model>
 <vn-portal slot="topbar">
     <vn-searchbar
@@ -30,6 +30,11 @@
         <slot-table>
             <table>
                 <thead>
+                    <tr second-header>
+                        <td></td>
+                        <th colspan="7" translate>Origin</th>
+                        <th colspan="4" translate>Destination</th>
+                    </tr>
                     <tr>
                         <th shrink>
                             <vn-multi-check
@@ -38,39 +43,39 @@
                                 check-field="checked">
                             </vn-multi-check>
                         </th>
-                        <th field="problems">
+                        <th field="totalProblems">
                             <span translate>Problems</span>
                         </th>
                         <th field="id">
-                            <span translate>Origin ID</span>
+                            <span translate>ID</span>
                         </th>
-                        <th field="originETD">
+                        <th field="shipped">
-                            <span translate>Origin ETD</span>
+                            <span translate>Date</span>
+                        </th>
+                        <th field="ipt" title="Item Packing Type">
+                            <span>IPT</span>
                         </th>
                         <th field="state">
-                            <span translate>Origin State</span>
+                            <span translate>State</span>
                         </th>
-                        <th field="ipt">
+                        <th field="liters">
-                            <span>IPT</span>
-                        </th>
-                        <th field="litersMax">
                             <span translate>Liters</span>
                         </th>
-                        <th field="linesMax">
+                        <th shrink field="lines">
                             <span translate>Available Lines</span>
                         </th>
-                        <th field="ticketFuture">
+                        <th field="futureId" separator>
-                            <span translate>Destination ID</span>
+                            <span translate>ID</span>
                         </th>
-                        <th field="destETD">
+                        <th field="futureShipped">
-                            <span translate>Destination ETD</span>
+                            <span translate>Date</span>
                         </th>
-                        <th field="tfState">
+                        <th field="futureIpt" title="Item Packing Type">
-                            <span translate>Destination State</span>
-                        </th>
-                        <th field="tfIpt">
                             <span>IPT</span>
                         </th>
+                        <th shrink field="futureState">
+                            <span translate>State</span>
+                        </th>
                     </tr>
                 </thead>
                 <tbody>
@@ -125,38 +130,38 @@
                             {{::ticket.id}}
                         </span></td>
                         <td shrink-date>
-                            <span class="chip {{$ctrl.compareDate(ticket.originETD)}}">
+                            <span class="chip {{$ctrl.compareDate(ticket.shipped)}}">
-                                {{::ticket.originETD | date: 'dd/MM/yyyy'}}
+                                {{::ticket.shipped | date: 'dd/MM/yyyy'}}
                             </span>
                         </td>
+                        <td>{{::ticket.ipt}}</td>
                         <td>
                             <span
                             class="chip {{$ctrl.stateColor(ticket.state)}}">
                                 {{::ticket.state}}
                             </span>
                         </td>
-                        <td>{{::ticket.ipt}}</td>
                         <td>{{::ticket.liters}}</td>
                         <td>{{::ticket.lines}}</td>
                         <td>
                             <span
-                            ng-click="ticketDescriptor.show($event, ticket.ticketFuture)"
+                            ng-click="ticketDescriptor.show($event, ticket.futureId)"
                             class="link">
-                                {{::ticket.ticketFuture}}
+                                {{::ticket.futureId}}
                             </span>
                         </td>
                         <td shrink-date>
-                            <span class="chip {{$ctrl.compareDate(ticket.destETD)}}">
+                            <span class="chip {{$ctrl.compareDate(ticket.futureShipped)}}">
-                                {{::ticket.destETD | date: 'dd/MM/yyyy'}}
+                                {{::ticket.futureShipped | date: 'dd/MM/yyyy'}}
                             </span>
                         </td>
+                        <td>{{::ticket.futureIpt}}</td>
                         <td>
                             <span
-                            class="chip {{$ctrl.stateColor(ticket.tfState)}}">
+                            class="chip {{$ctrl.stateColor(ticket.futureState)}}">
-                                {{::ticket.tfState}}
+                                {{::ticket.futureState}}
                             </span>
                         </td>
-                        <td>{{::ticket.tfIpt}}</td>
                     </tr>
                 </tbody>
             </table>

modules/ticket/front/future/index.js

@@ -11,15 +11,15 @@ export default class Controller extends Section {
                 search: true,
             },
             columns: [{
-                field: 'problems',
+                field: 'totalProblems',
+                searchable: false,
+            },
+            {
+                field: 'shipped',
                 searchable: false
             },
             {
-                field: 'originETD',
+                field: 'futureShipped',
-                searchable: false
-            },
-            {
-                field: 'destETD',
                 searchable: false
             },
             {
@@ -27,7 +27,7 @@ export default class Controller extends Section {
                 searchable: false
             },
             {
-                field: 'tfState',
+                field: 'futureState',
                 searchable: false
             },
             {
@@ -39,7 +39,7 @@ export default class Controller extends Section {
                 }
             },
             {
-                field: 'tfIpt',
+                field: 'futureIpt',
                 autocomplete: {
                     url: 'ItemPackingTypes',
                     showField: 'description',
@@ -48,6 +48,9 @@ export default class Controller extends Section {
             },
             ]
         };
+    }
+
+    $postLink() {
         this.setDefaultFilter();
     }
 
@@ -57,10 +60,9 @@ export default class Controller extends Section {
         this.filterParams = {
             originDated: today,
             futureDated: today,
-            linesMax: '9999',
+            warehouseFk: this.vnConfig.warehouseFk
-            litersMax: '9999',
-            warehouseFk: 1
         };
+        this.$.model.applyFilter(null, this.filterParams);
     }
 
     compareDate(date) {
@@ -113,7 +115,17 @@ export default class Controller extends Section {
     }
 
     moveTicketsFuture() {
-        let params = { tickets: this.checked };
+        let ticketsToMove = [];
+        this.checked.forEach(ticket => {
+            ticketsToMove.push({
+                originId: ticket.id,
+                destinationId: ticket.futureId,
+                originShipped: ticket.shipped,
+                destinationShipped: ticket.futureShipped,
+                workerFk: ticket.workerFk
+            });
+        });
+        let params = {tickets: ticketsToMove};
         return this.$http.post('Tickets/merge', params)
             .then(() => {
                 this.$.model.refresh();
@@ -125,16 +137,16 @@ export default class Controller extends Section {
         switch (param) {
         case 'id':
             return {'id': value};
-            case 'ticketFuture':
+        case 'futureId':
-                return { 'ticketFuture': value };
+            return {'futureId': value};
-            case 'litersMax':
+        case 'liters':
             return {'liters': value};
-            case 'linesMax':
+        case 'lines':
             return {'lines': value};
         case 'ipt':
             return {'ipt': value};
-            case 'tfIpt':
+        case 'futureIpt':
-                return { 'tfIpt': value };
+            return {'futureIpt': value};
         }
     }
 }

modules/ticket/front/future/index.spec.js

@@ -2,33 +2,30 @@ import './index.js';
 import crudModel from 'core/mocks/crud-model';
 
 describe('Component vnTicketFuture', () => {
+    const today = new Date();
     let controller;
     let $httpBackend;
-    let $window;
 
-    beforeEach(ngModule('ticket')
+    beforeEach(ngModule('ticket'));
-    );
 
-    beforeEach(inject(($componentController, _$window_, _$httpBackend_) => {
+    beforeEach(inject(($componentController, _$httpBackend_) => {
         $httpBackend = _$httpBackend_;
-        $window = _$window_;
         const $element = angular.element('<vn-ticket-future></vn-ticket-future>');
         controller = $componentController('vnTicketFuture', {$element});
         controller.$.model = crudModel;
         controller.$.model.data = [{
             id: 1,
             checked: true,
-            state: "OK"
+            state: 'OK'
         }, {
             id: 2,
             checked: true,
-            state: "Libre"
+            state: 'Libre'
         }];
     }));
 
     describe('compareDate()', () => {
         it('should return warning when the date is the present', () => {
-            let today = new Date();
             let result = controller.compareDate(today);
 
             expect(result).toEqual('warning');
@@ -67,6 +64,7 @@ describe('Component vnTicketFuture', () => {
         it('should return success to the OK tickets', () => {
             const ok = controller.stateColor(controller.$.model.data[0].state);
             const notOk = controller.stateColor(controller.$.model.data[1].state);
+
             expect(ok).toEqual('success');
             expect(notOk).not.toEqual('success');
         });
@@ -74,6 +72,7 @@ describe('Component vnTicketFuture', () => {
         it('should return success to the FREE tickets', () => {
             const notFree = controller.stateColor(controller.$.model.data[0].state);
             const free = controller.stateColor(controller.$.model.data[1].state);
+
             expect(free).toEqual('notice');
             expect(notFree).not.toEqual('notice');
         });
@@ -81,18 +80,14 @@ describe('Component vnTicketFuture', () => {
 
     describe('dateRange()', () => {
         it('should return two dates with the hours at the start and end of the given date', () => {
-            const now = new Date();
+            const dateRange = controller.dateRange(today);
-
-            const today = now.getDate();
-
-            const dateRange = controller.dateRange(now);
             const start = dateRange[0].toString();
             const end = dateRange[1].toString();
 
-            expect(start).toContain(today);
+            expect(start).toContain(today.getDate());
             expect(start).toContain('00:00:00');
 
-            expect(end).toContain(today);
+            expect(end).toContain(today.getDate());
             expect(end).toContain('23:59:59');
         });
     });

modules/ticket/front/future/locale/en.yml

@@ -1,6 +1,2 @@
 Move confirmation: Do you want to move {{checked}} tickets to the future?
-FREE: Free
-DELIVERED: Delivered
-ON_PREPARATION: On preparation
-PACKED: Packed
 Success: Tickets moved successfully!

modules/ticket/front/future/locale/es.yml

@@ -3,20 +3,14 @@ Search tickets: Buscar tickets
 Search future tickets by date: Buscar tickets por fecha
 Problems: Problemas
 Origin ID: ID origen
-Closing: Cierre
 Origin State: Estado origen
 Destination State: Estado destino
 Liters: Litros
 Available Lines: Líneas disponibles
 Destination ID: ID destino
-Destination ETD: ETD Destino
-Origin ETD: ETD Origen
 Move tickets: Mover tickets
 Move confirmation: ¿Desea mover {{checked}} tickets hacia el futuro?
 Success: Tickets movidos correctamente
-ETD: Tiempo estimado de entrega
 IPT: Encajado
-FREE: Libre
+Origin Date: Fecha origen
-DELIVERED: Servido
+Destination Date: Fecha destino
-ON_PREPARATION: En preparacion
-PACKED: Encajado

modules/ticket/front/index.js

@@ -32,7 +32,6 @@ import './weekly';
 import './dms/index';
 import './dms/create';
 import './dms/edit';
-import './sms';
 import './boxing';
 import './future';
 import './future-search-panel';

modules/ticket/front/sms/index.html

@@ -1,45 +0,0 @@
-<vn-dialog
-    vn-id="SMSDialog"
-    on-accept="$ctrl.onResponse()"
-    message="Send SMS">
-    <tpl-body>
-        <section class="SMSDialog">
-            <vn-horizontal>
-                <vn-textfield
-                    vn-one
-                    label="Destination"
-                    ng-model="$ctrl.sms.destination"
-                    required="true"
-                    rule>
-                </vn-textfield>
-            </vn-horizontal>
-            <vn-horizontal >
-                <vn-textarea vn-one
-                    vn-id="message"
-                    label="Message" 
-                    ng-model="$ctrl.sms.message"
-                    info="Special characters like accents counts as a multiple"
-                    rows="5"
-                    required="true"
-                    rule>
-                </vn-textarea>
-            </vn-horizontal>
-            <vn-horizontal>
-                <span>
-                    {{'Characters remaining' | translate}}: 
-                    <vn-chip translate-attr="{title: 'Packing'}" ng-class="{
-                        'colored': $ctrl.charactersRemaining() > 25,
-                        'warning': $ctrl.charactersRemaining() <= 25,
-                        'alert': $ctrl.charactersRemaining() < 0,
-                    }"> 
-                        {{$ctrl.charactersRemaining()}}
-                    </vn-chip>
-                </span>
-            </vn-horizontal>
-        </section>
-    </tpl-body>
-    <tpl-buttons>
-        <input type="button" response="cancel" translate-attr="{value: 'Cancel'}"/>
-        <button response="accept" translate>Send</button>
-    </tpl-buttons>
-</vn-dialog>

modules/ticket/front/sms/index.spec.js

@@ -1,71 +0,0 @@
-import './index';
-
-describe('Ticket', () => {
-    describe('Component vnTicketSms', () => {
-        let controller;
-        let $httpBackend;
-
-        beforeEach(ngModule('ticket'));
-
-        beforeEach(inject(($componentController, $rootScope, _$httpBackend_) => {
-            $httpBackend = _$httpBackend_;
-            let $scope = $rootScope.$new();
-            const $element = angular.element('<vn-dialog></vn-dialog>');
-            controller = $componentController('vnTicketSms', {$element, $scope});
-            controller.$.message = {
-                input: {
-                    value: 'My SMS'
-                }
-            };
-        }));
-
-        describe('onResponse()', () => {
-            it('should perform a POST query and show a success snackbar', () => {
-                let params = {ticketId: 11, destinationFk: 1101, destination: 111111111, message: 'My SMS'};
-                controller.sms = {ticketId: 11, destinationFk: 1101, destination: 111111111, message: 'My SMS'};
-
-                jest.spyOn(controller.vnApp, 'showMessage');
-                $httpBackend.expect('POST', `Tickets/11/sendSms`, params).respond(200, params);
-
-                controller.onResponse();
-                $httpBackend.flush();
-
-                expect(controller.vnApp.showMessage).toHaveBeenCalledWith('SMS sent!');
-            });
-
-            it('should call onResponse without the destination and show an error snackbar', () => {
-                controller.sms = {destinationFk: 1101, message: 'My SMS'};
-
-                jest.spyOn(controller.vnApp, 'showError');
-
-                controller.onResponse();
-
-                expect(controller.vnApp.showError).toHaveBeenCalledWith(`The destination can't be empty`);
-            });
-
-            it('should call onResponse without the message and show an error snackbar', () => {
-                controller.sms = {destinationFk: 1101, destination: 222222222};
-
-                jest.spyOn(controller.vnApp, 'showError');
-
-                controller.onResponse();
-
-                expect(controller.vnApp.showError).toHaveBeenCalledWith(`The message can't be empty`);
-            });
-        });
-
-        describe('charactersRemaining()', () => {
-            it('should return the characters remaining in a element', () => {
-                controller.$.message = {
-                    input: {
-                        value: 'My message 0€'
-                    }
-                };
-
-                let result = controller.charactersRemaining();
-
-                expect(result).toEqual(145);
-            });
-        });
-    });
-});

modules/ticket/front/sms/locale/es.yml

@@ -1,9 +0,0 @@
-Send SMS: Enviar SMS
-Destination: Destinatario
-Message: Mensaje
-SMS sent!: ¡SMS enviado!
-Characters remaining: Carácteres restantes
-The destination can't be empty: El destinatario no puede estar vacio
-The message can't be empty: El mensaje no puede estar vacio
-The message it's too long: El mensaje es demasiado largo
-Special characters like accents counts as a multiple: Carácteres especiales como los acentos cuentan como varios

modules/ticket/front/sms/style.scss

@@ -1,5 +0,0 @@
-@import "variables";
-
-.SMSDialog {
-    min-width: 400px
-}