From 018e17487e3fd542543efc4673596c91951180aa Mon Sep 17 00:00:00 2001
From: Carlos Jimenez Ruiz <jacarlosjimenezruiz@gmail.com>
Date: Fri, 3 Jul 2020 12:13:42 +0200
Subject: [PATCH] imput validation is ok with Jest

---
 .../components/input-number/index.spec.js     | 27 +++++++------------
 1 file changed, 10 insertions(+), 17 deletions(-)

diff --git a/front/core/components/input-number/index.spec.js b/front/core/components/input-number/index.spec.js
index d1bbe251c..0e0f8c4a5 100644
--- a/front/core/components/input-number/index.spec.js
+++ b/front/core/components/input-number/index.spec.js
@@ -7,7 +7,7 @@ describe('Component vnInputNumber', () => {
     beforeEach(ngModule('vnCore'));
 
     beforeEach(angular.mock.inject(($compile, $rootScope) => {
-        $element = $compile(`<vn-input-number></vn-input-number>`)($rootScope);
+        $element = $compile(`<vn-input-number ng-model="model" />`)($rootScope);
         $ctrl = $element.controller('vnInputNumber');
     }));
 
@@ -20,12 +20,10 @@ describe('Component vnInputNumber', () => {
             $ctrl.field = -1;
             $ctrl.min = 0;
 
-            // FIXME: Input validation doesn't work with Jest?
-            // expect($ctrl.shownError).toContain('Please select a value that is no less than 0');
-            expect($ctrl.shownError).toBeNull();
+            expect($ctrl.shownError).toContain('Constraints not satisfied');
         });
 
-        it(`should unset error property when value is upper than min`, () => {
+        it(`should unset error property when value is greater than min`, () => {
             $ctrl.field = 1;
             $ctrl.min = 0;
 
@@ -34,19 +32,16 @@ describe('Component vnInputNumber', () => {
     });
 
     describe('max() setter', () => {
-        it(`should set error property when value is upper than max`, () => {
+        it(`should set error property when value is greater than max`, () => {
             $ctrl.field = 1;
             $ctrl.max = 0;
 
-            // FIXME: Input validation doesn't work with Jest?
-            // expect($ctrl.shownError).toContain('Please select a value that is no more than 0');
-            expect($ctrl.shownError).toBeNull();
+            expect($ctrl.shownError).toContain('Constraints not satisfied');
         });
 
-        // FIXME: Input validation doesn't work with Jest?
         it(`should unset error property when value is lower than max`, () => {
             $ctrl.field = -1;
-            $ctrl.min = 0;
+            $ctrl.max = 0;
 
             expect($ctrl.shownError).toBeNull();
         });
@@ -54,14 +49,12 @@ describe('Component vnInputNumber', () => {
 
     describe('step() setter', () => {
         it(`should increase value when add icon is clicked`, () => {
-            $ctrl.step = 1;
-            $ctrl.field = 1;
+            $ctrl.input.step = 1;
+            $ctrl.input.value = 0;
 
-            // FIXME: Doesn't work with Jest?
-            // $ctrl.stepUp();
-            // $element[0].querySelector('vn-icon[icon=add]').click();
+            $ctrl.stepUp();
 
-            expect($ctrl.field).toBe(1);
+            expect($ctrl.input.value).toBe('1');
         });
     });
 });