From b55db4bdc00f0ab0e6e20604e268c7d3a0e4e73f Mon Sep 17 00:00:00 2001
From: Jon <jon@verdnatura.es>
Date: Mon, 30 Sep 2024 14:09:57 +0200
Subject: [PATCH] feat: refs #7010 added subquery to avoid using group by in
 sql

---
 modules/ticket/back/methods/ticket/filter.js | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/modules/ticket/back/methods/ticket/filter.js b/modules/ticket/back/methods/ticket/filter.js
index 37150e6e9..d7e77603b 100644
--- a/modules/ticket/back/methods/ticket/filter.js
+++ b/modules/ticket/back/methods/ticket/filter.js
@@ -229,7 +229,7 @@ module.exports = Self => {
             CREATE OR REPLACE TEMPORARY TABLE tmp.filter
                 (INDEX (id))
                 ENGINE = InnoDB
-                    SELECT t.id,
+                    SELECT DISTINCT t.id,
                        t.shipped,
                        CAST(DATE(t.shipped) AS CHAR) shippedDate,
                        HOUR(t.shipped) shippedHour,
@@ -261,7 +261,11 @@ module.exports = Self => {
                        z.id zoneFk,
                        CAST(z.hour AS CHAR) hour,
                        a.nickname addressNickname,
-                      GROUP_CONCAT(DISTINCT i.itemPackingTypeFk ORDER BY i.itemPackingTypeFk SEPARATOR ',') packing
+                        (SELECT GROUP_CONCAT(DISTINCT i2.itemPackingTypeFk ORDER BY i2.itemPackingTypeFk SEPARATOR ',')
+                            FROM sale s2
+                            JOIN item i2 ON i2.id = s2.itemFk
+                            WHERE s2.ticketFk = t.id
+                        ) AS packing
                    FROM ticket t
                        LEFT JOIN invoiceOut io ON t.refFk = io.ref
                        LEFT JOIN zone z ON z.id = t.zoneFk
@@ -275,8 +279,6 @@ module.exports = Self => {
                        LEFT JOIN worker wk ON wk.id = c.salesPersonFk
                        LEFT JOIN account.user u ON u.id = wk.id
                        LEFT JOIN route r ON r.id = t.routeFk
-                       LEFT JOIN sale s ON t.id = s.ticketFk
-                       LEFT JOIN item i ON i.id = s.itemFk
         `);
 
         if (args.orderFk) {
@@ -295,9 +297,7 @@ module.exports = Self => {
         }
 
         stmt.merge(conn.makeWhere(filter.where));
-        stmt.merge({
-            sql: `GROUP BY t.id`
-        });
+
         stmts.push(stmt);
 
         stmt = new ParameterizedSQL(`