From be93ea3a0713d52d005aad63e9b89984ec381a03 Mon Sep 17 00:00:00 2001
From: sergiodt <sergiodt@verdnatura.es>
Date: Thu, 30 Jan 2025 17:55:10 +0100
Subject: [PATCH] fix: refs #6964 visibleGreaterThanZero

---
 .../item-shelving/getItemsByReviewOrder.js        | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/modules/item/back/methods/item-shelving/getItemsByReviewOrder.js b/modules/item/back/methods/item-shelving/getItemsByReviewOrder.js
index 7a960a8c8..715456511 100644
--- a/modules/item/back/methods/item-shelving/getItemsByReviewOrder.js
+++ b/modules/item/back/methods/item-shelving/getItemsByReviewOrder.js
@@ -52,7 +52,9 @@ module.exports = Self => {
                     JOIN vn.shelving sh ON sh.id = is2.shelvingFk
                     LEFT JOIN vn.parking p ON p.id = sh.parkingFk
                     LEFT JOIN vn.sector s ON s.id = p.sectorFk
-                WHERE sh.code = ? AND (? IS NULL OR is2.itemFk = ?)
+                WHERE sh.code = ?
+                    AND (? IS NULL OR is2.itemFk = ?)
+                    AND is2.visible > 0
             ),
             itemShelvings AS (
                 SELECT is2.itemFk, is2.created, sh.code, p.pickingOrder, p.code AS parkingFk
@@ -61,15 +63,16 @@ module.exports = Self => {
                     JOIN vn.shelving sh ON sh.id = is2.shelvingFk AND ai.code <> sh.code
                     JOIN vn.parking p ON p.id = sh.parkingFk
                     JOIN vn.sector s ON s.id = p.sectorFk
+                WHERE is2.visible > 0
             ),
             parkingDestiny AS (
                 SELECT ? AS pickingOrder
             )
         SELECT ish.*,
-            CASE 
-                WHEN ish.pickingOrder < d.pickingOrder AND aish.created < ish.created 
+            CASE
+                WHEN ish.pickingOrder < d.pickingOrder AND aish.created < ish.created
                     AND ABS(TIMESTAMPDIFF(HOUR, aish.created, ish.created)) > ? THEN "old"
-                WHEN ish.pickingOrder > d.pickingOrder AND aish.created > ish.created 
+                WHEN ish.pickingOrder > d.pickingOrder AND aish.created > ish.created
                     AND ABS(TIMESTAMPDIFF(HOUR, aish.created, ish.created)) > ? THEN "new"
             END AS itemCreated
         FROM itemShelvings ish
@@ -77,8 +80,8 @@ module.exports = Self => {
             JOIN currentItemShelving aish ON ish.itemFk = aish.itemFk
         WHERE ABS(TIMESTAMPDIFF(HOUR, aish.created, ish.created)) > ?
             AND (
-                (ish.pickingOrder < d.pickingOrder AND aish.created < ish.created) 
-                OR 
+                (ish.pickingOrder < d.pickingOrder AND aish.created < ish.created)
+                OR
                 (ish.pickingOrder > d.pickingOrder AND aish.created > ish.created)
             );
             `,