From cf862202ffa468d8a54fa7b7b222273763110a11 Mon Sep 17 00:00:00 2001
From: carlossa <carlossa@verdnatura.es>
Date: Mon, 2 Dec 2024 10:12:56 +0100
Subject: [PATCH] fix: hotfix 7323 createAbsence

---
 .../11372-azureMedeola/00-firstScript.sql     |  2 ++
 loopback/locale/en.json                       |  4 +--
 loopback/locale/es.json                       |  3 +-
 .../back/methods/worker/createAbsence.js      |  6 ++++
 .../worker/specs/createAbsence.spec.js        | 29 +++++++++++++++++++
 5 files changed, 41 insertions(+), 3 deletions(-)
 create mode 100644 db/versions/11372-azureMedeola/00-firstScript.sql

diff --git a/db/versions/11372-azureMedeola/00-firstScript.sql b/db/versions/11372-azureMedeola/00-firstScript.sql
new file mode 100644
index 0000000000..b987015090
--- /dev/null
+++ b/db/versions/11372-azureMedeola/00-firstScript.sql
@@ -0,0 +1,2 @@
+INSERT INTO salix.ACL (model,property,accessType,permission,principalType,principalId)
+	VALUES ('Worker','isHr','WRITE','ALLOW','ROLE','hr');
diff --git a/loopback/locale/en.json b/loopback/locale/en.json
index fdd39325b8..c52da615a2 100644
--- a/loopback/locale/en.json
+++ b/loopback/locale/en.json
@@ -245,6 +245,6 @@
 	"Invalid or expired verification code": "Invalid or expired verification code",
 	"Payment method is required": "Payment method is required",
     "The raid information is not correct": "The raid information is not correct",
-    "Sales already moved": "Sales already moved"
-
+    "Sales already moved": "Sales already moved",
+    "Holidays to past days not available": "Holidays to past days not available"
 }
diff --git a/loopback/locale/es.json b/loopback/locale/es.json
index 4e691f3754..782b2504a2 100644
--- a/loopback/locale/es.json
+++ b/loopback/locale/es.json
@@ -388,5 +388,6 @@
 	"ticketLostExpedition": "El ticket [{{ticketId}}]({{{ticketUrl}}}) tiene la siguiente expedición perdida:{{ expeditionId }}",
 	"The web user's email already exists": "El correo del usuario web ya existe",
     "Sales already moved": "Ya han sido transferidas",
-    "The raid information is not correct": "La información de la redada no es correcta"
+    "The raid information is not correct": "La información de la redada no es correcta",
+    "Holidays to past days not available": "Las vacaciones a días pasados no están disponibles"
 }
diff --git a/modules/worker/back/methods/worker/createAbsence.js b/modules/worker/back/methods/worker/createAbsence.js
index 0397886cf1..264de4dd34 100644
--- a/modules/worker/back/methods/worker/createAbsence.js
+++ b/modules/worker/back/methods/worker/createAbsence.js
@@ -54,6 +54,7 @@ module.exports = Self => {
         try {
             const isSubordinate = await models.Worker.isSubordinate(ctx, id, myOptions);
             const isTeamBoss = await models.ACL.checkAccessAcl(ctx, 'Worker', 'isTeamBoss', 'WRITE');
+            const isHr = await models.ACL.checkAccessAcl(ctx, 'Worker', 'isHr', 'WRITE');
 
             if (!isSubordinate || (isSubordinate && userId == id && !isTeamBoss))
                 throw new UserError(`You don't have enough privileges`);
@@ -113,6 +114,11 @@ module.exports = Self => {
             if ((holiday && isFestive) && (workCenter.workcenterFk === holiday.workCenterFk))
                 throw new UserError(`Cannot add holidays on this day`);
 
+            const newDate = new Date(ctx.args.dated).getTime();
+            const nowDate = now.getTime();
+            if ((nowDate > newDate) && !isHr)
+                throw new UserError(`Holidays to past days not available`);
+
             const absence = await models.Calendar.create({
                 businessFk: labour.businessFk,
                 dayOffTypeFk: args.absenceTypeId,
diff --git a/modules/worker/back/methods/worker/specs/createAbsence.spec.js b/modules/worker/back/methods/worker/specs/createAbsence.spec.js
index fcb1c16337..1c7efcd285 100644
--- a/modules/worker/back/methods/worker/specs/createAbsence.spec.js
+++ b/modules/worker/back/methods/worker/specs/createAbsence.spec.js
@@ -162,4 +162,33 @@ describe('Worker createAbsence()', () => {
 
         expect(error.message).toEqual(`The worker has hours recorded that day`);
     });
+
+    it(`Should throw an error when adding a "Vacation" absence on a past day`, async() => {
+        const ctx = {
+            req: {accessToken: {userId: 19}},
+            args: {
+                id: 1110,
+                businessFk: 1110,
+                absenceTypeId: 1,
+                dated: '2000-12-27T23:00:00.000Z',
+            }
+        };
+        const workerId = 19;
+
+        const tx = await app.models.Calendar.beginTransaction({});
+
+        let error;
+        try {
+            const options = {transaction: tx};
+
+            await app.models.Worker.createAbsence(ctx, workerId, options);
+
+            await tx.rollback();
+        } catch (e) {
+            await tx.rollback();
+            error = e;
+        }
+
+        expect(error.message).toEqual(`Holidays to past days not available`);
+    });
 });