From d4f734455d3163040e5e662a2db2de44d66a2623 Mon Sep 17 00:00:00 2001
From: Jon <jon@verdnatura.es>
Date: Tue, 7 May 2024 11:35:05 +0200
Subject: [PATCH] refactor: refs #6739 transferInvoice() refactor

---
 .../methods/invoiceOut/makePdfAndNotify.js    |  1 -
 .../invoiceOut/front/descriptor-menu/index.js | 27 +++++++++----------
 2 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/modules/invoiceOut/back/methods/invoiceOut/makePdfAndNotify.js b/modules/invoiceOut/back/methods/invoiceOut/makePdfAndNotify.js
index 4bba2498f3..e2dc15993f 100644
--- a/modules/invoiceOut/back/methods/invoiceOut/makePdfAndNotify.js
+++ b/modules/invoiceOut/back/methods/invoiceOut/makePdfAndNotify.js
@@ -33,7 +33,6 @@ module.exports = Self => {
         try {
             await Self.makePdf(id, options);
         } catch (err) {
-            console.error(err);
             throw new UserError('Error while generating PDF', 'pdfError');
         }
 
diff --git a/modules/invoiceOut/front/descriptor-menu/index.js b/modules/invoiceOut/front/descriptor-menu/index.js
index 746e425223..c29e4b788f 100644
--- a/modules/invoiceOut/front/descriptor-menu/index.js
+++ b/modules/invoiceOut/front/descriptor-menu/index.js
@@ -148,25 +148,24 @@ class Controller extends Section {
             invoiceCorrectionTypeFk: this.invoiceCorrectionType,
             checked: this.checked
         };
+
+        const transferInvoiceRequest = () => {
+            this.$http.post(`InvoiceOuts/transferInvoice`, params).then(res => {
+                const invoiceId = res.data;
+                this.vnApp.showSuccess(this.$t('Transferred invoice'));
+                this.$state.go('invoiceOut.card.summary', {id: invoiceId});
+            });
+        };
+
         this.$http.get(`Clients/${this.clientId}`).then(response => {
             const clientData = response.data;
             const hasToInvoiceByAddress = clientData.hasToInvoiceByAddress;
 
             if (this.checked && hasToInvoiceByAddress) {
-                if (window.confirm('El cliente destino tiene marcado facturar por consignatario, ¿desea continuar?')) {
-                    this.$http.post(`InvoiceOuts/transferInvoice`, params).then(res => {
-                        const invoiceId = res.data;
-                        this.vnApp.showSuccess(this.$t('Transferred invoice'));
-                        this.$state.go('invoiceOut.card.summary', {id: invoiceId});
-                    });
-                }
-            } else {
-                this.$http.post(`InvoiceOuts/transferInvoice`, params).then(res => {
-                    const invoiceId = res.data;
-                    this.vnApp.showSuccess(this.$t('Transferred invoice'));
-                    this.$state.go('invoiceOut.card.summary', {id: invoiceId});
-                });
-            }
+                if (window.confirm('El cliente destino tiene marcado facturar por consignatario, ¿desea continuar?'))
+                    transferInvoiceRequest();
+            } else
+                transferInvoiceRequest();
         });
     }
 }