Prevent businessTypeFk validation for other invalid fields
This commit is contained in:
parent
7406c59f16
commit
d85f95a8f4
|
@ -184,15 +184,17 @@ module.exports = Self => {
|
|||
const changes = ctx.data || ctx.instance;
|
||||
const orgData = ctx.currentInstance;
|
||||
|
||||
const businessTypeFk = changes && changes.businessTypeFk || orgData && orgData.businessTypeFk;
|
||||
const isTaxDataChecked = changes && changes.isTaxDataChecked || orgData && orgData.isTaxDataChecked;
|
||||
if (!ctx.isNewInstance) {
|
||||
const businessTypeFk = changes && changes.businessTypeFk || orgData && orgData.businessTypeFk;
|
||||
const isTaxDataChecked = changes && changes.isTaxDataChecked || orgData && orgData.isTaxDataChecked;
|
||||
const changedFields = Object.keys(changes);
|
||||
const hasChangedOtherFields = changedFields.some(key => key !== 'businessTypeFk');
|
||||
|
||||
let isWorker = false;
|
||||
if (!ctx.isNewInstance)
|
||||
isWorker = await Self.app.models.UserAccount.findById(orgData.id);
|
||||
const isWorker = await Self.app.models.UserAccount.findById(orgData.id);
|
||||
|
||||
if (!businessTypeFk && !isTaxDataChecked && !isWorker)
|
||||
throw new UserError(`The type of business must be filled in basic data`);
|
||||
if (!businessTypeFk && !isTaxDataChecked && !isWorker && !hasChangedOtherFields)
|
||||
throw new UserError(`The type of business must be filled in basic data`);
|
||||
}
|
||||
});
|
||||
|
||||
Self.observe('before save', async function(ctx) {
|
||||
|
|
Loading…
Reference in New Issue