replaced isActive by active as per it's model and updated original data in controller
gitea/salix/pipeline/head This commit looks good
Details
gitea/salix/pipeline/head This commit looks good
Details
This commit is contained in:
parent
869c9caf98
commit
e151e35f7e
|
@ -10,7 +10,10 @@ describe('Client updateUser', () => {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
const ctx = {req: {accessToken: {userId: employeeId}}};
|
const ctx = {
|
||||||
|
req: {accessToken: {userId: employeeId}},
|
||||||
|
args: {name: 'test', active: true}
|
||||||
|
};
|
||||||
|
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
|
spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
|
||||||
|
@ -21,7 +24,8 @@ describe('Client updateUser', () => {
|
||||||
it('should throw an error the target user is not just a client but a worker', async() => {
|
it('should throw an error the target user is not just a client but a worker', async() => {
|
||||||
let error;
|
let error;
|
||||||
try {
|
try {
|
||||||
await models.Client.updateUser(ctx, 1106, 'test', true);
|
const clientID = 1106;
|
||||||
|
await models.Client.updateUser(ctx, clientID);
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
error = e;
|
error = e;
|
||||||
}
|
}
|
||||||
|
@ -38,8 +42,7 @@ describe('Client updateUser', () => {
|
||||||
const options = {transaction: tx};
|
const options = {transaction: tx};
|
||||||
|
|
||||||
const clientID = 1105;
|
const clientID = 1105;
|
||||||
|
await models.Client.updateUser(ctx, clientID, options);
|
||||||
await models.Client.updateUser(ctx, clientID, 'test', true, options);
|
|
||||||
const client = await models.Account.findById(clientID, null, options);
|
const client = await models.Account.findById(clientID, null, options);
|
||||||
|
|
||||||
expect(client.name).toEqual('test');
|
expect(client.name).toEqual('test');
|
||||||
|
|
|
@ -14,7 +14,7 @@ module.exports = Self => {
|
||||||
description: 'the user name'
|
description: 'the user name'
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
arg: 'isActive',
|
arg: 'active',
|
||||||
type: 'boolean',
|
type: 'boolean',
|
||||||
description: 'whether the user is active or not'
|
description: 'whether the user is active or not'
|
||||||
},
|
},
|
||||||
|
@ -25,7 +25,7 @@ module.exports = Self => {
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
Self.updateUser = async function(ctx, id, name, isActive, options) {
|
Self.updateUser = async function(ctx, id, options) {
|
||||||
const models = Self.app.models;
|
const models = Self.app.models;
|
||||||
let tx;
|
let tx;
|
||||||
const myOptions = {};
|
const myOptions = {};
|
||||||
|
@ -45,11 +45,7 @@ module.exports = Self => {
|
||||||
|
|
||||||
const user = await models.Account.findById(id, null, myOptions);
|
const user = await models.Account.findById(id, null, myOptions);
|
||||||
|
|
||||||
const data = {};
|
await user.updateAttributes(ctx.args, myOptions);
|
||||||
if (name) data.name = name;
|
|
||||||
if (isActive != undefined) data.active = isActive;
|
|
||||||
|
|
||||||
await user.updateAttributes(data, myOptions);
|
|
||||||
|
|
||||||
if (tx) await tx.commit();
|
if (tx) await tx.commit();
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
|
|
|
@ -63,11 +63,11 @@ export default class Controller extends Section {
|
||||||
onSubmit() {
|
onSubmit() {
|
||||||
const data = {
|
const data = {
|
||||||
name: this.account.name,
|
name: this.account.name,
|
||||||
isActive: this.account.isActive,
|
active: this.account.active
|
||||||
};
|
};
|
||||||
|
|
||||||
this.$http.patch(`Clients/${this.client.id}/updateUser`, data).then(() => {
|
this.$http.patch(`Clients/${this.client.id}/updateUser`, data).then(() => {
|
||||||
this.vnApp.showSuccess(this.$t('Data saved!'));
|
this.$.watcher.notifySaved();
|
||||||
|
this.$.watcher.updateOriginalData();
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue