From 29c6ca35ff112093d47d1b193f12bd3f1fd2e597 Mon Sep 17 00:00:00 2001
From: vicent <vicent@verdnatura.es>
Date: Fri, 27 Jan 2023 13:39:19 +0100
Subject: [PATCH 1/4] fix: test e2e

---
 modules/item/back/methods/tag/onSubmit.js | 24 ++++++-----------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/modules/item/back/methods/tag/onSubmit.js b/modules/item/back/methods/tag/onSubmit.js
index aec67e92a..7abbe60d4 100644
--- a/modules/item/back/methods/tag/onSubmit.js
+++ b/modules/item/back/methods/tag/onSubmit.js
@@ -47,44 +47,32 @@ module.exports = function(Self) {
         }
 
         try {
-            const promises = [];
-
             if (args.deletes) {
-                for (const itemTagId of args.deletes) {
-                    const itemTagDeleted = models.ItemTag.destroyById(itemTagId, myOptions);
-                    promises.push(itemTagDeleted);
-                }
+                for (const itemTagId of args.deletes)
+                    await models.ItemTag.destroyById(itemTagId, myOptions);
             }
 
             if (args.updates) {
                 for (const row of args.updates) {
                     if (row.data.priority) {
                         const itemTag = await models.ItemTag.findById(row.where.id, null, myOptions);
-                        const itemTagUpdatedPriority = itemTag.updateAttributes({
+                        await itemTag.updateAttributes({
                             priority: row.data.priority + args.maxPriority
                         }, myOptions);
-                        promises.push(itemTagUpdatedPriority);
                     }
                 }
                 for (const row of args.updates) {
                     const itemTag = await models.ItemTag.findById(row.where.id, null, myOptions);
-                    const itemTagUpdated = itemTag.updateAttributes(row.data, myOptions);
-                    promises.push(itemTagUpdated);
+                    await itemTag.updateAttributes(row.data, myOptions);
                 }
             }
 
             if (args.creates) {
-                for (const itemTag of args.creates) {
-                    const newItemTag = models.ItemTag.create(itemTag, myOptions);
-                    promises.push(newItemTag);
-                }
+                for (const itemTag of args.creates)
+                    await models.ItemTag.create(itemTag, myOptions);
             }
 
-            const resolvedPromises = await Promise.all(promises);
-
             if (tx) await tx.commit();
-
-            return resolvedPromises;
         } catch (e) {
             if (tx) await tx.rollback();
             throw e;

From 79bf1739baff7947c697ac5473a1f76294b18726 Mon Sep 17 00:00:00 2001
From: vicent <vicent@verdnatura.es>
Date: Fri, 27 Jan 2023 13:52:14 +0100
Subject: [PATCH 2/4] fix: backTest

---
 modules/item/back/methods/tag/specs/onSubmit.spec.js | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/modules/item/back/methods/tag/specs/onSubmit.spec.js b/modules/item/back/methods/tag/specs/onSubmit.spec.js
index a8077db67..f24aad7e4 100644
--- a/modules/item/back/methods/tag/specs/onSubmit.spec.js
+++ b/modules/item/back/methods/tag/specs/onSubmit.spec.js
@@ -12,9 +12,8 @@ describe('tag onSubmit()', () => {
                     deletes: deletes
                 }
             };
-            const result = await models.Tag.onSubmit(ctx, options);
+            await models.Tag.onSubmit(ctx, options);
 
-            expect(result.length).toEqual(1);
             await tx.rollback();
         } catch (e) {
             await tx.rollback();
@@ -33,9 +32,8 @@ describe('tag onSubmit()', () => {
                     updates: updates
                 }
             };
-            const result = await models.Tag.onSubmit(ctx, options);
+            await models.Tag.onSubmit(ctx, options);
 
-            expect(result.length).toEqual(1);
             await tx.rollback();
         } catch (e) {
             await tx.rollback();
@@ -62,9 +60,8 @@ describe('tag onSubmit()', () => {
                     creates: creates
                 }
             };
-            const result = await models.Tag.onSubmit(ctx, options);
+            await models.Tag.onSubmit(ctx, options);
 
-            expect(result.length).toEqual(1);
             await tx.rollback();
         } catch (e) {
             await tx.rollback();
@@ -88,9 +85,8 @@ describe('tag onSubmit()', () => {
 
                 }
             };
-            const result = await models.Tag.onSubmit(ctx, options);
+            await models.Tag.onSubmit(ctx, options);
 
-            expect(result.length).toEqual(4);
             await tx.rollback();
         } catch (e) {
             await tx.rollback();