From e51341102b8679644b970e8d0cb607cd700601ee Mon Sep 17 00:00:00 2001
From: Joan Sanchez <joan@verdnatura.es>
Date: Thu, 14 May 2020 14:30:43 +0200
Subject: [PATCH] Updated e2e

---
 e2e/helpers/selectors.js                   |  3 ++-
 e2e/paths/06-claim/04_claim_action.spec.js | 21 +++++++++++++++------
 modules/claim/front/action/index.html      |  4 ++--
 modules/claim/front/action/locale/es.yml   |  2 +-
 4 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/e2e/helpers/selectors.js b/e2e/helpers/selectors.js
index 6ec1d8ebe..bb6dbfd15 100644
--- a/e2e/helpers/selectors.js
+++ b/e2e/helpers/selectors.js
@@ -613,7 +613,8 @@ export default {
         firstLineDestination: 'vn-claim-action vn-tr:nth-child(1) vn-autocomplete[ng-model="saleClaimed.claimDestinationFk"]',
         secondLineDestination: 'vn-claim-action vn-tr:nth-child(2) vn-autocomplete[ng-model="saleClaimed.claimDestinationFk"]',
         firstDeleteLine: 'vn-claim-action vn-tr:nth-child(1) vn-icon-button[icon="delete"]',
-        isPaidWithManaCheckbox: 'vn-check[ng-model="$ctrl.claim.isChargedToMana"]'
+        isPaidWithManaCheckbox: 'vn-claim-action vn-check[ng-model="$ctrl.claim.isChargedToMana"]',
+        hasToPickUpCheckbox: 'vn-claim-action vn-check[ng-model="$ctrl.claim.hasToPickUp"]'
     },
     ordersIndex: {
         searchResult: 'vn-order-index vn-card > vn-table > div > vn-tbody > a.vn-tr',
diff --git a/e2e/paths/06-claim/04_claim_action.spec.js b/e2e/paths/06-claim/04_claim_action.spec.js
index 9897a3ef3..89b3f9c89 100644
--- a/e2e/paths/06-claim/04_claim_action.spec.js
+++ b/e2e/paths/06-claim/04_claim_action.spec.js
@@ -1,7 +1,7 @@
 import selectors from '../../helpers/selectors.js';
 import getBrowser from '../../helpers/puppeteer';
 
-describe('Claim action path', () => {
+fdescribe('Claim action path', () => {
     let browser;
     let page;
 
@@ -66,17 +66,26 @@ describe('Claim action path', () => {
     });
 
     it('should check the "is paid with mana" checkbox', async() => {
-        page.waitFor(3000); // can't use waitForNavigation here and needs more time than a single second to get the section ready...
+        // page.waitFor(3000); // can't use waitForNavigation here and needs more time than a single second to get the section ready...
         await page.waitToClick(selectors.claimAction.isPaidWithManaCheckbox);
         const message = await page.waitForSnackbar();
 
         expect(message.type).toBe('success');
     });
 
-    it('should confirm the "is paid with mana" checkbox is checked', async() => {
-        await page.reloadSection('claim.card.action');
-        const result = await page.checkboxState(selectors.claimAction.isPaidWithManaCheckbox);
+    it('should check the "Pick up" checkbox', async() => {
+        await page.waitToClick(selectors.claimAction.hasToPickUpCheckbox);
+        const message = await page.waitForSnackbar();
 
-        expect(result).toBe('checked');
+        expect(message.type).toBe('success');
+    });
+
+    it('should confirm the "is paid with mana" and "Pick up" checkbox are checked', async() => {
+        await page.reloadSection('claim.card.action');
+        const isPaidWithManaCheckbox = await page.checkboxState(selectors.claimAction.isPaidWithManaCheckbox);
+        const hasToPickUpCheckbox = await page.checkboxState(selectors.claimAction.hasToPickUpCheckbox);
+
+        expect(isPaidWithManaCheckbox).toBe('checked');
+        expect(hasToPickUpCheckbox).toBe('checked');
     });
 });
diff --git a/modules/claim/front/action/index.html b/modules/claim/front/action/index.html
index 1ed1b32a7..a9c179134 100644
--- a/modules/claim/front/action/index.html
+++ b/modules/claim/front/action/index.html
@@ -46,8 +46,8 @@
             </vn-range>
         </vn-tool-bar>
         <vn-check vn-one class="vn-mr-md"
-            label="Pickup"
-            ng-model="::$ctrl.claim.hasToPickUp"
+            label="Pick up"
+            ng-model="$ctrl.claim.hasToPickUp"
             on-change="$ctrl.save({hasToPickUp: value})">
         </vn-check>
         <vn-check vn-one
diff --git a/modules/claim/front/action/locale/es.yml b/modules/claim/front/action/locale/es.yml
index e4c2a1a53..bdf4bf8e9 100644
--- a/modules/claim/front/action/locale/es.yml
+++ b/modules/claim/front/action/locale/es.yml
@@ -10,4 +10,4 @@ Do you want to insert greuges?: Desea insertar greuges?
 Insert greuges on client card: Insertar greuges en la ficha del cliente
 Greuge inserted: Greuge insertado
 ClaimGreugeDescription: Reclamación id {{claimId}}
-Pickup: Recoger
\ No newline at end of file
+Pick up: Recoger
\ No newline at end of file