From eba3ac40a52214b5fc1943497aa13ddf4205347c Mon Sep 17 00:00:00 2001
From: vicent <vicent@verdnatura.es>
Date: Wed, 6 Apr 2022 11:48:12 +0200
Subject: [PATCH] refactor: delete item.compression

---
 e2e/helpers/selectors.js                 | 1 -
 e2e/paths/04-item/02_basic_data.spec.js  | 9 ---------
 modules/item/back/models/item.json       | 3 ---
 modules/item/front/basic-data/index.html | 8 --------
 modules/item/front/locale/es.yml         | 1 -
 modules/item/front/summary/index.html    | 3 ---
 6 files changed, 25 deletions(-)

diff --git a/e2e/helpers/selectors.js b/e2e/helpers/selectors.js
index 21ed27158..62c32434a 100644
--- a/e2e/helpers/selectors.js
+++ b/e2e/helpers/selectors.js
@@ -392,7 +392,6 @@ export default {
         name: 'vn-item-basic-data vn-textfield[ng-model="$ctrl.item.name"]',
         relevancy: 'vn-item-basic-data vn-input-number[ng-model="$ctrl.item.relevancy"]',
         origin: 'vn-autocomplete[ng-model="$ctrl.item.originFk"]',
-        compression: 'vn-item-basic-data vn-input-number[ng-model="$ctrl.item.compression"]',
         generic: 'vn-autocomplete[ng-model="$ctrl.item.genericFk"]',
         isFragile: 'vn-check[ng-model="$ctrl.item.isFragile"]',
         longName: 'vn-textfield[ng-model="$ctrl.item.longName"]',
diff --git a/e2e/paths/04-item/02_basic_data.spec.js b/e2e/paths/04-item/02_basic_data.spec.js
index 0bbb6ad12..a663ea3bb 100644
--- a/e2e/paths/04-item/02_basic_data.spec.js
+++ b/e2e/paths/04-item/02_basic_data.spec.js
@@ -30,8 +30,6 @@ describe('Item Edit basic data path', () => {
         await page.autocompleteSearch(selectors.itemBasicData.origin, 'Spain');
         await page.clearInput(selectors.itemBasicData.relevancy);
         await page.write(selectors.itemBasicData.relevancy, '1');
-        await page.clearInput(selectors.itemBasicData.compression);
-        await page.write(selectors.itemBasicData.compression, '2');
         await page.clearInput(selectors.itemBasicData.generic);
         await page.autocompleteSearch(selectors.itemBasicData.generic, '16');
         await page.waitToClick(selectors.itemBasicData.isActiveCheckbox);
@@ -96,13 +94,6 @@ describe('Item Edit basic data path', () => {
         expect(result).toEqual('Spain');
     });
 
-    it(`should confirm the item compression was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBasicData.compression, 'value');
-
-        expect(result).toEqual('2');
-    });
-
     it(`should confirm the item generic was edited`, async() => {
         const result = await page
             .waitToGetProperty(selectors.itemBasicData.generic, 'value');
diff --git a/modules/item/back/models/item.json b/modules/item/back/models/item.json
index 9b78264f7..efde2690f 100644
--- a/modules/item/back/models/item.json
+++ b/modules/item/back/models/item.json
@@ -112,9 +112,6 @@
         "itemPackingTypeFk": {
             "type": "string"
         },
-        "compression": {
-            "type": "number"
-        },
         "hasKgPrice": {
             "type": "boolean",
             "description": "Price per Kg"
diff --git a/modules/item/front/basic-data/index.html b/modules/item/front/basic-data/index.html
index b7db41094..22fd33a07 100644
--- a/modules/item/front/basic-data/index.html
+++ b/modules/item/front/basic-data/index.html
@@ -129,14 +129,6 @@
                 ng-model="$ctrl.item.density"
                 rule>
             </vn-input-number>
-            <vn-input-number
-                vn-one
-                min="0"
-                step="0.01"
-                label="Compression" 
-                ng-model="$ctrl.item.compression"
-                rule>
-            </vn-input-number>
             <vn-autocomplete
                 vn-one
                 label="Generic"
diff --git a/modules/item/front/locale/es.yml b/modules/item/front/locale/es.yml
index 27348d41c..12a729ef4 100644
--- a/modules/item/front/locale/es.yml
+++ b/modules/item/front/locale/es.yml
@@ -40,7 +40,6 @@ Create: Crear
 Client card: Ficha del cliente
 Shipped: F. envío
 stems: Tallos
-Compression: Compresión
 Density: Densidad
 Search items by id, name or barcode: Buscar articulos por identificador, nombre o codigo de barras
 SalesPerson: Comercial
diff --git a/modules/item/front/summary/index.html b/modules/item/front/summary/index.html
index b5ea79efb..dfc0b6e01 100644
--- a/modules/item/front/summary/index.html
+++ b/modules/item/front/summary/index.html
@@ -94,9 +94,6 @@
             <vn-label-value label="Density" 
                 value="{{$ctrl.summary.item.density}}">
             </vn-label-value>
-            <vn-label-value label="Compression" 
-                value="{{$ctrl.summary.item.compression}}">
-            </vn-label-value>
             <vn-label-value label="Expense" 
                 value="{{$ctrl.summary.item.expense.name}}">
             </vn-label-value>