From eb19bce1ba3084a3ec346ec25427590af87ec9ef Mon Sep 17 00:00:00 2001
From: carlosjr <carlosjr@verdnatura.es>
Date: Tue, 15 Dec 2020 16:51:36 +0100
Subject: [PATCH] client module refactors + dialog css

---
 front/core/components/dialog/style.scss           | 15 ++++++++++++++-
 modules/client/front/basic-data/index.html        |  5 +++--
 modules/client/front/billing-data/index.html      |  5 +++--
 modules/client/front/contact/index.html           |  9 ++++++++-
 modules/client/front/create/index.html            | 11 +++++++++--
 .../front/credit-insurance/create/index.html      |  7 ++++---
 modules/client/front/dms/create/index.html        | 11 +++++++++--
 modules/client/front/fiscal-data/index.html       |  5 +++--
 modules/client/front/recovery/create/index.html   |  9 +++++----
 modules/client/front/sample/create/index.html     |  9 +++++----
 modules/client/front/web-access/index.html        | 15 ++++++++-------
 11 files changed, 71 insertions(+), 30 deletions(-)

diff --git a/front/core/components/dialog/style.scss b/front/core/components/dialog/style.scss
index 47837af7e..998c475e0 100644
--- a/front/core/components/dialog/style.scss
+++ b/front/core/components/dialog/style.scss
@@ -34,7 +34,6 @@
             input[type="button"],
             input[type="submit"],
             input[type="reset"] {
-                @extend %clickable;
                 text-transform: uppercase;
                 background-color: transparent;
                 border: none;
@@ -44,6 +43,20 @@
                 padding: 11px;
                 margin: -11px;
                 margin-left: 11px;
+
+                &:hover,
+                &:focus {
+                    color: lighten($color-button, 10%);
+                }
+            }
+            button {
+                background-color: $color-button;
+                color: white;
+                &:hover,
+                &:focus {
+                    background-color: lighten($color-button, 10%);
+                    color: white;
+                }
             }
         }
     }
diff --git a/modules/client/front/basic-data/index.html b/modules/client/front/basic-data/index.html
index e47798bbb..6235ec923 100644
--- a/modules/client/front/basic-data/index.html
+++ b/modules/client/front/basic-data/index.html
@@ -72,12 +72,13 @@
     </vn-card>
     <vn-button-bar>
         <vn-submit
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             label="Save">
         </vn-submit>
         <vn-button
+            class="cancel"
             label="Undo changes"
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             ng-click="watcher.loadOriginalData()">
         </vn-button>
     </vn-button-bar>
diff --git a/modules/client/front/billing-data/index.html b/modules/client/front/billing-data/index.html
index 9871c9aa8..b9c20ec24 100644
--- a/modules/client/front/billing-data/index.html
+++ b/modules/client/front/billing-data/index.html
@@ -96,12 +96,13 @@
     </vn-card>
     <vn-button-bar>
         <vn-submit
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             label="Save">
         </vn-submit>
         <vn-button
+            class="cancel"
             label="Undo changes"
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             ng-click="watcher.loadOriginalData()">
         </vn-button>
     </vn-button-bar>
diff --git a/modules/client/front/contact/index.html b/modules/client/front/contact/index.html
index f1d7dbbd9..eab1f33ce 100644
--- a/modules/client/front/contact/index.html
+++ b/modules/client/front/contact/index.html
@@ -47,8 +47,15 @@
     </vn-card>
     <vn-button-bar>
         <vn-submit
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             label="Save">
         </vn-submit>
+        <!-- # #2680 Undo changes button bugs -->
+        <!-- <vn-button
+            class="cancel"
+            label="Undo changes"
+            disabled="!watcher.dataChanged()"
+            ng-click="watcher.loadOriginalData()">
+        </vn-button> -->
     </vn-button-bar>
 </form>
\ No newline at end of file
diff --git a/modules/client/front/create/index.html b/modules/client/front/create/index.html
index ce2ddc38b..d9759e347 100644
--- a/modules/client/front/create/index.html
+++ b/modules/client/front/create/index.html
@@ -125,8 +125,15 @@
         </vn-horizontal>
     </vn-card>
     <vn-button-bar>
-        <vn-submit label="Create"></vn-submit>
-        <vn-button ui-sref="client.index" label="Cancel"></vn-button>
+        <vn-submit
+            disabled="!watcher.dataChanged()"
+            label="Create">
+        </vn-submit>
+        <vn-button
+            class="cancel"
+            label="Cancel"
+            ui-sref="client.index">
+        </vn-button>
     </vn-button-bar>
 </form>
 <!-- New postcode dialog -->
diff --git a/modules/client/front/credit-insurance/create/index.html b/modules/client/front/credit-insurance/create/index.html
index 34ded289b..6812b793a 100644
--- a/modules/client/front/credit-insurance/create/index.html
+++ b/modules/client/front/credit-insurance/create/index.html
@@ -32,12 +32,13 @@
     </vn-card>
     <vn-button-bar>
         <vn-submit
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             label="Save">
         </vn-submit>
         <vn-button
-            ui-sref="client.card.creditInsurance.index"
-            label="Cancel">
+            class="cancel"
+            label="Cancel"
+            ui-sref="client.card.creditInsurance.index"></vn-button>
         </vn-button>
     </vn-button-bar>
 </form>
diff --git a/modules/client/front/dms/create/index.html b/modules/client/front/dms/create/index.html
index e585dc398..8f270378f 100644
--- a/modules/client/front/dms/create/index.html
+++ b/modules/client/front/dms/create/index.html
@@ -94,8 +94,15 @@
             </vn-vertical>
         </vn-card>
         <vn-button-bar>
-            <vn-submit label="Upload"></vn-submit>
-            <vn-button ui-sref="client.card.dms.index" label="Cancel"></vn-button>
+            <vn-submit
+                disabled="!watcher.dataChanged()"
+                label="Upload">
+            </vn-submit>
+            <vn-button
+                class="cancel"
+                label="Cancel"
+                ui-sref="client.card.dms.index">
+            </vn-button>
         </vn-button-bar>
     </div>
 </form>
diff --git a/modules/client/front/fiscal-data/index.html b/modules/client/front/fiscal-data/index.html
index 782a5d6f2..2b671c69a 100644
--- a/modules/client/front/fiscal-data/index.html
+++ b/modules/client/front/fiscal-data/index.html
@@ -203,12 +203,13 @@
     </vn-card>
     <vn-button-bar>
         <vn-submit
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             label="Save">
         </vn-submit>
         <vn-button
+            class="cancel"
             label="Undo changes"
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             ng-click="watcher.loadOriginalData()">
         </vn-button>
     </vn-button-bar>
diff --git a/modules/client/front/recovery/create/index.html b/modules/client/front/recovery/create/index.html
index 8b4942494..3d4cc2e1e 100644
--- a/modules/client/front/recovery/create/index.html
+++ b/modules/client/front/recovery/create/index.html
@@ -33,12 +33,13 @@
     </vn-card>
     <vn-button-bar>
         <vn-submit
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             label="Save">
         </vn-submit>
-        <vn-button 
-            ng-click="$ctrl.cancel()"
-            label="Cancel">
+        <vn-button
+            class="cancel"
+            label="Cancel"
+            ng-click="$ctrl.cancel()">
         </vn-button>
     </vn-button-bar>
 </form>
diff --git a/modules/client/front/sample/create/index.html b/modules/client/front/sample/create/index.html
index fe2edfc52..f941e885a 100644
--- a/modules/client/front/sample/create/index.html
+++ b/modules/client/front/sample/create/index.html
@@ -54,17 +54,18 @@
     </vn-card>
     <vn-button-bar>
         <vn-submit
-            ng-if="sampleType.selection"
+            disabled="!sampleType.selection"
             label="Send">
         </vn-submit>
         <vn-button
-            ng-if="sampleType.selection.hasPreview"
+            disabled="!sampleType.selection.hasPreview"
             label="Preview" 
             ng-click="$ctrl.showPreview()">
         </vn-button>
         <vn-button
-            ui-sref="client.card.sample.index"
-            label="Cancel">
+            class="cancel"
+            label="Cancel"
+            ui-sref="client.card.sample.index">
         </vn-button>
     </vn-button-bar>
 </form>
diff --git a/modules/client/front/web-access/index.html b/modules/client/front/web-access/index.html
index 20060f329..07a2615dd 100644
--- a/modules/client/front/web-access/index.html
+++ b/modules/client/front/web-access/index.html
@@ -27,18 +27,19 @@
     </vn-card>
     <vn-button-bar>
         <vn-submit
-            ng-if="watcher.dataChanged()"
+            disabled="!watcher.dataChanged()"
             label="Save">
         </vn-submit>
         <vn-button
-            label="Undo changes"
-            ng-if="$ctrl.$.form.$dirty"
-            ng-click="watcher.loadOriginalData()">
+        ng-if="$ctrl.canChangePassword"
+        label="Change password"
+        vn-dialog="change-pass">
         </vn-button>
         <vn-button
-            ng-if="$ctrl.canChangePassword"
-            label="Change password"
-            vn-dialog="change-pass">
+            class="cancel"
+            label="Undo changes"
+            disabled="!watcher.dataChanged()"
+            ng-click="watcher.loadOriginalData()">
         </vn-button>
     </vn-button-bar>
 </form>